You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/12/15 23:29:57 UTC
[GitHub] [netbeans] mbien opened a new pull request, #5116: globally enable maven stacktrace processing.
mbien opened a new pull request, #5116:
URL: https://github.com/apache/netbeans/pull/5116
stack trace processing is currently only enabled for the exec maven plugin. This PR enables it globally.
Unfortunately this is all public API so I don't think we can simply rename `ExecPluginOutputListenerProvider` and call it a day. So I created a copy and replaced the original provider with the global variant.
before:
imagine no links and no happy face
(don't worry this is not my pw it is a integration test)
this works best when #5099 is also applied, since it fixed some of the patterns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5116: globally enable maven stacktrace processing.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #5116:
URL: https://github.com/apache/netbeans/pull/5116#issuecomment-1355880117
> Beware that whereas maven-execute-plugin normally runs a process using a classpath taken from the project’s configured dependencies
right. There is actually another pending PR #5091 which fixes a few things there. E.g it adds the JDK to the path and fixes parsing for stack traces with module names in them.
I mostly got annoyed by NB not linking traces in tests (ant project did that if i remember correctly). Initially I only wanted to enable it in selected mojos, but I couldn't see a reason to not enable it everywhere. A stacktrace is a stacktrace. It does lose it's classloader information once its logged. The IDE can only resolve those links on a best-effort basis. Links leading into JDK or program code will be correct most of the time, but they don't have to be. The application can make up classes at runtime or load them from outside of the cp.
This could be potentially improved in future by letting the user pick a source path if the link can't be resolved or maybe make this hotkey activated (ctrl+click?) in case the user notices the link resolves to the wrong line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5116: globally enable maven stacktrace processing.
Posted by GitBox <gi...@apache.org>.
mbien merged PR #5116:
URL: https://github.com/apache/netbeans/pull/5116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5116: globally enable maven stacktrace processing.
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5116:
URL: https://github.com/apache/netbeans/pull/5116#discussion_r1051275584
##########
java/maven/src/org/netbeans/modules/maven/output/DefaultOutputProcessorFactory.java:
##########
@@ -33,13 +33,13 @@
public class DefaultOutputProcessorFactory implements ContextOutputProcessorFactory {
@Override public Set<OutputProcessor> createProcessorsSet(Project project) {
- Set<OutputProcessor> toReturn = new HashSet<OutputProcessor>();
+ Set<OutputProcessor> toReturn = new HashSet<>();
if (project != null) {
toReturn.add(new JavadocOutputProcessor());
toReturn.add(new TestOutputListenerProvider());
toReturn.add(new SiteOutputProcessor(project));
NbMavenProjectImpl nbprj = project.getLookup().lookup(NbMavenProjectImpl.class);
- toReturn.add(new ExecPluginOutputListenerProvider(nbprj));
Review Comment:
sure I can do that if you want me to
I didn't deprecate because:
- the class still works perfectly fine
- I usually don't ever deprecate anything unless it can be deprecated for removal and NB doesn't really have a process for removing code (unfortunately), although it happened before e.g. with Schlieman or CND cluster etc
To reuse the code of the method I could put it into an abstract class and let both extend it. The only difference between both would be the goal array.
What would you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #5116: globally enable maven stacktrace processing.
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5116:
URL: https://github.com/apache/netbeans/pull/5116#discussion_r1053791017
##########
java/maven/src/org/netbeans/modules/maven/output/DefaultOutputProcessorFactory.java:
##########
@@ -33,13 +33,13 @@
public class DefaultOutputProcessorFactory implements ContextOutputProcessorFactory {
@Override public Set<OutputProcessor> createProcessorsSet(Project project) {
- Set<OutputProcessor> toReturn = new HashSet<OutputProcessor>();
+ Set<OutputProcessor> toReturn = new HashSet<>();
if (project != null) {
toReturn.add(new JavadocOutputProcessor());
toReturn.add(new TestOutputListenerProvider());
toReturn.add(new SiteOutputProcessor(project));
NbMavenProjectImpl nbprj = project.getLookup().lookup(NbMavenProjectImpl.class);
- toReturn.add(new ExecPluginOutputListenerProvider(nbprj));
Review Comment:
i deprecated ExecPluginOutputListenerProvider and made the new JavaStacktraceOutputProcessor configurable. It uses global scope by default. Ran a project wide search and there were no usages of the deprecated class.
changed the hierarchy to make it DRY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jglick commented on a diff in pull request #5116: globally enable maven stacktrace processing.
Posted by GitBox <gi...@apache.org>.
jglick commented on code in PR #5116:
URL: https://github.com/apache/netbeans/pull/5116#discussion_r1050932378
##########
java/maven/src/org/netbeans/modules/maven/output/DefaultOutputProcessorFactory.java:
##########
@@ -33,13 +33,13 @@
public class DefaultOutputProcessorFactory implements ContextOutputProcessorFactory {
@Override public Set<OutputProcessor> createProcessorsSet(Project project) {
- Set<OutputProcessor> toReturn = new HashSet<OutputProcessor>();
+ Set<OutputProcessor> toReturn = new HashSet<>();
if (project != null) {
toReturn.add(new JavadocOutputProcessor());
toReturn.add(new TestOutputListenerProvider());
toReturn.add(new SiteOutputProcessor(project));
NbMavenProjectImpl nbprj = project.getLookup().lookup(NbMavenProjectImpl.class);
- toReturn.add(new ExecPluginOutputListenerProvider(nbprj));
Review Comment:
At least deprecate the original?
Was about to suggest making one extend the other, to reduce duplication, though the impl is pretty small anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists