You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/09 07:56:32 UTC
[GitHub] [incubator-inlong] LvJiancheng opened a new pull request, #4134: [INLONG-4131][Manager] Add inlong Real-time metrics
LvJiancheng opened a new pull request, #4134:
URL: https://github.com/apache/incubator-inlong/pull/4134
### Title Name: [INLONG-4131][Manager] Add inlong Real-time metrics
where *XYZ* should be replaced by the actual issue number.
Fixes #4131
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4134: [INLONG-4131][Manager] Add get real-time metrics API
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4134:
URL: https://github.com/apache/incubator-inlong/pull/4134#discussion_r867921503
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/util/InlongParser.java:
##########
@@ -82,6 +83,12 @@ public static WorkflowResult parseWorkflowResult(Response response) {
return GsonUtil.fromJson(resultData, WorkflowResult.class);
}
+ public static InlongGroupTotalMetricResponse parseGroupHeartbeat(Response response) {
Review Comment:
Please add a java doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] LvJiancheng closed pull request #4134: [INLONG-4131][Manager] Add get real-time metrics API
Posted by GitBox <gi...@apache.org>.
LvJiancheng closed pull request #4134: [INLONG-4131][Manager] Add get real-time metrics API
URL: https://github.com/apache/inlong/pull/4134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4134: [INLONG-4131][Manager] Add get real-time metrics API
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4134:
URL: https://github.com/apache/incubator-inlong/pull/4134#discussion_r867923588
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/InlongGroupServiceImpl.java:
##########
@@ -421,4 +434,38 @@ public void saveOrUpdateExt(String groupId, List<InlongGroupExtInfo> infoList) {
LOGGER.info("success to save or update inlong group ext for groupId={}", groupId);
}
+ @Override
+ public InlongGroupTotalMetricResponse getMetric(InlongGroupMetricRequest request) {
Review Comment:
Please refer to the `HeartbeatController`, and re-consider the design of those interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4134: [INLONG-4131][Manager] Add get real-time metrics API
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4134:
URL: https://github.com/apache/incubator-inlong/pull/4134#discussion_r867921220
##########
.github/dependabot.yml:
##########
@@ -0,0 +1,80 @@
+#
Review Comment:
Please do not change this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] LvJiancheng commented on pull request #4134: [INLONG-4131][Manager] Add get real-time metrics API
Posted by GitBox <gi...@apache.org>.
LvJiancheng commented on PR #4134:
URL: https://github.com/apache/inlong/pull/4134#issuecomment-1181609976
The previous plan has been changed，so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org