You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2016/03/23 04:38:49 UTC
Review Request 45198: SENTRY-1103: Authorizable names' case
sensitivity must be decided by plugins
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45198/
-----------------------------------------------------------
Review request for sentry.
Repository: sentry
Description
-------
With more and more components relying on sentry for authorization, it really makes sense to have the case-sensitivity configurable. We can keep the current behavior as default. However, for use cases like Kafka, it makes sense to have authorizable names case sensitive. For instance, a topic resource in Kafka can have case sensitive values, like, topic1 and TOPIC1 are two completely different valid topic resource instances.
Diffs
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ImplyMethodType.java 16a7a46
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java 079629e
sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java 43cb5c8
sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/ModelForTest.java a213987
sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java abaf61f
Diff: https://reviews.apache.org/r/45198/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 45198: SENTRY-1103: Authorizable names' case
sensitivity must be decided by plugins
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45198/#review125589
-----------------------------------------------------------
Ship it!
Ship It!
- Dapeng Sun
On 三月 25, 2016, 9:30 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45198/
> -----------------------------------------------------------
>
> (Updated 三月 25, 2016, 9:30 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> With more and more components relying on sentry for authorization, it really makes sense to have the case-sensitivity configurable. We can keep the current behavior as default. However, for use cases like Kafka, it makes sense to have authorizable names case sensitive. For instance, a topic resource in Kafka can have case sensitive values, like, topic1 and TOPIC1 are two completely different valid topic resource instances.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/policy/hive/DBPolicyTestUtil.java c390b66
> sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/policy/solr/SearchPolicyTestUtil.java 3856825
> sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyTestUtil.java a76554e
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ImplyMethodType.java 16a7a46
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java 079629e
> sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java 43cb5c8
> sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/ModelForTest.java a213987
> sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java abaf61f
> sentry-policy/sentry-policy-indexer/pom.xml 1a50581
> sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/IndexPolicyTestUtil.java 45d3400
>
> Diff: https://reviews.apache.org/r/45198/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 45198: SENTRY-1103: Authorizable names' case
sensitivity must be decided by plugins
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45198/
-----------------------------------------------------------
(Updated March 25, 2016, 1:30 a.m.)
Review request for sentry.
Repository: sentry
Description
-------
With more and more components relying on sentry for authorization, it really makes sense to have the case-sensitivity configurable. We can keep the current behavior as default. However, for use cases like Kafka, it makes sense to have authorizable names case sensitive. For instance, a topic resource in Kafka can have case sensitive values, like, topic1 and TOPIC1 are two completely different valid topic resource instances.
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/policy/hive/DBPolicyTestUtil.java c390b66
sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/policy/solr/SearchPolicyTestUtil.java 3856825
sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyTestUtil.java a76554e
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ImplyMethodType.java 16a7a46
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/KeyValue.java 079629e
sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java 43cb5c8
sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/ModelForTest.java a213987
sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java abaf61f
sentry-policy/sentry-policy-indexer/pom.xml 1a50581
sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/IndexPolicyTestUtil.java 45d3400
Diff: https://reviews.apache.org/r/45198/diff/
Testing
-------
Thanks,
Colin Ma