You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/30 07:56:12 UTC

[GitHub] [apisix] wu-sheng opened a new pull request #4339: Polish SkyWalking doc and a tiny thing about Zipkin

wu-sheng opened a new pull request #4339:
URL: https://github.com/apache/apisix/pull/4339


   ### What this PR does / why we need it:
   Neither Zipkin nor SkyWalking is a part of OpenTracing ecosystem, especially when we speak from Nginx and LUA perspectives. Also, OpenTracing is being abandoned, their APIs are not widely used, and merged into OpenTelemetry, which also doesn't relate to the Nginx ecosystem. So, let's focus on the tech itself.
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #4339: docs: Polish SkyWalking doc and a tiny thing about Zipkin

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #4339:
URL: https://github.com/apache/apisix/pull/4339#discussion_r642120255



##########
File path: docs/en/latest/plugins/skywalking.md
##########
@@ -33,7 +33,7 @@ title: skywalking
 
 ## Name
 
-[**Skywalking**](https://github.com/apache/skywalking) is an OpenTracing plugin.\
+[**Skywalking**](https://github.com/apache/skywalking) uses its native Ningx LUA tracer to provide tracing, topology analysis, and metrics from service and URI perspective.\

Review comment:
       ```suggestion
   [**Skywalking**](https://github.com/apache/skywalking) uses its native Nginx LUA tracer to provide tracing, topology analysis, and metrics from service and URI perspective.\
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on pull request #4339: docs: Polish SkyWalking doc and a tiny thing about Zipkin

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #4339:
URL: https://github.com/apache/apisix/pull/4339#issuecomment-851008387


   AFAIK, we have `paths_ignore` in most checks for `docs` changes, do they have a relationship? 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on pull request #4339: docs: Polish SkyWalking doc and a tiny thing about Zipkin

Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #4339:
URL: https://github.com/apache/apisix/pull/4339#issuecomment-851052392


   > AFAIK, we have `paths_ignore` in most checks for `docs` changes, do they have a relationship? 🤔
   
   Since this PR also changes README, so all CI would be running. Still checking the reason.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on a change in pull request #4339: Polish SkyWalking doc and a tiny thing about Zipkin

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #4339:
URL: https://github.com/apache/apisix/pull/4339#discussion_r642066222



##########
File path: README.md
##########
@@ -116,7 +116,8 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
 
 - **OPS friendly**
 
-  - OpenTracing: support [Apache Skywalking](docs/en/latest/plugins/skywalking.md) and [Zipkin](docs/en/latest/plugins/zipkin.md)
+  - Zipkin tracing: [Zipkin](docs/en/latest/plugins/zipkin.md)
+  - Open source APM: support [Apache Skywalking](docs/en/latest/plugins/skywalking.md)

Review comment:
       ```suggestion
     - Open source APM: support [Apache SkyWalking](docs/en/latest/plugins/skywalking.md)
   ```

##########
File path: docs/zh/latest/plugins/skywalking.md
##########
@@ -33,7 +33,7 @@ title: skywalking
 
 ## 名字
 
-`Skywalking`(https://github.com/apache/skywalking) 是一个开源的服务跟踪插件。
+`Skywalking`(https://github.com/apache/skywalking) 使用其原生的Nignx LUA tracer，提供分布式追踪，拓扑分析，以及服务和URI级别的metrics信息。

Review comment:
       ```suggestion
   `Skywalking`(https://github.com/apache/skywalking) 使用其原生的 Nginx LUA tracer，提供分布式追踪、拓扑分析以及服务和 URI 级别的 metrics 信息。
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on pull request #4339: docs: Polish SkyWalking doc and a tiny thing about Zipkin

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #4339:
URL: https://github.com/apache/apisix/pull/4339#issuecomment-851003307


   > Why CI get canceled?
   
   See https://github.com/apache/apisix/tree/master/.github/actions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu edited a comment on pull request #4339: docs: Polish SkyWalking doc and a tiny thing about Zipkin

Posted by GitBox <gi...@apache.org>.
Yiyiyimu edited a comment on pull request #4339:
URL: https://github.com/apache/apisix/pull/4339#issuecomment-851052392


   > AFAIK, we have `paths_ignore` in most checks for `docs` changes, do they have a relationship? 🤔
   
   Since this PR also changes README, so all CI would be running. Still checking the reason.
   
   ---
   
   I guess a part of the reason is that this PR is not coming from a forked repo, like most PRs. The rule of `cancel-workflow-action` is kind of sophisticated, and just got noticed that [It got deprecated since Github provides an official feature about it](https://github.com/potiuk/cancel-workflow-runs#deprecation-notice) so I guess I would not fix it (since for this PR doc change does not need all CI passed), but try to apply the new one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on pull request #4339: docs: Polish SkyWalking doc and a tiny thing about Zipkin

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #4339:
URL: https://github.com/apache/apisix/pull/4339#issuecomment-851008229


   > > > Why CI get canceled?
   > > 
   > > 
   > > See https://github.com/apache/apisix/tree/master/.github/actions
   > 
   > SkyWalking has this, but never cancels CI for the latest commit. What do I miss?
   
   got it. 😳 You mean the last commit's checks are cancelled unexpectedly, need @Yiyiyimu to confirm.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan edited a comment on pull request #4339: docs: Polish SkyWalking doc and a tiny thing about Zipkin

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on pull request #4339:
URL: https://github.com/apache/apisix/pull/4339#issuecomment-851008387


   AFAIK, we have `paths_ignore` in most checks for `docs` changes, do they have a relationship? 🤔 
   
   ![image](https://user-images.githubusercontent.com/2106987/120107955-9cce8480-c195-11eb-963e-91dda271ecff.png)
   
   ![image](https://user-images.githubusercontent.com/2106987/120107967-aeb02780-c195-11eb-9647-ccf633619b0a.png)
   
   Those checks won't run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Yiyiyimu merged pull request #4339: docs: Polish SkyWalking doc and a tiny thing about Zipkin

Posted by GitBox <gi...@apache.org>.
Yiyiyimu merged pull request #4339:
URL: https://github.com/apache/apisix/pull/4339


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] wu-sheng commented on pull request #4339: docs: Polish SkyWalking doc and a tiny thing about Zipkin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #4339:
URL: https://github.com/apache/apisix/pull/4339#issuecomment-850995355


   Why CI get canceled?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] wu-sheng commented on pull request #4339: docs: Polish SkyWalking doc and a tiny thing about Zipkin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #4339:
URL: https://github.com/apache/apisix/pull/4339#issuecomment-851003864


   > > Why CI get canceled?
   > 
   > See https://github.com/apache/apisix/tree/master/.github/actions
   
   SkyWalking has this, but never cancels CI for the latest commit. What do I miss?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org