You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by na...@apache.org on 2014/11/23 23:00:42 UTC
[01/50] [abbrv] jclouds git commit: Renamed test methods to match the
new api naming convention
Repository: jclouds
Updated Branches:
refs/heads/1.8.x 243b96798 -> 68f3bdc26
Renamed test methods to match the new api naming convention
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/7b28bbe6
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/7b28bbe6
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/7b28bbe6
Branch: refs/heads/1.8.x
Commit: 7b28bbe61c605d02aa5e06fe5de41ee74cb5a0fb
Parents: 7c4cf02
Author: Noorul Islam K M <no...@noorul.com>
Authored: Mon Sep 16 18:43:27 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Mon Sep 16 15:43:22 2013 +0200
----------------------------------------------------------------------
.../test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/7b28bbe6/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
index 84cc092..a742bd1 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
@@ -468,13 +468,13 @@ public abstract class BaseChefApiLiveTest<A extends ChefApi> extends BaseChefLiv
}
@Test(dependsOnMethods = "testCreateEnvironment")
- public void testListEnvironmentRecipes() {
+ public void testListRecipesInEnvironment() {
Set<String> recipeList = api.listRecipesInEnvironment(PREFIX);
assertTrue(!recipeList.isEmpty());
}
@Test(dependsOnMethods = "testCreateEnvironment")
- public void testListEnvironmentNodes() {
+ public void testListNodesInEnvironment() {
api.deleteNode(ENV_NODE);
api.createNode(Node.builder().name(ENV_NODE).runListElement("role[" + PREFIX + "]").environment(PREFIX).build());
Node node = api.getNode(ENV_NODE);
[46/50] [abbrv] jclouds git commit: Promoted jclouds-chef/core to
apis/chef
Posted by na...@apache.org.
Promoted jclouds-chef/core to apis/chef
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/36dcc576
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/36dcc576
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/36dcc576
Branch: refs/heads/1.8.x
Commit: 36dcc576af1154ed950644eaa0570c9303c00350
Parents: 243b967 35c1df4
Author: Ignasi Barrera <na...@apache.org>
Authored: Sun Nov 23 22:20:05 2014 +0100
Committer: Ignasi Barrera <na...@apache.org>
Committed: Sun Nov 23 22:20:05 2014 +0100
----------------------------------------------------------------------
apis/chef/pom.xml | 134 +++
apis/chef/src/main/clojure/org/jclouds/chef.clj | 261 ++++++
.../src/main/java/org/jclouds/chef/ChefApi.java | 853 +++++++++++++++++++
.../java/org/jclouds/chef/ChefApiMetadata.java | 110 +++
.../main/java/org/jclouds/chef/ChefContext.java | 37 +
.../main/java/org/jclouds/chef/ChefService.java | 263 ++++++
.../binders/BindChecksumsToJsonPayload.java | 54 ++
.../BindCreateClientOptionsToJsonPayload.java | 71 ++
.../BindGenerateKeyForClientToJsonPayload.java | 35 +
.../org/jclouds/chef/binders/DatabagItemId.java | 32 +
.../jclouds/chef/binders/EnvironmentName.java | 31 +
.../java/org/jclouds/chef/binders/NodeName.java | 32 +
.../java/org/jclouds/chef/binders/RoleName.java | 32 +
.../chef/config/BaseChefHttpApiModule.java | 208 +++++
.../chef/config/ChefBootstrapModule.java | 121 +++
.../jclouds/chef/config/ChefHttpApiModule.java | 28 +
.../jclouds/chef/config/ChefParserModule.java | 321 +++++++
.../org/jclouds/chef/config/ChefProperties.java | 110 +++
.../org/jclouds/chef/config/CookbookParser.java | 41 +
.../chef/config/CookbookVersionsParser.java | 41 +
.../org/jclouds/chef/config/InstallChef.java | 37 +
.../java/org/jclouds/chef/config/Validator.java | 40 +
.../java/org/jclouds/chef/domain/Attribute.java | 235 +++++
.../jclouds/chef/domain/BootstrapConfig.java | 95 +++
.../org/jclouds/chef/domain/ChecksumStatus.java | 102 +++
.../java/org/jclouds/chef/domain/Client.java | 182 ++++
.../jclouds/chef/domain/CookbookDefinition.java | 217 +++++
.../jclouds/chef/domain/CookbookVersion.java | 369 ++++++++
.../org/jclouds/chef/domain/DatabagItem.java | 63 ++
.../org/jclouds/chef/domain/Environment.java | 178 ++++
.../java/org/jclouds/chef/domain/Metadata.java | 447 ++++++++++
.../main/java/org/jclouds/chef/domain/Node.java | 263 ++++++
.../java/org/jclouds/chef/domain/Resource.java | 169 ++++
.../main/java/org/jclouds/chef/domain/Role.java | 205 +++++
.../java/org/jclouds/chef/domain/Sandbox.java | 195 +++++
.../org/jclouds/chef/domain/SearchResult.java | 46 +
.../org/jclouds/chef/domain/UploadSandbox.java | 136 +++
.../jclouds/chef/filters/SignedHeaderAuth.java | 199 +++++
.../chef/functions/BootstrapConfigForGroup.java | 61 ++
.../jclouds/chef/functions/ClientForGroup.java | 69 ++
.../chef/functions/GroupToBootScript.java | 130 +++
...seCookbookDefinitionCheckingChefVersion.java | 49 ++
.../ParseCookbookDefinitionFromJson.java | 50 ++
.../ParseCookbookDefinitionFromJsonv10.java | 52 ++
.../ParseCookbookDefinitionListFromJsonv10.java | 63 ++
...arseCookbookVersionsCheckingChefVersion.java | 49 ++
.../ParseCookbookVersionsV09FromJson.java | 49 ++
.../ParseCookbookVersionsV10FromJson.java | 59 ++
.../ParseErrorFromJsonOrReturnBody.java | 55 ++
.../chef/functions/ParseKeySetFromJson.java | 45 +
.../functions/ParseSearchClientsFromJson.java | 35 +
.../functions/ParseSearchDatabagFromJson.java | 77 ++
.../ParseSearchEnvironmentsFromJson.java | 35 +
.../functions/ParseSearchNodesFromJson.java | 35 +
.../functions/ParseSearchResultFromJson.java | 50 ++
.../functions/ParseSearchRolesFromJson.java | 35 +
.../jclouds/chef/functions/RunListForGroup.java | 61 ++
.../jclouds/chef/functions/UriForResource.java | 42 +
.../chef/handlers/ChefApiErrorRetryHandler.java | 67 ++
.../jclouds/chef/handlers/ChefErrorHandler.java | 71 ++
.../jclouds/chef/internal/BaseChefService.java | 299 +++++++
.../jclouds/chef/internal/ChefContextImpl.java | 55 ++
.../chef/options/CreateClientOptions.java | 64 ++
.../org/jclouds/chef/options/SearchOptions.java | 95 +++
.../predicates/CookbookVersionPredicates.java | 93 ++
.../strategy/CleanupStaleNodesAndClients.java | 32 +
...reateNodeAndPopulateAutomaticAttributes.java | 33 +
.../chef/strategy/DeleteAllClientsInList.java | 34 +
.../chef/strategy/DeleteAllNodesInList.java | 31 +
.../org/jclouds/chef/strategy/ListClients.java | 32 +
.../chef/strategy/ListCookbookVersions.java | 32 +
.../ListCookbookVersionsInEnvironment.java | 37 +
.../jclouds/chef/strategy/ListEnvironments.java | 31 +
.../org/jclouds/chef/strategy/ListNodes.java | 32 +
.../chef/strategy/ListNodesInEnvironment.java | 32 +
.../UpdateAutomaticAttributesOnNode.java | 31 +
.../internal/BaseListCookbookVersionsImpl.java | 97 +++
.../strategy/internal/BaseListNodesImpl.java | 77 ++
.../CleanupStaleNodesAndClientsImpl.java | 102 +++
...eNodeAndPopulateAutomaticAttributesImpl.java | 83 ++
.../internal/DeleteAllClientsInListImpl.java | 85 ++
.../internal/DeleteAllNodesInListImpl.java | 81 ++
.../chef/strategy/internal/ListClientsImpl.java | 109 +++
.../internal/ListCookbookVersionsImpl.java | 60 ++
.../ListCookbookVersionsInEnvironmentImpl.java | 117 +++
.../strategy/internal/ListEnvironmentsImpl.java | 96 +++
.../chef/strategy/internal/ListNodesImpl.java | 62 ++
.../internal/ListNodesInEnvironmentImpl.java | 62 ++
.../UpdateAutomaticAttributesOnNodeImpl.java | 75 ++
.../chef/suppliers/ChefVersionSupplier.java | 73 ++
.../org/jclouds/chef/test/TransientChefApi.java | 387 +++++++++
.../chef/test/TransientChefApiMetadata.java | 75 ++
.../test/config/TransientChefApiModule.java | 114 +++
.../java/org/jclouds/chef/util/ChefUtils.java | 71 ++
.../org/jclouds/chef/util/CollectionUtils.java | 69 ++
.../org/jclouds/chef/util/RunListBuilder.java | 83 ++
.../main/java/org/jclouds/ohai/Automatic.java | 33 +
.../org/jclouds/ohai/AutomaticSupplier.java | 48 ++
.../org/jclouds/ohai/config/ConfiguresOhai.java | 28 +
.../org/jclouds/ohai/config/JMXOhaiModule.java | 48 ++
.../org/jclouds/ohai/config/OhaiModule.java | 183 ++++
.../ohai/functions/ByteArrayToMacAddress.java | 51 ++
.../ohai/functions/MapSetToMultimap.java | 42 +
.../jclouds/ohai/functions/NestSlashKeys.java | 156 ++++
.../ohai/suppliers/UptimeSecondsSupplier.java | 44 +
.../services/org.jclouds.apis.ApiMetadata | 2 +
.../src/test/clojure/org/jclouds/chef_test.clj | 70 ++
.../org/jclouds/chef/BaseChefApiExpectTest.java | 44 +
.../org/jclouds/chef/ChefApiExpectTest.java | 279 ++++++
.../java/org/jclouds/chef/ChefApiLiveTest.java | 32 +
.../org/jclouds/chef/ChefApiMetadataTest.java | 33 +
.../test/java/org/jclouds/chef/ChefApiTest.java | 741 ++++++++++++++++
.../BindHexEncodedMD5sToJsonPayloadTest.java | 70 ++
.../chef/config/ChefParserModuleTest.java | 93 ++
.../chef/filters/SignedHeaderAuthTest.java | 213 +++++
.../functions/BootstrapConfigForGroupTest.java | 74 ++
.../chef/functions/ClientForGroupTest.java | 106 +++
.../chef/functions/GroupToBootScriptTest.java | 230 +++++
.../chef/functions/ParseClientFromJsonTest.java | 98 +++
...okbookDefinitionCheckingChefVersionTest.java | 62 ++
.../ParseCookbookDefinitionFromJsonTest.java | 72 ++
.../ParseCookbookDefinitionFromJsonv10Test.java | 74 ++
...seCookbookDefinitionListFromJsonv10Test.java | 92 ++
.../ParseCookbookVersionFromJsonTest.java | 129 +++
...CookbookVersionsCheckingChefVersionTest.java | 62 ++
.../ParseCookbookVersionsV09FromJsonTest.java | 61 ++
.../ParseCookbookVersionsV10FromJsonTest.java | 68 ++
.../functions/ParseDataBagItemFromJsonTest.java | 65 ++
.../ParseErrorFromJsonOrReturnBodyTest.java | 42 +
.../chef/functions/ParseKeySetFromJsonTest.java | 66 ++
.../chef/functions/ParseNodeFromJsonTest.java | 73 ++
.../functions/ParseSandboxFromJsonTest.java | 71 ++
.../ParseSearchDataBagItemFromJsonTest.java | 62 ++
.../ParseUploadSandboxFromJsonTest.java | 87 ++
.../chef/functions/RunListForGroupTest.java | 92 ++
.../chef/functions/UriForResourceTest.java | 54 ++
.../handlers/ChefApiErrorRetryHandlerTest.java | 115 +++
.../chef/internal/BaseChefApiLiveTest.java | 535 ++++++++++++
.../jclouds/chef/internal/BaseChefLiveTest.java | 96 +++
.../chef/internal/BaseChefServiceTest.java | 99 +++
.../chef/internal/BaseStubbedOhaiLiveTest.java | 60 ++
...CleanupStaleNodesAndClientsImplLiveTest.java | 61 ++
...PopulateAutomaticAttributesImplLiveTest.java | 62 ++
...eAndPopulateAutomaticAttributesImplTest.java | 61 ++
...DeleteAllApisAndNodesInListImplLiveTest.java | 64 ++
...okbookVersionsInEnvironmentImplLiveTest.java | 217 +++++
.../internal/ListNodesImplLiveTest.java | 82 ++
.../ListNodesInEnvironmentImplLiveTest.java | 86 ++
...teAutomaticAttributesOnNodeImplLiveTest.java | 61 ++
...UpdateAutomaticAttributesOnNodeImplTest.java | 63 ++
.../chef/suppliers/ChefVersionSupplierTest.java | 47 +
.../test/TransientChefApiIntegrationTest.java | 69 ++
.../chef/test/TransientChefApiMetadataTest.java | 33 +
.../org/jclouds/chef/util/ChefUtilsTest.java | 57 ++
.../jclouds/chef/util/RunListBuilderTest.java | 71 ++
.../java/org/jclouds/ohai/config/JMXTest.java | 82 ++
.../org/jclouds/ohai/config/OhaiModuleTest.java | 147 ++++
.../functions/ByteArrayToMacAddressTest.java | 33 +
.../ohai/functions/NestSlashKeysTest.java | 117 +++
.../resources/apache-chef-demo-cookbook.json | 46 +
apis/chef/src/test/resources/bootstrap-env.sh | 56 ++
apis/chef/src/test/resources/bootstrap.sh | 56 ++
apis/chef/src/test/resources/brew-cookbook.json | 48 ++
apis/chef/src/test/resources/client.json | 8 +
apis/chef/src/test/resources/clients_list.json | 5 +
apis/chef/src/test/resources/data_list.json | 4 +
apis/chef/src/test/resources/env_cookbooks.json | 20 +
.../src/test/resources/environment_recipes.json | 6 +
apis/chef/src/test/resources/logback.xml | 33 +
.../chef/src/test/resources/mysql-cookbook.json | 268 ++++++
apis/chef/src/test/resources/node.json | 10 +
apis/chef/src/test/resources/nodes_list.json | 5 +
apis/chef/src/test/resources/privkey.txt | 27 +
apis/chef/src/test/resources/pubkey.txt | 9 +
apis/chef/src/test/resources/roles_list.json | 4 +
apis/chef/src/test/resources/sandbox.json | 12 +
apis/chef/src/test/resources/search_role.json | 34 +
.../src/test/resources/search_role_empty.json | 5 +
.../src/test/resources/tomcat-cookbook.json | 121 +++
apis/chef/src/test/resources/upload-site.json | 13 +
180 files changed, 17231 insertions(+)
----------------------------------------------------------------------
[07/50] [abbrv] jclouds git commit: Make listCookbooksInEnvironment
return an empty set on 404
Posted by na...@apache.org.
Make listCookbooksInEnvironment return an empty set on 404
Added tests to validate above.
Also factored out some duplicate code in test.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/c9b56564
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/c9b56564
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/c9b56564
Branch: refs/heads/1.8.x
Commit: c9b56564257b305343fd1353262f0734414c53a7
Parents: c7bea4d
Author: Noorul Islam K M <no...@noorul.com>
Authored: Thu Sep 19 17:16:30 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Thu Sep 19 15:48:05 2013 +0200
----------------------------------------------------------------------
.../src/main/java/org/jclouds/chef/ChefApi.java | 11 +--
.../org/jclouds/chef/ChefApiExpectTest.java | 93 ++++++++------------
2 files changed, 45 insertions(+), 59 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/c9b56564/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java b/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java
index b8b4513..5601022 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java
@@ -192,7 +192,7 @@ public interface ChefApi extends Closeable {
*
* @param environmentname The name of the environment to get the cookbooks
* from.
- * @return The definitions of the cookbooks (URL and versions) available in
+ * @return The definitions of the cookbooks (name, URL and versions) available in
* the given environment.
*/
@SinceApiVersion("0.10.0")
@@ -200,17 +200,18 @@ public interface ChefApi extends Closeable {
@GET
@ResponseParser(ParseCookbookDefinitionListFromJsonv10.class)
@Path("/environments/{environmentname}/cookbooks")
- @Fallback(NullOnNotFoundOr404.class)
+ @Fallback(EmptySetOnNotFoundOr404.class)
Set<CookbookDefinition> listCookbooksInEnvironment(@PathParam("environmentname") String environmentName);
/**
* Lists the cookbooks that are available in the given environment, limiting
* the number of versions returned for each cookbook.
*
- * @param environmentname The name of the environment.
+ * @param environmentname The name of the environment to get the cookbooks
+ * from.
* @param numversions The number of cookbook versions to include in the
* response, where n is the number of cookbook versions.
- * @return The definitions of the cookbooks (URL and versions) available in
+ * @return The definitions of the cookbooks (name, URL and versions) available in
* the given environment.
*/
@SinceApiVersion("0.10.0")
@@ -218,7 +219,7 @@ public interface ChefApi extends Closeable {
@GET
@ResponseParser(ParseCookbookDefinitionListFromJsonv10.class)
@Path("/environments/{environmentname}/cookbooks?num_versions={numversions}")
- @Fallback(NullOnNotFoundOr404.class)
+ @Fallback(EmptySetOnNotFoundOr404.class)
Set<CookbookDefinition> listCookbooksInEnvironment(@PathParam("environmentname") String environmentName,
@PathParam("numversions") String numVersions);
http://git-wip-us.apache.org/repos/asf/jclouds/blob/c9b56564/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
index 65344ef..634c5da 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
@@ -45,16 +45,20 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
provider = "chef";
}
+ private HttpRequest.Builder getHttpRequestBuilder(String method, String endPoint) {
+ return HttpRequest.builder() //
+ .method(method) //
+ .endpoint("http://localhost:4000" + endPoint) //
+ .addHeader("X-Chef-Version", ChefApiMetadata.DEFAULT_API_VERSION) //
+ .addHeader("Accept", MediaType.APPLICATION_JSON);
+ }
+
public void testListClientsReturns2xx() {
ChefApi api = requestSendsResponse(
- signed(HttpRequest.builder() //
- .method("GET") //
- .endpoint("http://localhost:4000/clients") //
- .addHeader("X-Chef-Version", ChefApiMetadata.DEFAULT_API_VERSION) //
- .addHeader("Accept", MediaType.APPLICATION_JSON).build()), //
- HttpResponse.builder().statusCode(200)
- .payload(payloadFromResourceWithContentType("/clients_list.json", MediaType.APPLICATION_JSON)) //
- .build());
+ signed(getHttpRequestBuilder("GET", "/clients").build()),
+ HttpResponse.builder().statusCode(200) //
+ .payload(payloadFromResourceWithContentType("/clients_list.json", MediaType.APPLICATION_JSON)) //
+ .build());
Set<String> nodes = api.listClients();
assertEquals(nodes.size(), 3);
assertTrue(nodes.contains("adam"), String.format("Expected nodes to contain 'adam' but was: %s", nodes));
@@ -62,11 +66,7 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
public void testListClientsReturns404() {
ChefApi api = requestSendsResponse(
- signed(HttpRequest.builder() //
- .method("GET") //
- .endpoint("http://localhost:4000/clients") //
- .addHeader("X-Chef-Version", ChefApiMetadata.DEFAULT_API_VERSION) //
- .addHeader("Accept", MediaType.APPLICATION_JSON).build()), //
+ signed(getHttpRequestBuilder("GET", "/clients").build()),
HttpResponse.builder().statusCode(404)
.build());
Set<String> clients = api.listClients();
@@ -75,11 +75,7 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
public void testListNodesReturns2xx() {
ChefApi api = requestSendsResponse(
- signed(HttpRequest.builder() //
- .method("GET") //
- .endpoint("http://localhost:4000/nodes") //
- .addHeader("X-Chef-Version", ChefApiMetadata.DEFAULT_API_VERSION) //
- .addHeader("Accept", MediaType.APPLICATION_JSON).build()), //
+ signed(getHttpRequestBuilder("GET", "/nodes").build()),
HttpResponse.builder().statusCode(200)
.payload(payloadFromResourceWithContentType("/nodes_list.json", MediaType.APPLICATION_JSON)) //
.build());
@@ -90,24 +86,15 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
public void testListNodesReturns404() {
ChefApi api = requestSendsResponse(
- signed(HttpRequest.builder() //
- .method("GET") //
- .endpoint("http://localhost:4000/nodes") //
- .addHeader("X-Chef-Version", ChefApiMetadata.DEFAULT_API_VERSION) //
- .addHeader("Accept", MediaType.APPLICATION_JSON).build()), //
- HttpResponse.builder().statusCode(404)
- .build());
+ signed(getHttpRequestBuilder("GET", "/nodes").build()),
+ HttpResponse.builder().statusCode(404).build());
Set<String> nodes = api.listNodes();
assertTrue(nodes.isEmpty(), String.format("Expected nodes to be empty but was: %s", nodes));
}
public void testListRecipesInEnvironmentReturns2xx() {
ChefApi api = requestSendsResponse(
- signed(HttpRequest.builder() //
- .method("GET") //
- .endpoint("http://localhost:4000/environments/dev/recipes") //
- .addHeader("X-Chef-Version", ChefApiMetadata.DEFAULT_API_VERSION) //
- .addHeader("Accept", MediaType.APPLICATION_JSON).build()), //
+ signed(getHttpRequestBuilder("GET", "/environments/dev/recipes").build()),
HttpResponse.builder().statusCode(200)
.payload(payloadFromResourceWithContentType("/environment_recipes.json", MediaType.APPLICATION_JSON)) //
.build());
@@ -118,24 +105,15 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
public void testListRecipesInEnvironmentReturns404() {
ChefApi api = requestSendsResponse(
- signed(HttpRequest.builder() //
- .method("GET") //
- .endpoint("http://localhost:4000/environments/dev/recipes") //
- .addHeader("X-Chef-Version", ChefApiMetadata.DEFAULT_API_VERSION) //
- .addHeader("Accept", MediaType.APPLICATION_JSON).build()), //
- HttpResponse.builder().statusCode(404)
- .build());
+ signed(getHttpRequestBuilder("GET", "/environments/dev/recipes").build()),
+ HttpResponse.builder().statusCode(404).build());
Set<String> recipes = api.listRecipesInEnvironment("dev");
assertTrue(recipes.isEmpty(), String.format("Expected recipes to be empty but was: %s", recipes));
}
public void testListNodesInEnvironmentReturns2xx() {
ChefApi api = requestSendsResponse(
- signed(HttpRequest.builder() //
- .method("GET") //
- .endpoint("http://localhost:4000/environments/dev/nodes") //
- .addHeader("X-Chef-Version", ChefApiMetadata.DEFAULT_API_VERSION) //
- .addHeader("Accept", MediaType.APPLICATION_JSON).build()), //
+ signed(getHttpRequestBuilder("GET", "/environments/dev/nodes").build()),
HttpResponse.builder().statusCode(200)
.payload(payloadFromResourceWithContentType("/nodes_list.json", MediaType.APPLICATION_JSON)) //
.build());
@@ -146,24 +124,15 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
public void testListNodesInEnvironmentReturns404() {
ChefApi api = requestSendsResponse(
- signed(HttpRequest.builder() //
- .method("GET") //
- .endpoint("http://localhost:4000/environments/dev/nodes") //
- .addHeader("X-Chef-Version", ChefApiMetadata.DEFAULT_API_VERSION) //
- .addHeader("Accept", MediaType.APPLICATION_JSON).build()), //
- HttpResponse.builder().statusCode(404)
- .build());
+ signed(getHttpRequestBuilder("GET", "/environments/dev/nodes").build()),
+ HttpResponse.builder().statusCode(404).build());
Set<String> nodes = api.listNodesInEnvironment("dev");
assertTrue(nodes.isEmpty(), String.format("Expected nodes to be empty but was: %s", nodes));
}
public void testListCookbooksInEnvironmentReturnsValidSet() {
ChefApi api = requestSendsResponse(
- signed(HttpRequest.builder() //
- .method("GET") //
- .endpoint("http://localhost:4000/environments/dev/cookbooks") //
- .addHeader("X-Chef-Version", ChefApiMetadata.DEFAULT_API_VERSION) //
- .addHeader("Accept", MediaType.APPLICATION_JSON).build()), //
+ signed(getHttpRequestBuilder("GET", "/environments/dev/cookbooks").build()),
HttpResponse.builder().statusCode(200)
.payload(payloadFromResourceWithContentType("/env_cookbooks.json", MediaType.APPLICATION_JSON)) //
.build());
@@ -171,6 +140,22 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
assertEquals(cookbooks.size(), 2);
}
+ public void testListCookbooksInEnvironmentReturnsEmptySetOn404() {
+ ChefApi api = requestSendsResponse(
+ signed(getHttpRequestBuilder("GET", "/environments/dev/cookbooks").build()),
+ HttpResponse.builder().statusCode(404).build());
+ Set<CookbookDefinition> cookbooks = api.listCookbooksInEnvironment("dev");
+ assertTrue(cookbooks.isEmpty(), String.format("Expected cookbooks to be empty but was: %s", cookbooks));
+ }
+
+ public void testListCookbooksInEnvironmentWithNumVersionReturnsEmptySetOn404() {
+ ChefApi api = requestSendsResponse(
+ signed(getHttpRequestBuilder("GET", "/environments/dev/cookbooks").addQueryParam("num_versions", "2").build()),
+ HttpResponse.builder().statusCode(404).build());
+ Set<CookbookDefinition> cookbooks = api.listCookbooksInEnvironment("dev", "2");
+ assertTrue(cookbooks.isEmpty(), String.format("Expected cookbooks to be empty but was: %s", cookbooks));
+ }
+
@Override
protected Module createModule() {
return new TestChefRestClientModule();
[50/50] [abbrv] jclouds git commit: JCLOUDS-776: Map chef cookbook
attribute files with Resource instead of Attribute
Posted by na...@apache.org.
JCLOUDS-776: Map chef cookbook attribute files with Resource instead of Attribute
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/68f3bdc2
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/68f3bdc2
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/68f3bdc2
Branch: refs/heads/1.8.x
Commit: 68f3bdc264cde90772e3fc9c8551353dec7a1270
Parents: 494f35d
Author: akorompai <at...@gmail.com>
Authored: Sat Nov 15 12:58:01 2014 +0100
Committer: Ignasi Barrera <na...@apache.org>
Committed: Sun Nov 23 22:25:24 2014 +0100
----------------------------------------------------------------------
.../jclouds/chef/domain/CookbookVersion.java | 12 ++---
.../chef/internal/BaseChefApiLiveTest.java | 51 +++++++++++---------
2 files changed, 35 insertions(+), 28 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/68f3bdc2/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookVersion.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookVersion.java b/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookVersion.java
index df9bd82..01abb64 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookVersion.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookVersion.java
@@ -38,7 +38,7 @@ public class CookbookVersion {
public static class Builder {
private String cookbookName;
private ImmutableSet.Builder<Resource> definitions = ImmutableSet.builder();
- private ImmutableSet.Builder<Attribute> attributes = ImmutableSet.builder();
+ private ImmutableSet.Builder<Resource> attributes = ImmutableSet.builder();
private ImmutableSet.Builder<Resource> files = ImmutableSet.builder();
private Metadata metadata = Metadata.builder().build();
private ImmutableSet.Builder<Resource> providers = ImmutableSet.builder();
@@ -69,12 +69,12 @@ public class CookbookVersion {
return this;
}
- public Builder attribute(Attribute attribute) {
+ public Builder attribute(Resource attribute) {
this.attributes.add(checkNotNull(attribute, "attribute"));
return this;
}
- public Builder attributes(Iterable<Attribute> attributes) {
+ public Builder attributes(Iterable<Resource> attributes) {
this.attributes.addAll(checkNotNull(attributes, "attributes"));
return this;
}
@@ -168,7 +168,7 @@ public class CookbookVersion {
private final String name;
private final Set<Resource> definitions;
- private final Set<Attribute> attributes;
+ private final Set<Resource> attributes;
private final Set<Resource> files;
private final Metadata metadata;
private final Set<Resource> providers;
@@ -190,7 +190,7 @@ public class CookbookVersion {
@ConstructorProperties({ "name", "definitions", "attributes", "files", "metadata", "providers", "cookbook_name",
"resources", "templates", "libraries", "version", "recipes", "root_files" })
- protected CookbookVersion(String name, @Nullable Set<Resource> definitions, @Nullable Set<Attribute> attributes,
+ protected CookbookVersion(String name, @Nullable Set<Resource> definitions, @Nullable Set<Resource> attributes,
@Nullable Set<Resource> files, Metadata metadata, @Nullable Set<Resource> providers, String cookbookName,
@Nullable Set<Resource> resources, @Nullable Set<Resource> templates, @Nullable Set<Resource> libraries,
String version, @Nullable Set<Resource> recipes, @Nullable Set<Resource> rootFiles) {
@@ -217,7 +217,7 @@ public class CookbookVersion {
return definitions;
}
- public Set<Attribute> getAttributes() {
+ public Set<Resource> getAttributes() {
return attributes;
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/68f3bdc2/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
index a477be0..42a5cc2 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
@@ -30,6 +30,7 @@ import static org.testng.Assert.assertTrue;
import static org.testng.Assert.fail;
import java.io.File;
+import java.io.IOException;
import java.io.InputStream;
import java.util.Collections;
import java.util.List;
@@ -85,6 +86,30 @@ public abstract class BaseChefApiLiveTest<A extends ChefApi> extends BaseChefLiv
public void testCreateNewCookbook() throws Exception {
// Define the file you want in the cookbook
File file = new File(System.getProperty("user.dir"), "pom.xml");
+ FilePayload content = uploadAndGetFilePayload(file);
+
+ // Create the metadata of the cookbook
+ Metadata metadata = Metadata.builder() //
+ .name(PREFIX) //
+ .version("0.0.0") //
+ .description("Jclouds test uploaded cookbook") //
+ .maintainer("jclouds") //
+ .maintainerEmail("someone@jclouds.org") //
+ .license("Apache 2.0") //
+ .build();
+
+ // Create a new cookbook
+ CookbookVersion cookbook = CookbookVersion.builder(PREFIX, "0.0.0") //
+ .metadata(metadata) //
+ .rootFile(Resource.builder().fromPayload(content).build()) //
+ .attribute(Resource.builder().fromPayload(content).name("default.rb").build())
+ .build();
+
+ // upload the cookbook to the remote server
+ api.updateCookbook(PREFIX, "0.0.0", cookbook);
+ }
+
+ private FilePayload uploadAndGetFilePayload(File file) throws IOException {
FilePayload content = Payloads.newFilePayload(file);
content.getContentMetadata().setContentType("application/x-binary");
@@ -111,25 +136,7 @@ public abstract class BaseChefApiLiveTest<A extends ChefApi> extends BaseChefLiv
api.commitSandbox(site.getSandboxId(), false);
fail("Could not upload content");
}
-
- // Create the metadata of the cookbook
- Metadata metadata = Metadata.builder() //
- .name(PREFIX) //
- .version("0.0.0") //
- .description("Jclouds test uploaded cookbook") //
- .maintainer("jclouds") //
- .maintainerEmail("someone@jclouds.org") //
- .license("Apache 2.0") //
- .build();
-
- // Create a new cookbook
- CookbookVersion cookbook = CookbookVersion.builder(PREFIX, "0.0.0") //
- .metadata(metadata) //
- .rootFile(Resource.builder().fromPayload(content).build()) //
- .build();
-
- // upload the cookbook to the remote server
- api.updateCookbook(PREFIX, "0.0.0", cookbook);
+ return content;
}
public void testListCookbooks() throws Exception {
@@ -158,9 +165,9 @@ public abstract class BaseChefApiLiveTest<A extends ChefApi> extends BaseChefLiv
Iterable<? extends CookbookVersion> cookbooks = chefService.listCookbookVersions();
for (CookbookVersion cookbook : cookbooks) {
for (Resource resource : ImmutableList.<Resource> builder().addAll(cookbook.getDefinitions())
- .addAll(cookbook.getFiles()).addAll(cookbook.getLibraries()).addAll(cookbook.getSuppliers())
- .addAll(cookbook.getRecipes()).addAll(cookbook.getResources()).addAll(cookbook.getRootFiles())
- .addAll(cookbook.getTemplates()).build()) {
+ .addAll(cookbook.getFiles()).addAll(cookbook.getLibraries()).addAll(cookbook.getSuppliers())
+ .addAll(cookbook.getRecipes()).addAll(cookbook.getResources()).addAll(cookbook.getRootFiles())
+ .addAll(cookbook.getTemplates()).addAll(cookbook.getAttributes()).build()) {
InputStream stream = api.getResourceContents(resource);
assertNotNull(stream, "Resource contents are null for resource: " + resource.getName());
[23/50] [abbrv] jclouds git commit: Migrate InputSupplier callers to
ByteSource
Posted by na...@apache.org.
Migrate InputSupplier callers to ByteSource
A future version of Guava will remove InputSupplier.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ad47e24f
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ad47e24f
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ad47e24f
Branch: refs/heads/1.8.x
Commit: ad47e24f8f190b62be7025155b829a7475c4a7cb
Parents: 7ada0c7
Author: Andrew Gaul <ga...@apache.org>
Authored: Sat May 17 00:42:21 2014 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Sat May 17 00:44:17 2014 -0700
----------------------------------------------------------------------
.../java/org/jclouds/chef/config/BaseChefHttpApiModule.java | 6 +++---
.../main/java/org/jclouds/chef/config/ChefParserModule.java | 8 ++++----
.../org/jclouds/chef/functions/ParseClientFromJsonTest.java | 6 ++++--
3 files changed, 11 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad47e24f/apis/chef/src/main/java/org/jclouds/chef/config/BaseChefHttpApiModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/BaseChefHttpApiModule.java b/apis/chef/src/main/java/org/jclouds/chef/config/BaseChefHttpApiModule.java
index c7816cb..83a9e29 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/BaseChefHttpApiModule.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/BaseChefHttpApiModule.java
@@ -62,7 +62,7 @@ import com.google.common.base.Supplier;
import com.google.common.cache.CacheBuilder;
import com.google.common.cache.CacheLoader;
import com.google.common.cache.LoadingCache;
-import com.google.common.io.ByteStreams;
+import com.google.common.io.ByteSource;
import com.google.inject.ConfigurationException;
import com.google.inject.Injector;
import com.google.inject.Key;
@@ -137,7 +137,7 @@ public abstract class BaseChefHttpApiModule<S> extends HttpApiModule<S> {
public PrivateKey load(Credentials in) {
try {
return crypto.rsaKeyFactory().generatePrivate(
- privateKeySpec(ByteStreams.newInputStreamSupplier(in.credential.getBytes(Charsets.UTF_8))));
+ privateKeySpec(ByteSource.wrap(in.credential.getBytes(Charsets.UTF_8))));
} catch (InvalidKeySpecException e) {
throw propagate(e);
} catch (IOException e) {
@@ -171,7 +171,7 @@ public abstract class BaseChefHttpApiModule<S> extends HttpApiModule<S> {
try {
String validatorCredential = injector.getInstance(key);
PrivateKey validatorKey = crypto.rsaKeyFactory().generatePrivate(
- Pems.privateKeySpec(ByteStreams.newInputStreamSupplier(validatorCredential.getBytes(Charsets.UTF_8))));
+ Pems.privateKeySpec(ByteSource.wrap(validatorCredential.getBytes(Charsets.UTF_8))));
return Optional.<PrivateKey> of(validatorKey);
} catch (ConfigurationException ex) {
return Optional.<PrivateKey> absent();
http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad47e24f/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java b/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java
index 3e3f13e..baca929 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java
@@ -55,7 +55,7 @@ import com.google.common.base.Objects;
import com.google.common.base.Throwables;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Maps;
-import com.google.common.io.ByteStreams;
+import com.google.common.io.ByteSource;
import com.google.gson.Gson;
import com.google.gson.JsonDeserializationContext;
import com.google.gson.JsonDeserializer;
@@ -96,7 +96,7 @@ public class ChefParserModule extends AbstractModule {
String keyText = json.getAsString().replaceAll("\\n", "\n");
try {
return crypto.rsaKeyFactory().generatePrivate(
- Pems.privateKeySpec(ByteStreams.newInputStreamSupplier(keyText.getBytes(Charsets.UTF_8))));
+ Pems.privateKeySpec(ByteSource.wrap(keyText.getBytes(Charsets.UTF_8))));
} catch (UnsupportedEncodingException e) {
Throwables.propagate(e);
return null;
@@ -130,7 +130,7 @@ public class ChefParserModule extends AbstractModule {
String keyText = json.getAsString().replaceAll("\\n", "\n");
try {
return crypto.rsaKeyFactory().generatePublic(
- Pems.publicKeySpec(ByteStreams.newInputStreamSupplier(keyText.getBytes(Charsets.UTF_8))));
+ Pems.publicKeySpec(ByteSource.wrap(keyText.getBytes(Charsets.UTF_8))));
} catch (UnsupportedEncodingException e) {
Throwables.propagate(e);
return null;
@@ -163,7 +163,7 @@ public class ChefParserModule extends AbstractModule {
throws JsonParseException {
String keyText = json.getAsString().replaceAll("\\n", "\n");
try {
- return Pems.x509Certificate(ByteStreams.newInputStreamSupplier(keyText.getBytes(Charsets.UTF_8)),
+ return Pems.x509Certificate(ByteSource.wrap(keyText.getBytes(Charsets.UTF_8)),
crypto.certFactory());
} catch (UnsupportedEncodingException e) {
Throwables.propagate(e);
http://git-wip-us.apache.org/repos/asf/jclouds/blob/ad47e24f/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
index 7685a95..e21fb15 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
@@ -39,6 +39,8 @@ import org.jclouds.rest.annotations.ApiVersion;
import org.testng.annotations.BeforeTest;
import org.testng.annotations.Test;
+import com.google.common.base.Charsets;
+import com.google.common.io.ByteSource;
import com.google.common.io.ByteStreams;
import com.google.inject.AbstractModule;
import com.google.inject.Guice;
@@ -73,8 +75,8 @@ public class ParseClientFromJsonTest {
handler = injector.getInstance(Key.get(new TypeLiteral<ParseJson<Client>>() {
}));
crypto = injector.getInstance(Crypto.class);
- certificate = Pems.x509Certificate(Payloads.newStringPayload(CERTIFICATE), null);
- privateKey = crypto.rsaKeyFactory().generatePrivate(Pems.privateKeySpec(Payloads.newStringPayload(PRIVATE_KEY)));
+ certificate = Pems.x509Certificate(ByteSource.wrap(CERTIFICATE.getBytes(Charsets.UTF_8)), null);
+ privateKey = crypto.rsaKeyFactory().generatePrivate(Pems.privateKeySpec(ByteSource.wrap(PRIVATE_KEY.getBytes(Charsets.UTF_8))));
}
public void test() throws IOException {
[41/50] [abbrv] jclouds git commit: [maven-release-plugin] prepare
release jclouds-chef-1.8.1-rc1
Posted by na...@apache.org.
[maven-release-plugin] prepare release jclouds-chef-1.8.1-rc1
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/415e6252
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/415e6252
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/415e6252
Branch: refs/heads/1.8.x
Commit: 415e6252aee3856741a36490858bf4b677df9204
Parents: df5a674
Author: Andrew Phillips <an...@apache.org>
Authored: Fri Oct 10 14:22:15 2014 -0400
Committer: Andrew Phillips <an...@apache.org>
Committed: Fri Oct 10 14:22:15 2014 -0400
----------------------------------------------------------------------
apis/chef/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/415e6252/apis/chef/pom.xml
----------------------------------------------------------------------
diff --git a/apis/chef/pom.xml b/apis/chef/pom.xml
index 00a1c4c..3fb7dfe 100644
--- a/apis/chef/pom.xml
+++ b/apis/chef/pom.xml
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.jclouds.chef</groupId>
<artifactId>chef-project</artifactId>
- <version>1.8.1-SNAPSHOT</version>
+ <version>1.8.1</version>
<relativePath>../project/pom.xml</relativePath>
</parent>
<groupId>org.apache.jclouds.api</groupId>
[10/50] [abbrv] jclouds git commit: JCLOUDS-272: Migrate search role
tests from ChefApiTest to ChefApiExpectTest.
Posted by na...@apache.org.
JCLOUDS-272: Migrate search role tests from ChefApiTest to ChefApiExpectTest.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/eee53e38
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/eee53e38
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/eee53e38
Branch: refs/heads/1.8.x
Commit: eee53e38db0c95883edd653d65fe437efed255bf
Parents: 223540a
Author: Noorul Islam K M <no...@noorul.com>
Authored: Wed Sep 18 13:05:37 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Mon Sep 23 09:24:43 2013 +0200
----------------------------------------------------------------------
.../org/jclouds/chef/ChefApiExpectTest.java | 53 ++++++++++++++++++--
.../test/java/org/jclouds/chef/ChefApiTest.java | 34 -------------
apis/chef/src/test/resources/search_role.json | 34 +++++++++++++
.../src/test/resources/search_role_empty.json | 5 ++
4 files changed, 89 insertions(+), 37 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/eee53e38/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
index c3a9372..90e99da 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
@@ -25,6 +25,9 @@ import javax.ws.rs.core.MediaType;
import org.jclouds.chef.config.ChefHttpApiModule;
import org.jclouds.chef.domain.CookbookDefinition;
+import org.jclouds.chef.domain.Role;
+import org.jclouds.chef.domain.SearchResult;
+import org.jclouds.chef.options.SearchOptions;
import org.jclouds.date.TimeStamp;
import org.jclouds.http.HttpRequest;
import org.jclouds.http.HttpResponse;
@@ -36,7 +39,7 @@ import com.google.inject.Module;
/**
* Expect tests for the {@link ChefApi} class.
- *
+ *
* @author Noorul Islam K M
*/
@Test(groups = "unit", testName = "ChefApiExpectTest")
@@ -91,7 +94,7 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
Set<String> nodes = api.listNodes();
assertTrue(nodes.isEmpty(), String.format("Expected nodes to be empty but was: %s", nodes));
}
-
+
public void testListRecipesInEnvironmentReturnsValidSet() {
ChefApi api = requestSendsResponse(
signed(getHttpRequestBuilder("GET", "/environments/dev/recipes").build()),
@@ -156,6 +159,50 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
assertTrue(cookbooks.isEmpty(), String.format("Expected cookbooks to be empty but was: %s", cookbooks));
}
+ public void testSearchRolesReturnsValidResult() {
+ ChefApi api = requestSendsResponse(
+ signed(getHttpRequestBuilder("GET", "/search/role").build()),
+ HttpResponse.builder().statusCode(200)
+ .payload(payloadFromResourceWithContentType("/search_role.json", MediaType.APPLICATION_JSON)) //
+ .build());
+ SearchResult<? extends Role> result = api.searchRoles();
+ assertEquals(result.size(), 1);
+ assertEquals(result.iterator().next().getName(), "webserver");
+ }
+
+ public void testSearchRolesReturnsEmptyResult() {
+ ChefApi api = requestSendsResponse(
+ signed(getHttpRequestBuilder("GET", "/search/role").build()),
+ HttpResponse.builder().statusCode(200)
+ .payload(payloadFromResourceWithContentType("/search_role_empty.json", MediaType.APPLICATION_JSON)) //
+ .build());
+ SearchResult<? extends Role> result = api.searchRoles();
+ assertTrue(result.isEmpty(), String.format("Expected search result to be empty but was: %s", result));
+ }
+
+ public void testSearchRolesWithOptionsReturnsValidResult() {
+ ChefApi api = requestSendsResponse(
+ signed(getHttpRequestBuilder("GET", "/search/role").addQueryParam("q", "name:webserver").build()),
+ HttpResponse.builder().statusCode(200)
+ .payload(payloadFromResourceWithContentType("/search_role.json", MediaType.APPLICATION_JSON)) //
+ .build());
+ SearchOptions options = SearchOptions.Builder.query("name:webserver");
+ SearchResult<? extends Role> result = api.searchRoles(options);
+ assertEquals(result.size(), 1);
+ assertEquals(result.iterator().next().getName(), "webserver");
+ }
+
+ public void testSearchRolesWithOptionsReturnsEmptyResult() {
+ ChefApi api = requestSendsResponse(
+ signed(getHttpRequestBuilder("GET", "/search/role").addQueryParam("q", "name:dummy").build()),
+ HttpResponse.builder().statusCode(200)
+ .payload(payloadFromResourceWithContentType("/search_role_empty.json", MediaType.APPLICATION_JSON)) //
+ .build());
+ SearchOptions options = SearchOptions.Builder.query("name:dummy");
+ SearchResult<? extends Role> result = api.searchRoles(options);
+ assertTrue(result.isEmpty(), String.format("Expected search result to be empty but was: %s", result));
+ }
+
@Override
protected Module createModule() {
return new TestChefRestClientModule();
@@ -173,5 +220,5 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
protected ChefApiMetadata createApiMetadata() {
return new ChefApiMetadata();
}
-
+
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/eee53e38/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
index e6e2c66..5899486 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
@@ -635,40 +635,6 @@ public class ChefApiTest extends BaseAsyncApiTest<ChefApi> {
}
- public void testSearchRoles() throws SecurityException, NoSuchMethodException, IOException {
- Invokable<?, ?> method = method(ChefApi.class, "searchRoles");
- GeneratedHttpRequest httpRequest = processor.apply(Invocation.create(method, ImmutableList.of()));
-
- assertRequestLineEquals(httpRequest, "GET http://localhost:4000/search/role HTTP/1.1");
- assertNonPayloadHeadersEqual(httpRequest, "Accept: application/json\nX-Chef-Version: " + ChefApiMetadata.DEFAULT_API_VERSION
- + "-test\n");
- assertPayloadEquals(httpRequest, null, null, false);
-
- assertResponseParserClassEquals(method, httpRequest, ParseSearchRolesFromJson.class);
- assertSaxResponseParserClassEquals(method, null);
- assertFallbackClassEquals(method, MapHttp4xxCodesToExceptions.class);
-
- checkFilters(httpRequest);
-
- }
-
- public void testSearchRolesWithOptions() throws SecurityException, NoSuchMethodException, IOException {
- Invokable<?, ?> method = method(ChefApi.class, "searchRoles", SearchOptions.class);
- GeneratedHttpRequest httpRequest = processor.apply(Invocation.create(method,
- ImmutableList.<Object> of(SearchOptions.Builder.query("text"))));
-
- assertRequestLineEquals(httpRequest, "GET http://localhost:4000/search/role?q=text HTTP/1.1");
- assertNonPayloadHeadersEqual(httpRequest, "Accept: application/json\nX-Chef-Version: " + ChefApiMetadata.DEFAULT_API_VERSION
- + "-test\n");
- assertPayloadEquals(httpRequest, null, null, false);
-
- assertResponseParserClassEquals(method, httpRequest, ParseSearchRolesFromJson.class);
- assertSaxResponseParserClassEquals(method, null);
- assertFallbackClassEquals(method, MapHttp4xxCodesToExceptions.class);
-
- checkFilters(httpRequest);
-
- }
public void testSearchClients() throws SecurityException, NoSuchMethodException, IOException {
Invokable<?, ?> method = method(ChefApi.class, "searchClients");
http://git-wip-us.apache.org/repos/asf/jclouds/blob/eee53e38/apis/chef/src/test/resources/search_role.json
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/resources/search_role.json b/apis/chef/src/test/resources/search_role.json
new file mode 100644
index 0000000..5e51663
--- /dev/null
+++ b/apis/chef/src/test/resources/search_role.json
@@ -0,0 +1,34 @@
+{
+ "total": 1,
+ "start": 0,
+ "rows": [
+ {
+ "name": "webserver",
+ "description": "The base role for systems that serve HTTP traffic",
+ "json_class": "Chef::Role",
+ "default_attributes": {
+ "apache2": {
+ "listen_ports": [
+ "80",
+ "443"
+ ]
+ }
+ },
+ "override_attributes": {
+ "apache2": {
+ "max_children": "50"
+ }
+ },
+ "chef_type": "role",
+ "run_list": [],
+ "env_run_lists": {
+ "prod": [
+ "recipe[apache2]"
+ ],
+ "staging": [
+ "recipe[apache2::staging]"
+ ]
+ }
+ }
+ ]
+}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/eee53e38/apis/chef/src/test/resources/search_role_empty.json
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/resources/search_role_empty.json b/apis/chef/src/test/resources/search_role_empty.json
new file mode 100644
index 0000000..ab859ca
--- /dev/null
+++ b/apis/chef/src/test/resources/search_role_empty.json
@@ -0,0 +1,5 @@
+{
+ "total": 0,
+ "start": 0,
+ "rows": []
+}
[22/50] [abbrv] jclouds git commit: Prefer Guava HttpHeaders over
JAX-RS
Posted by na...@apache.org.
Prefer Guava HttpHeaders over JAX-RS
jclouds code contains more instances of the former and Guava has
additional constants like CONTENT_MD5.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/7ada0c79
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/7ada0c79
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/7ada0c79
Branch: refs/heads/1.8.x
Commit: 7ada0c7924243d1db026407bec45d16a543dbc6e
Parents: 1e37c67
Author: Andrew Gaul <ga...@apache.org>
Authored: Thu May 15 02:06:22 2014 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Thu May 15 02:06:39 2014 -0700
----------------------------------------------------------------------
.../test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/7ada0c79/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java b/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java
index 27472ca..da67279 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java
@@ -25,7 +25,6 @@ import java.security.PrivateKey;
import javax.inject.Provider;
import javax.ws.rs.HttpMethod;
-import javax.ws.rs.core.HttpHeaders;
import org.jclouds.ContextBuilder;
import org.jclouds.chef.ChefApiMetadata;
@@ -47,6 +46,7 @@ import com.google.common.collect.ImmutableMultimap;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.LinkedHashMultimap;
import com.google.common.collect.Multimap;
+import com.google.common.net.HttpHeaders;
import com.google.inject.Injector;
import com.google.inject.Key;
import com.google.inject.Module;
[29/50] [abbrv] jclouds git commit: JCLOUDS-617: Use the configured
JCE provider in the Cipher payloads
Posted by na...@apache.org.
JCLOUDS-617: Use the configured JCE provider in the Cipher payloads
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/cd0f21d8
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/cd0f21d8
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/cd0f21d8
Branch: refs/heads/1.8.x
Commit: cd0f21d86b2f6ffd53c88eb0831f33dc92e39a25
Parents: 1fe6bca
Author: Ignasi Barrera <na...@apache.org>
Authored: Tue Jul 1 16:07:12 2014 +0200
Committer: Ignasi Barrera <na...@apache.org>
Committed: Wed Jul 2 17:54:33 2014 +0200
----------------------------------------------------------------------
.../jclouds/chef/filters/SignedHeaderAuth.java | 19 ++++++++++++-------
.../jclouds/chef/internal/BaseChefService.java | 10 +++++++---
.../chef/filters/SignedHeaderAuthTest.java | 4 +++-
.../chef/functions/ParseClientFromJsonTest.java | 8 +++++---
4 files changed, 27 insertions(+), 14 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/cd0f21d8/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java b/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
index 30b26c0..0cab71f 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
@@ -18,6 +18,7 @@ package org.jclouds.chef.filters;
import static com.google.common.base.Charsets.UTF_8;
import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Preconditions.checkNotNull;
import static com.google.common.hash.Hashing.sha1;
import static com.google.common.io.BaseEncoding.base64;
import static com.google.common.io.ByteStreams.toByteArray;
@@ -33,6 +34,7 @@ import javax.inject.Provider;
import javax.inject.Singleton;
import org.jclouds.Constants;
+import org.jclouds.crypto.Crypto;
import org.jclouds.date.TimeStamp;
import org.jclouds.domain.Credentials;
import org.jclouds.http.HttpException;
@@ -50,6 +52,7 @@ import org.jclouds.logging.Logger;
import org.jclouds.util.Strings2;
import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Preconditions;
import com.google.common.base.Predicate;
import com.google.common.base.Splitter;
import com.google.common.base.Supplier;
@@ -74,6 +77,7 @@ public class SignedHeaderAuth implements HttpRequestFilter {
private final Provider<String> timeStampProvider;
private final String emptyStringHash;
private final HttpUtils utils;
+ private final Crypto crypto;
@Resource
@Named(Constants.LOGGER_SIGNATURE)
@@ -81,13 +85,14 @@ public class SignedHeaderAuth implements HttpRequestFilter {
@Inject
public SignedHeaderAuth(SignatureWire signatureWire, @org.jclouds.location.Provider Supplier<Credentials> creds,
- Supplier<PrivateKey> supplyKey, @TimeStamp Provider<String> timeStampProvider, HttpUtils utils) {
- this.signatureWire = signatureWire;
- this.creds = creds;
- this.supplyKey = supplyKey;
- this.timeStampProvider = timeStampProvider;
+ Supplier<PrivateKey> supplyKey, @TimeStamp Provider<String> timeStampProvider, HttpUtils utils, Crypto crypto) {
+ this.signatureWire = checkNotNull(signatureWire, "signatureWire");
+ this.creds = checkNotNull(creds, "creds");
+ this.supplyKey = checkNotNull(supplyKey, "supplyKey");
+ this.timeStampProvider = checkNotNull(timeStampProvider, "timeStampProvider");
this.emptyStringHash = hashBody(Payloads.newStringPayload(""));
- this.utils = utils;
+ this.utils = checkNotNull(utils, "utils");
+ this.crypto = checkNotNull(crypto, "crypto");
}
public HttpRequest filter(HttpRequest input) throws HttpException {
@@ -186,7 +191,7 @@ public class SignedHeaderAuth implements HttpRequestFilter {
public String sign(String toSign) {
try {
- byte[] encrypted = toByteArray(new RSAEncryptingPayload(Payloads.newStringPayload(toSign), supplyKey.get()));
+ byte[] encrypted = toByteArray(new RSAEncryptingPayload(crypto, Payloads.newStringPayload(toSign), supplyKey.get()));
return base64().encode(encrypted);
} catch (IOException e) {
throw new HttpException("error signing request", e);
http://git-wip-us.apache.org/repos/asf/jclouds/blob/cd0f21d8/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
index 9619b44..c22e697 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
@@ -54,6 +54,7 @@ import org.jclouds.chef.strategy.ListNodesInEnvironment;
import org.jclouds.chef.strategy.ListEnvironments;
import org.jclouds.chef.strategy.ListNodes;
import org.jclouds.chef.strategy.UpdateAutomaticAttributesOnNode;
+import org.jclouds.crypto.Crypto;
import org.jclouds.domain.JsonBall;
import org.jclouds.io.Payloads;
import org.jclouds.io.payloads.RSADecryptingPayload;
@@ -90,6 +91,8 @@ public class BaseChefService implements ChefService {
private final ListEnvironments listEnvironments;
private final ListNodesInEnvironment listNodesInEnvironment;
private final Json json;
+ private final Crypto crypto;
+
@Resource
@Named(ChefProperties.CHEF_LOGGER)
protected Logger logger = Logger.NULL;
@@ -104,7 +107,7 @@ public class BaseChefService implements ChefService {
@Named(CHEF_BOOTSTRAP_DATABAG) String databag, GroupToBootScript groupToBootScript,
BootstrapConfigForGroup bootstrapConfigForGroup, RunListForGroup runListForGroup,
ListEnvironments listEnvironments, ListNodesInEnvironment listNodesInEnvironment,
- ListCookbookVersionsInEnvironment listCookbookVersionsInEnvironment, Json json) {
+ ListCookbookVersionsInEnvironment listCookbookVersionsInEnvironment, Json json, Crypto crypto) {
this.chefContext = checkNotNull(chefContext, "chefContext");
this.api = checkNotNull(api, "api");
this.cleanupStaleNodesAndClients = checkNotNull(cleanupStaleNodesAndClients, "cleanupStaleNodesAndClients");
@@ -126,6 +129,7 @@ public class BaseChefService implements ChefService {
this.listNodesInEnvironment = checkNotNull(listNodesInEnvironment, "listNodesInEnvironment");
this.listCookbookVersionsInEnvironment = checkNotNull(listCookbookVersionsInEnvironment, "listCookbookVersionsInEnvironment");
this.json = checkNotNull(json, "json");
+ this.crypto = checkNotNull(crypto, "crypto");
}
@Override
@@ -135,13 +139,13 @@ public class BaseChefService implements ChefService {
@Override
public byte[] encrypt(InputSupplier<? extends InputStream> supplier) throws IOException {
- return ByteStreams.toByteArray(new RSAEncryptingPayload(Payloads.newPayload(supplier.getInput()), privateKey
+ return ByteStreams.toByteArray(new RSAEncryptingPayload(crypto, Payloads.newPayload(supplier.getInput()), privateKey
.get()));
}
@Override
public byte[] decrypt(InputSupplier<? extends InputStream> supplier) throws IOException {
- return ByteStreams.toByteArray(new RSADecryptingPayload(Payloads.newPayload(supplier.getInput()), privateKey
+ return ByteStreams.toByteArray(new RSADecryptingPayload(crypto, Payloads.newPayload(supplier.getInput()), privateKey
.get()));
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/cd0f21d8/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java b/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java
index 0e6ca4a..bfba190 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java
@@ -28,6 +28,7 @@ import javax.ws.rs.HttpMethod;
import org.jclouds.ContextBuilder;
import org.jclouds.chef.ChefApiMetadata;
+import org.jclouds.crypto.Crypto;
import org.jclouds.domain.Credentials;
import org.jclouds.http.HttpRequest;
import org.jclouds.http.HttpUtils;
@@ -193,6 +194,7 @@ public class SignedHeaderAuthTest {
.modules(ImmutableSet.<Module> of(new MockModule(), new NullLoggingModule())).buildInjector();
HttpUtils utils = injector.getInstance(HttpUtils.class);
+ Crypto crypto = injector.getInstance(Crypto.class);
Supplier<PrivateKey> privateKey = injector.getInstance(Key.get(new TypeLiteral<Supplier<PrivateKey>>() {
}));
@@ -205,7 +207,7 @@ public class SignedHeaderAuthTest {
return TIMESTAMP_ISO8601;
}
- }, utils);
+ }, utils, crypto);
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/cd0f21d8/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
index 671ff93..e8bebcb 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
@@ -19,6 +19,7 @@ package org.jclouds.chef.functions;
import static org.testng.Assert.assertEquals;
import java.io.IOException;
+import java.security.NoSuchAlgorithmException;
import java.security.PrivateKey;
import java.security.cert.CertificateException;
import java.security.cert.X509Certificate;
@@ -29,6 +30,7 @@ import org.jclouds.chef.config.ChefParserModule;
import org.jclouds.chef.domain.Client;
import org.jclouds.crypto.Crypto;
import org.jclouds.crypto.Pems;
+import org.jclouds.encryption.internal.JCECrypto;
import org.jclouds.http.HttpResponse;
import org.jclouds.http.functions.ParseJson;
import org.jclouds.io.Payloads;
@@ -77,16 +79,16 @@ public class ParseClientFromJsonTest {
privateKey = crypto.rsaKeyFactory().generatePrivate(Pems.privateKeySpec(ByteSource.wrap(PRIVATE_KEY.getBytes(Charsets.UTF_8))));
}
- public void test() throws IOException {
+ public void test() throws IOException, CertificateException, NoSuchAlgorithmException {
Client user = Client.builder().certificate(certificate).orgname("jclouds").clientname("adriancole-jcloudstest")
.name("adriancole-jcloudstest").isValidator(false).privateKey(privateKey).build();
- byte[] encrypted = ByteStreams.toByteArray(new RSAEncryptingPayload(Payloads.newPayload("fooya"), user
+ byte[] encrypted = ByteStreams.toByteArray(new RSAEncryptingPayload(new JCECrypto(), Payloads.newPayload("fooya"), user
.getCertificate().getPublicKey()));
assertEquals(
- ByteStreams.toByteArray(new RSADecryptingPayload(Payloads.newPayload(encrypted), user.getPrivateKey())),
+ ByteStreams.toByteArray(new RSADecryptingPayload(new JCECrypto(), Payloads.newPayload(encrypted), user.getPrivateKey())),
"fooya".getBytes());
assertEquals(
[25/50] [abbrv] jclouds git commit: JCLOUDS-546: Remove Javadoc
@author annotations
Posted by na...@apache.org.
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/ohai/config/OhaiModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/ohai/config/OhaiModule.java b/apis/chef/src/main/java/org/jclouds/ohai/config/OhaiModule.java
index 152b120..650fe9e 100644
--- a/apis/chef/src/main/java/org/jclouds/ohai/config/OhaiModule.java
+++ b/apis/chef/src/main/java/org/jclouds/ohai/config/OhaiModule.java
@@ -45,8 +45,6 @@ import com.google.inject.multibindings.MapBinder;
/**
* Wires the components needed to parse ohai data
- *
- * @author Adrian Cole
*/
@ConfiguresOhai
public class OhaiModule extends AbstractModule {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/ohai/functions/ByteArrayToMacAddress.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/ohai/functions/ByteArrayToMacAddress.java b/apis/chef/src/main/java/org/jclouds/ohai/functions/ByteArrayToMacAddress.java
index 81a2a54..be7e46a 100644
--- a/apis/chef/src/main/java/org/jclouds/ohai/functions/ByteArrayToMacAddress.java
+++ b/apis/chef/src/main/java/org/jclouds/ohai/functions/ByteArrayToMacAddress.java
@@ -32,8 +32,6 @@ import com.google.common.base.Joiner;
/**
*
* Creates a string in the form: {@code 00:26:bb:09:e6:c4 }
- *
- * @author Adrian Cole
*/
@Singleton
public class ByteArrayToMacAddress implements Function<byte[], String> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/ohai/functions/MapSetToMultimap.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/ohai/functions/MapSetToMultimap.java b/apis/chef/src/main/java/org/jclouds/ohai/functions/MapSetToMultimap.java
index 623df9b..4ef3c87 100644
--- a/apis/chef/src/main/java/org/jclouds/ohai/functions/MapSetToMultimap.java
+++ b/apis/chef/src/main/java/org/jclouds/ohai/functions/MapSetToMultimap.java
@@ -26,10 +26,6 @@ import com.google.common.base.Function;
import com.google.common.collect.LinkedHashMultimap;
import com.google.common.collect.Multimap;
-/**
- *
- * @author Adrian Cole
- */
@Singleton
public class MapSetToMultimap<K, V> implements Function<Map<K, Set<V>>, Multimap<K, V>> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/ohai/functions/NestSlashKeys.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/ohai/functions/NestSlashKeys.java b/apis/chef/src/main/java/org/jclouds/ohai/functions/NestSlashKeys.java
index 7e5019a..c709463 100644
--- a/apis/chef/src/main/java/org/jclouds/ohai/functions/NestSlashKeys.java
+++ b/apis/chef/src/main/java/org/jclouds/ohai/functions/NestSlashKeys.java
@@ -42,11 +42,6 @@ import com.google.common.collect.Multimap;
import com.google.common.collect.Sets;
import com.google.inject.TypeLiteral;
-/**
- *
- *
- * @author Adrian Cole
- */
@Singleton
public class NestSlashKeys implements Function<Multimap<String, Supplier<JsonBall>>, Map<String, JsonBall>> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/ohai/suppliers/UptimeSecondsSupplier.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/ohai/suppliers/UptimeSecondsSupplier.java b/apis/chef/src/main/java/org/jclouds/ohai/suppliers/UptimeSecondsSupplier.java
index e4b6800..9713902 100644
--- a/apis/chef/src/main/java/org/jclouds/ohai/suppliers/UptimeSecondsSupplier.java
+++ b/apis/chef/src/main/java/org/jclouds/ohai/suppliers/UptimeSecondsSupplier.java
@@ -25,10 +25,6 @@ import org.jclouds.domain.JsonBall;
import com.google.common.base.Supplier;
-/**
- *
- * @author Adrian Cole
- */
@Singleton
public class UptimeSecondsSupplier implements Supplier<JsonBall> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/BaseChefApiExpectTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/BaseChefApiExpectTest.java b/apis/chef/src/test/java/org/jclouds/chef/BaseChefApiExpectTest.java
index 6e20ed7..23013a9 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/BaseChefApiExpectTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/BaseChefApiExpectTest.java
@@ -26,8 +26,6 @@ import com.google.common.collect.ImmutableMap;
/**
* Base class for Chef Api expect tests.
- *
- * @author Ignasi Barrera
*/
public abstract class BaseChefApiExpectTest<S> extends BaseRestApiExpectTest<S> {
public static final String PRIVATE_KEY = "-----BEGIN RSA PRIVATE KEY-----\nMIIEpQIBAAKCAQEAyb2ZJJqGm0KKR+8nfQJNsSd+F9tXNMV7CfOcW6jsqs8EZgiV\nR09hD1IYOj4YqM0qJONlgyg4xRWewdSG7QTPj1lJpVAida9sXy2+kzyagZA1Am0O\nZcbqb5hoeIDgcX+eDa79s0u0DomjcfO9EKhvHLBz+zM+3QqPRkPV8nYTbfs+HjVz\nzOU6D1B0XR3+IPZZl2AnWs2d0qhnStHcDUvnRVQ0P482YwN9VgceOZtpPz0DCKEJ\n5Tx5STub8k0/zt/VAMHQafLSuQMLd2s4ZLuOZptN//uAsTmxireqd37z+8ZTdBbJ\n8LEpJ+iCXuSfm5aUh7iw6oxvToY2AL53+jK2UQIDAQABAoIBAQDA88B3i/xWn0vX\nBVxFamCYoecuNjGwXXkSyZew616A+EOCu47bh4aTurdFbYL0YFaAtaWvzlaN2eHg\nDb+HDuTefE29+WkcGk6SshPmiz5T0XOCAICWw6wSVDkHmGwS4jZvbAFm7W8nwGk9\nYhxgxFiRngswJZFopOLoF5WXs2td8guIYNslMpo7tu50iFnBHwKO2ZsPAk8t9nnS\nxlDavKruymEmqHCr3+dtio5eaenJcp3fjoXBQOKUk3ipII29XRB8NqeCVV/7Kxwq\nckqOBEbRwBclckyIbD+RiAgKvOelORjEiE9R42vuqvxRA6k9kd9o7utlX0AUtpEn\n3gZc6LepAoGBAP9ael5Y75+sK2JJUNOOhO8ae45cdsilp2yI0X+UBaSuQs2+dyPp\nkpEHAxd4pmmSvn/8c9TlEZhr+qYbABXVPlDncxpIuw2Ajbk7s/S4XaSKsRqpXL57\nzj/QOqLkRk8+OVV9q6lMeQNqLtEj1u6JPviX70Ro+FQtRttNOYbfdP/fAoGBA
MpA\nXjR5woV5sUb+REg9vEuYo8RSyOarxqKFCIXVUNsLOx+22+AK4+CQpbueWN7jotrl\nYD6uT6svWi3AAC7kiY0UI/fjVPRCUi8tVoQUE0TaU5VLITaYOB+W/bBaDE4M9560\n1NuDWO90baA5dfU44iuzva02rGJXK9+nS3o8nk/PAoGBALOL6djnDe4mwAaG6Jco\ncd4xr8jkyPzCRZuyBCSBbwphIUXLc7hDprPky064ncJD1UDmwIdkXd/fpMkg2QmA\n/CUk6LEFjMisqHojOaCL9gQZJPhLN5QUN2x1PJWGjs1vQh8Tkx0iUUCOa8bQPXNR\n+34OTsW6TUna4CSZAycLfhffAoGBAIggVsefBCvuQkF0NeUhmDCRZfhnd8y55RHR\n1HCvqKIlpv+rhcX/zmyBLuteopYyRJRsOiE2FW00i8+rIPRu4Z3Q5nybx7w3PzV9\noHN5R5baE9OyI4KpZWztpYYitZF67NcnAvVULHHOvVJQGnKYfLHJYmrJF7GA1ojM\nAuMdFbjFAoGAPxUhxwFy8gaqBahKUEZn4F81HFP5ihGhkT4QL6AFPO2e+JhIGjuR\n27+85hcFqQ+HHVtFsm81b/a+R7P4UuCRgc8eCjxQMoJ1Xl4n7VbjPbHMnIN0Ryvd\nO4ZpWDWYnCO021JTOUUOJ4J/y0416Bvkw0z59y7sNX7wDBBHHbK/XCc=\n-----END RSA PRIVATE KEY-----\n";
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
index 4417f0d..ea4070d 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
@@ -39,8 +39,6 @@ import com.google.inject.Module;
/**
* Expect tests for the {@link ChefApi} class.
- *
- * @author Noorul Islam K M
*/
@Test(groups = "unit", testName = "ChefApiExpectTest")
public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/ChefApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiLiveTest.java
index b8fce0e..e4ad583 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiLiveTest.java
@@ -21,8 +21,6 @@ import org.testng.annotations.Test;
/**
* Tests behavior of {@code ChefApi} against a Chef Server <= 0.9.8.
- *
- * @author Adrian Cole
*/
@Test(groups = { "live" })
public class ChefApiLiveTest extends BaseChefApiLiveTest<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/ChefApiMetadataTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiMetadataTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiMetadataTest.java
index cb6f714..a78c20a 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiMetadataTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiMetadataTest.java
@@ -23,10 +23,6 @@ import org.testng.annotations.Test;
import com.google.common.collect.ImmutableSet;
import com.google.common.reflect.TypeToken;
-/**
- *
- * @author Adrian Cole
- */
@Test(groups = "unit", testName = "ChefApiMetadataTest")
public class ChefApiMetadataTest extends BaseHttpApiMetadataTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
index 28df35f..98eeb0b 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
@@ -70,8 +70,6 @@ import com.google.inject.Module;
/**
* Tests annotation parsing of {@code ChefApi}.
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" })
public class ChefApiTest extends BaseAsyncApiTest<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/binders/BindHexEncodedMD5sToJsonPayloadTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/binders/BindHexEncodedMD5sToJsonPayloadTest.java b/apis/chef/src/test/java/org/jclouds/chef/binders/BindHexEncodedMD5sToJsonPayloadTest.java
index cd40808..7648732 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/binders/BindHexEncodedMD5sToJsonPayloadTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/binders/BindHexEncodedMD5sToJsonPayloadTest.java
@@ -36,9 +36,6 @@ import com.google.inject.AbstractModule;
import com.google.inject.Guice;
import com.google.inject.Injector;
-/**
- * @author Adrian Cole
- */
@Test(groups = { "unit" })
public class BindHexEncodedMD5sToJsonPayloadTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/config/ChefParserModuleTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/config/ChefParserModuleTest.java b/apis/chef/src/test/java/org/jclouds/chef/config/ChefParserModuleTest.java
index 76db791..9b1354e 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/config/ChefParserModuleTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/config/ChefParserModuleTest.java
@@ -33,8 +33,6 @@ import com.google.gson.GsonBuilder;
/**
* Unit tests for the {@link ChefParserModule} class.
- *
- * @author Ignasi Barrera
*/
@Test(groups = "unit", testName = "ChefParserModuleTest")
public class ChefParserModuleTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java b/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java
index da67279..0e6ca4a 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/filters/SignedHeaderAuthTest.java
@@ -52,10 +52,6 @@ import com.google.inject.Key;
import com.google.inject.Module;
import com.google.inject.TypeLiteral;
-/**
- *
- * @author Adrian Cole
- */
@Test(groups = { "unit" })
public class SignedHeaderAuthTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/BootstrapConfigForGroupTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/BootstrapConfigForGroupTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/BootstrapConfigForGroupTest.java
index b8cb982..f326482 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/BootstrapConfigForGroupTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/BootstrapConfigForGroupTest.java
@@ -30,10 +30,6 @@ import org.jclouds.chef.domain.DatabagItem;
import org.jclouds.rest.annotations.Api;
import org.testng.annotations.Test;
-/**
- * @author Adrian Cole
- * @author Ignasi Barrera
- */
@Test(groups = "unit", testName = "BootstrapConfigForGroupTest")
public class BootstrapConfigForGroupTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ClientForGroupTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ClientForGroupTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ClientForGroupTest.java
index 6737ca6..4be873c 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ClientForGroupTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ClientForGroupTest.java
@@ -31,9 +31,6 @@ import org.testng.annotations.Test;
import com.google.common.collect.ImmutableSet;
-/**
- * @author Adrian Cole
- */
@Test(groups = "unit", testName = "ClientForGroupTest")
public class ClientForGroupTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/GroupToBootScriptTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/GroupToBootScriptTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/GroupToBootScriptTest.java
index fa9cf3f..8792025 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/GroupToBootScriptTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/GroupToBootScriptTest.java
@@ -58,9 +58,6 @@ import com.google.inject.Injector;
import com.google.inject.Key;
import com.google.inject.name.Names;
-/**
- * @author Adrian Cole
- */
@Test(groups = "unit", testName = "GroupToBootScriptTest")
public class GroupToBootScriptTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
index e21fb15..671ff93 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
@@ -50,8 +50,6 @@ import com.google.inject.TypeLiteral;
/**
* Tests behavior of {@code ParseClientFromJson}
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" })
public class ParseClientFromJsonTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionCheckingChefVersionTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionCheckingChefVersionTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionCheckingChefVersionTest.java
index ad984a6..300c8e0 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionCheckingChefVersionTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionCheckingChefVersionTest.java
@@ -29,8 +29,6 @@ import com.google.inject.Injector;
/**
* Tests behavior of {@code ParseCookbookDefinitionCheckingChefVersion}.
- *
- * @author Ignasi Barrera
*/
@Test(groups = { "unit" }, singleThreaded = true)
public class ParseCookbookDefinitionCheckingChefVersionTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonTest.java
index a89da9a..736b283 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonTest.java
@@ -35,8 +35,6 @@ import com.google.inject.Injector;
/**
* Tests behavior of {@code ParseCookbookDefinitionFromJson}.
- *
- * @author Ignasi Barrera
*/
@Test(groups = { "unit" }, singleThreaded = true)
public class ParseCookbookDefinitionFromJsonTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionFromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionFromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionFromJsonTest.java
index 9a279b4..7bc19bf 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionFromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionFromJsonTest.java
@@ -43,9 +43,6 @@ import com.google.inject.TypeLiteral;
/**
* Tests behavior of {@code ParseCookbookVersionFromJson}
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
@Test(groups = { "unit" }, singleThreaded = true)
public class ParseCookbookVersionFromJsonTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsCheckingChefVersionTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsCheckingChefVersionTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsCheckingChefVersionTest.java
index 21fb712..bad0edf 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsCheckingChefVersionTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsCheckingChefVersionTest.java
@@ -29,8 +29,6 @@ import com.google.inject.Injector;
/**
* Tests behavior of {@code ParseCookbookVersionsCheckingChefVersion}.
- *
- * @author Ignasi Barrera
*/
@Test(groups = { "unit" }, singleThreaded = true)
public class ParseCookbookVersionsCheckingChefVersionTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJsonTest.java
index 77128d0..08cf1d2 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJsonTest.java
@@ -35,8 +35,6 @@ import com.google.inject.Injector;
/**
* Tests behavior of {@code ParseCookbookVersionsV09FromJson}
- *
- * @author Ignasi Barrera
*/
@Test(groups = { "unit" }, singleThreaded = true)
public class ParseCookbookVersionsV09FromJsonTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJsonTest.java
index 0d14c31..e8b396a 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJsonTest.java
@@ -35,8 +35,6 @@ import com.google.inject.Injector;
/**
* Tests behavior of {@code ParseCookbookVersionsV10FromJson}
- *
- * @author Ignasi Barrera
*/
@Test(groups = { "unit" }, singleThreaded = true)
public class ParseCookbookVersionsV10FromJsonTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseDataBagItemFromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseDataBagItemFromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseDataBagItemFromJsonTest.java
index cab8d8a..5dde523 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseDataBagItemFromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseDataBagItemFromJsonTest.java
@@ -37,9 +37,6 @@ import com.google.inject.Injector;
import com.google.inject.Key;
import com.google.inject.TypeLiteral;
-/**
- * @author AdrianCole
- */
@Test(groups = { "unit" })
public class ParseDataBagItemFromJsonTest {
private ParseJson<DatabagItem> handler;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseErrorFromJsonOrReturnBodyTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseErrorFromJsonOrReturnBodyTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseErrorFromJsonOrReturnBodyTest.java
index 9749664..940e858 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseErrorFromJsonOrReturnBodyTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseErrorFromJsonOrReturnBodyTest.java
@@ -26,9 +26,6 @@ import org.jclouds.http.functions.ReturnStringIf2xx;
import org.jclouds.util.Strings2;
import org.testng.annotations.Test;
-/**
- * @author Adrian Cole
- */
@Test(groups = { "unit" })
public class ParseErrorFromJsonOrReturnBodyTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseKeySetFromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseKeySetFromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseKeySetFromJsonTest.java
index 82e6d90..8c646b2 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseKeySetFromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseKeySetFromJsonTest.java
@@ -35,8 +35,6 @@ import com.google.inject.Injector;
/**
* Tests behavior of {@code ParseKeySetFromJson}
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" }, singleThreaded = true)
public class ParseKeySetFromJsonTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseNodeFromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseNodeFromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseNodeFromJsonTest.java
index f0b8a7d..72b4956 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseNodeFromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseNodeFromJsonTest.java
@@ -39,8 +39,6 @@ import com.google.inject.TypeLiteral;
/**
* Tests behavior of {@code ParseNodeFromJson}
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" }, singleThreaded = true)
public class ParseNodeFromJsonTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseSandboxFromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseSandboxFromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseSandboxFromJsonTest.java
index 781b7a6..dd31d38 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseSandboxFromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseSandboxFromJsonTest.java
@@ -39,8 +39,6 @@ import com.google.inject.TypeLiteral;
/**
* Tests behavior of {@code ParseSandboxFromJson}
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" }, singleThreaded = true)
public class ParseSandboxFromJsonTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseSearchDataBagItemFromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseSearchDataBagItemFromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseSearchDataBagItemFromJsonTest.java
index c506d61..3daf3a8 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseSearchDataBagItemFromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseSearchDataBagItemFromJsonTest.java
@@ -34,9 +34,6 @@ import com.google.inject.AbstractModule;
import com.google.inject.Guice;
import com.google.inject.Injector;
-/**
- * @author Ignasi Barrera
- */
@Test(groups = { "unit" })
public class ParseSearchDataBagItemFromJsonTest {
private ParseSearchDatabagFromJson handler;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/ParseUploadSandboxFromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseUploadSandboxFromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseUploadSandboxFromJsonTest.java
index e242992..b92fb3a 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseUploadSandboxFromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseUploadSandboxFromJsonTest.java
@@ -42,8 +42,6 @@ import com.google.inject.TypeLiteral;
/**
* Tests behavior of {@code ParseUploadSiteFromJson}
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" }, singleThreaded = true)
public class ParseUploadSandboxFromJsonTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/RunListForGroupTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/RunListForGroupTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/RunListForGroupTest.java
index fdb1c52..28b8833 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/RunListForGroupTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/RunListForGroupTest.java
@@ -40,10 +40,6 @@ import com.google.inject.AbstractModule;
import com.google.inject.Guice;
import com.google.inject.Injector;
-/**
- * @author Adrian Cole
- * @author Ignasi Barrera
- */
@Test(groups = "unit", testName = "RunListForGroupTest")
public class RunListForGroupTest {
private Injector injector = Guice.createInjector(new AbstractModule() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/functions/UriForResourceTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/UriForResourceTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/UriForResourceTest.java
index 98c7d07..3285a1c 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/UriForResourceTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/UriForResourceTest.java
@@ -27,8 +27,6 @@ import com.google.common.base.Function;
/**
* Tests behavior of {@code UriForResource}
- *
- * @author Ignasi Barrera
*/
@Test(groups = { "unit" })
public class UriForResourceTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/handlers/ChefApiErrorRetryHandlerTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/handlers/ChefApiErrorRetryHandlerTest.java b/apis/chef/src/test/java/org/jclouds/chef/handlers/ChefApiErrorRetryHandlerTest.java
index 85c9240..5e99675 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/handlers/ChefApiErrorRetryHandlerTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/handlers/ChefApiErrorRetryHandlerTest.java
@@ -29,8 +29,6 @@ import org.testng.annotations.Test;
/**
* Tests behavior of {@code ChefClientErrorRetryHandler}
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" })
public class ChefApiErrorRetryHandlerTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
index bae390f..bbc1473 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
@@ -69,8 +69,6 @@ import com.google.common.primitives.Bytes;
/**
* Tests behavior of {@code ChefApi}
- *
- * @author Adrian Cole
*/
@Test(groups = { "live", "integration" })
public abstract class BaseChefApiLiveTest<A extends ChefApi> extends BaseChefLiveTest<A> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefLiveTest.java
index 4c6ca59..e314418 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefLiveTest.java
@@ -35,10 +35,6 @@ import com.google.common.reflect.TypeToken;
import com.google.inject.Injector;
import com.google.inject.Module;
-/**
- *
- * @author Adrian Cole
- */
@Test(groups = "live")
public abstract class BaseChefLiveTest<A extends ChefApi> extends BaseApiLiveTest<A> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefServiceTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefServiceTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefServiceTest.java
index 7f74e54..e763d8f 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefServiceTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefServiceTest.java
@@ -38,8 +38,6 @@ import com.google.inject.Module;
/**
* Unit tests for the <code>BaseChefService</code> class.
- *
- * @author Ignasi Barrera
*/
@Test(groups = "unit", testName = "BaseChefServiceTest")
public class BaseChefServiceTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/internal/BaseStubbedOhaiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseStubbedOhaiLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseStubbedOhaiLiveTest.java
index b057e68..8779017 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseStubbedOhaiLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseStubbedOhaiLiveTest.java
@@ -36,10 +36,6 @@ import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import com.google.inject.Module;
-/**
- *
- * @author Adrian Cole
- */
@Test(groups = "live")
@Deprecated
public class BaseStubbedOhaiLiveTest extends BaseChefLiveTest<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImplLiveTest.java
index 30363c3..e8b249b 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImplLiveTest.java
@@ -27,8 +27,6 @@ import com.google.common.collect.ImmutableSet;
/**
* Tests behavior of {@code CleanupStaleNodesAndClientsImpl} strategies
- *
- * @author Adrian Cole
*/
@Test(groups = "live", testName = "CleanupStaleNodesAndClientsImplLiveTest")
public class CleanupStaleNodesAndClientsImplLiveTest extends BaseChefLiveTest<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImplLiveTest.java
index 4b55efd..60f2661 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImplLiveTest.java
@@ -31,8 +31,6 @@ import com.google.common.collect.ImmutableSet;
/**
* Tests behavior of {@code CreateNodeAndPopulateAutomaticAttributesImpl}
* strategies
- *
- * @author Adrian Cole
*/
@Test(groups = "live", testName = "CreateNodeAndPopulateAutomaticAttributesImplLiveTest")
public class CreateNodeAndPopulateAutomaticAttributesImplLiveTest extends BaseChefLiveTest<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImplTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImplTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImplTest.java
index ace63e1..3ba7110 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImplTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImplTest.java
@@ -34,8 +34,6 @@ import com.google.common.collect.ImmutableSet;
/**
* Tests behavior of {@code CreateNodeAndPopulateAutomaticAttributesImpl}
- *
- * @author Adrian Cole
*/
@Test(groups = "unit", testName = "CreateNodeAndPopulateAutomaticAttributesImplTest")
public class CreateNodeAndPopulateAutomaticAttributesImplTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/DeleteAllApisAndNodesInListImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/DeleteAllApisAndNodesInListImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/DeleteAllApisAndNodesInListImplLiveTest.java
index 79cef87..6f0e595 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/DeleteAllApisAndNodesInListImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/DeleteAllApisAndNodesInListImplLiveTest.java
@@ -27,8 +27,6 @@ import com.google.common.collect.ImmutableSet;
/**
* Tests behavior of {@code DeleteAllApisAndNodesInListImpl} strategies
- *
- * @author Adrian Cole
*/
@Test(groups = "live", testName = "DeleteAllApisAndNodesInListImplLiveTest")
public class DeleteAllApisAndNodesInListImplLiveTest extends BaseChefLiveTest<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
index 1868256..d1786aa 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
@@ -45,8 +45,6 @@ import com.google.common.primitives.Bytes;
/**
* Tests behavior of {@code ListCookbookVersionsInEnvironmentImpl} strategies
- *
- * @author Noorul Islam K M
*/
@Test(groups = "live", testName = "ListCookbookVersionsInEnvironmentImplLiveTest")
public class ListCookbookVersionsInEnvironmentImplLiveTest extends BaseChefLiveTest<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
index f4c7ed1..b9de2b8 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
@@ -28,8 +28,6 @@ import com.google.common.collect.ImmutableSet;
/**
* Tests behavior of {@code ListNodesImpl} strategies
- *
- * @author Adrian Cole
*/
@Test(groups = "live", testName = "ListNodesImplLiveTest")
public class ListNodesImplLiveTest extends BaseChefLiveTest<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
index 25863d9..81dd6d8 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
@@ -28,8 +28,6 @@ import com.google.common.collect.ImmutableSet;
/**
* Tests behavior of {@code ListNodesInEnvironmentImpl} strategies
- *
- * @author Noorul Islam K M
*/
@Test(groups = "live", testName = "ListNodesInEnvironmentImplLiveTest")
public class ListNodesInEnvironmentImplLiveTest extends BaseChefLiveTest<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImplLiveTest.java
index e8681d2..a8f7438 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImplLiveTest.java
@@ -30,8 +30,6 @@ import com.google.common.collect.ImmutableSet;
/**
* Tests behavior of {@code UpdateAutomaticAttributesOnNodeImpl} strategies
- *
- * @author Adrian Cole
*/
@Test(groups = "live", testName = "UpdateAutomaticAttributesOnNodeImplLiveTest")
public class UpdateAutomaticAttributesOnNodeImplLiveTest extends BaseChefLiveTest<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImplTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImplTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImplTest.java
index 792e391..2e0d198 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImplTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImplTest.java
@@ -34,8 +34,6 @@ import com.google.common.collect.ImmutableMap;
/**
* Tests behavior of {@code UpdateAutomaticAttributesOnNodeImpl}
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" })
public class UpdateAutomaticAttributesOnNodeImplTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/suppliers/ChefVersionSupplierTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/suppliers/ChefVersionSupplierTest.java b/apis/chef/src/test/java/org/jclouds/chef/suppliers/ChefVersionSupplierTest.java
index a32359d..915f5cf 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/suppliers/ChefVersionSupplierTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/suppliers/ChefVersionSupplierTest.java
@@ -23,8 +23,6 @@ import org.testng.annotations.Test;
/**
* Unit tests for the {@link ChefVersionSupplier} class.
- *
- * @author Ignasi Barrera
*/
@Test(groups = "unit", testName = "ChefVersionSupplierTest")
public class ChefVersionSupplierTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiIntegrationTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiIntegrationTest.java b/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiIntegrationTest.java
index 13c002e..ecd5d16 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiIntegrationTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiIntegrationTest.java
@@ -28,8 +28,6 @@ import org.testng.annotations.Test;
/**
* Tests behavior of {@code TransientChefApi}
- *
- * @author Adrian Cole
*/
@Test(groups = { "integration" })
public class TransientChefApiIntegrationTest extends BaseChefLiveTest<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiMetadataTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiMetadataTest.java b/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiMetadataTest.java
index 50f23fb..eac33f3 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiMetadataTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiMetadataTest.java
@@ -23,10 +23,6 @@ import org.testng.annotations.Test;
import com.google.common.collect.ImmutableSet;
import com.google.common.reflect.TypeToken;
-/**
- *
- * @author Adrian Cole
- */
@Test(groups = "unit", testName = "TransientChefApiMetadataTest")
public class TransientChefApiMetadataTest extends BaseHttpApiMetadataTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/util/ChefUtilsTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/util/ChefUtilsTest.java b/apis/chef/src/test/java/org/jclouds/chef/util/ChefUtilsTest.java
index 70b9e97..40645e7 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/util/ChefUtilsTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/util/ChefUtilsTest.java
@@ -28,8 +28,6 @@ import com.google.common.collect.ImmutableList;
/**
* Tests behavior of {@code ChefUtils}
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" }, sequential = true)
public class ChefUtilsTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/chef/util/RunListBuilderTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/util/RunListBuilderTest.java b/apis/chef/src/test/java/org/jclouds/chef/util/RunListBuilderTest.java
index 9e3ca25..674be80 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/util/RunListBuilderTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/util/RunListBuilderTest.java
@@ -24,8 +24,6 @@ import com.google.common.collect.ImmutableList;
/**
* Tests possible uses of RunListBuilder
- *
- * @author Adrian Cole
*/
public class RunListBuilderTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/ohai/config/JMXTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/ohai/config/JMXTest.java b/apis/chef/src/test/java/org/jclouds/ohai/config/JMXTest.java
index f3f12c6..bcda2e9 100644
--- a/apis/chef/src/test/java/org/jclouds/ohai/config/JMXTest.java
+++ b/apis/chef/src/test/java/org/jclouds/ohai/config/JMXTest.java
@@ -42,8 +42,6 @@ import com.google.inject.Injector;
/**
* Tests behavior of {@code JMX}
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" })
public class JMXTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/ohai/config/OhaiModuleTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/ohai/config/OhaiModuleTest.java b/apis/chef/src/test/java/org/jclouds/ohai/config/OhaiModuleTest.java
index ca600a1..ecc4562 100644
--- a/apis/chef/src/test/java/org/jclouds/ohai/config/OhaiModuleTest.java
+++ b/apis/chef/src/test/java/org/jclouds/ohai/config/OhaiModuleTest.java
@@ -45,8 +45,6 @@ import com.google.inject.util.Providers;
/**
* Tests behavior of {@code OhaiModule}
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" })
public class OhaiModuleTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/ohai/functions/ByteArrayToMacAddressTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/ohai/functions/ByteArrayToMacAddressTest.java b/apis/chef/src/test/java/org/jclouds/ohai/functions/ByteArrayToMacAddressTest.java
index 0825374..f736dad 100644
--- a/apis/chef/src/test/java/org/jclouds/ohai/functions/ByteArrayToMacAddressTest.java
+++ b/apis/chef/src/test/java/org/jclouds/ohai/functions/ByteArrayToMacAddressTest.java
@@ -23,8 +23,6 @@ import org.testng.annotations.Test;
/**
* Tests behavior of {@code ByteArrayToMacAddress}
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" }, sequential = true)
public class ByteArrayToMacAddressTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/test/java/org/jclouds/ohai/functions/NestSlashKeysTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/ohai/functions/NestSlashKeysTest.java b/apis/chef/src/test/java/org/jclouds/ohai/functions/NestSlashKeysTest.java
index 6d26cb6..594ab58 100644
--- a/apis/chef/src/test/java/org/jclouds/ohai/functions/NestSlashKeysTest.java
+++ b/apis/chef/src/test/java/org/jclouds/ohai/functions/NestSlashKeysTest.java
@@ -38,8 +38,6 @@ import com.google.inject.Injector;
/**
* Tests behavior of {@code NestSlashKeys}
- *
- * @author Adrian Cole
*/
@Test(groups = { "unit" }, sequential = true)
public class NestSlashKeysTest {
[37/50] [abbrv] jclouds git commit: Addressing Checkstyle violations
Posted by na...@apache.org.
Addressing Checkstyle violations
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/742e3eb6
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/742e3eb6
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/742e3eb6
Branch: refs/heads/1.8.x
Commit: 742e3eb65c4fb3093d72ddfdc23e8631255bb721
Parents: 22d8a38
Author: Andrew Phillips <an...@apache.org>
Authored: Mon Aug 11 17:06:28 2014 -0400
Committer: Andrew Phillips <an...@apache.org>
Committed: Mon Aug 11 17:06:28 2014 -0400
----------------------------------------------------------------------
.../src/main/java/org/jclouds/chef/internal/BaseChefService.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/742e3eb6/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
index d390555..d7cf89b 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
@@ -128,7 +128,7 @@ public class BaseChefService implements ChefService {
this.runListForGroup = checkNotNull(runListForGroup, "runListForGroup");
this.listEnvironments = checkNotNull(listEnvironments, "listEnvironments");
this.listNodesInEnvironment = checkNotNull(listNodesInEnvironment, "listNodesInEnvironment");
- this.listCookbookVersionsInEnvironment = checkNotNull(listCookbookVersionsInEnvironment,"listCookbookVersionsInEnvironment");
+ this.listCookbookVersionsInEnvironment = checkNotNull(listCookbookVersionsInEnvironment, "listCookbookVersionsInEnvironment");
this.json = checkNotNull(json, "json");
this.crypto = checkNotNull(crypto, "crypto");
}
[36/50] [abbrv] jclouds git commit: [maven-release-plugin] prepare
for next development iteration
Posted by na...@apache.org.
[maven-release-plugin] prepare for next development iteration
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/423f1eaf
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/423f1eaf
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/423f1eaf
Branch: refs/heads/1.8.x
Commit: 423f1eaf99e6c50a220023eebb0fdd46fc81a8ed
Parents: 67c0846
Author: Andrew Phillips <an...@apache.org>
Authored: Tue Jul 29 19:53:30 2014 -0400
Committer: Andrew Phillips <an...@apache.org>
Committed: Tue Jul 29 19:53:30 2014 -0400
----------------------------------------------------------------------
providers/enterprisechef/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/423f1eaf/providers/enterprisechef/pom.xml
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/pom.xml b/providers/enterprisechef/pom.xml
index 3a0e2de..dc6c527 100644
--- a/providers/enterprisechef/pom.xml
+++ b/providers/enterprisechef/pom.xml
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.jclouds.chef</groupId>
<artifactId>chef-project</artifactId>
- <version>1.8.0</version>
+ <version>1.8.1-SNAPSHOT</version>
<relativePath>../project/pom.xml</relativePath>
</parent>
<groupId>org.apache.jclouds.provider</groupId>
[18/50] [abbrv] jclouds git commit: Enforce no unused imports via
Checkstyle
Posted by na...@apache.org.
Enforce no unused imports via Checkstyle
Removed with:
mvn checkstyle:checkstyle --quiet -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | while read i; do echo $i | sed -n 's/\([^:]*\):\([^:]*\):.*/sed -i \2d \1/p' | bash; done
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/f4895cc0
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/f4895cc0
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/f4895cc0
Branch: refs/heads/1.8.x
Commit: f4895cc0e2be714f6a1df824da2d0d3d1cc60275
Parents: ec1f237
Author: Andrew Gaul <ga...@apache.org>
Authored: Wed Dec 11 17:27:59 2013 -0800
Committer: Andrew Gaul <ga...@apache.org>
Committed: Wed Dec 11 17:27:59 2013 -0800
----------------------------------------------------------------------
.../java/org/jclouds/enterprisechef/EnterpriseChefApiMetadata.java | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/f4895cc0/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApiMetadata.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApiMetadata.java b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApiMetadata.java
index a0a6d08..ed5ca34 100644
--- a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApiMetadata.java
+++ b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApiMetadata.java
@@ -19,7 +19,6 @@ package org.jclouds.enterprisechef;
import java.net.URI;
import java.util.Properties;
-import org.jclouds.apis.ApiMetadata;
import org.jclouds.chef.ChefApiMetadata;
import org.jclouds.chef.ChefContext;
import org.jclouds.chef.config.ChefBootstrapModule;
[24/50] [abbrv] jclouds git commit: JCLOUDS-546: Remove Javadoc
@author annotations
Posted by na...@apache.org.
JCLOUDS-546: Remove Javadoc @author annotations
Annotations removed with:
find -name \*.java | xargs sed -i /@author/d
Empty Javadoc removed with multiple iterations of:
find -name \*.java | xargs sed -i -z 's/ \*\n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/ \* \n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/\/\*\*\n \*\/\n//'
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/b9b6f39d
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/b9b6f39d
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/b9b6f39d
Branch: refs/heads/1.8.x
Commit: b9b6f39d420336844f00cd1f00a4ad669148d831
Parents: bd36ccd
Author: Andrew Gaul <ga...@apache.org>
Authored: Fri Jun 6 22:25:04 2014 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Sat Jun 7 21:09:23 2014 -0700
----------------------------------------------------------------------
.../main/java/org/jclouds/enterprisechef/EnterpriseChefApi.java | 2 --
.../java/org/jclouds/enterprisechef/EnterpriseChefApiMetadata.java | 2 --
.../org/jclouds/enterprisechef/EnterpriseChefProviderMetadata.java | 2 --
.../binders/BindGroupToUpdateRequestJsonPayload.java | 2 --
.../main/java/org/jclouds/enterprisechef/binders/GroupName.java | 2 --
.../jclouds/enterprisechef/config/EnterpriseChefHttpApiModule.java | 2 --
.../src/main/java/org/jclouds/enterprisechef/domain/Group.java | 2 --
.../src/main/java/org/jclouds/enterprisechef/domain/User.java | 2 --
.../org/jclouds/enterprisechef/EnterpriseChefApiExpectTest.java | 2 --
.../java/org/jclouds/enterprisechef/EnterpriseChefApiLiveTest.java | 2 --
.../jclouds/enterprisechef/EnterpriseChefProviderMetadataTest.java | 2 --
.../binders/BindGroupToUpdateRequestJsonPayloadTest.java | 2 --
.../java/org/jclouds/enterprisechef/binders/GroupNameTest.java | 2 --
13 files changed, 26 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApi.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApi.java b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApi.java
index 33f85c6..8f1a0ed 100644
--- a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApi.java
+++ b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApi.java
@@ -47,8 +47,6 @@ import org.jclouds.rest.annotations.WrapWith;
/**
* Provides synchronous access to the Enterprise Chef Api.
- *
- * @author Ignasi Barrera
*/
@RequestFilters(SignedHeaderAuth.class)
@Consumes(MediaType.APPLICATION_JSON)
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApiMetadata.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApiMetadata.java b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApiMetadata.java
index ed5ca34..fdccf46 100644
--- a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApiMetadata.java
+++ b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefApiMetadata.java
@@ -32,8 +32,6 @@ import com.google.inject.Module;
/**
* Implementation of {@link ApiMetadata} for the Enterprise Chef api.
- *
- * @author Adrian Cole
*/
public class EnterpriseChefApiMetadata extends BaseHttpApiMetadata<EnterpriseChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefProviderMetadata.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefProviderMetadata.java b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefProviderMetadata.java
index 89c6db8..336ea7a 100644
--- a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefProviderMetadata.java
+++ b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/EnterpriseChefProviderMetadata.java
@@ -24,8 +24,6 @@ import org.jclouds.providers.internal.BaseProviderMetadata;
/**
* Implementation of @ link org.jclouds.types.ProviderMetadata} for Enterprise Chef
- *
- * @author Adrian Cole
*/
public class EnterpriseChefProviderMetadata extends BaseProviderMetadata
{
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/binders/BindGroupToUpdateRequestJsonPayload.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/binders/BindGroupToUpdateRequestJsonPayload.java b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/binders/BindGroupToUpdateRequestJsonPayload.java
index 0b24341..2573b9d 100644
--- a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/binders/BindGroupToUpdateRequestJsonPayload.java
+++ b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/binders/BindGroupToUpdateRequestJsonPayload.java
@@ -32,8 +32,6 @@ import org.jclouds.rest.binders.BindToJsonPayload;
/**
* Binds a group to the payload expected for the Put method in the Enterprise Chef
* Api.
- *
- * @author Ignasi Barrera
*/
@Singleton
public class BindGroupToUpdateRequestJsonPayload extends BindToJsonPayload {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/binders/GroupName.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/binders/GroupName.java b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/binders/GroupName.java
index ec79567..12286a6 100644
--- a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/binders/GroupName.java
+++ b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/binders/GroupName.java
@@ -26,8 +26,6 @@ import com.google.common.base.Function;
/**
* Gets the name of a group.
- *
- * @author Ignasi Barrera
*/
@Singleton
public class GroupName implements Function<Object, String> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/config/EnterpriseChefHttpApiModule.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/config/EnterpriseChefHttpApiModule.java b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/config/EnterpriseChefHttpApiModule.java
index d1e16c7..ed0a49f 100644
--- a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/config/EnterpriseChefHttpApiModule.java
+++ b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/config/EnterpriseChefHttpApiModule.java
@@ -23,8 +23,6 @@ import org.jclouds.rest.ConfiguresHttpApi;
/**
* Configures the Enterprise Chef connection.
- *
- * @author Ignasi Barrera
*/
@ConfiguresHttpApi
public class EnterpriseChefHttpApiModule extends BaseChefHttpApiModule<EnterpriseChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/domain/Group.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/domain/Group.java b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/domain/Group.java
index 2c0f058..8535ca2 100644
--- a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/domain/Group.java
+++ b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/domain/Group.java
@@ -28,8 +28,6 @@ import com.google.common.collect.ImmutableSet;
/**
* Group object.
- *
- * @author Ignasi Barrera
*/
public class Group {
public static Builder builder(String groupname) {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/domain/User.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/domain/User.java b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/domain/User.java
index c2c71fa..da4e9e5 100644
--- a/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/domain/User.java
+++ b/providers/enterprisechef/src/main/java/org/jclouds/enterprisechef/domain/User.java
@@ -25,8 +25,6 @@ import com.google.gson.annotations.SerializedName;
/**
* User object.
- *
- * @author Ignasi Barrera
*/
public class User {
public static Builder builder() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiExpectTest.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiExpectTest.java b/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiExpectTest.java
index 2a58dd0..3785cf6 100644
--- a/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiExpectTest.java
+++ b/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiExpectTest.java
@@ -42,8 +42,6 @@ import com.google.inject.Module;
/**
* Expect tests for the {@link EnterpriseChefApi} class.
- *
- * @author Ignasi Barrera
*/
@Test(groups = "unit", testName = "EnterpriseChefApiExpectTest")
public class EnterpriseChefApiExpectTest extends BaseChefApiExpectTest<EnterpriseChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiLiveTest.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiLiveTest.java b/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiLiveTest.java
index 47148c9..6ac99c1 100644
--- a/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiLiveTest.java
+++ b/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiLiveTest.java
@@ -33,8 +33,6 @@ import org.testng.annotations.Test;
/**
* Tests behavior of the EnterpriseChefApi.
- *
- * @author Adrian Cole
*/
@Test(groups = "live", singleThreaded = true, testName = "EnterpriseChefApiLiveTest")
public class EnterpriseChefApiLiveTest extends BaseChefApiLiveTest<EnterpriseChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefProviderMetadataTest.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefProviderMetadataTest.java b/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefProviderMetadataTest.java
index f6784a0..9675af8 100644
--- a/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefProviderMetadataTest.java
+++ b/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefProviderMetadataTest.java
@@ -21,8 +21,6 @@ import org.testng.annotations.Test;
/**
* Unit tests for the {@link EnterpriseChefProviderMetadata} class.
- *
- * @author Adrian Cole
*/
@Test(groups = "unit", testName = "EnterpriseChefProviderTest")
public class EnterpriseChefProviderMetadataTest extends BaseProviderMetadataTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/binders/BindGroupToUpdateRequestJsonPayloadTest.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/binders/BindGroupToUpdateRequestJsonPayloadTest.java b/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/binders/BindGroupToUpdateRequestJsonPayloadTest.java
index 26a599d..4e9a3c2 100644
--- a/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/binders/BindGroupToUpdateRequestJsonPayloadTest.java
+++ b/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/binders/BindGroupToUpdateRequestJsonPayloadTest.java
@@ -36,8 +36,6 @@ import com.google.inject.Injector;
/**
* Unit tests for the {@link BindGroupToUpdateRequestJsonPayload} class.
- *
- * @author Ignasi Barrera
*/
@Test(groups = "unit", testName = "BindGroupToUpdateRequestJsonPayloadTest")
public class BindGroupToUpdateRequestJsonPayloadTest {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b9b6f39d/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/binders/GroupNameTest.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/binders/GroupNameTest.java b/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/binders/GroupNameTest.java
index cbe6642..98ea715 100644
--- a/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/binders/GroupNameTest.java
+++ b/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/binders/GroupNameTest.java
@@ -25,8 +25,6 @@ import org.testng.annotations.Test;
/**
* Unit tests for the {@link GroupName} class.
- *
- * @author Ignasi Barrera
*/
@Test(groups = "unit", testName = "GroupNameTest")
public class GroupNameTest {
[31/50] [abbrv] jclouds git commit: Correct typo
Posted by na...@apache.org.
Correct typo
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/1908f02e
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/1908f02e
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/1908f02e
Branch: refs/heads/1.8.x
Commit: 1908f02e04996e4704c7c679860bfb2c43d611a1
Parents: 2681a8e
Author: Andrew Gaul <ga...@apache.org>
Authored: Thu Jul 24 23:41:13 2014 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Thu Jul 24 23:41:13 2014 -0700
----------------------------------------------------------------------
.../test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/1908f02e/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
index b57499c..225e593 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
@@ -54,7 +54,7 @@ import org.jclouds.chef.domain.UploadSandbox;
import org.jclouds.chef.options.CreateClientOptions;
import org.jclouds.chef.options.SearchOptions;
import org.jclouds.crypto.Pems;
-import org.jclouds.io.ByteStream2;
+import org.jclouds.io.ByteStreams2;
import org.jclouds.io.Payloads;
import org.jclouds.io.payloads.FilePayload;
import org.jclouds.rest.ResourceNotFoundException;
@@ -167,7 +167,7 @@ public abstract class BaseChefApiLiveTest<A extends ChefApi> extends BaseChefLiv
InputStream stream = api.getResourceContents(resource);
assertNotNull(stream, "Resource contents are null for resource: " + resource.getName());
- byte[] md5 = ByteStream2.hashAndClose(stream, md5()).asBytes();
+ byte[] md5 = ByteStreams2.hashAndClose(stream, md5()).asBytes();
assertEquals(md5, resource.getChecksum());
}
}
[04/50] [abbrv] jclouds git commit: Use meaningful parameter name in
ParseSearchResultFromJson and ParseSearchDatabagFromJson.
Posted by na...@apache.org.
Use meaningful parameter name in ParseSearchResultFromJson and ParseSearchDatabagFromJson.
Also use static import for Sets and Iterables.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/18a3b77e
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/18a3b77e
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/18a3b77e
Branch: refs/heads/1.8.x
Commit: 18a3b77edb0eee49930087ea75f02c23dea947ca
Parents: f8c0659
Author: Noorul Islam K M <no...@noorul.com>
Authored: Wed Sep 18 14:09:18 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Thu Sep 19 08:38:24 2013 +0200
----------------------------------------------------------------------
.../chef/functions/ParseCookbookVersionsV09FromJson.java | 6 +++---
.../chef/functions/ParseCookbookVersionsV10FromJson.java | 9 +++++----
.../jclouds/chef/functions/ParseSearchDatabagFromJson.java | 8 ++++----
.../jclouds/chef/functions/ParseSearchResultFromJson.java | 4 ++--
4 files changed, 14 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/18a3b77e/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJson.java
index f5c0487..5c94e41 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJson.java
@@ -26,7 +26,7 @@ import org.jclouds.http.HttpResponse;
import org.jclouds.http.functions.ParseJson;
import com.google.common.base.Function;
-import com.google.common.collect.Iterables;
+import static com.google.common.collect.Iterables.getFirst;
/**
* Parses the cookbook versions in a Chef Server <= 0.9.8.
@@ -44,8 +44,8 @@ public class ParseCookbookVersionsV09FromJson implements Function<HttpResponse,
}
@Override
- public Set<String> apply(HttpResponse arg0) {
- return Iterables.getFirst(json.apply(arg0).values(), null);
+ public Set<String> apply(HttpResponse response) {
+ return getFirst(json.apply(response).values(), null);
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/18a3b77e/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJson.java
index 4a34374..955fe8e 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJson.java
@@ -28,8 +28,9 @@ import org.jclouds.http.HttpResponse;
import org.jclouds.http.functions.ParseJson;
import com.google.common.base.Function;
-import com.google.common.collect.Iterables;
-import com.google.common.collect.Sets;
+import static com.google.common.collect.Iterables.getFirst;
+import static com.google.common.collect.Iterables.transform;
+import static com.google.common.collect.Sets.newLinkedHashSet;
/**
* Parses the cookbook versions in a Chef Server >= 0.10.8.
@@ -49,8 +50,8 @@ public class ParseCookbookVersionsV10FromJson implements Function<HttpResponse,
@Override
public Set<String> apply(HttpResponse response) {
- CookbookDefinition def = Iterables.getFirst(parser.apply(response).values(), null);
- return Sets.newLinkedHashSet(Iterables.transform(def.getVersions(), new Function<Version, String>() {
+ CookbookDefinition def = getFirst(parser.apply(response).values(), null);
+ return newLinkedHashSet(transform(def.getVersions(), new Function<Version, String>() {
@Override
public String apply(Version input) {
return input.getVersion();
http://git-wip-us.apache.org/repos/asf/jclouds/blob/18a3b77e/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchDatabagFromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchDatabagFromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchDatabagFromJson.java
index 90aebd3..4826b38 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchDatabagFromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchDatabagFromJson.java
@@ -29,8 +29,8 @@ import org.jclouds.http.functions.ParseJson;
import org.jclouds.json.Json;
import com.google.common.base.Function;
-import com.google.common.collect.Iterables;
import com.google.gson.annotations.SerializedName;
+import static com.google.common.collect.Iterables.transform;
/**
* Parses the search result into a {@link DatabagItem} object.
@@ -64,9 +64,9 @@ public class ParseSearchDatabagFromJson implements Function<HttpResponse, Search
}
@Override
- public SearchResult<DatabagItem> apply(HttpResponse arg0) {
- Response returnVal = responseParser.apply(arg0);
- Iterable<DatabagItem> items = Iterables.transform(returnVal.rows, new Function<Row, DatabagItem>() {
+ public SearchResult<DatabagItem> apply(HttpResponse response) {
+ Response returnVal = responseParser.apply(response);
+ Iterable<DatabagItem> items = transform(returnVal.rows, new Function<Row, DatabagItem>() {
@Override
public DatabagItem apply(Row input) {
return json.fromJson(input.rawData.toString(), DatabagItem.class);
http://git-wip-us.apache.org/repos/asf/jclouds/blob/18a3b77e/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchResultFromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchResultFromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchResultFromJson.java
index 2346638..983ce8f 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchResultFromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchResultFromJson.java
@@ -46,8 +46,8 @@ public class ParseSearchResultFromJson<T> implements Function<HttpResponse, Sear
}
@Override
- public SearchResult<T> apply(HttpResponse arg0) {
- Response<T> returnVal = json.apply(arg0);
+ public SearchResult<T> apply(HttpResponse response) {
+ Response<T> returnVal = json.apply(response);
return new SearchResult<T>(returnVal.start, returnVal.rows);
}
}
[34/50] [abbrv] jclouds git commit: [maven-release-plugin] prepare
release jclouds-chef-1.8.0-rc1
Posted by na...@apache.org.
[maven-release-plugin] prepare release jclouds-chef-1.8.0-rc1
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/34b6f4aa
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/34b6f4aa
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/34b6f4aa
Branch: refs/heads/1.8.x
Commit: 34b6f4aac6dcd3eec89d5c6819621b6cca88a744
Parents: fc09c4e
Author: Andrew Phillips <an...@apache.org>
Authored: Tue Jul 29 19:53:29 2014 -0400
Committer: Andrew Phillips <an...@apache.org>
Committed: Tue Jul 29 19:53:29 2014 -0400
----------------------------------------------------------------------
apis/chef/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/34b6f4aa/apis/chef/pom.xml
----------------------------------------------------------------------
diff --git a/apis/chef/pom.xml b/apis/chef/pom.xml
index 74780d2..4f4e378 100644
--- a/apis/chef/pom.xml
+++ b/apis/chef/pom.xml
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.jclouds.chef</groupId>
<artifactId>chef-project</artifactId>
- <version>1.8.0-SNAPSHOT</version>
+ <version>1.8.0</version>
<relativePath>../project/pom.xml</relativePath>
</parent>
<groupId>org.apache.jclouds.api</groupId>
[40/50] [abbrv] jclouds git commit: Fix drift due to unasyncing
Posted by na...@apache.org.
Fix drift due to unasyncing
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/df5a674f
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/df5a674f
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/df5a674f
Branch: refs/heads/1.8.x
Commit: df5a674f48a9852fdf7e7066e6c1ea63025272d4
Parents: c230f2c
Author: Adrian Cole <ad...@gmail.com>
Authored: Sun Oct 5 20:12:46 2014 -0700
Committer: Adrian Cole <ad...@gmail.com>
Committed: Sun Oct 5 20:24:18 2014 -0700
----------------------------------------------------------------------
.../chef/test/config/TransientChefApiModule.java | 2 --
.../test/java/org/jclouds/chef/ChefApiExpectTest.java | 8 ++++----
.../src/test/java/org/jclouds/chef/ChefApiTest.java | 12 ++++++------
3 files changed, 10 insertions(+), 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/df5a674f/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java b/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java
index d9eab4d..bab35d0 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java
@@ -40,7 +40,6 @@ import org.jclouds.crypto.Crypto;
import org.jclouds.domain.JsonBall;
import org.jclouds.rest.ConfiguresHttpApi;
import org.jclouds.rest.config.RestModule;
-import org.jclouds.rest.config.SyncToAsyncHttpInvocationModule;
import com.google.common.base.Optional;
import com.google.common.base.Supplier;
@@ -58,7 +57,6 @@ public class TransientChefApiModule extends AbstractModule {
@Override
protected void configure() {
install(new RestModule());
- install(new SyncToAsyncHttpInvocationModule());
bind(ChefApi.class).to(TransientChefApi.class);
bind(LocalBlobStore.class).annotatedWith(Names.named("databags"))
.toInstance(
http://git-wip-us.apache.org/repos/asf/jclouds/blob/df5a674f/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
index ea4070d..478959b 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
@@ -31,7 +31,7 @@ import org.jclouds.chef.options.SearchOptions;
import org.jclouds.date.TimeStamp;
import org.jclouds.http.HttpRequest;
import org.jclouds.http.HttpResponse;
-import org.jclouds.rest.ConfiguresRestClient;
+import org.jclouds.rest.ConfiguresHttpApi;
import org.testng.annotations.Test;
import com.google.common.base.Supplier;
@@ -260,11 +260,11 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
@Override
protected Module createModule() {
- return new TestChefRestClientModule();
+ return new TestChefHttpApiModule();
}
- @ConfiguresRestClient
- static class TestChefRestClientModule extends ChefHttpApiModule {
+ @ConfiguresHttpApi
+ static class TestChefHttpApiModule extends ChefHttpApiModule {
@Override
protected String provideTimeStamp(@TimeStamp Supplier<String> cache) {
return "timestamp";
http://git-wip-us.apache.org/repos/asf/jclouds/blob/df5a674f/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
index 434c22c..f998a95 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
@@ -56,8 +56,8 @@ import org.jclouds.http.functions.ReturnInputStream;
import org.jclouds.io.Payload;
import org.jclouds.io.payloads.StringPayload;
import org.jclouds.reflect.Invocation;
-import org.jclouds.rest.ConfiguresRestClient;
-import org.jclouds.rest.internal.BaseAsyncApiTest;
+import org.jclouds.rest.ConfiguresHttpApi;
+import org.jclouds.rest.internal.BaseRestAnnotationProcessingTest;
import org.jclouds.rest.internal.GeneratedHttpRequest;
import org.testng.annotations.Test;
@@ -71,7 +71,7 @@ import com.google.inject.Module;
* Tests annotation parsing of {@code ChefApi}.
*/
@Test(groups = { "unit" })
-public class ChefApiTest extends BaseAsyncApiTest<ChefApi> {
+public class ChefApiTest extends BaseRestAnnotationProcessingTest<ChefApi> {
public void testCommitSandbox() throws SecurityException, NoSuchMethodException, IOException {
@@ -713,7 +713,7 @@ public class ChefApiTest extends BaseAsyncApiTest<ChefApi> {
@Override
protected Module createModule() {
- return new TestChefRestClientModule();
+ return new TestChefHttpApiModule();
}
@Override
@@ -723,8 +723,8 @@ public class ChefApiTest extends BaseAsyncApiTest<ChefApi> {
return props;
}
- @ConfiguresRestClient
- static class TestChefRestClientModule extends ChefHttpApiModule {
+ @ConfiguresHttpApi
+ static class TestChefHttpApiModule extends ChefHttpApiModule {
@Override
protected String provideTimeStamp(@TimeStamp Supplier<String> cache) {
return "timestamp";
[21/50] [abbrv] jclouds git commit: Updating to 1.8.0-SNAPSHOT
Posted by na...@apache.org.
Updating to 1.8.0-SNAPSHOT
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/bd36ccd5
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/bd36ccd5
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/bd36ccd5
Branch: refs/heads/1.8.x
Commit: bd36ccd55121cd06aec67b2601775090a7832de3
Parents: f4895cc
Author: Andrew Bayer <an...@gmail.com>
Authored: Tue Dec 17 11:51:11 2013 -0800
Committer: Andrew Bayer <an...@gmail.com>
Committed: Tue Dec 17 11:51:11 2013 -0800
----------------------------------------------------------------------
providers/enterprisechef/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/bd36ccd5/providers/enterprisechef/pom.xml
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/pom.xml b/providers/enterprisechef/pom.xml
index 849c9b6..b148e4c 100644
--- a/providers/enterprisechef/pom.xml
+++ b/providers/enterprisechef/pom.xml
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.jclouds.chef</groupId>
<artifactId>chef-project</artifactId>
- <version>1.7.0-SNAPSHOT</version>
+ <version>1.8.0-SNAPSHOT</version>
<relativePath>../project/pom.xml</relativePath>
</parent>
<groupId>org.apache.jclouds.provider</groupId>
[32/50] [abbrv] jclouds git commit: JCLOUDS-624 - Fixed bug in
ListNodes
Posted by na...@apache.org.
JCLOUDS-624 - Fixed bug in ListNodes
To fix this bug, I used the approach debated in the above issue: create
new methods to do the operation using an ExecutorService provided by the
user.The the old methods are still working, but now the operations in
those methods are not concurrent anymore.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/fc09c4eb
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/fc09c4eb
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/fc09c4eb
Branch: refs/heads/1.8.x
Commit: fc09c4eb466f388eca793610937eb4997c12cc4a
Parents: 1908f02
Author: Luciano P. Sabenca(luciano.sabenca@movile.com) <lu...@movile.com>
Authored: Mon Jul 14 13:58:38 2014 -0300
Committer: Ignasi Barrera <na...@apache.org>
Committed: Mon Jul 28 15:31:11 2014 +0200
----------------------------------------------------------------------
.../main/java/org/jclouds/chef/ChefService.java | 120 +++++++++++++------
.../jclouds/chef/internal/BaseChefService.java | 46 ++++++-
.../org/jclouds/chef/strategy/ListClients.java | 7 +-
.../chef/strategy/ListCookbookVersions.java | 7 +-
.../ListCookbookVersionsInEnvironment.java | 10 +-
.../jclouds/chef/strategy/ListEnvironments.java | 6 +-
.../org/jclouds/chef/strategy/ListNodes.java | 7 +-
.../chef/strategy/ListNodesInEnvironment.java | 7 +-
.../internal/BaseListCookbookVersionsImpl.java | 97 +++++++++++++++
.../strategy/internal/BaseListNodesImpl.java | 77 ++++++++++++
.../chef/strategy/internal/ListClientsImpl.java | 50 +++++---
.../internal/ListCookbookVersionsImpl.java | 68 +++--------
.../ListCookbookVersionsInEnvironmentImpl.java | 111 +++++++++--------
.../strategy/internal/ListEnvironmentsImpl.java | 12 +-
.../chef/strategy/internal/ListNodesImpl.java | 50 ++------
.../internal/ListNodesInEnvironmentImpl.java | 50 ++------
...okbookVersionsInEnvironmentImplLiveTest.java | 49 ++++++++
.../internal/ListNodesImplLiveTest.java | 23 ++++
.../ListNodesInEnvironmentImplLiveTest.java | 31 ++++-
19 files changed, 576 insertions(+), 252 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/ChefService.java b/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
index bae2e1b..040107a 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
@@ -16,10 +16,8 @@
*/
package org.jclouds.chef;
-import java.io.IOException;
-import java.io.InputStream;
-import java.util.List;
-
+import com.google.common.io.InputSupplier;
+import com.google.inject.ImplementedBy;
import org.jclouds.chef.domain.BootstrapConfig;
import org.jclouds.chef.domain.Client;
import org.jclouds.chef.domain.CookbookVersion;
@@ -30,8 +28,10 @@ import org.jclouds.domain.JsonBall;
import org.jclouds.rest.annotations.SinceApiVersion;
import org.jclouds.scriptbuilder.domain.Statement;
-import com.google.common.io.InputSupplier;
-import com.google.inject.ImplementedBy;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.List;
+import java.util.concurrent.ExecutorService;
/**
* Provides high level Chef operations.
@@ -41,7 +41,7 @@ public interface ChefService {
/**
* Gets the context that created this service.
- *
+ *
* @return The context that created the service.
*/
ChefContext getContext();
@@ -50,7 +50,7 @@ public interface ChefService {
/**
* Encrypts the given input stream.
- *
+ *
* @param supplier The input stream to encrypt.
* @return The encrypted bytes for the given input stream.
* @throws IOException If there is an error reading from the input stream.
@@ -59,7 +59,7 @@ public interface ChefService {
/**
* Decrypts the given input stream.
- *
+ *
* @param supplier The input stream to decrypt.
* @return The decrypted bytes for the given input stream.
* @throws IOException If there is an error reading from the input stream.
@@ -70,27 +70,27 @@ public interface ChefService {
/**
* Creates all steps necessary to bootstrap the node.
- *
+ *
* @param group corresponds to a configured
- * {@link ChefProperties#CHEF_BOOTSTRAP_DATABAG} data bag where
- * run_list and other information are stored.
+ * {@link ChefProperties#CHEF_BOOTSTRAP_DATABAG} data bag where
+ * run_list and other information are stored.
* @return The script used to bootstrap the node.
*/
Statement createBootstrapScriptForGroup(String group);
/**
* Configures how the nodes of a certain group will be bootstrapped
- *
- * @param group The group where the given bootstrap configuration will be
- * applied.
+ *
+ * @param group The group where the given bootstrap configuration will be
+ * applied.
* @param bootstrapConfig The configuration to be applied to the nodes in the
- * group.
+ * group.
*/
void updateBootstrapConfigForGroup(String group, BootstrapConfig bootstrapConfig);
/**
* Gets the run list for the given group.
- *
+ *
* @param The group to get the configured run list for.
* @return run list for all nodes bootstrapped with a certain group
*/
@@ -98,10 +98,10 @@ public interface ChefService {
/**
* Gets the bootstrap configuration for a given group.
- * <p>
+ * <p/>
* The bootstrap configuration is a Json object containing the run list and
* the configured attributes.
- *
+ *
* @param group The name of the group.
* @return The bootstrap configuration for the given group.
*/
@@ -111,9 +111,9 @@ public interface ChefService {
/**
* Creates a new node and populates the automatic attributes.
- *
+ *
* @param nodeName The name of the node to create.
- * @param runList The run list for the created node.
+ * @param runList The run list for the created node.
* @return The created node with the automatic attributes populated.
* @see OhaiModule
* @see ChefUtils#ohaiAutomaticAttributeBinder(com.google.inject.Binder)
@@ -122,7 +122,7 @@ public interface ChefService {
/**
* Updates and populate the automatic attributes of the given node.
- *
+ *
* @param nodeName The node to update.
*/
void updateAutomaticAttributesOnNode(String nodeName);
@@ -130,37 +130,44 @@ public interface ChefService {
/**
* Removes the nodes and clients that have been inactive for a given amount of
* time.
- *
- * @param prefix The prefix for the nodes and clients to delete.
+ *
+ * @param prefix The prefix for the nodes and clients to delete.
* @param secondsStale The seconds of inactivity to consider a node and
- * client obsolete.
+ * client obsolete.
*/
void cleanupStaleNodesAndClients(String prefix, int secondsStale);
/**
* Deletes the given nodes.
- *
+ *
* @param names The names of the nodes to delete.
*/
void deleteAllNodesInList(Iterable<String> names);
/**
* Deletes the given clients.
- *
+ *
* @param names The names of the client to delete.
*/
void deleteAllClientsInList(Iterable<String> names);
/**
* Lists the details of all existing nodes.
- *
+ *
* @return The details of all existing nodes.
*/
Iterable<? extends Node> listNodes();
/**
+ * Lists the details of all existing nodes, executing concurrently using the executorService.
+ *
+ * @return The details of all existing nodes.
+ */
+ Iterable<? extends Node> listNodes(ExecutorService executorService);
+
+ /**
* Lists the details of all existing nodes in the given environment.
- *
+ *
* @param environmentName The name fo the environment.
* @return The details of all existing nodes in the given environment.
*/
@@ -168,20 +175,44 @@ public interface ChefService {
Iterable<? extends Node> listNodesInEnvironment(String environmentName);
/**
+ * Lists the details of all existing nodes in the given environment, using the ExecutorService to paralleling the execution.
+ *
+ * @param executorService The thread pool used in this operation
+ * @param environmentName The name fo the environment.
+ * @return The details of all existing nodes in the given environment.
+ */
+ @SinceApiVersion("0.10.0")
+ Iterable<? extends Node> listNodesInEnvironment(String environmentName, ExecutorService executorService);
+
+ /**
* Lists the details of all existing clients.
- *
+ *
* @return The details of all existing clients.
*/
Iterable<? extends Client> listClients();
/**
+ * Lists the details of all existing clients, but executing concurrently using the threads available in the ExecutorService.
+ *
+ * @return The details of all existing clients.
+ */
+ Iterable<? extends Client> listClients(ExecutorService executorService);
+
+ /**
* Lists the details of all existing cookbooks.
- *
+ *
* @return The details of all existing cookbooks.
*/
Iterable<? extends CookbookVersion> listCookbookVersions();
/**
+ * Lists the details of all existing cookbooks. This method is executed concurrently, using the threads available in the ExecutorService.
+ *
+ * @return The details of all existing cookbooks.
+ */
+ Iterable<? extends CookbookVersion> listCookbookVersions(ExecutorService executorService);
+
+ /**
* Lists the details of all existing cookbooks in an environment.
*
* @param environmentName The environment name.
@@ -190,19 +221,40 @@ public interface ChefService {
Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName);
/**
+ * Lists the details of all existing cookbooks in an environment.
+
+ * @param executorService The thread pool to do the concurrent execution.
+ * @param environmentName The environment name.
+ * @return The details of all existing cookbooks in an environment.
+ */
+ Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName, ExecutorService executorService);
+
+ /**
* Lists the details of all existing cookbooks in an environment
* limiting number of versions.
*
* @param environmentName The environment name.
- * @param numVersions The number of cookbook versions to include.
- * Use 'all' to return all cookbook versions.
+ * @param numVersions The number of cookbook versions to include.
+ * Use 'all' to return all cookbook versions.
* @return The details of all existing cookbooks in environment.
*/
Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName, String numVersions);
/**
+ * Lists the details of all existing cookbooks in an environment
+ * limiting number of versions.
+ *
+ * @param executorService The executorService used to do this operation concurrently.
+ * @param environmentName The environment name.
+ * @param numVersions The number of cookbook versions to include.
+ * Use 'all' to return all cookbook versions.
+ * @return The details of all existing cookbooks in environment.
+ */
+ Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName, String numVersions, ExecutorService executorService);
+
+ /**
* Lists the details of all existing environments.
- *
+ *
* @return The details of all existing environments.
*/
@SinceApiVersion("0.10.0")
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
index c22e697..d390555 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
@@ -24,6 +24,7 @@ import java.io.InputStream;
import java.security.PrivateKey;
import java.util.List;
import java.util.Map;
+import java.util.concurrent.ExecutorService;
import javax.annotation.Resource;
import javax.inject.Inject;
@@ -50,9 +51,9 @@ import org.jclouds.chef.strategy.DeleteAllNodesInList;
import org.jclouds.chef.strategy.ListClients;
import org.jclouds.chef.strategy.ListCookbookVersions;
import org.jclouds.chef.strategy.ListCookbookVersionsInEnvironment;
-import org.jclouds.chef.strategy.ListNodesInEnvironment;
import org.jclouds.chef.strategy.ListEnvironments;
import org.jclouds.chef.strategy.ListNodes;
+import org.jclouds.chef.strategy.ListNodesInEnvironment;
import org.jclouds.chef.strategy.UpdateAutomaticAttributesOnNode;
import org.jclouds.crypto.Crypto;
import org.jclouds.domain.JsonBall;
@@ -92,7 +93,7 @@ public class BaseChefService implements ChefService {
private final ListNodesInEnvironment listNodesInEnvironment;
private final Json json;
private final Crypto crypto;
-
+
@Resource
@Named(ChefProperties.CHEF_LOGGER)
protected Logger logger = Logger.NULL;
@@ -127,7 +128,7 @@ public class BaseChefService implements ChefService {
this.runListForGroup = checkNotNull(runListForGroup, "runListForGroup");
this.listEnvironments = checkNotNull(listEnvironments, "listEnvironments");
this.listNodesInEnvironment = checkNotNull(listNodesInEnvironment, "listNodesInEnvironment");
- this.listCookbookVersionsInEnvironment = checkNotNull(listCookbookVersionsInEnvironment, "listCookbookVersionsInEnvironment");
+ this.listCookbookVersionsInEnvironment = checkNotNull(listCookbookVersionsInEnvironment,"listCookbookVersionsInEnvironment");
this.json = checkNotNull(json, "json");
this.crypto = checkNotNull(crypto, "crypto");
}
@@ -140,13 +141,13 @@ public class BaseChefService implements ChefService {
@Override
public byte[] encrypt(InputSupplier<? extends InputStream> supplier) throws IOException {
return ByteStreams.toByteArray(new RSAEncryptingPayload(crypto, Payloads.newPayload(supplier.getInput()), privateKey
- .get()));
+ .get()));
}
@Override
public byte[] decrypt(InputSupplier<? extends InputStream> supplier) throws IOException {
return ByteStreams.toByteArray(new RSADecryptingPayload(crypto, Payloads.newPayload(supplier.getInput()), privateKey
- .get()));
+ .get()));
}
@VisibleForTesting
@@ -233,26 +234,54 @@ public class BaseChefService implements ChefService {
}
@Override
+ public Iterable<? extends Node> listNodes(ExecutorService executorService) {
+ return listNodes.execute(executorService);
+ }
+
+ @Override
public Iterable<? extends Client> listClients() {
return listClients.execute();
}
@Override
+ public Iterable<? extends Client> listClients(ExecutorService executorService) {
+ return listClients.execute(executorService);
+ }
+
+ @Override
public Iterable<? extends CookbookVersion> listCookbookVersions() {
return listCookbookVersions.execute();
}
+ @Override public Iterable<? extends CookbookVersion> listCookbookVersions(
+ ExecutorService executorService) {
+ return listCookbookVersions.execute(executorService);
+ }
+
@Override
public Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName) {
return listCookbookVersionsInEnvironment.execute(environmentName);
}
@Override
- public Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName, String numVersions) {
+ public Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName,
+ ExecutorService executorService) {
+ return listCookbookVersionsInEnvironment.execute(executorService, environmentName);
+ }
+
+ @Override
+ public Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName,
+ String numVersions) {
return listCookbookVersionsInEnvironment.execute(environmentName, numVersions);
}
@Override
+ public Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName,
+ String numVersions, ExecutorService executorService) {
+ return listCookbookVersionsInEnvironment.execute(executorService, environmentName, numVersions);
+ }
+
+ @Override
public Iterable<? extends Environment> listEnvironments() {
return listEnvironments.execute();
}
@@ -262,4 +291,9 @@ public class BaseChefService implements ChefService {
return listNodesInEnvironment.execute(environmentName);
}
+ @Override
+ public Iterable<? extends Node> listNodesInEnvironment(String environmentName, ExecutorService executorService) {
+ return listNodesInEnvironment.execute(executorService, environmentName);
+ }
+
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
index f531a32..aa40c2a 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
@@ -16,16 +16,17 @@
*/
package org.jclouds.chef.strategy;
+import com.google.inject.ImplementedBy;
import org.jclouds.chef.domain.Client;
import org.jclouds.chef.strategy.internal.ListClientsImpl;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.ImplementedBy;
+import java.util.concurrent.ExecutorService;
@ImplementedBy(ListClientsImpl.class)
public interface ListClients {
Iterable<? extends Client> execute();
- Iterable<? extends Client> execute(ListeningExecutorService executor);
+ Iterable<? extends Client> execute(ExecutorService executor);
+
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
index 4409e4e..45663a3 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
@@ -16,16 +16,17 @@
*/
package org.jclouds.chef.strategy;
+import com.google.inject.ImplementedBy;
import org.jclouds.chef.domain.CookbookVersion;
import org.jclouds.chef.strategy.internal.ListCookbookVersionsImpl;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.ImplementedBy;
+import java.util.concurrent.ExecutorService;
@ImplementedBy(ListCookbookVersionsImpl.class)
public interface ListCookbookVersions {
Iterable<? extends CookbookVersion> execute();
- Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor);
+ Iterable<? extends CookbookVersion> execute(ExecutorService executor);
+
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
index b0e1c54..188d29f 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
@@ -16,11 +16,11 @@
*/
package org.jclouds.chef.strategy;
+import com.google.inject.ImplementedBy;
import org.jclouds.chef.domain.CookbookVersion;
import org.jclouds.chef.strategy.internal.ListCookbookVersionsInEnvironmentImpl;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.ImplementedBy;
+import java.util.concurrent.ExecutorService;
@ImplementedBy(ListCookbookVersionsInEnvironmentImpl.class)
public interface ListCookbookVersionsInEnvironment {
@@ -29,7 +29,9 @@ public interface ListCookbookVersionsInEnvironment {
Iterable<? extends CookbookVersion> execute(String environmentName, String numVersions);
- Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, String environmentName);
+ Iterable<? extends CookbookVersion> execute(ExecutorService executor, String environmentName);
+
+ Iterable<? extends CookbookVersion> execute(ExecutorService executor, String environmentName, String numVersions);
+
- Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, String environmentName, String numVersions);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java
index 3e5b11f..553e8d4 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java
@@ -16,16 +16,16 @@
*/
package org.jclouds.chef.strategy;
+import com.google.inject.ImplementedBy;
import org.jclouds.chef.domain.Environment;
import org.jclouds.chef.strategy.internal.ListEnvironmentsImpl;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.ImplementedBy;
+import java.util.concurrent.ExecutorService;
@ImplementedBy(ListEnvironmentsImpl.class)
public interface ListEnvironments {
Iterable<? extends Environment> execute();
- Iterable<? extends Environment> execute(ListeningExecutorService executor);
+ Iterable<? extends Environment> execute(ExecutorService executor);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
index a1a4093..660eed0 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
@@ -16,16 +16,17 @@
*/
package org.jclouds.chef.strategy;
+import com.google.inject.ImplementedBy;
import org.jclouds.chef.domain.Node;
import org.jclouds.chef.strategy.internal.ListNodesImpl;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.ImplementedBy;
+import java.util.concurrent.ExecutorService;
@ImplementedBy(ListNodesImpl.class)
public interface ListNodes {
Iterable<? extends Node> execute();
- Iterable<? extends Node> execute(ListeningExecutorService executor);
+ Iterable<? extends Node> execute(ExecutorService executor);
+
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
index 6a46fab..efeffe6 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
@@ -16,16 +16,17 @@
*/
package org.jclouds.chef.strategy;
+import com.google.inject.ImplementedBy;
import org.jclouds.chef.domain.Node;
import org.jclouds.chef.strategy.internal.ListNodesInEnvironmentImpl;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.ImplementedBy;
+import java.util.concurrent.ExecutorService;
@ImplementedBy(ListNodesInEnvironmentImpl.class)
public interface ListNodesInEnvironment {
Iterable<? extends Node> execute(String environmentName);
- Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName);
+ Iterable<? extends Node> execute(ExecutorService executor, String environmentName);
+
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/BaseListCookbookVersionsImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/BaseListCookbookVersionsImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/BaseListCookbookVersionsImpl.java
new file mode 100644
index 0000000..94cf79a
--- /dev/null
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/BaseListCookbookVersionsImpl.java
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.chef.strategy.internal;
+
+import com.google.common.base.Function;
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import org.jclouds.chef.ChefApi;
+import org.jclouds.chef.domain.CookbookVersion;
+import org.jclouds.logging.Logger;
+
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.Callable;
+
+import static com.google.common.base.Preconditions.checkNotNull;
+import static com.google.common.collect.Iterables.concat;
+import static com.google.common.collect.Iterables.transform;
+import static com.google.common.util.concurrent.Futures.allAsList;
+import static com.google.common.util.concurrent.Futures.getUnchecked;
+
+public abstract class BaseListCookbookVersionsImpl {
+
+ protected final ChefApi api;
+
+ protected Logger logger = Logger.NULL;
+
+ BaseListCookbookVersionsImpl(ChefApi api) {
+ this.api = checkNotNull(api, "api");
+ }
+
+ protected Iterable<? extends CookbookVersion> execute(Iterable<String> toGet) {
+ return concat(transform(toGet, new Function<String, Iterable<? extends CookbookVersion>>() {
+
+ @Override
+ public Iterable<? extends CookbookVersion> apply(final String cookbook) {
+ // TODO getting each version could also go parallel
+ Set<String> cookbookVersions = api.listVersionsOfCookbook(cookbook);
+ Iterable<? extends CookbookVersion> cookbooksVersions = transform(cookbookVersions,
+ new Function<String, CookbookVersion>() {
+ @Override
+ public CookbookVersion apply(final String version) {
+ return api.getCookbook(cookbook, version);
+ }
+ }
+ );
+
+ logger.trace(String.format("getting versions of cookbook: %s", cookbook));
+ return cookbooksVersions;
+ }
+ }));
+
+ }
+
+ protected Iterable<? extends CookbookVersion> executeConcurrently(final ListeningExecutorService executor,
+ Iterable<String> cookbookNames) {
+ return concat(transform(cookbookNames, new Function<String, Iterable<? extends CookbookVersion>>() {
+
+ @Override
+ public Iterable<? extends CookbookVersion> apply(final String cookbook) {
+ // TODO getting each version could also go parallel
+ Set<String> cookbookVersions = api.listVersionsOfCookbook(cookbook);
+ ListenableFuture<List<CookbookVersion>> futures = allAsList(transform(cookbookVersions,
+ new Function<String, ListenableFuture<CookbookVersion>>() {
+ @Override
+ public ListenableFuture<CookbookVersion> apply(final String version) {
+ return executor.submit(new Callable<CookbookVersion>() {
+ @Override
+ public CookbookVersion call() throws Exception {
+ return api.getCookbook(cookbook, version);
+ }
+ });
+ }
+ }
+ ));
+
+ logger.trace(String.format("getting versions of cookbook: %s", cookbook));
+ return getUnchecked(futures);
+ }
+ }));
+ }
+
+}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/BaseListNodesImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/BaseListNodesImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/BaseListNodesImpl.java
new file mode 100644
index 0000000..a426b8d
--- /dev/null
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/BaseListNodesImpl.java
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.chef.strategy.internal;
+
+import com.google.common.base.Function;
+import com.google.common.base.Joiner;
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import org.jclouds.chef.ChefApi;
+import org.jclouds.chef.domain.Node;
+import org.jclouds.logging.Logger;
+
+import java.util.List;
+import java.util.concurrent.Callable;
+
+import static com.google.common.base.Preconditions.checkNotNull;
+import static com.google.common.collect.Iterables.transform;
+import static com.google.common.util.concurrent.Futures.allAsList;
+import static com.google.common.util.concurrent.Futures.getUnchecked;
+
+public abstract class BaseListNodesImpl {
+
+ protected final ChefApi api;
+
+ protected Logger logger = Logger.NULL;
+
+ BaseListNodesImpl(ChefApi api) {
+ this.api = checkNotNull(api, "api");
+ }
+
+ protected Iterable<? extends Node> execute(Iterable<String> toGet) {
+ Iterable<? extends Node> nodes = transform(toGet, new Function<String, Node>() {
+ @Override
+ public Node apply(final String input) {
+ return api.getNode(input);
+ }
+ }
+ );
+
+ logger.trace(String.format("getting nodes: %s", Joiner.on(',').join(toGet)));
+ return nodes;
+
+ }
+
+ protected Iterable<? extends Node> executeConcurrently(final ListeningExecutorService executor,
+ Iterable<String> toGet) {
+ ListenableFuture<List<Node>> futures = allAsList(transform(toGet, new Function<String, ListenableFuture<Node>>() {
+ @Override
+ public ListenableFuture<Node> apply(final String input) {
+ return executor.submit(new Callable<Node>() {
+ @Override
+ public Node call() throws Exception {
+ return api.getNode(input);
+ }
+ });
+ }
+ }));
+
+ logger.trace(String.format("getting nodes: %s", Joiner.on(',').join(toGet)));
+ return getUnchecked(futures);
+ }
+
+}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java
index 6acda30..105be2f 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java
@@ -28,45 +28,66 @@ import javax.annotation.Resource;
import javax.inject.Named;
import javax.inject.Singleton;
-import org.jclouds.Constants;
+import com.google.common.base.Function;
+import com.google.common.base.Joiner;
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.common.util.concurrent.MoreExecutors;
+import com.google.inject.Inject;
import org.jclouds.chef.ChefApi;
import org.jclouds.chef.config.ChefProperties;
import org.jclouds.chef.domain.Client;
import org.jclouds.chef.strategy.ListClients;
import org.jclouds.logging.Logger;
-import com.google.common.base.Function;
-import com.google.common.base.Joiner;
-import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.Inject;
+import java.util.concurrent.ExecutorService;
+
@Singleton
public class ListClientsImpl implements ListClients {
protected final ChefApi api;
- protected final ListeningExecutorService userExecutor;
@Resource
@Named(ChefProperties.CHEF_LOGGER)
protected Logger logger = Logger.NULL;
@Inject
- ListClientsImpl(@Named(Constants.PROPERTY_USER_THREADS) ListeningExecutorService userExecutor, ChefApi api) {
- this.userExecutor = checkNotNull(userExecutor, "userExecuor");
+ ListClientsImpl(ChefApi api) {
this.api = checkNotNull(api, "api");
}
@Override
public Iterable<? extends Client> execute() {
- return execute(userExecutor);
+
+ Iterable<String> toGet = api.listClients();
+ Iterable<? extends Client> clients = transform(toGet,
+ new Function<String, Client>() {
+ @Override
+ public Client apply(final String input) {
+
+ return api.getClient(input);
+ }
+
+ }
+ );
+
+ logger.trace(String.format("getting clients: %s", Joiner.on(',').join(toGet)));
+ return clients;
+
}
@Override
- public Iterable<? extends Client> execute(ListeningExecutorService executor) {
- return execute(executor, api.listClients());
+ public Iterable<? extends Client> execute(ExecutorService executorService) {
+ return this.execute(MoreExecutors.listeningDecorator(executorService));
+ }
+
+
+ private Iterable<? extends Client> execute(ListeningExecutorService listeningExecutor) {
+ return executeConcurrently(listeningExecutor, api.listClients());
}
- private Iterable<? extends Client> execute(final ListeningExecutorService executor, Iterable<String> toGet) {
+ private Iterable<? extends Client> executeConcurrently(final ListeningExecutorService executor,
+ Iterable<String> toGet) {
ListenableFuture<List<Client>> futures = allAsList(transform(toGet,
new Function<String, ListenableFuture<Client>>() {
@Override
@@ -78,7 +99,8 @@ public class ListClientsImpl implements ListClients {
}
});
}
- }));
+ }
+ ));
logger.trace(String.format("getting clients: %s", Joiner.on(',').join(toGet)));
return getUnchecked(futures);
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java
index 75794d9..d109038 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java
@@ -16,81 +16,45 @@
*/
package org.jclouds.chef.strategy.internal;
-import static com.google.common.base.Preconditions.checkNotNull;
-import static com.google.common.collect.Iterables.concat;
-import static com.google.common.collect.Iterables.transform;
-import static com.google.common.util.concurrent.Futures.allAsList;
-import static com.google.common.util.concurrent.Futures.getUnchecked;
-
-import java.util.List;
-import java.util.Set;
-import java.util.concurrent.Callable;
-
-import javax.annotation.Resource;
-import javax.inject.Named;
-import javax.inject.Singleton;
-
-import org.jclouds.Constants;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.common.util.concurrent.MoreExecutors;
+import com.google.inject.Inject;
import org.jclouds.chef.ChefApi;
import org.jclouds.chef.config.ChefProperties;
import org.jclouds.chef.domain.CookbookVersion;
import org.jclouds.chef.strategy.ListCookbookVersions;
import org.jclouds.logging.Logger;
-import com.google.common.base.Function;
-import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.Inject;
+import javax.annotation.Resource;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.util.concurrent.ExecutorService;
@Singleton
-public class ListCookbookVersionsImpl implements ListCookbookVersions {
+public class ListCookbookVersionsImpl extends BaseListCookbookVersionsImpl implements ListCookbookVersions {
- protected final ChefApi api;
- protected final ListeningExecutorService userExecutor;
@Resource
@Named(ChefProperties.CHEF_LOGGER)
protected Logger logger = Logger.NULL;
@Inject
- ListCookbookVersionsImpl(@Named(Constants.PROPERTY_USER_THREADS) ListeningExecutorService userExecutor, ChefApi api) {
- this.userExecutor = checkNotNull(userExecutor, "userExecuor");
- this.api = checkNotNull(api, "api");
+ ListCookbookVersionsImpl(ChefApi api) {
+ super(api);
}
@Override
public Iterable<? extends CookbookVersion> execute() {
- return execute(userExecutor);
+ return super.execute(api.listCookbooks());
}
@Override
- public Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor) {
- return execute(executor, api.listCookbooks());
+ public Iterable<? extends CookbookVersion> execute(ExecutorService executor) {
+ return this.executeConcurrently(MoreExecutors.listeningDecorator(executor));
}
- private Iterable<? extends CookbookVersion> execute(final ListeningExecutorService executor,
- Iterable<String> cookbookNames) {
- return concat(transform(cookbookNames, new Function<String, Iterable<? extends CookbookVersion>>() {
-
- @Override
- public Iterable<? extends CookbookVersion> apply(final String cookbook) {
- // TODO getting each version could also go parallel
- Set<String> cookbookVersions = api.listVersionsOfCookbook(cookbook);
- ListenableFuture<List<CookbookVersion>> futures = allAsList(transform(cookbookVersions,
- new Function<String, ListenableFuture<CookbookVersion>>() {
- @Override
- public ListenableFuture<CookbookVersion> apply(final String version) {
- return executor.submit(new Callable<CookbookVersion>() {
- @Override
- public CookbookVersion call() throws Exception {
- return api.getCookbook(cookbook, version);
- }
- });
- }
- }));
- logger.trace(String.format("getting versions of cookbook: %s", cookbook));
- return getUnchecked(futures);
- }
- }));
+ private Iterable<? extends CookbookVersion> executeConcurrently(ListeningExecutorService executor) {
+ return super.executeConcurrently(executor, api.listCookbooks());
}
+
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
index ccc2992..a7142dc 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
@@ -16,21 +16,16 @@
*/
package org.jclouds.chef.strategy.internal;
-import static com.google.common.base.Preconditions.checkNotNull;
-import static com.google.common.collect.Iterables.concat;
import static com.google.common.collect.Iterables.transform;
-import static com.google.common.util.concurrent.Futures.allAsList;
-import static com.google.common.util.concurrent.Futures.getUnchecked;
-
-import java.util.List;
-import java.util.Set;
-import java.util.concurrent.Callable;
import javax.annotation.Resource;
import javax.inject.Named;
import javax.inject.Singleton;
-import org.jclouds.Constants;
+import com.google.common.base.Function;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.common.util.concurrent.MoreExecutors;
+import com.google.inject.Inject;
import org.jclouds.chef.ChefApi;
import org.jclouds.chef.config.ChefProperties;
import org.jclouds.chef.domain.CookbookDefinition;
@@ -38,69 +33,85 @@ import org.jclouds.chef.domain.CookbookVersion;
import org.jclouds.chef.strategy.ListCookbookVersionsInEnvironment;
import org.jclouds.logging.Logger;
-import com.google.common.base.Function;
-import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.Inject;
+import java.util.concurrent.ExecutorService;
@Singleton
-public class ListCookbookVersionsInEnvironmentImpl implements ListCookbookVersionsInEnvironment {
+public class ListCookbookVersionsInEnvironmentImpl extends BaseListCookbookVersionsImpl
+ implements ListCookbookVersionsInEnvironment {
- protected final ChefApi api;
- protected final ListeningExecutorService userExecutor;
@Resource
@Named(ChefProperties.CHEF_LOGGER)
protected Logger logger = Logger.NULL;
@Inject
- ListCookbookVersionsInEnvironmentImpl(@Named(Constants.PROPERTY_USER_THREADS) ListeningExecutorService userExecutor, ChefApi api) {
- this.userExecutor = checkNotNull(userExecutor, "userExecuor");
- this.api = checkNotNull(api, "api");
+ ListCookbookVersionsInEnvironmentImpl(ChefApi api) {
+ super(api);
}
@Override
public Iterable<? extends CookbookVersion> execute(String environmentName) {
- return execute(userExecutor, environmentName);
+ return super.execute(transform(api.listCookbooksInEnvironment(environmentName),
+ new Function<CookbookDefinition, String>() {
+
+ @Override
+ public String apply(CookbookDefinition cookbookDefinition) {
+ return cookbookDefinition.getName();
+ }
+ }
+ ));
}
@Override
public Iterable<? extends CookbookVersion> execute(String environmentName, String numVersions) {
- return execute(userExecutor, environmentName, numVersions);
+ return super.execute(transform(api.listCookbooksInEnvironment(environmentName, numVersions),
+ new Function<CookbookDefinition, String>() {
+
+ @Override
+ public String apply(CookbookDefinition cookbookDefinition) {
+ return cookbookDefinition.getName();
+ }
+ }
+ ));
}
- public Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, String environmentName) {
- return execute(executor, api.listCookbooksInEnvironment(environmentName));
+ @Override
+ public Iterable<? extends CookbookVersion> execute(ExecutorService executor,
+ String environmentName) {
+ return this.executeConcurrently(MoreExecutors.listeningDecorator(executor), environmentName);
}
@Override
- public Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, String environmentName, String numVersions) {
- return execute(executor, api.listCookbooksInEnvironment(environmentName, numVersions));
+ public Iterable<? extends CookbookVersion> execute(ExecutorService executor,
+ String environmentName, String numVersions) {
+ return this.executeConcurrently(MoreExecutors.listeningDecorator(executor), environmentName, numVersions);
+ }
+
+
+ private Iterable<? extends CookbookVersion> executeConcurrently(ListeningExecutorService executor,
+ String environmentName) {
+ return super.execute(
+ transform(api.listCookbooksInEnvironment(environmentName), new Function<CookbookDefinition, String>() {
+
+ @Override
+ public String apply(CookbookDefinition cookbookDefinition) {
+ return cookbookDefinition.getName();
+ }
+ })
+ );
}
- private Iterable<? extends CookbookVersion> execute(final ListeningExecutorService executor,
- Iterable<CookbookDefinition> cookbookDefs) {
- return concat(transform(cookbookDefs, new Function<CookbookDefinition, Iterable<? extends CookbookVersion>>() {
-
- @Override
- public Iterable<? extends CookbookVersion> apply(final CookbookDefinition cookbookDef) {
- // TODO getting each version could also go parallel
- Set<CookbookDefinition.Version> cookbookVersions = cookbookDef.getVersions();
- ListenableFuture<List<CookbookVersion>> futures = allAsList(transform(cookbookVersions,
- new Function<CookbookDefinition.Version, ListenableFuture<CookbookVersion>>() {
- @Override
- public ListenableFuture<CookbookVersion> apply(final CookbookDefinition.Version version) {
- return executor.submit(new Callable<CookbookVersion>() {
- @Override
- public CookbookVersion call() throws Exception {
- return api.getCookbook(cookbookDef.getName(), version.getVersion());
- }
- });
- }
- }));
-
- logger.trace(String.format("getting versions of cookbook %s: ", cookbookDef.getName()));
- return getUnchecked(futures);
- }
- }));
+
+ private Iterable<? extends CookbookVersion> executeConcurrently(ListeningExecutorService executor,
+ String environmentName, String numVersions) {
+ return super.execute(transform(api.listCookbooksInEnvironment(environmentName, numVersions),
+ new Function<CookbookDefinition, String>() {
+
+ @Override
+ public String apply(CookbookDefinition cookbookDefinition) {
+ return cookbookDefinition.getName();
+ }
+ }
+ ));
}
+
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentsImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentsImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentsImpl.java
index 9b79de2..0ed792e 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentsImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentsImpl.java
@@ -40,6 +40,12 @@ import com.google.common.base.Joiner;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
+import com.google.common.util.concurrent.MoreExecutors;
+
+
+import java.util.concurrent.ExecutorService;
+
+
@Singleton
public class ListEnvironmentsImpl implements ListEnvironments {
@@ -62,7 +68,11 @@ public class ListEnvironmentsImpl implements ListEnvironments {
}
@Override
- public Iterable<? extends Environment> execute(ListeningExecutorService executor) {
+ public Iterable<? extends Environment> execute(ExecutorService executor) {
+ return this.execute(MoreExecutors.listeningDecorator(executor));
+ }
+
+ private Iterable<? extends Environment> execute(ListeningExecutorService executor) {
return execute(executor, api.listEnvironments());
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java
index be9b652..8d95965 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java
@@ -16,71 +16,47 @@
*/
package org.jclouds.chef.strategy.internal;
-import static com.google.common.base.Preconditions.checkNotNull;
-import static com.google.common.collect.Iterables.transform;
-import static com.google.common.util.concurrent.Futures.allAsList;
-import static com.google.common.util.concurrent.Futures.getUnchecked;
-
-import java.util.List;
-import java.util.concurrent.Callable;
-
import javax.annotation.Resource;
import javax.inject.Named;
import javax.inject.Singleton;
-import org.jclouds.Constants;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.common.util.concurrent.MoreExecutors;
+import com.google.inject.Inject;
import org.jclouds.chef.ChefApi;
import org.jclouds.chef.config.ChefProperties;
import org.jclouds.chef.domain.Node;
import org.jclouds.chef.strategy.ListNodes;
import org.jclouds.logging.Logger;
-import com.google.common.base.Function;
-import com.google.common.base.Joiner;
-import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.Inject;
+import java.util.concurrent.ExecutorService;
@Singleton
-public class ListNodesImpl implements ListNodes {
+public class ListNodesImpl extends BaseListNodesImpl implements ListNodes {
+
- protected final ChefApi api;
- protected final ListeningExecutorService userExecutor;
@Resource
@Named(ChefProperties.CHEF_LOGGER)
protected Logger logger = Logger.NULL;
@Inject
- ListNodesImpl(@Named(Constants.PROPERTY_USER_THREADS) ListeningExecutorService userExecutor, ChefApi api) {
- this.userExecutor = checkNotNull(userExecutor, "userExecuor");
- this.api = checkNotNull(api, "api");
+ ListNodesImpl(ChefApi api) {
+ super(api);
}
@Override
public Iterable<? extends Node> execute() {
- return execute(userExecutor);
+ return super.execute(api.listNodes());
}
@Override
- public Iterable<? extends Node> execute(ListeningExecutorService executor) {
- return execute(executor, api.listNodes());
+ public Iterable<? extends Node> execute(ExecutorService executor) {
+ return this.executeConcurrently(MoreExecutors.listeningDecorator(executor));
}
- private Iterable<? extends Node> execute(final ListeningExecutorService executor, Iterable<String> toGet) {
- ListenableFuture<List<Node>> futures = allAsList(transform(toGet, new Function<String, ListenableFuture<Node>>() {
- @Override
- public ListenableFuture<Node> apply(final String input) {
- return executor.submit(new Callable<Node>() {
- @Override
- public Node call() throws Exception {
- return api.getNode(input);
- }
- });
- }
- }));
- logger.trace(String.format("getting nodes: %s", Joiner.on(',').join(toGet)));
- return getUnchecked(futures);
+ private Iterable<? extends Node> executeConcurrently(ListeningExecutorService executor) {
+ return super.executeConcurrently(executor, api.listNodes());
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
index 8ae747e..58ecaaa 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
@@ -16,71 +16,47 @@
*/
package org.jclouds.chef.strategy.internal;
-import static com.google.common.base.Preconditions.checkNotNull;
-import static com.google.common.collect.Iterables.transform;
-import static com.google.common.util.concurrent.Futures.allAsList;
-import static com.google.common.util.concurrent.Futures.getUnchecked;
-
-import java.util.List;
-import java.util.concurrent.Callable;
-
import javax.annotation.Resource;
import javax.inject.Named;
import javax.inject.Singleton;
-import org.jclouds.Constants;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.common.util.concurrent.MoreExecutors;
+import com.google.inject.Inject;
import org.jclouds.chef.ChefApi;
import org.jclouds.chef.config.ChefProperties;
import org.jclouds.chef.domain.Node;
import org.jclouds.chef.strategy.ListNodesInEnvironment;
import org.jclouds.logging.Logger;
-import com.google.common.base.Function;
-import com.google.common.base.Joiner;
-import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.Inject;
+import java.util.concurrent.ExecutorService;
@Singleton
-public class ListNodesInEnvironmentImpl implements ListNodesInEnvironment {
+public class ListNodesInEnvironmentImpl extends BaseListNodesImpl implements ListNodesInEnvironment {
- protected final ChefApi api;
- protected final ListeningExecutorService userExecutor;
@Resource
@Named(ChefProperties.CHEF_LOGGER)
protected Logger logger = Logger.NULL;
@Inject
- ListNodesInEnvironmentImpl(@Named(Constants.PROPERTY_USER_THREADS) ListeningExecutorService userExecutor, ChefApi api) {
- this.userExecutor = checkNotNull(userExecutor, "userExecuor");
- this.api = checkNotNull(api, "api");
+ ListNodesInEnvironmentImpl(ChefApi api) {
+ super(api);
}
@Override
public Iterable<? extends Node> execute(String environmentName) {
- return execute(userExecutor, environmentName);
+ return super.execute(api.listNodesInEnvironment(environmentName));
}
@Override
- public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName) {
- return execute(executor, environmentName, api.listNodesInEnvironment(environmentName));
+ public Iterable<? extends Node> execute(ExecutorService executor, String environmentName) {
+ return this.executeConcurrently(MoreExecutors.listeningDecorator(executor), environmentName);
}
- private Iterable<? extends Node> execute(final ListeningExecutorService executor, String environmentName, Iterable<String> toGet) {
- ListenableFuture<List<Node>> futures = allAsList(transform(toGet, new Function<String, ListenableFuture<Node>>() {
- @Override
- public ListenableFuture<Node> apply(final String input) {
- return executor.submit(new Callable<Node>() {
- @Override
- public Node call() throws Exception {
- return api.getNode(input);
- }
- });
- }
- }));
- logger.trace(String.format("getting nodes in environment %s: %s", environmentName, Joiner.on(',').join(toGet)));
- return getUnchecked(futures);
+ private Iterable<? extends Node> executeConcurrently(ListeningExecutorService executor,
+ String environmentName) {
+ return super.executeConcurrently(executor, api.listNodesInEnvironment(environmentName));
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
index a9b667d..5f68fcf 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
@@ -22,7 +22,11 @@ import static org.testng.Assert.fail;
import java.io.File;
import java.util.List;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.common.util.concurrent.MoreExecutors;
import org.jclouds.chef.ChefApi;
import org.jclouds.chef.domain.ChecksumStatus;
import org.jclouds.chef.domain.CookbookVersion;
@@ -51,6 +55,9 @@ public class ListCookbookVersionsInEnvironmentImplLiveTest extends BaseChefLiveT
private ListCookbookVersionsInEnvironmentImpl strategy;
private CreateNodeAndPopulateAutomaticAttributesImpl creator;
+ private ExecutorService testExecutorService;
+ private ListeningExecutorService testListeningExecutorService;
+
@Override
protected void initialize() {
super.initialize();
@@ -63,6 +70,8 @@ public class ListCookbookVersionsInEnvironmentImplLiveTest extends BaseChefLiveT
}
this.strategy = injector.getInstance(ListCookbookVersionsInEnvironmentImpl.class);
+ this.testExecutorService = Executors.newFixedThreadPool(5);
+ this.testListeningExecutorService = MoreExecutors.listeningDecorator(Executors.newFixedThreadPool(5));
}
@AfterClass(groups = { "integration", "live" })
@@ -72,6 +81,10 @@ public class ListCookbookVersionsInEnvironmentImplLiveTest extends BaseChefLiveT
api.deleteCookbook(PREFIX, "1.0.0");
api.deleteCookbook(PREFIX + 1, "0.0.0");
api.deleteCookbook(PREFIX + 1, "1.0.0");
+
+ this.testExecutorService.shutdown();
+ this.testListeningExecutorService.shutdown();
+
super.tearDown();
}
@@ -81,15 +94,51 @@ public class ListCookbookVersionsInEnvironmentImplLiveTest extends BaseChefLiveT
}
@Test
+ public void testExecuteConcurrentlyWithExecutorService() {
+ assertTrue(size(strategy.execute(testExecutorService, "_default")) > 0,
+ "Expected one or more elements");
+ }
+
+ @Test
+ public void testExecuteConcurrentlyWithListeningExecutorService() {
+ assertTrue(size(strategy.execute(testListeningExecutorService, "_default")) > 0,
+ "Expected one or more elements");
+ }
+
+ @Test
public void testExecuteWithNumVersions() {
assertTrue(size(strategy.execute("_default", "2")) > 0, "Expected one or more elements");
}
@Test
+ public void testExecuteConcurrentlyWithNumVersionsAndExecutorService() {
+ assertTrue(size(strategy.execute(testExecutorService, "_default", "2")) > 0,
+ "Expected one or more elements");
+ }
+
+ @Test
+ public void testExecuteConcurrentlyWithNumVersionsAndListeningExecutorService() {
+ assertTrue(size(strategy.execute(testListeningExecutorService, "_default", "2")) > 0,
+ "Expected one or more elements");
+ }
+
+ @Test
public void testExecuteWithNumVersionsAll() {
assertTrue(size(strategy.execute("_default", "all")) > 0, "Expected one or more elements");
}
+ @Test
+ public void testExecuteConcurrentlyWithNumVersionsAllAndExecutorService() {
+ assertTrue(size(strategy.execute(testExecutorService, "_default", "all")) > 0,
+ "Expected one or more elements");
+ }
+
+ @Test
+ public void testExecuteConcurrentlyWithNumVersionsAllAndListeningExecutorService() {
+ assertTrue(size(strategy.execute(testListeningExecutorService, "_default", "all")) > 0,
+ "Expected one or more elements");
+ }
+
private FilePayload uploadContent(String fileName) throws Exception {
// Define the file you want in the cookbook
File file = new File(System.getProperty("user.dir"), fileName);
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
index b9de2b8..903b998 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
@@ -19,6 +19,8 @@ package org.jclouds.chef.strategy.internal;
import static com.google.common.collect.Iterables.size;
import static org.testng.Assert.assertTrue;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.common.util.concurrent.MoreExecutors;
import org.jclouds.chef.ChefApi;
import org.jclouds.chef.internal.BaseChefLiveTest;
import org.testng.annotations.AfterClass;
@@ -26,6 +28,9 @@ import org.testng.annotations.Test;
import com.google.common.collect.ImmutableSet;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+
/**
* Tests behavior of {@code ListNodesImpl} strategies
*/
@@ -35,6 +40,9 @@ public class ListNodesImplLiveTest extends BaseChefLiveTest<ChefApi> {
private ListNodesImpl strategy;
private CreateNodeAndPopulateAutomaticAttributesImpl creator;
+ private ExecutorService testExecutorService;
+ private ListeningExecutorService testListeningExecutorService;
+
@Override
protected void initialize() {
super.initialize();
@@ -42,6 +50,9 @@ public class ListNodesImplLiveTest extends BaseChefLiveTest<ChefApi> {
this.strategy = injector.getInstance(ListNodesImpl.class);
creator.execute(prefix, ImmutableSet.<String> of());
creator.execute(prefix + 1, ImmutableSet.<String> of());
+
+ this.testExecutorService = Executors.newFixedThreadPool(5);
+ this.testListeningExecutorService = MoreExecutors.listeningDecorator(Executors.newFixedThreadPool(5));
}
@AfterClass(groups = { "integration", "live" })
@@ -49,6 +60,10 @@ public class ListNodesImplLiveTest extends BaseChefLiveTest<ChefApi> {
protected void tearDown() {
api.deleteNode(prefix);
api.deleteNode(prefix + 1);
+
+ this.testExecutorService.shutdown();
+ this.testListeningExecutorService.shutdown();
+
super.tearDown();
}
@@ -56,4 +71,12 @@ public class ListNodesImplLiveTest extends BaseChefLiveTest<ChefApi> {
public void testExecute() {
assertTrue(size(strategy.execute()) > 0, "Expected one or more elements");
}
+
+ public void testExecuteConcurrentlyWithExecutorService() {
+ assertTrue(size(strategy.execute(testExecutorService)) > 0, "Expected one or more elements");
+ }
+
+ public void testExecuteConcurrentlyWithListeningExecutorService() {
+ assertTrue(size(strategy.execute(testListeningExecutorService)) > 0, "Expected one or more elements");
+ }
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/fc09c4eb/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
index 81dd6d8..f655d52 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
@@ -19,6 +19,8 @@ package org.jclouds.chef.strategy.internal;
import static com.google.common.collect.Iterables.size;
import static org.testng.Assert.assertTrue;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.common.util.concurrent.MoreExecutors;
import org.jclouds.chef.ChefApi;
import org.jclouds.chef.internal.BaseChefLiveTest;
import org.testng.annotations.AfterClass;
@@ -26,6 +28,9 @@ import org.testng.annotations.Test;
import com.google.common.collect.ImmutableSet;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+
/**
* Tests behavior of {@code ListNodesInEnvironmentImpl} strategies
*/
@@ -35,13 +40,19 @@ public class ListNodesInEnvironmentImplLiveTest extends BaseChefLiveTest<ChefApi
private ListNodesInEnvironmentImpl strategy;
private CreateNodeAndPopulateAutomaticAttributesImpl creator;
+ private ExecutorService testExecutorService;
+ private ListeningExecutorService testListeningExecutorService;
+
@Override
protected void initialize() {
super.initialize();
this.creator = injector.getInstance(CreateNodeAndPopulateAutomaticAttributesImpl.class);
this.strategy = injector.getInstance(ListNodesInEnvironmentImpl.class);
- creator.execute(prefix, ImmutableSet.<String> of());
- creator.execute(prefix + 1, ImmutableSet.<String> of());
+ creator.execute(prefix, ImmutableSet.<String>of());
+ creator.execute(prefix + 1, ImmutableSet.<String>of());
+
+ this.testExecutorService = Executors.newFixedThreadPool(5);
+ this.testListeningExecutorService = MoreExecutors.listeningDecorator(Executors.newFixedThreadPool(5));
}
@AfterClass(groups = { "integration", "live" })
@@ -49,6 +60,10 @@ public class ListNodesInEnvironmentImplLiveTest extends BaseChefLiveTest<ChefApi
protected void tearDown() {
api.deleteNode(prefix);
api.deleteNode(prefix + 1);
+
+ this.testExecutorService.shutdown();
+ this.testListeningExecutorService.shutdown();
+
super.tearDown();
}
@@ -56,4 +71,16 @@ public class ListNodesInEnvironmentImplLiveTest extends BaseChefLiveTest<ChefApi
public void testExecute() {
assertTrue(size(strategy.execute("_default")) > 0, "Expected one or more elements");
}
+
+ @Test
+ public void testExecuteConcurrentlyWithExecutorService() {
+ assertTrue(size(strategy.execute(testExecutorService, "_default")) > 0,
+ "Expected one or more elements");
+ }
+
+ @Test
+ public void testExecuteConcurrentlyWithListeningExecutorService() {
+ assertTrue(size(strategy.execute(testListeningExecutorService, "_default")) > 0,
+ "Expected one or more elements");
+ }
}
[39/50] [abbrv] jclouds git commit: Fix drift due to unasyncing
Posted by na...@apache.org.
Fix drift due to unasyncing
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/3943c2d2
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/3943c2d2
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/3943c2d2
Branch: refs/heads/1.8.x
Commit: 3943c2d221d45b3dbb3c33c97542aaa1f35790da
Parents: 423f1ea
Author: Adrian Cole <ad...@gmail.com>
Authored: Sun Oct 5 20:12:46 2014 -0700
Committer: Adrian Cole <ad...@gmail.com>
Committed: Sun Oct 5 20:24:18 2014 -0700
----------------------------------------------------------------------
.../jclouds/enterprisechef/EnterpriseChefApiExpectTest.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/3943c2d2/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiExpectTest.java
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiExpectTest.java b/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiExpectTest.java
index 3785cf6..7ca79f7 100644
--- a/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiExpectTest.java
+++ b/providers/enterprisechef/src/test/java/org/jclouds/enterprisechef/EnterpriseChefApiExpectTest.java
@@ -33,7 +33,7 @@ import org.jclouds.enterprisechef.domain.User;
import org.jclouds.http.HttpRequest;
import org.jclouds.http.HttpResponse;
import org.jclouds.providers.ProviderMetadata;
-import org.jclouds.rest.ConfiguresRestClient;
+import org.jclouds.rest.ConfiguresHttpApi;
import org.jclouds.rest.ResourceNotFoundException;
import org.testng.annotations.Test;
@@ -190,11 +190,11 @@ public class EnterpriseChefApiExpectTest extends BaseChefApiExpectTest<Enterpris
@Override
protected Module createModule() {
- return new TestEnterpriseChefRestClientModule();
+ return new TestEnterpriseChefHttpApiModule();
}
- @ConfiguresRestClient
- static class TestEnterpriseChefRestClientModule extends EnterpriseChefHttpApiModule {
+ @ConfiguresHttpApi
+ static class TestEnterpriseChefHttpApiModule extends EnterpriseChefHttpApiModule {
@Override
protected String provideTimeStamp(@TimeStamp Supplier<String> cache) {
return "timestamp";
[08/50] [abbrv] jclouds git commit: JCLOUDS-286: Use by default the
Omnibus installer
Posted by na...@apache.org.
JCLOUDS-286: Use by default the Omnibus installer
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/373f9ead
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/373f9ead
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/373f9ead
Branch: refs/heads/1.8.x
Commit: 373f9ead72a20f5f0f330b4a1c1bfb95a2be3068
Parents: c9b5656
Author: Ignasi Barrera <na...@apache.org>
Authored: Tue Sep 17 14:43:16 2013 +0200
Committer: Ignasi Barrera <na...@apache.org>
Committed: Thu Sep 19 23:45:06 2013 +0200
----------------------------------------------------------------------
.../java/org/jclouds/chef/ChefApiMetadata.java | 4 +-
.../chef/config/ChefBootstrapModule.java | 28 +++++-
.../org/jclouds/chef/config/ChefProperties.java | 15 +++-
.../org/jclouds/chef/config/InstallChef.java | 39 ++++++++
.../chef/functions/GroupToBootScript.java | 10 ++-
.../org/jclouds/chef/ChefApiExpectTest.java | 2 +-
.../chef/functions/GroupToBootScriptTest.java | 93 +++++++++++++++++---
7 files changed, 167 insertions(+), 24 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/373f9ead/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java b/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java
index e28b481..951d2d2 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java
@@ -23,6 +23,7 @@ import static org.jclouds.Constants.PROPERTY_TIMEOUTS_PREFIX;
import static org.jclouds.chef.config.ChefProperties.CHEF_BOOTSTRAP_DATABAG;
import static org.jclouds.chef.config.ChefProperties.CHEF_UPDATE_GEMS;
import static org.jclouds.chef.config.ChefProperties.CHEF_UPDATE_GEM_SYSTEM;
+import static org.jclouds.chef.config.ChefProperties.CHEF_USE_OMNIBUS;
import java.net.URI;
import java.util.Properties;
@@ -44,7 +45,7 @@ import com.google.inject.Module;
* @author Ignasi Barrera
*/
public class ChefApiMetadata extends BaseHttpApiMetadata<ChefApi> {
-
+
/**
* The default Chef Server API version to use.
*/
@@ -78,6 +79,7 @@ public class ChefApiMetadata extends BaseHttpApiMetadata<ChefApi> {
properties.setProperty(CHEF_BOOTSTRAP_DATABAG, "bootstrap");
properties.setProperty(CHEF_UPDATE_GEM_SYSTEM, "false");
properties.setProperty(CHEF_UPDATE_GEMS, "false");
+ properties.setProperty(CHEF_USE_OMNIBUS, "true");
return properties;
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/373f9ead/apis/chef/src/main/java/org/jclouds/chef/config/ChefBootstrapModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/ChefBootstrapModule.java b/apis/chef/src/main/java/org/jclouds/chef/config/ChefBootstrapModule.java
index 3d9d04f..65d1422 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/ChefBootstrapModule.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/ChefBootstrapModule.java
@@ -19,6 +19,7 @@ package org.jclouds.chef.config;
import static org.jclouds.chef.config.ChefProperties.CHEF_GEM_SYSTEM_VERSION;
import static org.jclouds.chef.config.ChefProperties.CHEF_UPDATE_GEMS;
import static org.jclouds.chef.config.ChefProperties.CHEF_UPDATE_GEM_SYSTEM;
+import static org.jclouds.chef.config.ChefProperties.CHEF_USE_OMNIBUS;
import static org.jclouds.chef.config.ChefProperties.CHEF_VERSION;
import javax.inject.Named;
@@ -27,6 +28,7 @@ import javax.inject.Singleton;
import org.jclouds.scriptbuilder.domain.Statement;
import org.jclouds.scriptbuilder.domain.StatementList;
import org.jclouds.scriptbuilder.statements.chef.InstallChefGems;
+import org.jclouds.scriptbuilder.statements.chef.InstallChefUsingOmnibus;
import org.jclouds.scriptbuilder.statements.ruby.InstallRuby;
import org.jclouds.scriptbuilder.statements.ruby.InstallRubyGems;
@@ -45,8 +47,7 @@ public class ChefBootstrapModule extends AbstractModule {
@Provides
@Named("installChefGems")
@Singleton
- Statement installChef(BootstrapProperties bootstrapProperties) {
-
+ Statement installChefGems(BootstrapProperties bootstrapProperties) {
InstallRubyGems installRubyGems = InstallRubyGems.builder()
.version(bootstrapProperties.gemSystemVersion().orNull())
.updateSystem(bootstrapProperties.updateGemSystem(), bootstrapProperties.gemSystemVersion().orNull())
@@ -58,6 +59,21 @@ public class ChefBootstrapModule extends AbstractModule {
return new StatementList(InstallRuby.builder().build(), installRubyGems, installChef);
}
+ @Provides
+ @Named("installChefOmnibus")
+ @Singleton
+ Statement installChefUsingOmnibus() {
+ return new InstallChefUsingOmnibus();
+ }
+
+ @Provides
+ @InstallChef
+ @Singleton
+ Statement installChef(BootstrapProperties bootstrapProperties, @Named("installChefGems") Statement installChefGems,
+ @Named("installChefOmnibus") Statement installChefOmnibus) {
+ return bootstrapProperties.useOmnibus() ? installChefOmnibus : installChefGems;
+ }
+
@Singleton
private static class BootstrapProperties {
@Named(CHEF_VERSION)
@@ -76,6 +92,10 @@ public class ChefBootstrapModule extends AbstractModule {
@Inject
private String updateGemsProperty;
+ @Named(CHEF_USE_OMNIBUS)
+ @Inject
+ private String useOmnibus;
+
public Optional<String> chefVersion() {
return Optional.fromNullable(chefVersionProperty);
}
@@ -91,6 +111,10 @@ public class ChefBootstrapModule extends AbstractModule {
public boolean updateGems() {
return Boolean.parseBoolean(updateGemsProperty);
}
+
+ public boolean useOmnibus() {
+ return Boolean.parseBoolean(useOmnibus);
+ }
}
@Override
http://git-wip-us.apache.org/repos/asf/jclouds/blob/373f9ead/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java b/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java
index 75b3aa8..a6cf5f2 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java
@@ -31,7 +31,7 @@ public interface ChefProperties {
public static final String CHEF_LOGGER = "jclouds.chef";
/**
- * Ddatabag that holds chef bootstrap hints, should be a json ball in the
+ * Databag that holds chef bootstrap hints, should be a json ball in the
* following format:
* <p>
* {"tag":{"run_list":["recipe[apache2]"]}}
@@ -91,7 +91,7 @@ public interface ChefProperties {
/**
* Boolean property. Default (false).
* <p>
- * When bootstrapping a node, updates teh existing gems before installing
+ * When bootstrapping a node, updates the existing gems before installing
* Chef.
* <p>
* This property must be set prior to running the
@@ -99,4 +99,15 @@ public interface ChefProperties {
*/
public static final String CHEF_UPDATE_GEMS = "chef.update-gems";
+ /**
+ * Boolean property. Default (true).
+ * <p>
+ * When bootstrapping a node, install the Chef client using the Omnibus
+ * installer.
+ * <p>
+ * This property must be set prior to running the
+ * {@link ChefService#createBootstrapScriptForGroup(String)} method.
+ */
+ public static final String CHEF_USE_OMNIBUS = "chef.use-omnibus";
+
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/373f9ead/apis/chef/src/main/java/org/jclouds/chef/config/InstallChef.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/InstallChef.java b/apis/chef/src/main/java/org/jclouds/chef/config/InstallChef.java
new file mode 100644
index 0000000..909b99a
--- /dev/null
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/InstallChef.java
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.chef.config;
+
+import static java.lang.annotation.ElementType.METHOD;
+import static java.lang.annotation.ElementType.PARAMETER;
+import static java.lang.annotation.ElementType.FIELD;
+import static java.lang.annotation.RetentionPolicy.RUNTIME;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.Target;
+
+import javax.inject.Qualifier;
+
+/**
+ * Used to configure the Chef install script.
+ *
+ * @author Ignasi Barrera
+ */
+@Target({ METHOD, PARAMETER, FIELD })
+@Retention(RUNTIME)
+@Qualifier
+public @interface InstallChef {
+
+}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/373f9ead/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java b/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java
index 9154471..707119b 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java
@@ -34,11 +34,13 @@ import javax.inject.Inject;
import javax.inject.Named;
import javax.inject.Singleton;
+import org.jclouds.chef.config.InstallChef;
import org.jclouds.chef.config.Validator;
import org.jclouds.crypto.Pems;
import org.jclouds.domain.JsonBall;
import org.jclouds.json.Json;
import org.jclouds.location.Provider;
+import org.jclouds.scriptbuilder.ExitInsteadOfReturn;
import org.jclouds.scriptbuilder.domain.Statement;
import com.google.common.annotations.VisibleForTesting;
@@ -68,19 +70,19 @@ public class GroupToBootScript implements Function<String, Statement> {
private final Supplier<URI> endpoint;
private final Json json;
private final CacheLoader<String, ? extends JsonBall> bootstrapConfigForGroup;
- private final Statement installChefGems;
+ private final Statement installChef;
private final Optional<String> validatorName;
private final Optional<PrivateKey> validatorCredential;
@Inject
public GroupToBootScript(@Provider Supplier<URI> endpoint, Json json,
CacheLoader<String, ? extends JsonBall> bootstrapConfigForGroup,
- @Named("installChefGems") Statement installChefGems, @Validator Optional<String> validatorName,
+ @InstallChef Statement installChef, @Validator Optional<String> validatorName,
@Validator Optional<PrivateKey> validatorCredential) {
this.endpoint = checkNotNull(endpoint, "endpoint");
this.json = checkNotNull(json, "json");
this.bootstrapConfigForGroup = checkNotNull(bootstrapConfigForGroup, "bootstrapConfigForGroup");
- this.installChefGems = checkNotNull(installChefGems, "installChefGems");
+ this.installChef = checkNotNull(installChef, "installChef");
this.validatorName = checkNotNull(validatorName, "validatorName");
this.validatorCredential = checkNotNull(validatorCredential, validatorCredential);
}
@@ -124,7 +126,7 @@ public class GroupToBootScript implements Function<String, Statement> {
String strOptions = Joiner.on(' ').withKeyValueSeparator(" ").join(options.build());
Statement runChef = exec("chef-client " + strOptions);
- return newStatementList(installChefGems, createChefConfigDir, createClientRb, createValidationPem,
+ return newStatementList(new ExitInsteadOfReturn(installChef), createChefConfigDir, createClientRb, createValidationPem,
createFirstBoot, runChef);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/373f9ead/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
index 634c5da..3a7bae4 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
@@ -45,7 +45,7 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
provider = "chef";
}
- private HttpRequest.Builder getHttpRequestBuilder(String method, String endPoint) {
+ private HttpRequest.Builder<?> getHttpRequestBuilder(String method, String endPoint) {
return HttpRequest.builder() //
.method(method) //
.endpoint("http://localhost:4000" + endPoint) //
http://git-wip-us.apache.org/repos/asf/jclouds/blob/373f9ead/apis/chef/src/test/java/org/jclouds/chef/functions/GroupToBootScriptTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/GroupToBootScriptTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/GroupToBootScriptTest.java
index 7b51f04..fa9cf3f 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/GroupToBootScriptTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/GroupToBootScriptTest.java
@@ -22,6 +22,7 @@ import static org.easymock.EasyMock.replay;
import static org.easymock.EasyMock.verify;
import static org.jclouds.chef.config.ChefProperties.CHEF_UPDATE_GEMS;
import static org.jclouds.chef.config.ChefProperties.CHEF_UPDATE_GEM_SYSTEM;
+import static org.jclouds.chef.config.ChefProperties.CHEF_USE_OMNIBUS;
import static org.testng.Assert.assertEquals;
import java.io.IOException;
@@ -31,6 +32,7 @@ import java.security.PrivateKey;
import org.jclouds.chef.ChefApiMetadata;
import org.jclouds.chef.config.ChefBootstrapModule;
import org.jclouds.chef.config.ChefParserModule;
+import org.jclouds.chef.config.InstallChef;
import org.jclouds.chef.domain.DatabagItem;
import org.jclouds.crypto.PemsTest;
import org.jclouds.domain.JsonBall;
@@ -64,21 +66,34 @@ public class GroupToBootScriptTest {
private Json json;
private Statement installChefGems;
+ private Statement installChefOmnibus;
private Optional<String> validatorName;
@BeforeClass
public void setup() {
- Injector injector = Guice.createInjector(new AbstractModule() {
+ Injector injectorGems = Guice.createInjector(new AbstractModule() {
@Override
protected void configure() {
bind(String.class).annotatedWith(ApiVersion.class).toInstance(ChefApiMetadata.DEFAULT_API_VERSION);
bind(String.class).annotatedWith(Names.named(CHEF_UPDATE_GEM_SYSTEM)).toInstance("true");
bind(String.class).annotatedWith(Names.named(CHEF_UPDATE_GEMS)).toInstance("true");
+ bind(String.class).annotatedWith(Names.named(CHEF_USE_OMNIBUS)).toInstance("false");
}
}, new ChefParserModule(), new GsonModule(), new ChefBootstrapModule());
- json = injector.getInstance(Json.class);
- installChefGems = injector.getInstance(Key.get(Statement.class, Names.named("installChefGems")));
+ Injector injectorOmnibus = Guice.createInjector(new AbstractModule() {
+ @Override
+ protected void configure() {
+ bind(String.class).annotatedWith(ApiVersion.class).toInstance(ChefApiMetadata.DEFAULT_API_VERSION);
+ bind(String.class).annotatedWith(Names.named(CHEF_UPDATE_GEM_SYSTEM)).toInstance("true");
+ bind(String.class).annotatedWith(Names.named(CHEF_UPDATE_GEMS)).toInstance("true");
+ bind(String.class).annotatedWith(Names.named(CHEF_USE_OMNIBUS)).toInstance("true");
+ }
+ }, new ChefParserModule(), new GsonModule(), new ChefBootstrapModule());
+
+ json = injectorGems.getInstance(Json.class);
+ installChefGems = injectorGems.getInstance(Key.get(Statement.class, InstallChef.class));
+ installChefOmnibus = injectorOmnibus.getInstance(Key.get(Statement.class, InstallChef.class));
validatorName = Optional.<String> of("chef-validator");
}
@@ -130,13 +145,15 @@ public class GroupToBootScriptTest {
assertEquals(
fn.apply("foo").render(OsFamily.UNIX),
- Resources.toString(Resources.getResource("test_install_ruby." + ShellToken.SH.to(OsFamily.UNIX)),
- Charsets.UTF_8)
- + Resources.toString(
- Resources.getResource("test_install_rubygems." + ShellToken.SH.to(OsFamily.UNIX)),
+ exitInsteadOfReturn(
+ OsFamily.UNIX,
+ Resources.toString(Resources.getResource("test_install_ruby." + ShellToken.SH.to(OsFamily.UNIX)),
Charsets.UTF_8)
- + "gem install chef --no-rdoc --no-ri\n"
- + Resources.toString(Resources.getResource("bootstrap.sh"), Charsets.UTF_8));
+ + Resources.toString(
+ Resources.getResource("test_install_rubygems." + ShellToken.SH.to(OsFamily.UNIX)),
+ Charsets.UTF_8)
+ + "gem install chef --no-rdoc --no-ri\n"
+ + Resources.toString(Resources.getResource("bootstrap.sh"), Charsets.UTF_8)));
verify(validatorKey);
}
@@ -155,14 +172,62 @@ public class GroupToBootScriptTest {
assertEquals(
fn.apply("foo").render(OsFamily.UNIX),
- Resources.toString(Resources.getResource("test_install_ruby." + ShellToken.SH.to(OsFamily.UNIX)),
- Charsets.UTF_8)
- + Resources.toString(
- Resources.getResource("test_install_rubygems." + ShellToken.SH.to(OsFamily.UNIX)),
+ exitInsteadOfReturn(
+ OsFamily.UNIX,
+ Resources.toString(Resources.getResource("test_install_ruby." + ShellToken.SH.to(OsFamily.UNIX)),
Charsets.UTF_8)
- + "gem install chef --no-rdoc --no-ri\n"
+ + Resources.toString(
+ Resources.getResource("test_install_rubygems." + ShellToken.SH.to(OsFamily.UNIX)),
+ Charsets.UTF_8)
+ + "gem install chef --no-rdoc --no-ri\n"
+ + Resources.toString(Resources.getResource("bootstrap-env.sh"), Charsets.UTF_8)));
+
+ verify(validatorKey);
+ }
+
+ public void testOneRecipeOmnibus() throws IOException {
+ Optional<PrivateKey> validatorCredential = Optional.of(createMock(PrivateKey.class));
+ GroupToBootScript fn = new GroupToBootScript(Suppliers.ofInstance(URI.create("http://localhost:4000")), json,
+ CacheLoader.from(Functions.forMap(ImmutableMap.<String, JsonBall> of("foo", new JsonBall(
+ "{\"tomcat6\":{\"ssl_port\":8433},\"run_list\":[\"recipe[apache2]\",\"role[webserver]\"]}")))),
+ installChefOmnibus, validatorName, validatorCredential);
+
+ PrivateKey validatorKey = validatorCredential.get();
+ expect(validatorKey.getEncoded()).andReturn(PemsTest.PRIVATE_KEY.getBytes());
+ replay(validatorKey);
+
+ assertEquals(
+ fn.apply("foo").render(OsFamily.UNIX),
+ "setupPublicCurl || exit 1\ncurl -q -s -S -L --connect-timeout 10 --max-time 600 --retry 20 "
+ + "-X GET https://www.opscode.com/chef/install.sh |(bash)\n"
+ + Resources.toString(Resources.getResource("bootstrap.sh"), Charsets.UTF_8));
+
+ verify(validatorKey);
+ }
+
+ public void testOneRecipeAndEnvironmentOmnibus() throws IOException {
+ Optional<PrivateKey> validatorCredential = Optional.of(createMock(PrivateKey.class));
+ GroupToBootScript fn = new GroupToBootScript(Suppliers.ofInstance(URI.create("http://localhost:4000")), json,
+ CacheLoader.from(Functions.forMap(ImmutableMap.<String, JsonBall> of("foo", new JsonBall(
+ "{\"tomcat6\":{\"ssl_port\":8433},\"environment\":\"env\","
+ + "\"run_list\":[\"recipe[apache2]\",\"role[webserver]\"]}")))), installChefOmnibus,
+ validatorName, validatorCredential);
+
+ PrivateKey validatorKey = validatorCredential.get();
+ expect(validatorKey.getEncoded()).andReturn(PemsTest.PRIVATE_KEY.getBytes());
+ replay(validatorKey);
+
+ assertEquals(
+ fn.apply("foo").render(OsFamily.UNIX),
+ "setupPublicCurl || exit 1\ncurl -q -s -S -L --connect-timeout 10 --max-time 600 --retry 20 "
+ + "-X GET https://www.opscode.com/chef/install.sh |(bash)\n"
+ Resources.toString(Resources.getResource("bootstrap-env.sh"), Charsets.UTF_8));
verify(validatorKey);
}
+
+ private static String exitInsteadOfReturn(OsFamily family, String input) {
+ return input.replaceAll(ShellToken.RETURN.to(family), ShellToken.EXIT.to(family));
+ }
+
}
[30/50] [abbrv] jclouds git commit: Prefer ByteStreams2 over
ByteSources.asByteSource
Posted by na...@apache.org.
Prefer ByteStreams2 over ByteSources.asByteSource
The latter breaks the contract of ByteSource which specifies that
openStream can produce multiple independent streams.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/2681a8e1
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/2681a8e1
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/2681a8e1
Branch: refs/heads/1.8.x
Commit: 2681a8e19d1efadfda4f4287b205ccc1949c4249
Parents: d082995
Author: Andrew Gaul <ga...@apache.org>
Authored: Tue Jul 22 16:50:46 2014 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Tue Jul 22 16:56:00 2014 -0700
----------------------------------------------------------------------
.../src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java | 4 ++--
.../test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2681a8e1/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java b/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
index 7d789bb..cabe579 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
@@ -42,7 +42,7 @@ import org.jclouds.http.HttpRequest;
import org.jclouds.http.HttpRequestFilter;
import org.jclouds.http.HttpUtils;
import org.jclouds.http.internal.SignatureWire;
-import org.jclouds.io.ByteSources;
+import org.jclouds.io.ByteStreams2;
import org.jclouds.io.Payload;
import org.jclouds.io.Payloads;
import org.jclouds.io.payloads.MultipartForm;
@@ -162,7 +162,7 @@ public class SignedHeaderAuth implements HttpRequestFilter {
checkArgument(payload != null, "payload was null");
checkArgument(payload.isRepeatable(), "payload must be repeatable: " + payload);
try {
- return base64().encode(ByteSources.asByteSource(payload.getInput()).hash(sha1()).asBytes());
+ return base64().encode(ByteStreams2.hashAndClose(payload.getInput(), sha1()).asBytes());
} catch (Exception e) {
Throwables.propagateIfPossible(e);
throw new HttpException("error creating sigature for payload: " + payload, e);
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2681a8e1/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
index 2d04dcd..b57499c 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
@@ -21,7 +21,6 @@ import static com.google.common.collect.Iterables.any;
import static com.google.common.collect.Iterables.isEmpty;
import static com.google.common.hash.Hashing.md5;
import static java.util.concurrent.TimeUnit.MILLISECONDS;
-import static org.jclouds.io.ByteSources.asByteSource;
import static org.jclouds.util.Predicates2.retry;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
@@ -55,6 +54,7 @@ import org.jclouds.chef.domain.UploadSandbox;
import org.jclouds.chef.options.CreateClientOptions;
import org.jclouds.chef.options.SearchOptions;
import org.jclouds.crypto.Pems;
+import org.jclouds.io.ByteStream2;
import org.jclouds.io.Payloads;
import org.jclouds.io.payloads.FilePayload;
import org.jclouds.rest.ResourceNotFoundException;
@@ -167,7 +167,7 @@ public abstract class BaseChefApiLiveTest<A extends ChefApi> extends BaseChefLiv
InputStream stream = api.getResourceContents(resource);
assertNotNull(stream, "Resource contents are null for resource: " + resource.getName());
- byte[] md5 = asByteSource(stream).hash(md5()).asBytes();
+ byte[] md5 = ByteStream2.hashAndClose(stream, md5()).asBytes();
assertEquals(md5, resource.getChecksum());
}
}
[02/50] [abbrv] jclouds git commit: Renamed test methods and file
names to match the new api naming convention
Posted by na...@apache.org.
Renamed test methods and file names to match the new api naming convention
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/694cfdf4
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/694cfdf4
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/694cfdf4
Branch: refs/heads/1.8.x
Commit: 694cfdf441b5446d94678f85912a25c7859c9671
Parents: 7b28bbe
Author: Noorul Islam K M <no...@noorul.com>
Authored: Tue Sep 17 08:49:41 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Tue Sep 17 14:44:23 2013 +0200
----------------------------------------------------------------------
.../jclouds/chef/internal/BaseChefService.java | 10 +-
.../chef/strategy/ListEnvironmentNodes.java | 45 --------
.../chef/strategy/ListNodesInEnvironment.java | 45 ++++++++
.../internal/ListEnvironmentNodesImpl.java | 109 -------------------
.../internal/ListNodesInEnvironmentImpl.java | 109 +++++++++++++++++++
.../GetEnvironmentNodesImplLiveTest.java | 81 --------------
.../strategy/internal/GetNodesImplLiveTest.java | 81 --------------
.../internal/ListNodesImplLiveTest.java | 81 ++++++++++++++
.../ListNodesInEnvironmentImplLiveTest.java | 81 ++++++++++++++
9 files changed, 321 insertions(+), 321 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/694cfdf4/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
index 9d33570..4600ffc 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
@@ -49,7 +49,7 @@ import org.jclouds.chef.strategy.DeleteAllClientsInList;
import org.jclouds.chef.strategy.DeleteAllNodesInList;
import org.jclouds.chef.strategy.ListClients;
import org.jclouds.chef.strategy.ListCookbookVersions;
-import org.jclouds.chef.strategy.ListEnvironmentNodes;
+import org.jclouds.chef.strategy.ListNodesInEnvironment;
import org.jclouds.chef.strategy.ListEnvironments;
import org.jclouds.chef.strategy.ListNodes;
import org.jclouds.chef.strategy.UpdateAutomaticAttributesOnNode;
@@ -89,7 +89,7 @@ public class BaseChefService implements ChefService {
private final RunListForGroup runListForGroup;
private final ListCookbookVersions listCookbookVersions;
private final ListEnvironments listEnvironments;
- private final ListEnvironmentNodes listEnvironmentNodes;
+ private final ListNodesInEnvironment listNodesInEnvironment;
private final Json json;
@Resource
@Named(ChefProperties.CHEF_LOGGER)
@@ -104,7 +104,7 @@ public class BaseChefService implements ChefService {
UpdateAutomaticAttributesOnNode updateAutomaticAttributesOnNode, Supplier<PrivateKey> privateKey,
@Named(CHEF_BOOTSTRAP_DATABAG) String databag, GroupToBootScript groupToBootScript,
BootstrapConfigForGroup bootstrapConfigForGroup, RunListForGroup runListForGroup,
- ListEnvironments listEnvironments, ListEnvironmentNodes listEnvironmentNodes, Json json) {
+ ListEnvironments listEnvironments, ListNodesInEnvironment listNodesInEnvironment, Json json) {
this.chefContext = checkNotNull(chefContext, "chefContext");
this.api = checkNotNull(api, "api");
this.cleanupStaleNodesAndClients = checkNotNull(cleanupStaleNodesAndClients, "cleanupStaleNodesAndClients");
@@ -123,7 +123,7 @@ public class BaseChefService implements ChefService {
this.bootstrapConfigForGroup = checkNotNull(bootstrapConfigForGroup, "bootstrapConfigForGroup");
this.runListForGroup = checkNotNull(runListForGroup, "runListForGroup");
this.listEnvironments = checkNotNull(listEnvironments, "listEnvironments");
- this.listEnvironmentNodes = checkNotNull(listEnvironmentNodes, "listEnvironmentNodes");
+ this.listNodesInEnvironment = checkNotNull(listNodesInEnvironment, "listNodesInEnvironment");
this.json = checkNotNull(json, "json");
}
@@ -244,7 +244,7 @@ public class BaseChefService implements ChefService {
@Override
public Iterable<? extends Node> listNodesInEnvironment(String environmentName) {
- return listEnvironmentNodes.execute(environmentName);
+ return listNodesInEnvironment.execute(environmentName);
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/694cfdf4/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironmentNodes.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironmentNodes.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironmentNodes.java
deleted file mode 100644
index 6414994..0000000
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironmentNodes.java
+++ /dev/null
@@ -1,45 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jclouds.chef.strategy;
-
-import org.jclouds.chef.domain.Node;
-import org.jclouds.chef.strategy.internal.ListEnvironmentNodesImpl;
-
-import com.google.common.base.Predicate;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.ImplementedBy;
-
-/**
- *
- *
- * @author Noorul Islam K M
- */
-@ImplementedBy(ListEnvironmentNodesImpl.class)
-public interface ListEnvironmentNodes {
-
- public Iterable<? extends Node> execute(String environmentName);
-
- public Iterable<? extends Node> execute(String environmentName, Predicate<String> nodeNameSelector);
-
- public Iterable<? extends Node> execute(String environmentName, Iterable<String> toGet);
-
- public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName);
-
- public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Predicate<String> nodeNameSelector);
-
- public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Iterable<String> toGet);
-}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/694cfdf4/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
new file mode 100644
index 0000000..c007d0e
--- /dev/null
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.chef.strategy;
+
+import org.jclouds.chef.domain.Node;
+import org.jclouds.chef.strategy.internal.ListNodesInEnvironmentImpl;
+
+import com.google.common.base.Predicate;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.inject.ImplementedBy;
+
+/**
+ *
+ *
+ * @author Noorul Islam K M
+ */
+@ImplementedBy(ListNodesInEnvironmentImpl.class)
+public interface ListNodesInEnvironment {
+
+ public Iterable<? extends Node> execute(String environmentName);
+
+ public Iterable<? extends Node> execute(String environmentName, Predicate<String> nodeNameSelector);
+
+ public Iterable<? extends Node> execute(String environmentName, Iterable<String> toGet);
+
+ public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName);
+
+ public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Predicate<String> nodeNameSelector);
+
+ public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Iterable<String> toGet);
+}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/694cfdf4/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentNodesImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentNodesImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentNodesImpl.java
deleted file mode 100644
index c017828..0000000
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentNodesImpl.java
+++ /dev/null
@@ -1,109 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jclouds.chef.strategy.internal;
-
-import static com.google.common.base.Preconditions.checkNotNull;
-import static com.google.common.collect.Iterables.filter;
-import static com.google.common.collect.Iterables.transform;
-import static com.google.common.util.concurrent.Futures.allAsList;
-import static com.google.common.util.concurrent.Futures.getUnchecked;
-
-import java.util.List;
-import java.util.concurrent.Callable;
-
-import javax.annotation.Resource;
-import javax.inject.Named;
-import javax.inject.Singleton;
-
-import org.jclouds.Constants;
-import org.jclouds.chef.ChefApi;
-import org.jclouds.chef.config.ChefProperties;
-import org.jclouds.chef.domain.Node;
-import org.jclouds.chef.strategy.ListEnvironmentNodes;
-import org.jclouds.logging.Logger;
-
-import com.google.common.base.Function;
-import com.google.common.base.Joiner;
-import com.google.common.base.Predicate;
-import com.google.common.util.concurrent.ListenableFuture;
-import com.google.common.util.concurrent.ListeningExecutorService;
-import com.google.inject.Inject;
-
-/**
- *
- *
- * @author Noorul Islam K M
- */
-@Singleton
-public class ListEnvironmentNodesImpl implements ListEnvironmentNodes {
-
- protected final ChefApi api;
- protected final ListeningExecutorService userExecutor;
- @Resource
- @Named(ChefProperties.CHEF_LOGGER)
- protected Logger logger = Logger.NULL;
-
- @Inject
- ListEnvironmentNodesImpl(@Named(Constants.PROPERTY_USER_THREADS) ListeningExecutorService userExecutor, ChefApi api) {
- this.userExecutor = checkNotNull(userExecutor, "userExecuor");
- this.api = checkNotNull(api, "api");
- }
-
- @Override
- public Iterable<? extends Node> execute(String environmentName) {
- return execute(userExecutor, environmentName);
- }
-
- @Override
- public Iterable<? extends Node> execute(String environmentName, Predicate<String> nodeNameSelector) {
- return execute(userExecutor, environmentName, nodeNameSelector);
- }
-
- @Override
- public Iterable<? extends Node> execute(String environmentName, Iterable<String> toGet) {
- return execute(userExecutor, environmentName, toGet);
- }
-
- @Override
- public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName) {
- return execute(executor, environmentName, api.listNodesInEnvironment(environmentName));
- }
-
- @Override
- public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Predicate<String> nodeNameSelector) {
- return execute(executor, environmentName, filter(api.listNodesInEnvironment(environmentName), nodeNameSelector));
- }
-
- @Override
- public Iterable<? extends Node> execute(final ListeningExecutorService executor, String environmentName, Iterable<String> toGet) {
- ListenableFuture<List<Node>> futures = allAsList(transform(toGet, new Function<String, ListenableFuture<Node>>() {
- @Override
- public ListenableFuture<Node> apply(final String input) {
- return executor.submit(new Callable<Node>() {
- @Override
- public Node call() throws Exception {
- return api.getNode(input);
- }
- });
- }
- }));
-
- logger.trace(String.format("getting nodes in environment %s: %s", environmentName, Joiner.on(',').join(toGet)));
- return getUnchecked(futures);
- }
-
-}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/694cfdf4/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
new file mode 100644
index 0000000..c430b95
--- /dev/null
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.chef.strategy.internal;
+
+import static com.google.common.base.Preconditions.checkNotNull;
+import static com.google.common.collect.Iterables.filter;
+import static com.google.common.collect.Iterables.transform;
+import static com.google.common.util.concurrent.Futures.allAsList;
+import static com.google.common.util.concurrent.Futures.getUnchecked;
+
+import java.util.List;
+import java.util.concurrent.Callable;
+
+import javax.annotation.Resource;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.jclouds.Constants;
+import org.jclouds.chef.ChefApi;
+import org.jclouds.chef.config.ChefProperties;
+import org.jclouds.chef.domain.Node;
+import org.jclouds.chef.strategy.ListNodesInEnvironment;
+import org.jclouds.logging.Logger;
+
+import com.google.common.base.Function;
+import com.google.common.base.Joiner;
+import com.google.common.base.Predicate;
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.inject.Inject;
+
+/**
+ *
+ *
+ * @author Noorul Islam K M
+ */
+@Singleton
+public class ListNodesInEnvironmentImpl implements ListNodesInEnvironment {
+
+ protected final ChefApi api;
+ protected final ListeningExecutorService userExecutor;
+ @Resource
+ @Named(ChefProperties.CHEF_LOGGER)
+ protected Logger logger = Logger.NULL;
+
+ @Inject
+ ListNodesInEnvironmentImpl(@Named(Constants.PROPERTY_USER_THREADS) ListeningExecutorService userExecutor, ChefApi api) {
+ this.userExecutor = checkNotNull(userExecutor, "userExecuor");
+ this.api = checkNotNull(api, "api");
+ }
+
+ @Override
+ public Iterable<? extends Node> execute(String environmentName) {
+ return execute(userExecutor, environmentName);
+ }
+
+ @Override
+ public Iterable<? extends Node> execute(String environmentName, Predicate<String> nodeNameSelector) {
+ return execute(userExecutor, environmentName, nodeNameSelector);
+ }
+
+ @Override
+ public Iterable<? extends Node> execute(String environmentName, Iterable<String> toGet) {
+ return execute(userExecutor, environmentName, toGet);
+ }
+
+ @Override
+ public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName) {
+ return execute(executor, environmentName, api.listNodesInEnvironment(environmentName));
+ }
+
+ @Override
+ public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Predicate<String> nodeNameSelector) {
+ return execute(executor, environmentName, filter(api.listNodesInEnvironment(environmentName), nodeNameSelector));
+ }
+
+ @Override
+ public Iterable<? extends Node> execute(final ListeningExecutorService executor, String environmentName, Iterable<String> toGet) {
+ ListenableFuture<List<Node>> futures = allAsList(transform(toGet, new Function<String, ListenableFuture<Node>>() {
+ @Override
+ public ListenableFuture<Node> apply(final String input) {
+ return executor.submit(new Callable<Node>() {
+ @Override
+ public Node call() throws Exception {
+ return api.getNode(input);
+ }
+ });
+ }
+ }));
+
+ logger.trace(String.format("getting nodes in environment %s: %s", environmentName, Joiner.on(',').join(toGet)));
+ return getUnchecked(futures);
+ }
+
+}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/694cfdf4/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/GetEnvironmentNodesImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/GetEnvironmentNodesImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/GetEnvironmentNodesImplLiveTest.java
deleted file mode 100644
index 706f275..0000000
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/GetEnvironmentNodesImplLiveTest.java
+++ /dev/null
@@ -1,81 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jclouds.chef.strategy.internal;
-
-import static com.google.common.collect.Iterables.size;
-import static org.testng.Assert.assertEquals;
-import static org.testng.Assert.assertTrue;
-
-import org.jclouds.chef.ChefApi;
-import org.jclouds.chef.internal.BaseChefLiveTest;
-import org.testng.annotations.AfterClass;
-import org.testng.annotations.Test;
-
-import com.google.common.base.Predicate;
-import com.google.common.collect.ImmutableSet;
-
-/**
- * Tests behavior of {@code GetEnvironmentNodesImpl} strategies
- *
- * @author Noorul Islam K M
- */
-@Test(groups = "live", testName = "GetEnvironmentNodesImplLiveTest")
-public class GetEnvironmentNodesImplLiveTest extends BaseChefLiveTest<ChefApi> {
-
- private ListEnvironmentNodesImpl strategy;
- private CreateNodeAndPopulateAutomaticAttributesImpl creator;
-
- @Override
- protected void initialize() {
- super.initialize();
- this.creator = injector.getInstance(CreateNodeAndPopulateAutomaticAttributesImpl.class);
- this.strategy = injector.getInstance(ListEnvironmentNodesImpl.class);
- creator.execute(prefix, ImmutableSet.<String> of());
- creator.execute(prefix + 1, ImmutableSet.<String> of());
- }
-
- @AfterClass(groups = { "integration", "live" })
- @Override
- protected void tearDown() {
- api.deleteNode(prefix);
- api.deleteNode(prefix + 1);
- super.tearDown();
- }
-
- @Test
- public void testExecute() {
- assertTrue(size(strategy.execute("_default")) > 0, "Expected one or more elements");
- }
-
- @Test
- public void testExecutePredicateOfString() {
- assertEquals(size(strategy.execute("_default", new Predicate<String>() {
-
- @Override
- public boolean apply(String input) {
- return input.startsWith(prefix);
- }
-
- })), 2);
- }
-
- @Test
- public void testExecuteIterableOfString() {
- assertEquals(size(strategy.execute("_default", ImmutableSet.of(prefix, prefix + 1))), 2);
- }
-
-}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/694cfdf4/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java
deleted file mode 100644
index 1b36471..0000000
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/GetNodesImplLiveTest.java
+++ /dev/null
@@ -1,81 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jclouds.chef.strategy.internal;
-
-import static com.google.common.collect.Iterables.size;
-import static org.testng.Assert.assertEquals;
-import static org.testng.Assert.assertTrue;
-
-import org.jclouds.chef.ChefApi;
-import org.jclouds.chef.internal.BaseChefLiveTest;
-import org.testng.annotations.AfterClass;
-import org.testng.annotations.Test;
-
-import com.google.common.base.Predicate;
-import com.google.common.collect.ImmutableSet;
-
-/**
- * Tests behavior of {@code GetNodesImpl} strategies
- *
- * @author Adrian Cole
- */
-@Test(groups = "live", testName = "GetNodesImplLiveTest")
-public class GetNodesImplLiveTest extends BaseChefLiveTest<ChefApi> {
-
- private ListNodesImpl strategy;
- private CreateNodeAndPopulateAutomaticAttributesImpl creator;
-
- @Override
- protected void initialize() {
- super.initialize();
- this.creator = injector.getInstance(CreateNodeAndPopulateAutomaticAttributesImpl.class);
- this.strategy = injector.getInstance(ListNodesImpl.class);
- creator.execute(prefix, ImmutableSet.<String> of());
- creator.execute(prefix + 1, ImmutableSet.<String> of());
- }
-
- @AfterClass(groups = { "integration", "live" })
- @Override
- protected void tearDown() {
- api.deleteNode(prefix);
- api.deleteNode(prefix + 1);
- super.tearDown();
- }
-
- @Test
- public void testExecute() {
- assertTrue(size(strategy.execute()) > 0, "Expected one or more elements");
- }
-
- @Test
- public void testExecutePredicateOfString() {
- assertEquals(size(strategy.execute(new Predicate<String>() {
-
- @Override
- public boolean apply(String input) {
- return input.startsWith(prefix);
- }
-
- })), 2);
- }
-
- @Test
- public void testExecuteIterableOfString() {
- assertEquals(size(strategy.execute(ImmutableSet.of(prefix, prefix + 1))), 2);
- }
-
-}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/694cfdf4/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
new file mode 100644
index 0000000..80b9678
--- /dev/null
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.chef.strategy.internal;
+
+import static com.google.common.collect.Iterables.size;
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertTrue;
+
+import org.jclouds.chef.ChefApi;
+import org.jclouds.chef.internal.BaseChefLiveTest;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.Test;
+
+import com.google.common.base.Predicate;
+import com.google.common.collect.ImmutableSet;
+
+/**
+ * Tests behavior of {@code ListNodesImpl} strategies
+ *
+ * @author Adrian Cole
+ */
+@Test(groups = "live", testName = "ListNodesImplLiveTest")
+public class ListNodesImplLiveTest extends BaseChefLiveTest<ChefApi> {
+
+ private ListNodesImpl strategy;
+ private CreateNodeAndPopulateAutomaticAttributesImpl creator;
+
+ @Override
+ protected void initialize() {
+ super.initialize();
+ this.creator = injector.getInstance(CreateNodeAndPopulateAutomaticAttributesImpl.class);
+ this.strategy = injector.getInstance(ListNodesImpl.class);
+ creator.execute(prefix, ImmutableSet.<String> of());
+ creator.execute(prefix + 1, ImmutableSet.<String> of());
+ }
+
+ @AfterClass(groups = { "integration", "live" })
+ @Override
+ protected void tearDown() {
+ api.deleteNode(prefix);
+ api.deleteNode(prefix + 1);
+ super.tearDown();
+ }
+
+ @Test
+ public void testExecute() {
+ assertTrue(size(strategy.execute()) > 0, "Expected one or more elements");
+ }
+
+ @Test
+ public void testExecutePredicateOfString() {
+ assertEquals(size(strategy.execute(new Predicate<String>() {
+
+ @Override
+ public boolean apply(String input) {
+ return input.startsWith(prefix);
+ }
+
+ })), 2);
+ }
+
+ @Test
+ public void testExecuteIterableOfString() {
+ assertEquals(size(strategy.execute(ImmutableSet.of(prefix, prefix + 1))), 2);
+ }
+
+}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/694cfdf4/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
new file mode 100644
index 0000000..0d19c12
--- /dev/null
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.chef.strategy.internal;
+
+import static com.google.common.collect.Iterables.size;
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertTrue;
+
+import org.jclouds.chef.ChefApi;
+import org.jclouds.chef.internal.BaseChefLiveTest;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.Test;
+
+import com.google.common.base.Predicate;
+import com.google.common.collect.ImmutableSet;
+
+/**
+ * Tests behavior of {@code ListNodesInEnvironmentImpl} strategies
+ *
+ * @author Noorul Islam K M
+ */
+@Test(groups = "live", testName = "ListNodesInEnvironmentImplLiveTest")
+public class ListNodesInEnvironmentImplLiveTest extends BaseChefLiveTest<ChefApi> {
+
+ private ListNodesInEnvironmentImpl strategy;
+ private CreateNodeAndPopulateAutomaticAttributesImpl creator;
+
+ @Override
+ protected void initialize() {
+ super.initialize();
+ this.creator = injector.getInstance(CreateNodeAndPopulateAutomaticAttributesImpl.class);
+ this.strategy = injector.getInstance(ListNodesInEnvironmentImpl.class);
+ creator.execute(prefix, ImmutableSet.<String> of());
+ creator.execute(prefix + 1, ImmutableSet.<String> of());
+ }
+
+ @AfterClass(groups = { "integration", "live" })
+ @Override
+ protected void tearDown() {
+ api.deleteNode(prefix);
+ api.deleteNode(prefix + 1);
+ super.tearDown();
+ }
+
+ @Test
+ public void testExecute() {
+ assertTrue(size(strategy.execute("_default")) > 0, "Expected one or more elements");
+ }
+
+ @Test
+ public void testExecutePredicateOfString() {
+ assertEquals(size(strategy.execute("_default", new Predicate<String>() {
+
+ @Override
+ public boolean apply(String input) {
+ return input.startsWith(prefix);
+ }
+
+ })), 2);
+ }
+
+ @Test
+ public void testExecuteIterableOfString() {
+ assertEquals(size(strategy.execute("_default", ImmutableSet.of(prefix, prefix + 1))), 2);
+ }
+
+}
[16/50] [abbrv] jclouds git commit: JCLOUDS-274 Implement
listCookbookVersionsInEnvironment in ChefService API
Posted by na...@apache.org.
JCLOUDS-274 Implement listCookbookVersionsInEnvironment in ChefService API
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/89a2b8ab
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/89a2b8ab
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/89a2b8ab
Branch: refs/heads/1.8.x
Commit: 89a2b8ab36d677d9ad4e343049ff22de6a0bae51
Parents: d786daa
Author: Noorul Islam K M <no...@noorul.com>
Authored: Fri Oct 4 14:09:05 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Tue Nov 5 12:10:58 2013 +0100
----------------------------------------------------------------------
.../main/java/org/jclouds/chef/ChefService.java | 19 +++
.../jclouds/chef/internal/BaseChefService.java | 16 +-
.../ListCookbookVersionsInEnvironment.java | 41 +++++
.../ListCookbookVersionsInEnvironmentImpl.java | 113 ++++++++++++
...okbookVersionsInEnvironmentImplLiveTest.java | 171 +++++++++++++++++++
5 files changed, 359 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/89a2b8ab/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/ChefService.java b/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
index f20df68..8006b88 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
@@ -187,6 +187,25 @@ public interface ChefService {
Iterable<? extends CookbookVersion> listCookbookVersions();
/**
+ * Lists the details of all existing cookbooks in an environment.
+ *
+ * @param environmentName The environment name.
+ * @return The details of all existing cookbooks in an environment.
+ */
+ Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName);
+
+ /**
+ * Lists the details of all existing cookbooks in an environment
+ * limiting number of versions.
+ *
+ * @param environmentName The environment name.
+ * @param numVersions The number of cookbook versions to include.
+ * Use 'all' to return all cookbook versions.
+ * @return The details of all existing cookbooks in environment.
+ */
+ Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName, String numVersions);
+
+ /**
* Lists the details of all existing environments.
*
* @return The details of all existing environments.
http://git-wip-us.apache.org/repos/asf/jclouds/blob/89a2b8ab/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
index 4600ffc..a841922 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
@@ -49,6 +49,7 @@ import org.jclouds.chef.strategy.DeleteAllClientsInList;
import org.jclouds.chef.strategy.DeleteAllNodesInList;
import org.jclouds.chef.strategy.ListClients;
import org.jclouds.chef.strategy.ListCookbookVersions;
+import org.jclouds.chef.strategy.ListCookbookVersionsInEnvironment;
import org.jclouds.chef.strategy.ListNodesInEnvironment;
import org.jclouds.chef.strategy.ListEnvironments;
import org.jclouds.chef.strategy.ListNodes;
@@ -88,6 +89,7 @@ public class BaseChefService implements ChefService {
private final BootstrapConfigForGroup bootstrapConfigForGroup;
private final RunListForGroup runListForGroup;
private final ListCookbookVersions listCookbookVersions;
+ private final ListCookbookVersionsInEnvironment listCookbookVersionsInEnvironment;
private final ListEnvironments listEnvironments;
private final ListNodesInEnvironment listNodesInEnvironment;
private final Json json;
@@ -104,7 +106,8 @@ public class BaseChefService implements ChefService {
UpdateAutomaticAttributesOnNode updateAutomaticAttributesOnNode, Supplier<PrivateKey> privateKey,
@Named(CHEF_BOOTSTRAP_DATABAG) String databag, GroupToBootScript groupToBootScript,
BootstrapConfigForGroup bootstrapConfigForGroup, RunListForGroup runListForGroup,
- ListEnvironments listEnvironments, ListNodesInEnvironment listNodesInEnvironment, Json json) {
+ ListEnvironments listEnvironments, ListNodesInEnvironment listNodesInEnvironment,
+ ListCookbookVersionsInEnvironment listCookbookVersionsInEnvironment, Json json) {
this.chefContext = checkNotNull(chefContext, "chefContext");
this.api = checkNotNull(api, "api");
this.cleanupStaleNodesAndClients = checkNotNull(cleanupStaleNodesAndClients, "cleanupStaleNodesAndClients");
@@ -124,6 +127,7 @@ public class BaseChefService implements ChefService {
this.runListForGroup = checkNotNull(runListForGroup, "runListForGroup");
this.listEnvironments = checkNotNull(listEnvironments, "listEnvironments");
this.listNodesInEnvironment = checkNotNull(listNodesInEnvironment, "listNodesInEnvironment");
+ this.listCookbookVersionsInEnvironment = checkNotNull(listCookbookVersionsInEnvironment, "listCookbookVersionsInEnvironment");
this.json = checkNotNull(json, "json");
}
@@ -238,6 +242,16 @@ public class BaseChefService implements ChefService {
}
@Override
+ public Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName) {
+ return listCookbookVersionsInEnvironment.execute(environmentName);
+ }
+
+ @Override
+ public Iterable<? extends CookbookVersion> listCookbookVersionsInEnvironment(String environmentName, String numVersions) {
+ return listCookbookVersionsInEnvironment.execute(environmentName, numVersions);
+ }
+
+ @Override
public Iterable<? extends Environment> listEnvironments() {
return listEnvironments.execute();
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/89a2b8ab/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
new file mode 100644
index 0000000..e19918c
--- /dev/null
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.chef.strategy;
+
+import org.jclouds.chef.domain.CookbookDefinition;
+import org.jclouds.chef.domain.CookbookVersion;
+import org.jclouds.chef.strategy.internal.ListCookbookVersionsInEnvironmentImpl;
+
+import com.google.common.base.Predicate;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.inject.ImplementedBy;
+
+/**
+ *
+ * @author Noorul Islam K M
+ */
+@ImplementedBy(ListCookbookVersionsInEnvironmentImpl.class)
+public interface ListCookbookVersionsInEnvironment {
+
+ Iterable<? extends CookbookVersion> execute(String environmentName);
+
+ Iterable<? extends CookbookVersion> execute(String environmentName, String numVersions);
+
+ Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, String environmentName);
+
+ Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, String environmentName, String numVersions);
+}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/89a2b8ab/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
new file mode 100644
index 0000000..48d563e
--- /dev/null
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.chef.strategy.internal;
+
+import static com.google.common.base.Preconditions.checkNotNull;
+import static com.google.common.collect.Iterables.concat;
+import static com.google.common.collect.Iterables.contains;
+import static com.google.common.collect.Iterables.filter;
+import static com.google.common.collect.Iterables.transform;
+import static com.google.common.util.concurrent.Futures.allAsList;
+import static com.google.common.util.concurrent.Futures.getUnchecked;
+
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.Callable;
+
+import javax.annotation.Resource;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.jclouds.Constants;
+import org.jclouds.chef.ChefApi;
+import org.jclouds.chef.config.ChefProperties;
+import org.jclouds.chef.domain.CookbookDefinition;
+import org.jclouds.chef.domain.CookbookVersion;
+import org.jclouds.chef.strategy.ListCookbookVersionsInEnvironment;
+import org.jclouds.logging.Logger;
+
+import com.google.common.base.Function;
+import com.google.common.base.Predicate;
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.inject.Inject;
+
+/**
+ *
+ * @author Noorul Islam K M
+ */
+@Singleton
+public class ListCookbookVersionsInEnvironmentImpl implements ListCookbookVersionsInEnvironment {
+
+ protected final ChefApi api;
+ protected final ListeningExecutorService userExecutor;
+ @Resource
+ @Named(ChefProperties.CHEF_LOGGER)
+ protected Logger logger = Logger.NULL;
+
+ @Inject
+ ListCookbookVersionsInEnvironmentImpl(@Named(Constants.PROPERTY_USER_THREADS) ListeningExecutorService userExecutor, ChefApi api) {
+ this.userExecutor = checkNotNull(userExecutor, "userExecuor");
+ this.api = checkNotNull(api, "api");
+ }
+
+ @Override
+ public Iterable<? extends CookbookVersion> execute(String environmentName) {
+ return execute(userExecutor, environmentName);
+ }
+
+ @Override
+ public Iterable<? extends CookbookVersion> execute(String environmentName, String numVersions) {
+ return execute(userExecutor, environmentName, numVersions);
+ }
+
+ public Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, String environmentName) {
+ return execute(executor, api.listCookbooksInEnvironment(environmentName));
+ }
+
+ @Override
+ public Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, String environmentName, String numVersions) {
+ return execute(executor, api.listCookbooksInEnvironment(environmentName, numVersions));
+ }
+
+ private Iterable<? extends CookbookVersion> execute(final ListeningExecutorService executor,
+ Iterable<CookbookDefinition> cookbookDefs) {
+ return concat(transform(cookbookDefs, new Function<CookbookDefinition, Iterable<? extends CookbookVersion>>() {
+
+ @Override
+ public Iterable<? extends CookbookVersion> apply(final CookbookDefinition cookbookDef) {
+ // TODO getting each version could also go parallel
+ Set<CookbookDefinition.Version> cookbookVersions = cookbookDef.getVersions();
+ ListenableFuture<List<CookbookVersion>> futures = allAsList(transform(cookbookVersions,
+ new Function<CookbookDefinition.Version, ListenableFuture<CookbookVersion>>() {
+ @Override
+ public ListenableFuture<CookbookVersion> apply(final CookbookDefinition.Version version) {
+ return executor.submit(new Callable<CookbookVersion>() {
+ @Override
+ public CookbookVersion call() throws Exception {
+ return api.getCookbook(cookbookDef.getName(), version.getVersion());
+ }
+ });
+ }
+ }));
+
+ logger.trace(String.format("getting versions of cookbook %s: ", cookbookDef.getName()));
+ return getUnchecked(futures);
+ }
+ }));
+ }
+}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/89a2b8ab/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
new file mode 100644
index 0000000..1868256
--- /dev/null
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.chef.strategy.internal;
+
+import static com.google.common.collect.Iterables.size;
+import static org.testng.Assert.assertEquals;
+import static org.testng.Assert.assertNotNull;
+import static org.testng.Assert.assertTrue;
+import static org.testng.Assert.fail;
+
+import org.jclouds.chef.ChefApi;
+import org.jclouds.chef.domain.ChecksumStatus;
+import org.jclouds.chef.domain.CookbookDefinition;
+import org.jclouds.chef.domain.CookbookVersion;
+import org.jclouds.chef.domain.Metadata;
+import org.jclouds.chef.domain.Resource;
+import org.jclouds.chef.domain.Sandbox;
+import org.jclouds.chef.domain.UploadSandbox;
+import org.jclouds.chef.internal.BaseChefLiveTest;
+import org.jclouds.io.Payloads;
+import org.jclouds.io.payloads.FilePayload;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.Test;
+
+import java.io.File;
+import java.util.List;
+
+import com.google.common.base.Predicate;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.primitives.Bytes;
+
+/**
+ * Tests behavior of {@code ListCookbookVersionsInEnvironmentImpl} strategies
+ *
+ * @author Noorul Islam K M
+ */
+@Test(groups = "live", testName = "ListCookbookVersionsInEnvironmentImplLiveTest")
+public class ListCookbookVersionsInEnvironmentImplLiveTest extends BaseChefLiveTest<ChefApi> {
+ public static final String PREFIX = "jcloudstest-strategy-" + System.getProperty("user.name");
+
+ private ListCookbookVersionsInEnvironmentImpl strategy;
+ private CreateNodeAndPopulateAutomaticAttributesImpl creator;
+
+ @Override
+ protected void initialize() {
+ super.initialize();
+
+ try {
+ createCookbooksWithMultipleVersions(PREFIX);
+ createCookbooksWithMultipleVersions(PREFIX + 1);
+ } catch (Exception e) {
+ fail("Could not create cookbooks", e);
+ }
+
+ this.strategy = injector.getInstance(ListCookbookVersionsInEnvironmentImpl.class);
+ }
+
+ @AfterClass(groups = { "integration", "live" })
+ @Override
+ protected void tearDown() {
+ api.deleteCookbook(PREFIX, "0.0.0");
+ api.deleteCookbook(PREFIX, "1.0.0");
+ api.deleteCookbook(PREFIX + 1, "0.0.0");
+ api.deleteCookbook(PREFIX + 1, "1.0.0");
+ super.tearDown();
+ }
+
+ @Test
+ public void testExecute() {
+ assertTrue(size(strategy.execute("_default")) > 0, "Expected one or more elements");
+ }
+
+ @Test
+ public void testExecuteWithNumVersions() {
+ assertTrue(size(strategy.execute("_default", "2")) > 0, "Expected one or more elements");
+ }
+
+ @Test
+ public void testExecuteWithNumVersionsAll() {
+ assertTrue(size(strategy.execute("_default", "all")) > 0, "Expected one or more elements");
+ }
+
+ private FilePayload uploadContent(String fileName) throws Exception {
+ // Define the file you want in the cookbook
+ FilePayload content = Payloads.newFilePayload(new File(System.getProperty("user.dir"), fileName));
+ content.getContentMetadata().setContentType("application/x-binary");
+
+ // Get an md5 so that you can see if the server already has it or not
+ Payloads.calculateMD5(content);
+
+ // Note that java collections cannot effectively do equals or hashcodes on
+ // byte arrays, so let's convert to a list of bytes.
+ List<Byte> md5 = Bytes.asList(content.getContentMetadata().getContentMD5());
+
+ // Request an upload site for this file
+ UploadSandbox site = api.createUploadSandboxForChecksums(ImmutableSet.of(md5));
+ assertTrue(site.getChecksums().containsKey(md5), md5 + " not in " + site.getChecksums());
+
+ try {
+ // Upload the file contents, if still not uploaded
+ ChecksumStatus status = site.getChecksums().get(md5);
+ if (status.needsUpload()) {
+ api.uploadContent(status.getUrl(), content);
+ }
+ Sandbox sandbox = api.commitSandbox(site.getSandboxId(), true);
+ assertTrue(sandbox.isCompleted(), "Sandbox should be completed after uploading");
+ } catch (RuntimeException e) {
+ api.commitSandbox(site.getSandboxId(), false);
+ fail("Could not upload content", e);
+ }
+
+ return content;
+ }
+
+ private void createCookbooksWithMultipleVersions(String cookbookName) throws Exception {
+ FilePayload v0content = uploadContent("pom.xml");
+ FilePayload v1content = uploadContent("../README.md");
+
+ // Create the metadata of the cookbook
+ Metadata metadata = Metadata.builder() //
+ .name(cookbookName) //
+ .version("0.0.0") //
+ .description("Jclouds test uploaded cookbook") //
+ .maintainer("jclouds") //
+ .maintainerEmail("someone@jclouds.org") //
+ .license("Apache 2.0") //
+ .build();
+
+ // Create new cookbook version
+ CookbookVersion cookbook = CookbookVersion.builder(cookbookName, "0.0.0") //
+ .metadata(metadata) //
+ .rootFile(Resource.builder().fromPayload(v0content).build()) //
+ .build();
+
+ // upload the cookbook to the remote server
+ api.updateCookbook(cookbookName, "0.0.0", cookbook);
+
+ // Create the metadata of the cookbook
+ metadata = Metadata.builder() //
+ .name(cookbookName) //
+ .version("1.0.0") //
+ .description("Jclouds test uploaded cookbook") //
+ .maintainer("jclouds") //
+ .maintainerEmail("someone@jclouds.org") //
+ .license("Apache 2.0") //
+ .build();
+
+ // Create a new cookbook version
+ cookbook = CookbookVersion.builder(cookbookName, "1.0.0") //
+ .metadata(metadata) //
+ .rootFile(Resource.builder().fromPayload(v1content).build()) //
+ .build();
+
+ // upload the cookbook to the remote server
+ api.updateCookbook(cookbookName, "1.0.0", cookbook);
+ }
+}
[33/50] [abbrv] jclouds git commit: [maven-release-plugin] prepare
release jclouds-chef-1.8.0-rc1
Posted by na...@apache.org.
[maven-release-plugin] prepare release jclouds-chef-1.8.0-rc1
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/67c08462
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/67c08462
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/67c08462
Branch: refs/heads/1.8.x
Commit: 67c084628dada83c92b9729e134151c95732c823
Parents: b9b6f39
Author: Andrew Phillips <an...@apache.org>
Authored: Tue Jul 29 19:53:29 2014 -0400
Committer: Andrew Phillips <an...@apache.org>
Committed: Tue Jul 29 19:53:29 2014 -0400
----------------------------------------------------------------------
providers/enterprisechef/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/67c08462/providers/enterprisechef/pom.xml
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/pom.xml b/providers/enterprisechef/pom.xml
index b148e4c..3a0e2de 100644
--- a/providers/enterprisechef/pom.xml
+++ b/providers/enterprisechef/pom.xml
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.jclouds.chef</groupId>
<artifactId>chef-project</artifactId>
- <version>1.8.0-SNAPSHOT</version>
+ <version>1.8.0</version>
<relativePath>../project/pom.xml</relativePath>
</parent>
<groupId>org.apache.jclouds.provider</groupId>
[03/50] [abbrv] jclouds git commit: Use meaningful parameter name in
ParseKeySetFromJson
Posted by na...@apache.org.
Use meaningful parameter name in ParseKeySetFromJson
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/f8c06599
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/f8c06599
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/f8c06599
Branch: refs/heads/1.8.x
Commit: f8c0659988547d2a7add66952aa3fc0a41435d3d
Parents: 694cfdf
Author: Noorul Islam K M <no...@noorul.com>
Authored: Tue Sep 17 16:48:34 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Tue Sep 17 14:45:06 2013 +0200
----------------------------------------------------------------------
.../java/org/jclouds/chef/functions/ParseKeySetFromJson.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/f8c06599/apis/chef/src/main/java/org/jclouds/chef/functions/ParseKeySetFromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseKeySetFromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseKeySetFromJson.java
index b24d668..06714aa 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseKeySetFromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseKeySetFromJson.java
@@ -41,8 +41,8 @@ public class ParseKeySetFromJson implements Function<HttpResponse, Set<String>>
}
@Override
- public Set<String> apply(HttpResponse arg0) {
- return json.apply(arg0).keySet();
+ public Set<String> apply(HttpResponse response) {
+ return json.apply(response).keySet();
}
}
[14/50] [abbrv] jclouds git commit: Remove public keyword from
interface method.
Posted by na...@apache.org.
Remove public keyword from interface method.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/4711f6ba
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/4711f6ba
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/4711f6ba
Branch: refs/heads/1.8.x
Commit: 4711f6bae14550f58ce5963b8e24b6b76ea89b8b
Parents: 8ed8aad
Author: Noorul Islam K M <no...@noorul.com>
Authored: Wed Oct 30 22:09:52 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Wed Oct 30 23:20:11 2013 +0100
----------------------------------------------------------------------
apis/chef/src/main/java/org/jclouds/chef/ChefService.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/4711f6ba/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/ChefService.java b/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
index cf6993f..f20df68 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
@@ -110,7 +110,7 @@ public interface ChefService {
* @param group The name of the group.
* @return The bootstrap configuration for the given group.
*/
- public JsonBall getBootstrapConfigForGroup(String group);
+ JsonBall getBootstrapConfigForGroup(String group);
// Nodes / Clients
[47/50] [abbrv] jclouds git commit: Promoted jclouds-chef/enterprise
to providers/chef
Posted by na...@apache.org.
Promoted jclouds-chef/enterprise to providers/chef
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/da34161f
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/da34161f
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/da34161f
Branch: refs/heads/1.8.x
Commit: da34161ffa55f6848d6d8549a895f6e772e3af59
Parents: 36dcc57 b873030
Author: Ignasi Barrera <na...@apache.org>
Authored: Sun Nov 23 22:20:51 2014 +0100
Committer: Ignasi Barrera <na...@apache.org>
Committed: Sun Nov 23 22:20:51 2014 +0100
----------------------------------------------------------------------
providers/enterprisechef/pom.xml | 110 ++++++++++
.../enterprisechef/EnterpriseChefApi.java | 124 +++++++++++
.../EnterpriseChefApiMetadata.java | 82 +++++++
.../EnterpriseChefProviderMetadata.java | 86 ++++++++
.../BindGroupToUpdateRequestJsonPayload.java | 79 +++++++
.../enterprisechef/binders/GroupName.java | 38 ++++
.../config/EnterpriseChefHttpApiModule.java | 36 +++
.../jclouds/enterprisechef/domain/Group.java | 211 ++++++++++++++++++
.../org/jclouds/enterprisechef/domain/User.java | 220 +++++++++++++++++++
.../org.jclouds.providers.ProviderMetadata | 1 +
.../EnterpriseChefApiExpectTest.java | 209 ++++++++++++++++++
.../EnterpriseChefApiLiveTest.java | 122 ++++++++++
.../EnterpriseChefProviderMetadataTest.java | 31 +++
...BindGroupToUpdateRequestJsonPayloadTest.java | 82 +++++++
.../enterprisechef/binders/GroupNameTest.java | 40 ++++
.../src/test/resources/group-update.json | 1 +
.../src/test/resources/group.json | 14 ++
.../src/test/resources/groups.json | 7 +
.../enterprisechef/src/test/resources/user.json | 9 +
19 files changed, 1502 insertions(+)
----------------------------------------------------------------------
[38/50] [abbrv] jclouds git commit: Using openStream() to read
Payload contents
Posted by na...@apache.org.
Using openStream() to read Payload contents
Payload is no longer an InputSupplier, which was deprecated in Guava 16.
See https://github.com/jclouds/jclouds/commit/80a0256c
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/c230f2c3
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/c230f2c3
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/c230f2c3
Branch: refs/heads/1.8.x
Commit: c230f2c3371a50994d21d3cba5172b25ae5ffd9c
Parents: 742e3eb
Author: Andrew Phillips <an...@apache.org>
Authored: Mon Aug 11 08:13:40 2014 -0400
Committer: Andrew Phillips <an...@apache.org>
Committed: Mon Aug 11 17:06:57 2014 -0400
----------------------------------------------------------------------
.../java/org/jclouds/chef/filters/SignedHeaderAuth.java | 3 +--
.../java/org/jclouds/chef/internal/BaseChefService.java | 10 +++++-----
.../jclouds/chef/functions/ParseClientFromJsonTest.java | 8 ++++----
3 files changed, 10 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/c230f2c3/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java b/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
index cabe579..50d26a1 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
@@ -21,7 +21,6 @@ import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkNotNull;
import static com.google.common.hash.Hashing.sha1;
import static com.google.common.io.BaseEncoding.base64;
-import static com.google.common.io.ByteStreams.toByteArray;
import java.io.IOException;
import java.security.PrivateKey;
@@ -190,7 +189,7 @@ public class SignedHeaderAuth implements HttpRequestFilter {
public String sign(String toSign) {
try {
- byte[] encrypted = toByteArray(new RSAEncryptingPayload(crypto, Payloads.newStringPayload(toSign), supplyKey.get()));
+ byte[] encrypted = ByteStreams2.toByteArrayAndClose(new RSAEncryptingPayload(crypto, Payloads.newStringPayload(toSign), supplyKey.get()).openStream());
return base64().encode(encrypted);
} catch (IOException e) {
throw new HttpException("error signing request", e);
http://git-wip-us.apache.org/repos/asf/jclouds/blob/c230f2c3/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
index d7cf89b..1b6fcfe 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
@@ -57,6 +57,7 @@ import org.jclouds.chef.strategy.ListNodesInEnvironment;
import org.jclouds.chef.strategy.UpdateAutomaticAttributesOnNode;
import org.jclouds.crypto.Crypto;
import org.jclouds.domain.JsonBall;
+import org.jclouds.io.ByteStreams2;
import org.jclouds.io.Payloads;
import org.jclouds.io.payloads.RSADecryptingPayload;
import org.jclouds.io.payloads.RSAEncryptingPayload;
@@ -67,7 +68,6 @@ import org.jclouds.scriptbuilder.domain.Statement;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Supplier;
import com.google.common.collect.Maps;
-import com.google.common.io.ByteStreams;
import com.google.common.io.InputSupplier;
@Singleton
@@ -140,14 +140,14 @@ public class BaseChefService implements ChefService {
@Override
public byte[] encrypt(InputSupplier<? extends InputStream> supplier) throws IOException {
- return ByteStreams.toByteArray(new RSAEncryptingPayload(crypto, Payloads.newPayload(supplier.getInput()), privateKey
- .get()));
+ return ByteStreams2.toByteArrayAndClose(new RSAEncryptingPayload(crypto, Payloads.newPayload(supplier.getInput()), privateKey
+ .get()).openStream());
}
@Override
public byte[] decrypt(InputSupplier<? extends InputStream> supplier) throws IOException {
- return ByteStreams.toByteArray(new RSADecryptingPayload(crypto, Payloads.newPayload(supplier.getInput()), privateKey
- .get()));
+ return ByteStreams2.toByteArrayAndClose(new RSADecryptingPayload(crypto, Payloads.newPayload(supplier.getInput()), privateKey
+ .get()).openStream());
}
@VisibleForTesting
http://git-wip-us.apache.org/repos/asf/jclouds/blob/c230f2c3/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
index e8bebcb..1382a6c 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseClientFromJsonTest.java
@@ -33,6 +33,7 @@ import org.jclouds.crypto.Pems;
import org.jclouds.encryption.internal.JCECrypto;
import org.jclouds.http.HttpResponse;
import org.jclouds.http.functions.ParseJson;
+import org.jclouds.io.ByteStreams2;
import org.jclouds.io.Payloads;
import org.jclouds.io.payloads.RSADecryptingPayload;
import org.jclouds.io.payloads.RSAEncryptingPayload;
@@ -43,7 +44,6 @@ import org.testng.annotations.Test;
import com.google.common.base.Charsets;
import com.google.common.io.ByteSource;
-import com.google.common.io.ByteStreams;
import com.google.inject.AbstractModule;
import com.google.inject.Guice;
import com.google.inject.Injector;
@@ -84,11 +84,11 @@ public class ParseClientFromJsonTest {
Client user = Client.builder().certificate(certificate).orgname("jclouds").clientname("adriancole-jcloudstest")
.name("adriancole-jcloudstest").isValidator(false).privateKey(privateKey).build();
- byte[] encrypted = ByteStreams.toByteArray(new RSAEncryptingPayload(new JCECrypto(), Payloads.newPayload("fooya"), user
- .getCertificate().getPublicKey()));
+ byte[] encrypted = ByteStreams2.toByteArrayAndClose(new RSAEncryptingPayload(new JCECrypto(), Payloads.newPayload("fooya"), user
+ .getCertificate().getPublicKey()).openStream());
assertEquals(
- ByteStreams.toByteArray(new RSADecryptingPayload(new JCECrypto(), Payloads.newPayload(encrypted), user.getPrivateKey())),
+ ByteStreams2.toByteArrayAndClose(new RSADecryptingPayload(new JCECrypto(), Payloads.newPayload(encrypted), user.getPrivateKey()).openStream()),
"fooya".getBytes());
assertEquals(
[13/50] [abbrv] jclouds git commit: Remove public keyword from
interface methods.
Posted by na...@apache.org.
Remove public keyword from interface methods.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/8ed8aad1
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/8ed8aad1
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/8ed8aad1
Branch: refs/heads/1.8.x
Commit: 8ed8aad1a7488aa1bcca8fce5a5679e074bc23a6
Parents: c1ff33d
Author: Noorul Islam K M <no...@noorul.com>
Authored: Wed Oct 30 17:44:14 2013 +0530
Committer: Andrew Gaul <an...@gaul.org>
Committed: Wed Oct 30 08:31:34 2013 -0700
----------------------------------------------------------------------
.../chef/strategy/CleanupStaleNodesAndClients.java | 2 +-
.../CreateNodeAndPopulateAutomaticAttributes.java | 4 ++--
.../jclouds/chef/strategy/DeleteAllClientsInList.java | 4 ++--
.../jclouds/chef/strategy/DeleteAllNodesInList.java | 4 ++--
.../java/org/jclouds/chef/strategy/ListClients.java | 12 ++++++------
.../jclouds/chef/strategy/ListCookbookVersions.java | 13 ++++++-------
.../org/jclouds/chef/strategy/ListEnvironments.java | 13 ++++++-------
.../main/java/org/jclouds/chef/strategy/ListNodes.java | 12 ++++++------
.../jclouds/chef/strategy/ListNodesInEnvironment.java | 12 ++++++------
.../chef/strategy/UpdateAutomaticAttributesOnNode.java | 2 +-
10 files changed, 38 insertions(+), 40 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8ed8aad1/apis/chef/src/main/java/org/jclouds/chef/strategy/CleanupStaleNodesAndClients.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/CleanupStaleNodesAndClients.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/CleanupStaleNodesAndClients.java
index 3d32f83..077da30 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/CleanupStaleNodesAndClients.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/CleanupStaleNodesAndClients.java
@@ -29,6 +29,6 @@ import com.google.inject.ImplementedBy;
@ImplementedBy(CleanupStaleNodesAndClientsImpl.class)
public interface CleanupStaleNodesAndClients {
- public void execute(String prefix, int secondsStale);
+ void execute(String prefix, int secondsStale);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8ed8aad1/apis/chef/src/main/java/org/jclouds/chef/strategy/CreateNodeAndPopulateAutomaticAttributes.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/CreateNodeAndPopulateAutomaticAttributes.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/CreateNodeAndPopulateAutomaticAttributes.java
index 9d48ae9..070aaa3 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/CreateNodeAndPopulateAutomaticAttributes.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/CreateNodeAndPopulateAutomaticAttributes.java
@@ -29,7 +29,7 @@ import com.google.inject.ImplementedBy;
*/
@ImplementedBy(CreateNodeAndPopulateAutomaticAttributesImpl.class)
public interface CreateNodeAndPopulateAutomaticAttributes {
- public Node execute(Node node);
+ Node execute(Node node);
- public Node execute(String nodeName, Iterable<String> runList);
+ Node execute(String nodeName, Iterable<String> runList);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8ed8aad1/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllClientsInList.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllClientsInList.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllClientsInList.java
index 3db24f8..0fa54c0 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllClientsInList.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllClientsInList.java
@@ -30,8 +30,8 @@ import com.google.inject.ImplementedBy;
@ImplementedBy(DeleteAllClientsInListImpl.class)
public interface DeleteAllClientsInList {
- public void execute(Iterable<String> names);
+ void execute(Iterable<String> names);
- public void execute(ListeningExecutorService executor, Iterable<String> names);
+ void execute(ListeningExecutorService executor, Iterable<String> names);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8ed8aad1/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllNodesInList.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllNodesInList.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllNodesInList.java
index d1fc8cf..16a196e 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllNodesInList.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllNodesInList.java
@@ -29,8 +29,8 @@ import com.google.inject.ImplementedBy;
@ImplementedBy(DeleteAllNodesInListImpl.class)
public interface DeleteAllNodesInList {
- public void execute(Iterable<String> names);
+ void execute(Iterable<String> names);
- public void execute(ListeningExecutorService executor, Iterable<String> names);
+ void execute(ListeningExecutorService executor, Iterable<String> names);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8ed8aad1/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
index 0985f69..18b7c13 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
@@ -31,15 +31,15 @@ import com.google.inject.ImplementedBy;
@ImplementedBy(ListClientsImpl.class)
public interface ListClients {
- public Iterable<? extends Client> execute();
+ Iterable<? extends Client> execute();
- public Iterable<? extends Client> execute(Predicate<String> clientNameSelector);
+ Iterable<? extends Client> execute(Predicate<String> clientNameSelector);
- public Iterable<? extends Client> execute(Iterable<String> toGet);
+ Iterable<? extends Client> execute(Iterable<String> toGet);
- public Iterable<? extends Client> execute(ListeningExecutorService executor);
+ Iterable<? extends Client> execute(ListeningExecutorService executor);
- public Iterable<? extends Client> execute(ListeningExecutorService executor, Predicate<String> clientNameSelector);
+ Iterable<? extends Client> execute(ListeningExecutorService executor, Predicate<String> clientNameSelector);
- public Iterable<? extends Client> execute(ListeningExecutorService executor, Iterable<String> toGet);
+ Iterable<? extends Client> execute(ListeningExecutorService executor, Iterable<String> toGet);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8ed8aad1/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
index f30e199..5987de0 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
@@ -31,16 +31,15 @@ import com.google.inject.ImplementedBy;
@ImplementedBy(ListCookbookVersionsImpl.class)
public interface ListCookbookVersions {
- public Iterable<? extends CookbookVersion> execute();
+ Iterable<? extends CookbookVersion> execute();
- public Iterable<? extends CookbookVersion> execute(Predicate<String> cookbookNameSelector);
+ Iterable<? extends CookbookVersion> execute(Predicate<String> cookbookNameSelector);
- public Iterable<? extends CookbookVersion> execute(Iterable<String> cookbookNames);
+ Iterable<? extends CookbookVersion> execute(Iterable<String> cookbookNames);
- public Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor);
+ Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor);
- public Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor,
- Predicate<String> cookbookNameSelector);
+ Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, Predicate<String> cookbookNameSelector);
- public Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, Iterable<String> cookbookNames);
+ Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, Iterable<String> cookbookNames);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8ed8aad1/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java
index a3c9764..6dc4aa3 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java
@@ -26,16 +26,15 @@ import com.google.inject.ImplementedBy;
@ImplementedBy(ListEnvironmentsImpl.class)
public interface ListEnvironments {
- public Iterable<? extends Environment> execute();
+ Iterable<? extends Environment> execute();
- public Iterable<? extends Environment> execute(Predicate<String> environmentNameSelector);
+ Iterable<? extends Environment> execute(Predicate<String> environmentNameSelector);
- public Iterable<? extends Environment> execute(Iterable<String> toGet);
+ Iterable<? extends Environment> execute(Iterable<String> toGet);
- public Iterable<? extends Environment> execute(ListeningExecutorService executor);
+ Iterable<? extends Environment> execute(ListeningExecutorService executor);
- public Iterable<? extends Environment> execute(ListeningExecutorService executor,
- Predicate<String> environmentNameSelector);
+ Iterable<? extends Environment> execute(ListeningExecutorService executor, Predicate<String> environmentNameSelector);
- public Iterable<? extends Environment> execute(ListeningExecutorService executor, Iterable<String> toGet);
+ Iterable<? extends Environment> execute(ListeningExecutorService executor, Iterable<String> toGet);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8ed8aad1/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
index 15fda81..8790456 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
@@ -31,15 +31,15 @@ import com.google.inject.ImplementedBy;
@ImplementedBy(ListNodesImpl.class)
public interface ListNodes {
- public Iterable<? extends Node> execute();
+ Iterable<? extends Node> execute();
- public Iterable<? extends Node> execute(Predicate<String> nodeNameSelector);
+ Iterable<? extends Node> execute(Predicate<String> nodeNameSelector);
- public Iterable<? extends Node> execute(Iterable<String> toGet);
+ Iterable<? extends Node> execute(Iterable<String> toGet);
- public Iterable<? extends Node> execute(ListeningExecutorService executor);
+ Iterable<? extends Node> execute(ListeningExecutorService executor);
- public Iterable<? extends Node> execute(ListeningExecutorService executor, Predicate<String> nodeNameSelector);
+ Iterable<? extends Node> execute(ListeningExecutorService executor, Predicate<String> nodeNameSelector);
- public Iterable<? extends Node> execute(ListeningExecutorService executor, Iterable<String> toGet);
+ Iterable<? extends Node> execute(ListeningExecutorService executor, Iterable<String> toGet);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8ed8aad1/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
index c007d0e..9f6b324 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
@@ -31,15 +31,15 @@ import com.google.inject.ImplementedBy;
@ImplementedBy(ListNodesInEnvironmentImpl.class)
public interface ListNodesInEnvironment {
- public Iterable<? extends Node> execute(String environmentName);
+ Iterable<? extends Node> execute(String environmentName);
- public Iterable<? extends Node> execute(String environmentName, Predicate<String> nodeNameSelector);
+ Iterable<? extends Node> execute(String environmentName, Predicate<String> nodeNameSelector);
- public Iterable<? extends Node> execute(String environmentName, Iterable<String> toGet);
+ Iterable<? extends Node> execute(String environmentName, Iterable<String> toGet);
- public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName);
+ Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName);
- public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Predicate<String> nodeNameSelector);
+ Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Predicate<String> nodeNameSelector);
- public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Iterable<String> toGet);
+ Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Iterable<String> toGet);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8ed8aad1/apis/chef/src/main/java/org/jclouds/chef/strategy/UpdateAutomaticAttributesOnNode.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/UpdateAutomaticAttributesOnNode.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/UpdateAutomaticAttributesOnNode.java
index 90f8197..c4b6220 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/UpdateAutomaticAttributesOnNode.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/UpdateAutomaticAttributesOnNode.java
@@ -29,5 +29,5 @@ import com.google.inject.ImplementedBy;
@ImplementedBy(UpdateAutomaticAttributesOnNodeImpl.class)
public interface UpdateAutomaticAttributesOnNode {
- public void execute(String nodeName);
+ void execute(String nodeName);
}
[15/50] [abbrv] jclouds git commit: Fix checkstyle warnings
Posted by na...@apache.org.
Fix checkstyle warnings
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/d786daa7
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/d786daa7
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/d786daa7
Branch: refs/heads/1.8.x
Commit: d786daa70e63e7cf106b3f697eea505ed2cd3cfa
Parents: 4711f6b
Author: Noorul Islam K M <no...@noorul.com>
Authored: Thu Oct 31 09:50:20 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Mon Nov 4 11:30:16 2013 +0100
----------------------------------------------------------------------
.../main/java/org/jclouds/chef/config/ChefParserModule.java | 6 +++---
apis/chef/src/main/java/org/jclouds/chef/domain/Attribute.java | 2 +-
.../src/main/java/org/jclouds/chef/domain/ChecksumStatus.java | 2 +-
apis/chef/src/main/java/org/jclouds/chef/domain/Client.java | 2 +-
apis/chef/src/main/java/org/jclouds/chef/domain/Resource.java | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d786daa7/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java b/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java
index 67dd35a..3e3f13e 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java
@@ -77,7 +77,7 @@ import com.google.inject.Provides;
*/
public class ChefParserModule extends AbstractModule {
@ImplementedBy(PrivateKeyAdapterImpl.class)
- public static interface PrivateKeyAdapter extends JsonDeserializer<PrivateKey> {
+ public interface PrivateKeyAdapter extends JsonDeserializer<PrivateKey> {
}
@@ -111,7 +111,7 @@ public class ChefParserModule extends AbstractModule {
}
@ImplementedBy(PublicKeyAdapterImpl.class)
- public static interface PublicKeyAdapter extends JsonDeserializer<PublicKey> {
+ public interface PublicKeyAdapter extends JsonDeserializer<PublicKey> {
}
@@ -145,7 +145,7 @@ public class ChefParserModule extends AbstractModule {
}
@ImplementedBy(X509CertificateAdapterImpl.class)
- public static interface X509CertificateAdapter extends JsonDeserializer<X509Certificate> {
+ public interface X509CertificateAdapter extends JsonDeserializer<X509Certificate> {
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d786daa7/apis/chef/src/main/java/org/jclouds/chef/domain/Attribute.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/Attribute.java b/apis/chef/src/main/java/org/jclouds/chef/domain/Attribute.java
index a5fb25d..c863af2 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/Attribute.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/Attribute.java
@@ -16,7 +16,7 @@
*/
package org.jclouds.chef.domain;
-import static org.jclouds.chef.util.CollectionUtils.*;
+import static org.jclouds.chef.util.CollectionUtils.copyOfOrEmpty;
import static com.google.common.base.Preconditions.checkNotNull;
import java.beans.ConstructorProperties;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d786daa7/apis/chef/src/main/java/org/jclouds/chef/domain/ChecksumStatus.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/ChecksumStatus.java b/apis/chef/src/main/java/org/jclouds/chef/domain/ChecksumStatus.java
index e1c77e9..fde8bd6 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/ChecksumStatus.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/ChecksumStatus.java
@@ -16,7 +16,7 @@
*/
package org.jclouds.chef.domain;
-import static com.google.common.base.Preconditions.*;
+import static com.google.common.base.Preconditions.checkNotNull;
import java.beans.ConstructorProperties;
import java.net.URI;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d786daa7/apis/chef/src/main/java/org/jclouds/chef/domain/Client.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/Client.java b/apis/chef/src/main/java/org/jclouds/chef/domain/Client.java
index 101638c..9586787 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/Client.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/Client.java
@@ -16,7 +16,7 @@
*/
package org.jclouds.chef.domain;
-import static com.google.common.base.Preconditions.*;
+import static com.google.common.base.Preconditions.checkNotNull;
import java.beans.ConstructorProperties;
import java.security.PrivateKey;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d786daa7/apis/chef/src/main/java/org/jclouds/chef/domain/Resource.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/Resource.java b/apis/chef/src/main/java/org/jclouds/chef/domain/Resource.java
index 15ac613..aa4e71c 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/Resource.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/Resource.java
@@ -16,7 +16,7 @@
*/
package org.jclouds.chef.domain;
-import static com.google.common.base.Preconditions.*;
+import static com.google.common.base.Preconditions.checkNotNull;
import java.beans.ConstructorProperties;
import java.net.URI;
[06/50] [abbrv] jclouds git commit: Removed unused imports
Posted by na...@apache.org.
Removed unused imports
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/c7bea4dc
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/c7bea4dc
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/c7bea4dc
Branch: refs/heads/1.8.x
Commit: c7bea4dc37f55ece2167cf6b22b37070c72150c9
Parents: 996a477
Author: Ignasi Barrera <na...@apache.org>
Authored: Thu Sep 19 15:21:36 2013 +0200
Committer: Ignasi Barrera <na...@apache.org>
Committed: Thu Sep 19 15:21:36 2013 +0200
----------------------------------------------------------------------
.../test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/c7bea4dc/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
index 6d5f075..85acc44 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
@@ -17,6 +17,7 @@
package org.jclouds.chef.internal;
import static com.google.common.base.Throwables.propagate;
+import static com.google.common.collect.Iterables.any;
import static com.google.common.collect.Iterables.isEmpty;
import static com.google.common.hash.Hashing.md5;
import static java.util.concurrent.TimeUnit.MILLISECONDS;
@@ -65,9 +66,6 @@ import com.google.common.collect.ImmutableSet;
import com.google.common.io.Closeables;
import com.google.common.primitives.Bytes;
-import static com.google.common.collect.Iterables.any;
-import static com.google.common.collect.Iterables.all;
-
/**
* Tests behavior of {@code ChefApi}
*
[42/50] [abbrv] jclouds git commit: [maven-release-plugin] prepare
release jclouds-chef-1.8.1-rc1
Posted by na...@apache.org.
[maven-release-plugin] prepare release jclouds-chef-1.8.1-rc1
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/4b13de2e
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/4b13de2e
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/4b13de2e
Branch: refs/heads/1.8.x
Commit: 4b13de2e6557913dfa6bf379bf18faa63b1cac42
Parents: 3943c2d
Author: Andrew Phillips <an...@apache.org>
Authored: Fri Oct 10 14:22:15 2014 -0400
Committer: Andrew Phillips <an...@apache.org>
Committed: Fri Oct 10 14:22:15 2014 -0400
----------------------------------------------------------------------
providers/enterprisechef/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/4b13de2e/providers/enterprisechef/pom.xml
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/pom.xml b/providers/enterprisechef/pom.xml
index dc6c527..5753c31 100644
--- a/providers/enterprisechef/pom.xml
+++ b/providers/enterprisechef/pom.xml
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.jclouds.chef</groupId>
<artifactId>chef-project</artifactId>
- <version>1.8.1-SNAPSHOT</version>
+ <version>1.8.1</version>
<relativePath>../project/pom.xml</relativePath>
</parent>
<groupId>org.apache.jclouds.provider</groupId>
[26/50] [abbrv] jclouds git commit: JCLOUDS-546: Remove Javadoc
@author annotations
Posted by na...@apache.org.
JCLOUDS-546: Remove Javadoc @author annotations
Annotations removed with:
find -name \*.java | xargs sed -i /@author/d
Empty Javadoc removed with multiple iterations of:
find -name \*.java | xargs sed -i -z 's/ \*\n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/ \* \n \*\// \*\//'
find -name \*.java | xargs sed -i -z 's/\/\*\*\n \*\/\n//'
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/2982d996
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/2982d996
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/2982d996
Branch: refs/heads/1.8.x
Commit: 2982d9967063f22c6d97fdb4f3bfbab6fc1049ac
Parents: ad47e24
Author: Andrew Gaul <ga...@apache.org>
Authored: Fri Jun 6 22:25:04 2014 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Sat Jun 7 21:09:23 2014 -0700
----------------------------------------------------------------------
apis/chef/src/main/java/org/jclouds/chef/ChefApi.java | 3 ---
apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java | 3 ---
apis/chef/src/main/java/org/jclouds/chef/ChefContext.java | 2 --
apis/chef/src/main/java/org/jclouds/chef/ChefService.java | 2 --
.../org/jclouds/chef/binders/BindChecksumsToJsonPayload.java | 5 -----
.../chef/binders/BindCreateClientOptionsToJsonPayload.java | 2 --
.../chef/binders/BindGenerateKeyForClientToJsonPayload.java | 5 -----
.../src/main/java/org/jclouds/chef/binders/DatabagItemId.java | 4 ----
apis/chef/src/main/java/org/jclouds/chef/binders/NodeName.java | 4 ----
apis/chef/src/main/java/org/jclouds/chef/binders/RoleName.java | 4 ----
.../java/org/jclouds/chef/config/BaseChefHttpApiModule.java | 3 ---
.../main/java/org/jclouds/chef/config/ChefBootstrapModule.java | 2 --
.../main/java/org/jclouds/chef/config/ChefHttpApiModule.java | 3 ---
.../src/main/java/org/jclouds/chef/config/ChefParserModule.java | 5 -----
.../src/main/java/org/jclouds/chef/config/ChefProperties.java | 2 --
.../src/main/java/org/jclouds/chef/config/CookbookParser.java | 2 --
.../java/org/jclouds/chef/config/CookbookVersionsParser.java | 2 --
.../chef/src/main/java/org/jclouds/chef/config/InstallChef.java | 2 --
apis/chef/src/main/java/org/jclouds/chef/config/Validator.java | 2 --
apis/chef/src/main/java/org/jclouds/chef/domain/Attribute.java | 3 ---
.../src/main/java/org/jclouds/chef/domain/BootstrapConfig.java | 1 -
.../src/main/java/org/jclouds/chef/domain/ChecksumStatus.java | 3 ---
apis/chef/src/main/java/org/jclouds/chef/domain/Client.java | 3 ---
.../main/java/org/jclouds/chef/domain/CookbookDefinition.java | 2 --
.../src/main/java/org/jclouds/chef/domain/CookbookVersion.java | 3 ---
.../chef/src/main/java/org/jclouds/chef/domain/DatabagItem.java | 3 ---
.../chef/src/main/java/org/jclouds/chef/domain/Environment.java | 2 --
apis/chef/src/main/java/org/jclouds/chef/domain/Metadata.java | 3 ---
apis/chef/src/main/java/org/jclouds/chef/domain/Node.java | 3 ---
apis/chef/src/main/java/org/jclouds/chef/domain/Resource.java | 3 ---
apis/chef/src/main/java/org/jclouds/chef/domain/Role.java | 3 ---
apis/chef/src/main/java/org/jclouds/chef/domain/Sandbox.java | 3 ---
.../src/main/java/org/jclouds/chef/domain/SearchResult.java | 3 ---
.../src/main/java/org/jclouds/chef/domain/UploadSandbox.java | 3 ---
.../main/java/org/jclouds/chef/filters/SignedHeaderAuth.java | 2 --
.../org/jclouds/chef/functions/BootstrapConfigForGroup.java | 3 ---
.../main/java/org/jclouds/chef/functions/ClientForGroup.java | 2 --
.../main/java/org/jclouds/chef/functions/GroupToBootScript.java | 2 --
.../functions/ParseCookbookDefinitionCheckingChefVersion.java | 2 --
.../jclouds/chef/functions/ParseCookbookDefinitionFromJson.java | 2 --
.../chef/functions/ParseCookbookDefinitionFromJsonv10.java | 2 --
.../chef/functions/ParseCookbookDefinitionListFromJsonv10.java | 2 --
.../functions/ParseCookbookVersionsCheckingChefVersion.java | 2 --
.../chef/functions/ParseCookbookVersionsV09FromJson.java | 2 --
.../chef/functions/ParseCookbookVersionsV10FromJson.java | 2 --
.../jclouds/chef/functions/ParseErrorFromJsonOrReturnBody.java | 5 -----
.../java/org/jclouds/chef/functions/ParseKeySetFromJson.java | 3 ---
.../org/jclouds/chef/functions/ParseSearchClientsFromJson.java | 4 ----
.../org/jclouds/chef/functions/ParseSearchDatabagFromJson.java | 2 --
.../jclouds/chef/functions/ParseSearchEnvironmentsFromJson.java | 3 ---
.../org/jclouds/chef/functions/ParseSearchNodesFromJson.java | 4 ----
.../org/jclouds/chef/functions/ParseSearchResultFromJson.java | 3 ---
.../org/jclouds/chef/functions/ParseSearchRolesFromJson.java | 4 ----
.../main/java/org/jclouds/chef/functions/RunListForGroup.java | 3 ---
.../main/java/org/jclouds/chef/functions/UriForResource.java | 2 --
.../org/jclouds/chef/handlers/ChefApiErrorRetryHandler.java | 2 --
.../main/java/org/jclouds/chef/handlers/ChefErrorHandler.java | 3 ---
.../main/java/org/jclouds/chef/internal/BaseChefService.java | 3 ---
.../main/java/org/jclouds/chef/internal/ChefContextImpl.java | 4 ----
.../main/java/org/jclouds/chef/options/CreateClientOptions.java | 2 --
.../src/main/java/org/jclouds/chef/options/SearchOptions.java | 2 --
.../org/jclouds/chef/predicates/CookbookVersionPredicates.java | 2 --
.../org/jclouds/chef/strategy/CleanupStaleNodesAndClients.java | 2 --
.../chef/strategy/CreateNodeAndPopulateAutomaticAttributes.java | 2 --
.../java/org/jclouds/chef/strategy/DeleteAllClientsInList.java | 3 ---
.../java/org/jclouds/chef/strategy/DeleteAllNodesInList.java | 5 -----
.../src/main/java/org/jclouds/chef/strategy/ListClients.java | 4 ----
.../java/org/jclouds/chef/strategy/ListCookbookVersions.java | 4 ----
.../chef/strategy/ListCookbookVersionsInEnvironment.java | 4 ----
.../chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java | 4 ----
.../java/org/jclouds/chef/strategy/ListNodesInEnvironment.java | 4 ----
.../jclouds/chef/strategy/UpdateAutomaticAttributesOnNode.java | 2 --
.../chef/strategy/internal/CleanupStaleNodesAndClientsImpl.java | 2 --
.../internal/CreateNodeAndPopulateAutomaticAttributesImpl.java | 2 --
.../chef/strategy/internal/DeleteAllClientsInListImpl.java | 3 ---
.../chef/strategy/internal/DeleteAllNodesInListImpl.java | 5 -----
.../org/jclouds/chef/strategy/internal/ListClientsImpl.java | 4 ----
.../chef/strategy/internal/ListCookbookVersionsImpl.java | 4 ----
.../internal/ListCookbookVersionsInEnvironmentImpl.java | 4 ----
.../java/org/jclouds/chef/strategy/internal/ListNodesImpl.java | 4 ----
.../chef/strategy/internal/ListNodesInEnvironmentImpl.java | 4 ----
.../strategy/internal/UpdateAutomaticAttributesOnNodeImpl.java | 2 --
.../java/org/jclouds/chef/suppliers/ChefVersionSupplier.java | 2 --
.../src/main/java/org/jclouds/chef/test/TransientChefApi.java | 2 --
.../java/org/jclouds/chef/test/TransientChefApiMetadata.java | 2 --
.../org/jclouds/chef/test/config/TransientChefApiModule.java | 4 ----
apis/chef/src/main/java/org/jclouds/chef/util/ChefUtils.java | 5 -----
.../src/main/java/org/jclouds/chef/util/CollectionUtils.java | 2 --
.../src/main/java/org/jclouds/chef/util/RunListBuilder.java | 2 --
apis/chef/src/main/java/org/jclouds/ohai/Automatic.java | 4 ----
apis/chef/src/main/java/org/jclouds/ohai/AutomaticSupplier.java | 5 -----
.../src/main/java/org/jclouds/ohai/config/ConfiguresOhai.java | 4 ----
.../src/main/java/org/jclouds/ohai/config/JMXOhaiModule.java | 2 --
apis/chef/src/main/java/org/jclouds/ohai/config/OhaiModule.java | 2 --
.../java/org/jclouds/ohai/functions/ByteArrayToMacAddress.java | 2 --
.../main/java/org/jclouds/ohai/functions/MapSetToMultimap.java | 4 ----
.../src/main/java/org/jclouds/ohai/functions/NestSlashKeys.java | 5 -----
.../java/org/jclouds/ohai/suppliers/UptimeSecondsSupplier.java | 4 ----
.../src/test/java/org/jclouds/chef/BaseChefApiExpectTest.java | 2 --
apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java | 2 --
apis/chef/src/test/java/org/jclouds/chef/ChefApiLiveTest.java | 2 --
.../src/test/java/org/jclouds/chef/ChefApiMetadataTest.java | 4 ----
apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java | 2 --
.../chef/binders/BindHexEncodedMD5sToJsonPayloadTest.java | 3 ---
.../test/java/org/jclouds/chef/config/ChefParserModuleTest.java | 2 --
.../java/org/jclouds/chef/filters/SignedHeaderAuthTest.java | 4 ----
.../org/jclouds/chef/functions/BootstrapConfigForGroupTest.java | 4 ----
.../java/org/jclouds/chef/functions/ClientForGroupTest.java | 3 ---
.../java/org/jclouds/chef/functions/GroupToBootScriptTest.java | 3 ---
.../org/jclouds/chef/functions/ParseClientFromJsonTest.java | 2 --
.../ParseCookbookDefinitionCheckingChefVersionTest.java | 2 --
.../chef/functions/ParseCookbookDefinitionFromJsonTest.java | 2 --
.../chef/functions/ParseCookbookVersionFromJsonTest.java | 3 ---
.../functions/ParseCookbookVersionsCheckingChefVersionTest.java | 2 --
.../chef/functions/ParseCookbookVersionsV09FromJsonTest.java | 2 --
.../chef/functions/ParseCookbookVersionsV10FromJsonTest.java | 2 --
.../jclouds/chef/functions/ParseDataBagItemFromJsonTest.java | 3 ---
.../chef/functions/ParseErrorFromJsonOrReturnBodyTest.java | 3 ---
.../org/jclouds/chef/functions/ParseKeySetFromJsonTest.java | 2 --
.../java/org/jclouds/chef/functions/ParseNodeFromJsonTest.java | 2 --
.../org/jclouds/chef/functions/ParseSandboxFromJsonTest.java | 2 --
.../chef/functions/ParseSearchDataBagItemFromJsonTest.java | 3 ---
.../jclouds/chef/functions/ParseUploadSandboxFromJsonTest.java | 2 --
.../java/org/jclouds/chef/functions/RunListForGroupTest.java | 4 ----
.../java/org/jclouds/chef/functions/UriForResourceTest.java | 2 --
.../org/jclouds/chef/handlers/ChefApiErrorRetryHandlerTest.java | 2 --
.../java/org/jclouds/chef/internal/BaseChefApiLiveTest.java | 2 --
.../test/java/org/jclouds/chef/internal/BaseChefLiveTest.java | 4 ----
.../java/org/jclouds/chef/internal/BaseChefServiceTest.java | 2 --
.../java/org/jclouds/chef/internal/BaseStubbedOhaiLiveTest.java | 4 ----
.../internal/CleanupStaleNodesAndClientsImplLiveTest.java | 2 --
.../CreateNodeAndPopulateAutomaticAttributesImplLiveTest.java | 2 --
.../CreateNodeAndPopulateAutomaticAttributesImplTest.java | 2 --
.../internal/DeleteAllApisAndNodesInListImplLiveTest.java | 2 --
.../internal/ListCookbookVersionsInEnvironmentImplLiveTest.java | 2 --
.../jclouds/chef/strategy/internal/ListNodesImplLiveTest.java | 2 --
.../strategy/internal/ListNodesInEnvironmentImplLiveTest.java | 2 --
.../internal/UpdateAutomaticAttributesOnNodeImplLiveTest.java | 2 --
.../internal/UpdateAutomaticAttributesOnNodeImplTest.java | 2 --
.../org/jclouds/chef/suppliers/ChefVersionSupplierTest.java | 2 --
.../org/jclouds/chef/test/TransientChefApiIntegrationTest.java | 2 --
.../org/jclouds/chef/test/TransientChefApiMetadataTest.java | 4 ----
.../chef/src/test/java/org/jclouds/chef/util/ChefUtilsTest.java | 2 --
.../src/test/java/org/jclouds/chef/util/RunListBuilderTest.java | 2 --
apis/chef/src/test/java/org/jclouds/ohai/config/JMXTest.java | 2 --
.../src/test/java/org/jclouds/ohai/config/OhaiModuleTest.java | 2 --
.../org/jclouds/ohai/functions/ByteArrayToMacAddressTest.java | 2 --
.../test/java/org/jclouds/ohai/functions/NestSlashKeysTest.java | 2 --
148 files changed, 412 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java b/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java
index 1b1ca2a..13f4971 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java
@@ -87,9 +87,6 @@ import org.jclouds.rest.binders.BindToJsonPayload;
/**
* Provides synchronous access to Chef.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
@RequestFilters(SignedHeaderAuth.class)
@Headers(keys = "X-Chef-Version", values = "{" + Constants.PROPERTY_API_VERSION + "}")
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java b/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java
index 614d58d..ede03e9 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java
@@ -39,9 +39,6 @@ import com.google.inject.Module;
/**
* Implementation of {@link ApiMetadata} for OpsCode's Chef api.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class ChefApiMetadata extends BaseHttpApiMetadata<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/ChefContext.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/ChefContext.java b/apis/chef/src/main/java/org/jclouds/chef/ChefContext.java
index a3d9d98..7809634 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/ChefContext.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/ChefContext.java
@@ -25,8 +25,6 @@ import com.google.inject.ImplementedBy;
/**
* Provides an entry point to Chef features.
- *
- * @author Ignasi Barrera
*/
@ImplementedBy(ChefContextImpl.class)
public interface ChefContext extends View, Closeable {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/ChefService.java b/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
index 1fe9814..bae2e1b 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
@@ -35,8 +35,6 @@ import com.google.inject.ImplementedBy;
/**
* Provides high level Chef operations.
- *
- * @author Adrian Cole
*/
@ImplementedBy(BaseChefService.class)
public interface ChefService {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/binders/BindChecksumsToJsonPayload.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/binders/BindChecksumsToJsonPayload.java b/apis/chef/src/main/java/org/jclouds/chef/binders/BindChecksumsToJsonPayload.java
index 21aca39..9a744a3 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/binders/BindChecksumsToJsonPayload.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/binders/BindChecksumsToJsonPayload.java
@@ -30,11 +30,6 @@ import javax.ws.rs.core.MediaType;
import org.jclouds.http.HttpRequest;
import org.jclouds.rest.binders.BindToStringPayload;
-/**
- *
- *
- * @author Adrian Cole
- */
@Singleton
public class BindChecksumsToJsonPayload extends BindToStringPayload {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/binders/BindCreateClientOptionsToJsonPayload.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/binders/BindCreateClientOptionsToJsonPayload.java b/apis/chef/src/main/java/org/jclouds/chef/binders/BindCreateClientOptionsToJsonPayload.java
index 043b6be..b719c66 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/binders/BindCreateClientOptionsToJsonPayload.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/binders/BindCreateClientOptionsToJsonPayload.java
@@ -35,8 +35,6 @@ import com.google.common.collect.Iterables;
/**
* Bind the parameters of a {@link CreateClientOptions} to the payload.
- *
- * @author Ignasi Barrera
*/
public class BindCreateClientOptionsToJsonPayload extends BindToJsonPayload {
@Inject
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/binders/BindGenerateKeyForClientToJsonPayload.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/binders/BindGenerateKeyForClientToJsonPayload.java b/apis/chef/src/main/java/org/jclouds/chef/binders/BindGenerateKeyForClientToJsonPayload.java
index 691587f..4bd5821 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/binders/BindGenerateKeyForClientToJsonPayload.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/binders/BindGenerateKeyForClientToJsonPayload.java
@@ -22,11 +22,6 @@ import javax.ws.rs.core.MediaType;
import org.jclouds.http.HttpRequest;
import org.jclouds.rest.binders.BindToStringPayload;
-/**
- *
- * @author Adrian Cole
- *
- */
@Singleton
public class BindGenerateKeyForClientToJsonPayload extends BindToStringPayload {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/binders/DatabagItemId.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/binders/DatabagItemId.java b/apis/chef/src/main/java/org/jclouds/chef/binders/DatabagItemId.java
index 5abe592..5dd5a62 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/binders/DatabagItemId.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/binders/DatabagItemId.java
@@ -22,10 +22,6 @@ import org.jclouds.chef.domain.DatabagItem;
import com.google.common.base.Function;
-/**
- *
- * @author Adrian Cole
- */
@Singleton
public class DatabagItemId implements Function<Object, String> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/binders/NodeName.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/binders/NodeName.java b/apis/chef/src/main/java/org/jclouds/chef/binders/NodeName.java
index affaf74..5277895 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/binders/NodeName.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/binders/NodeName.java
@@ -22,10 +22,6 @@ import org.jclouds.chef.domain.Node;
import com.google.common.base.Function;
-/**
- *
- * @author Adrian Cole
- */
@Singleton
public class NodeName implements Function<Object, String> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/binders/RoleName.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/binders/RoleName.java b/apis/chef/src/main/java/org/jclouds/chef/binders/RoleName.java
index b2401c8..aa78a06 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/binders/RoleName.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/binders/RoleName.java
@@ -22,10 +22,6 @@ import org.jclouds.chef.domain.Role;
import com.google.common.base.Function;
-/**
- *
- * @author Adrian Cole
- */
@Singleton
public class RoleName implements Function<Object, String> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/config/BaseChefHttpApiModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/BaseChefHttpApiModule.java b/apis/chef/src/main/java/org/jclouds/chef/config/BaseChefHttpApiModule.java
index 83a9e29..2fc4201 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/BaseChefHttpApiModule.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/BaseChefHttpApiModule.java
@@ -71,9 +71,6 @@ import com.google.inject.name.Names;
/**
* Configures the Chef connection.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
@ConfiguresHttpApi
public abstract class BaseChefHttpApiModule<S> extends HttpApiModule<S> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/config/ChefBootstrapModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/ChefBootstrapModule.java b/apis/chef/src/main/java/org/jclouds/chef/config/ChefBootstrapModule.java
index 65d1422..a5fd231 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/ChefBootstrapModule.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/ChefBootstrapModule.java
@@ -39,8 +39,6 @@ import com.google.inject.Provides;
/**
* Provides bootstrap configuration for nodes.
- *
- * @author Ignasi Barrera
*/
public class ChefBootstrapModule extends AbstractModule {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/config/ChefHttpApiModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/ChefHttpApiModule.java b/apis/chef/src/main/java/org/jclouds/chef/config/ChefHttpApiModule.java
index b8c068f..ffd3b0b 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/ChefHttpApiModule.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/ChefHttpApiModule.java
@@ -21,9 +21,6 @@ import org.jclouds.rest.ConfiguresHttpApi;
/**
* Configures the Chef connection.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
@ConfiguresHttpApi
public class ChefHttpApiModule extends BaseChefHttpApiModule<ChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java b/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java
index baca929..c214236 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/ChefParserModule.java
@@ -70,11 +70,6 @@ import com.google.inject.AbstractModule;
import com.google.inject.ImplementedBy;
import com.google.inject.Provides;
-/**
- *
- *
- * @author Adrian Cole
- */
public class ChefParserModule extends AbstractModule {
@ImplementedBy(PrivateKeyAdapterImpl.class)
public interface PrivateKeyAdapter extends JsonDeserializer<PrivateKey> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java b/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java
index c366ee9..211b5d6 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java
@@ -19,8 +19,6 @@ package org.jclouds.chef.config;
/**
* Configuration properties and constants used in Chef connections.
- *
- * @author Adrian Cole
*/
public interface ChefProperties {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/config/CookbookParser.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/CookbookParser.java b/apis/chef/src/main/java/org/jclouds/chef/config/CookbookParser.java
index 22a3dea..34eedde 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/CookbookParser.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/CookbookParser.java
@@ -32,8 +32,6 @@ import javax.inject.Qualifier;
* Chef Server version 0.9 and 0.10 return a different Json when rquesting the
* cookbook definitions. This annotation can be used to setup the cookbook
* parser.
- *
- * @author Ignasi Barrera
*/
@Target({ METHOD, PARAMETER, FIELD })
@Retention(RUNTIME)
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/config/CookbookVersionsParser.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/CookbookVersionsParser.java b/apis/chef/src/main/java/org/jclouds/chef/config/CookbookVersionsParser.java
index 6e4f5a1..c946917 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/CookbookVersionsParser.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/CookbookVersionsParser.java
@@ -32,8 +32,6 @@ import javax.inject.Qualifier;
* Chef Server version 0.9 and 0.10 return a different Json when rquesting the
* cookbook versions. This annotation can be used to setup the cookbook versions
* parser.
- *
- * @author Ignasi Barrera
*/
@Target({ METHOD, PARAMETER, FIELD })
@Retention(RUNTIME)
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/config/InstallChef.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/InstallChef.java b/apis/chef/src/main/java/org/jclouds/chef/config/InstallChef.java
index 909b99a..d40ae91 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/InstallChef.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/InstallChef.java
@@ -28,8 +28,6 @@ import javax.inject.Qualifier;
/**
* Used to configure the Chef install script.
- *
- * @author Ignasi Barrera
*/
@Target({ METHOD, PARAMETER, FIELD })
@Retention(RUNTIME)
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/config/Validator.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/Validator.java b/apis/chef/src/main/java/org/jclouds/chef/config/Validator.java
index 677b170..99825d8 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/Validator.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/Validator.java
@@ -31,8 +31,6 @@ import javax.inject.Qualifier;
* <p>
* In a Chef server it must be only one validator client. This client is used by
* new nodes to autoregister themselves in the Chef server.
- *
- * @author Ignasi Barrera
*/
@Target({ METHOD, PARAMETER, FIELD })
@Retention(RUNTIME)
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/Attribute.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/Attribute.java b/apis/chef/src/main/java/org/jclouds/chef/domain/Attribute.java
index c863af2..34be6b7 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/Attribute.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/Attribute.java
@@ -32,9 +32,6 @@ import com.google.gson.annotations.SerializedName;
/**
* An attribute in a cookbook metadata.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class Attribute {
public static Builder builder() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/BootstrapConfig.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/BootstrapConfig.java b/apis/chef/src/main/java/org/jclouds/chef/domain/BootstrapConfig.java
index 22d8f36..c10c150 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/BootstrapConfig.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/BootstrapConfig.java
@@ -28,7 +28,6 @@ import com.google.common.collect.ImmutableList;
/**
* Configures how the nodes in a group will bootstrap.
*
- * @author Ignasi Barrera
* @since 1.7
*/
public class BootstrapConfig {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/ChecksumStatus.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/ChecksumStatus.java b/apis/chef/src/main/java/org/jclouds/chef/domain/ChecksumStatus.java
index fde8bd6..e5a48ca 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/ChecksumStatus.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/ChecksumStatus.java
@@ -24,9 +24,6 @@ import com.google.gson.annotations.SerializedName;
/**
* The checksum of an uploaded resource.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class ChecksumStatus {
public static Builder builder() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/Client.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/Client.java b/apis/chef/src/main/java/org/jclouds/chef/domain/Client.java
index 9586787..7335609 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/Client.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/Client.java
@@ -28,9 +28,6 @@ import com.google.gson.annotations.SerializedName;
/**
* Client object.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class Client {
public static Builder builder() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookDefinition.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookDefinition.java b/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookDefinition.java
index b2f071a..17db702 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookDefinition.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookDefinition.java
@@ -29,8 +29,6 @@ import com.google.common.collect.ImmutableSet;
/**
* Cookbook definition as returned by the Chef server >= 0.10.8.
- *
- * @author Ignasi Barrera
*/
public class CookbookDefinition {
public static Builder builder() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookVersion.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookVersion.java b/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookVersion.java
index 5af929e..df9bd82 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookVersion.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookVersion.java
@@ -29,9 +29,6 @@ import com.google.gson.annotations.SerializedName;
/**
* Cookbook object.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class CookbookVersion {
public static Builder builder(String name, String version) {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/DatabagItem.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/DatabagItem.java b/apis/chef/src/main/java/org/jclouds/chef/domain/DatabagItem.java
index 9138b9f..ec68d99 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/DatabagItem.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/DatabagItem.java
@@ -22,9 +22,6 @@ import org.jclouds.domain.JsonBall;
/**
* An item in a data bag.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class DatabagItem extends JsonBall {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/Environment.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/Environment.java b/apis/chef/src/main/java/org/jclouds/chef/domain/Environment.java
index f54208e..48e6efa 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/Environment.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/Environment.java
@@ -30,8 +30,6 @@ import com.google.gson.annotations.SerializedName;
/**
* An environment.
- *
- * @author Ignasi Barrera
*/
public class Environment {
public static Builder builder() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/Metadata.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/Metadata.java b/apis/chef/src/main/java/org/jclouds/chef/domain/Metadata.java
index 0cfb66f..33f8dfb 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/Metadata.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/Metadata.java
@@ -29,9 +29,6 @@ import com.google.gson.annotations.SerializedName;
/**
* A metadata object.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class Metadata {
public static Builder builder() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/Node.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/Node.java b/apis/chef/src/main/java/org/jclouds/chef/domain/Node.java
index 4d4fa0f..ec83f4c 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/Node.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/Node.java
@@ -32,9 +32,6 @@ import com.google.gson.annotations.SerializedName;
/**
* Node object.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class Node {
public static Builder builder() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/Resource.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/Resource.java b/apis/chef/src/main/java/org/jclouds/chef/domain/Resource.java
index aa4e71c..94b5471 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/Resource.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/Resource.java
@@ -28,9 +28,6 @@ import com.google.common.primitives.Bytes;
/**
* Resource object.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class Resource {
public static Builder builder() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/Role.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/Role.java b/apis/chef/src/main/java/org/jclouds/chef/domain/Role.java
index 1b73609..d51dc1e 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/Role.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/Role.java
@@ -32,9 +32,6 @@ import com.google.gson.annotations.SerializedName;
/**
* Role object.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class Role {
public static Builder builder() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/Sandbox.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/Sandbox.java b/apis/chef/src/main/java/org/jclouds/chef/domain/Sandbox.java
index 774aa4a..c58d02d 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/Sandbox.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/Sandbox.java
@@ -30,9 +30,6 @@ import com.google.gson.annotations.SerializedName;
/**
* Sandbox object.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class Sandbox {
public static Builder builder() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/SearchResult.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/SearchResult.java b/apis/chef/src/main/java/org/jclouds/chef/domain/SearchResult.java
index 1e2cced..7e406c1 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/SearchResult.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/SearchResult.java
@@ -22,9 +22,6 @@ import com.google.common.collect.Iterables;
/**
* A result of a search.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class SearchResult<T> extends LinkedHashSet<T> {
private static final long serialVersionUID = 4000610660948065287L;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/domain/UploadSandbox.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/UploadSandbox.java b/apis/chef/src/main/java/org/jclouds/chef/domain/UploadSandbox.java
index 868c147..9ca4c0f 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/UploadSandbox.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/UploadSandbox.java
@@ -31,9 +31,6 @@ import com.google.gson.annotations.SerializedName;
/**
* An upload sandbox.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
public class UploadSandbox {
public static Builder builder() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java b/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
index 50b58df..30b26c0 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
@@ -63,8 +63,6 @@ import com.google.common.io.ByteSource;
* Ported from mixlib-authentication in order to sign Chef requests.
*
* @see <a href= "http://github.com/opscode/mixlib-authentication" />
- * @author Adrian Cole
- *
*/
@Singleton
public class SignedHeaderAuth implements HttpRequestFilter {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/BootstrapConfigForGroup.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/BootstrapConfigForGroup.java b/apis/chef/src/main/java/org/jclouds/chef/functions/BootstrapConfigForGroup.java
index 43060ee..ec75e47 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/BootstrapConfigForGroup.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/BootstrapConfigForGroup.java
@@ -37,9 +37,6 @@ import com.google.inject.TypeLiteral;
/**
*
* Retrieves the bootstrap configuration for a specific group
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
@Singleton
public class BootstrapConfigForGroup implements Function<String, DatabagItem> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ClientForGroup.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ClientForGroup.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ClientForGroup.java
index a9c1c33..d1a9250 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ClientForGroup.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ClientForGroup.java
@@ -32,8 +32,6 @@ import com.google.common.base.Function;
/**
*
* Generates a client relevant for a particular group
- *
- * @author Adrian Cole
*/
@Singleton
public class ClientForGroup implements Function<String, Client> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java b/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java
index 1472d19..516d9f9 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java
@@ -56,8 +56,6 @@ import com.google.inject.TypeLiteral;
/**
*
* Generates a bootstrap script relevant for a particular group
- *
- * @author Adrian Cole
*/
@Singleton
public class GroupToBootScript implements Function<String, Statement> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionCheckingChefVersion.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionCheckingChefVersion.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionCheckingChefVersion.java
index cb1ee98..ffb4201 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionCheckingChefVersion.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionCheckingChefVersion.java
@@ -30,8 +30,6 @@ import com.google.common.base.Function;
/**
* Parses a cookbook definition from a Json response, taking care of using the
* appropriate parser.
- *
- * @author Ignasi Barrera
*/
@Singleton
public class ParseCookbookDefinitionCheckingChefVersion implements Function<HttpResponse, Set<String>> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJson.java
index 0156d46..3e172e4 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJson.java
@@ -31,8 +31,6 @@ import com.google.common.base.Function;
/**
* Parses a cookbook definition from a Json response, assuming a Chef Server >=
* 0.10.8.
- *
- * @author Ignasi Barrera
*/
@Singleton
public class ParseCookbookDefinitionFromJson implements Function<HttpResponse, Set<String>> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10.java
index 80ba9af..692d969 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10.java
@@ -27,8 +27,6 @@ import java.util.Map;
/**
* Parses the cookbook versions in a Chef Server >= 0.10.8.
- *
- * @author Alexandr Kulik
*/
@Singleton
public class ParseCookbookDefinitionFromJsonv10 implements Function<HttpResponse, CookbookDefinition> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10.java
index 019ed0d..5da0797 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10.java
@@ -31,8 +31,6 @@ import static com.google.common.collect.Sets.newLinkedHashSet;
/**
* Parses the cookbook versions in a Chef Server >= 0.10.8.
- *
- * @author Alexandr Kulik
*/
@Singleton
public class ParseCookbookDefinitionListFromJsonv10 implements Function<HttpResponse, Set<CookbookDefinition>> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsCheckingChefVersion.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsCheckingChefVersion.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsCheckingChefVersion.java
index e8f9124..f82a900 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsCheckingChefVersion.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsCheckingChefVersion.java
@@ -30,8 +30,6 @@ import com.google.common.base.Function;
/**
* Parses a cookbook versions from a Json response, taking care of using the
* appropriate parser.
- *
- * @author Ignasi Barrera
*/
@Singleton
public class ParseCookbookVersionsCheckingChefVersion implements Function<HttpResponse, Set<String>> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJson.java
index 5c94e41..4421b3e 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV09FromJson.java
@@ -30,8 +30,6 @@ import static com.google.common.collect.Iterables.getFirst;
/**
* Parses the cookbook versions in a Chef Server <= 0.9.8.
- *
- * @author Ignasi Barrera
*/
@Singleton
public class ParseCookbookVersionsV09FromJson implements Function<HttpResponse, Set<String>> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJson.java
index 955fe8e..1a25ac0 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookVersionsV10FromJson.java
@@ -34,8 +34,6 @@ import static com.google.common.collect.Sets.newLinkedHashSet;
/**
* Parses the cookbook versions in a Chef Server >= 0.10.8.
- *
- * @author Ignasi Barrera
*/
@Singleton
public class ParseCookbookVersionsV10FromJson implements Function<HttpResponse, Set<String>> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseErrorFromJsonOrReturnBody.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseErrorFromJsonOrReturnBody.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseErrorFromJsonOrReturnBody.java
index 2136674..6440409 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseErrorFromJsonOrReturnBody.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseErrorFromJsonOrReturnBody.java
@@ -27,11 +27,6 @@ import org.jclouds.http.functions.ReturnStringIf2xx;
import com.google.common.base.Function;
-/**
- *
- *
- * @author Adrian Cole
- */
@Singleton
public class ParseErrorFromJsonOrReturnBody implements Function<HttpResponse, String> {
Pattern pattern = Pattern.compile(".*\\[\"([^\"]+)\"\\].*");
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseKeySetFromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseKeySetFromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseKeySetFromJson.java
index 06714aa..963c19b 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseKeySetFromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseKeySetFromJson.java
@@ -27,9 +27,6 @@ import org.jclouds.http.functions.ParseJson;
import com.google.common.base.Function;
-/**
- * @author Adrian Cole
- */
@Singleton
public class ParseKeySetFromJson implements Function<HttpResponse, Set<String>> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchClientsFromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchClientsFromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchClientsFromJson.java
index 28ee572..18ecbfa 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchClientsFromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchClientsFromJson.java
@@ -22,10 +22,6 @@ import javax.inject.Singleton;
import org.jclouds.chef.domain.Client;
import org.jclouds.http.functions.ParseJson;
-/**
- *
- * @author Adrian Cole
- */
@Singleton
public class ParseSearchClientsFromJson extends ParseSearchResultFromJson<Client> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchDatabagFromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchDatabagFromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchDatabagFromJson.java
index 4826b38..c2c58ef 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchDatabagFromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchDatabagFromJson.java
@@ -37,8 +37,6 @@ import static com.google.common.collect.Iterables.transform;
* <p>
* When searching databags, the items are contained inside the
* <code>raw_data</code> list.
- *
- * @author Adrian Cole
*/
@Singleton
public class ParseSearchDatabagFromJson implements Function<HttpResponse, SearchResult<DatabagItem>> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchEnvironmentsFromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchEnvironmentsFromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchEnvironmentsFromJson.java
index d60ef43..852e0f3 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchEnvironmentsFromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchEnvironmentsFromJson.java
@@ -22,9 +22,6 @@ import org.jclouds.http.functions.ParseJson;
import javax.inject.Inject;
import javax.inject.Singleton;
-/**
- * @author Alex Kulik
- */
@Singleton
public class ParseSearchEnvironmentsFromJson extends ParseSearchResultFromJson<Environment> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchNodesFromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchNodesFromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchNodesFromJson.java
index bacbb25..6d34575 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchNodesFromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchNodesFromJson.java
@@ -22,10 +22,6 @@ import javax.inject.Singleton;
import org.jclouds.chef.domain.Node;
import org.jclouds.http.functions.ParseJson;
-/**
- *
- * @author Adrian Cole
- */
@Singleton
public class ParseSearchNodesFromJson extends ParseSearchResultFromJson<Node> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchResultFromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchResultFromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchResultFromJson.java
index 983ce8f..6c9bd84 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchResultFromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchResultFromJson.java
@@ -27,9 +27,6 @@ import org.jclouds.http.functions.ParseJson;
import com.google.common.base.Function;
-/**
- * @author Adrian Cole
- */
@Singleton
public class ParseSearchResultFromJson<T> implements Function<HttpResponse, SearchResult<T>> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchRolesFromJson.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchRolesFromJson.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchRolesFromJson.java
index f656b9c..42ba797 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchRolesFromJson.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseSearchRolesFromJson.java
@@ -22,10 +22,6 @@ import javax.inject.Singleton;
import org.jclouds.chef.domain.Role;
import org.jclouds.http.functions.ParseJson;
-/**
- *
- * @author Adrian Cole
- */
@Singleton
public class ParseSearchRolesFromJson extends ParseSearchResultFromJson<Role> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/RunListForGroup.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/RunListForGroup.java b/apis/chef/src/main/java/org/jclouds/chef/functions/RunListForGroup.java
index 0495905..b14ae71 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/RunListForGroup.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/RunListForGroup.java
@@ -34,9 +34,6 @@ import com.google.inject.TypeLiteral;
/**
* Retrieves the run-list for a specific group
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
@Singleton
public class RunListForGroup implements Function<String, List<String>> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/functions/UriForResource.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/UriForResource.java b/apis/chef/src/main/java/org/jclouds/chef/functions/UriForResource.java
index fce5ae2..d5d0810 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/UriForResource.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/UriForResource.java
@@ -29,8 +29,6 @@ import com.google.common.base.Function;
/**
* Extracts the uri field of the given {@link Resource}.
- *
- * @author Ignasi Barrera
*/
@Singleton
public class UriForResource implements Function<Object, URI> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefApiErrorRetryHandler.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefApiErrorRetryHandler.java b/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefApiErrorRetryHandler.java
index 6d1232e..3b4da4a 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefApiErrorRetryHandler.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefApiErrorRetryHandler.java
@@ -32,8 +32,6 @@ import com.google.inject.Inject;
/**
* Allow for eventual consistency on sandbox requests.
- *
- * @author Adrian Cole
*/
public class ChefApiErrorRetryHandler implements HttpRetryHandler {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefErrorHandler.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefErrorHandler.java b/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefErrorHandler.java
index 10a122f..3376219 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefErrorHandler.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefErrorHandler.java
@@ -37,9 +37,6 @@ import com.google.common.io.Closeables;
/**
* This will parse and set an appropriate exception on the command object.
- *
- * @author Adrian Cole
- *
*/
@Singleton
public class ChefErrorHandler implements HttpErrorHandler {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
index a841922..9619b44 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java
@@ -68,9 +68,6 @@ import com.google.common.collect.Maps;
import com.google.common.io.ByteStreams;
import com.google.common.io.InputSupplier;
-/**
- * @author Adrian Cole
- */
@Singleton
public class BaseChefService implements ChefService {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/internal/ChefContextImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/internal/ChefContextImpl.java b/apis/chef/src/main/java/org/jclouds/chef/internal/ChefContextImpl.java
index e641e70..8aef880 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/internal/ChefContextImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/internal/ChefContextImpl.java
@@ -31,10 +31,6 @@ import org.jclouds.location.Provider;
import com.google.common.reflect.TypeToken;
-/**
- * @author Adrian Cole
- * @author Ignasi Barrera
- */
@Singleton
public class ChefContextImpl extends BaseView implements ChefContext {
private final ChefService chefService;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/options/CreateClientOptions.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/options/CreateClientOptions.java b/apis/chef/src/main/java/org/jclouds/chef/options/CreateClientOptions.java
index 86783ad..776d7bb 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/options/CreateClientOptions.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/options/CreateClientOptions.java
@@ -18,8 +18,6 @@ package org.jclouds.chef.options;
/**
* Options for the create client method.
- *
- * @author Ignasi Barrera
*/
public class CreateClientOptions implements Cloneable {
/** Administrator flag. This flag will be ignored in Opscode Hosted Chef. */
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/options/SearchOptions.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/options/SearchOptions.java b/apis/chef/src/main/java/org/jclouds/chef/options/SearchOptions.java
index a2fda95..cbc1d54 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/options/SearchOptions.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/options/SearchOptions.java
@@ -22,8 +22,6 @@ import org.jclouds.http.options.BaseHttpRequestOptions;
/**
* Options for the search api.
- *
- * @author Ignasi Barrera
*/
public class SearchOptions extends BaseHttpRequestOptions {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/predicates/CookbookVersionPredicates.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/predicates/CookbookVersionPredicates.java b/apis/chef/src/main/java/org/jclouds/chef/predicates/CookbookVersionPredicates.java
index 49b04dc..7edbcae 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/predicates/CookbookVersionPredicates.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/predicates/CookbookVersionPredicates.java
@@ -33,8 +33,6 @@ import com.google.common.collect.Multimap;
*
* This class has static methods that create customized predicates to use with
* {@link org.jclouds.chef.ChefService}.
- *
- * @author Adrian Cole
*/
public class CookbookVersionPredicates {
/**
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/CleanupStaleNodesAndClients.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/CleanupStaleNodesAndClients.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/CleanupStaleNodesAndClients.java
index 077da30..8519450 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/CleanupStaleNodesAndClients.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/CleanupStaleNodesAndClients.java
@@ -23,8 +23,6 @@ import com.google.inject.ImplementedBy;
/**
*
* Cleans up nodes and clients who have been hanging around too long.
- *
- * @author Adrian Cole
*/
@ImplementedBy(CleanupStaleNodesAndClientsImpl.class)
public interface CleanupStaleNodesAndClients {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/CreateNodeAndPopulateAutomaticAttributes.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/CreateNodeAndPopulateAutomaticAttributes.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/CreateNodeAndPopulateAutomaticAttributes.java
index 070aaa3..249be48 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/CreateNodeAndPopulateAutomaticAttributes.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/CreateNodeAndPopulateAutomaticAttributes.java
@@ -24,8 +24,6 @@ import com.google.inject.ImplementedBy;
/**
*
* Creates a new node with automatic attributes.
- *
- * @author Adrian Cole
*/
@ImplementedBy(CreateNodeAndPopulateAutomaticAttributesImpl.class)
public interface CreateNodeAndPopulateAutomaticAttributes {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllClientsInList.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllClientsInList.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllClientsInList.java
index 0fa54c0..7dd7b89 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllClientsInList.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllClientsInList.java
@@ -23,9 +23,6 @@ import com.google.inject.ImplementedBy;
/**
* Deletes all clients in a given list.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
@ImplementedBy(DeleteAllClientsInListImpl.class)
public interface DeleteAllClientsInList {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllNodesInList.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllNodesInList.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllNodesInList.java
index 16a196e..8867e49 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllNodesInList.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/DeleteAllNodesInList.java
@@ -21,11 +21,6 @@ import org.jclouds.chef.strategy.internal.DeleteAllNodesInListImpl;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.ImplementedBy;
-/**
- *
- *
- * @author Adrian Cole
- */
@ImplementedBy(DeleteAllNodesInListImpl.class)
public interface DeleteAllNodesInList {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
index 5d6b8a0..f531a32 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
@@ -22,10 +22,6 @@ import org.jclouds.chef.strategy.internal.ListClientsImpl;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.ImplementedBy;
-/**
- *
- * @author Adrian Cole
- */
@ImplementedBy(ListClientsImpl.class)
public interface ListClients {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
index 01bcd33..4409e4e 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
@@ -22,10 +22,6 @@ import org.jclouds.chef.strategy.internal.ListCookbookVersionsImpl;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.ImplementedBy;
-/**
- *
- * @author Adrian Cole
- */
@ImplementedBy(ListCookbookVersionsImpl.class)
public interface ListCookbookVersions {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
index 1c1186e..b0e1c54 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
@@ -22,10 +22,6 @@ import org.jclouds.chef.strategy.internal.ListCookbookVersionsInEnvironmentImpl;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.ImplementedBy;
-/**
- *
- * @author Noorul Islam K M
- */
@ImplementedBy(ListCookbookVersionsInEnvironmentImpl.class)
public interface ListCookbookVersionsInEnvironment {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
index 92b451b..a1a4093 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
@@ -22,10 +22,6 @@ import org.jclouds.chef.strategy.internal.ListNodesImpl;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.ImplementedBy;
-/**
- *
- * @author Adrian Cole
- */
@ImplementedBy(ListNodesImpl.class)
public interface ListNodes {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
index 6308747..6a46fab 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
@@ -22,10 +22,6 @@ import org.jclouds.chef.strategy.internal.ListNodesInEnvironmentImpl;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.ImplementedBy;
-/**
- *
- * @author Noorul Islam K M
- */
@ImplementedBy(ListNodesInEnvironmentImpl.class)
public interface ListNodesInEnvironment {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/UpdateAutomaticAttributesOnNode.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/UpdateAutomaticAttributesOnNode.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/UpdateAutomaticAttributesOnNode.java
index c4b6220..0dcb81e 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/UpdateAutomaticAttributesOnNode.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/UpdateAutomaticAttributesOnNode.java
@@ -23,8 +23,6 @@ import com.google.inject.ImplementedBy;
/**
*
* Updates node with new automatic attributes.
- *
- * @author Adrian Cole
*/
@ImplementedBy(UpdateAutomaticAttributesOnNodeImpl.class)
public interface UpdateAutomaticAttributesOnNode {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImpl.java
index a9dbaa8..46c765b 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImpl.java
@@ -46,8 +46,6 @@ import com.google.common.base.Predicate;
/**
*
* Cleans up nodes and apis who have been hanging around too long.
- *
- * @author Adrian Cole
*/
@Singleton
public class CleanupStaleNodesAndClientsImpl implements CleanupStaleNodesAndClients {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImpl.java
index d6336b2..7dabd06 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CreateNodeAndPopulateAutomaticAttributesImpl.java
@@ -38,8 +38,6 @@ import com.google.common.base.Supplier;
/**
*
* Updates node with new automatic attributes.
- *
- * @author Adrian Cole
*/
@Singleton
public class CreateNodeAndPopulateAutomaticAttributesImpl implements CreateNodeAndPopulateAutomaticAttributes {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/DeleteAllClientsInListImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/DeleteAllClientsInListImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/DeleteAllClientsInListImpl.java
index 561471b..ffdd3ec 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/DeleteAllClientsInListImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/DeleteAllClientsInListImpl.java
@@ -43,9 +43,6 @@ import com.google.inject.Inject;
/**
* Concurrently delete all given clients.
- *
- * @author Adrian Cole
- * @author Ignasi Barrera
*/
@Singleton
public class DeleteAllClientsInListImpl implements DeleteAllClientsInList {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/DeleteAllNodesInListImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/DeleteAllNodesInListImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/DeleteAllNodesInListImpl.java
index de5e922..212d8b7 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/DeleteAllNodesInListImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/DeleteAllNodesInListImpl.java
@@ -41,11 +41,6 @@ import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
-/**
- *
- *
- * @author Adrian Cole
- */
@Singleton
public class DeleteAllNodesInListImpl implements DeleteAllNodesInList {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java
index 63c2484..6acda30 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java
@@ -41,10 +41,6 @@ import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
-/**
- *
- * @author Adrian Cole
- */
@Singleton
public class ListClientsImpl implements ListClients {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java
index cdd71c4..75794d9 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java
@@ -42,10 +42,6 @@ import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
-/**
- *
- * @author Adrian Cole
- */
@Singleton
public class ListCookbookVersionsImpl implements ListCookbookVersions {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
index 881f251..ccc2992 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
@@ -43,10 +43,6 @@ import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
-/**
- *
- * @author Noorul Islam K M
- */
@Singleton
public class ListCookbookVersionsInEnvironmentImpl implements ListCookbookVersionsInEnvironment {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java
index 3af264b..be9b652 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java
@@ -41,10 +41,6 @@ import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
-/**
- *
- * @author Adrian Cole
- */
@Singleton
public class ListNodesImpl implements ListNodes {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
index a2b2244..8ae747e 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
@@ -41,10 +41,6 @@ import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
-/**
- *
- * @author Noorul Islam K M
- */
@Singleton
public class ListNodesInEnvironmentImpl implements ListNodesInEnvironment {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImpl.java
index 4d9bea4..a6dcac2 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/UpdateAutomaticAttributesOnNodeImpl.java
@@ -38,8 +38,6 @@ import com.google.common.base.Supplier;
/**
*
* Updates node with new automatic attributes.
- *
- * @author Adrian Cole
*/
@Singleton
public class UpdateAutomaticAttributesOnNodeImpl implements UpdateAutomaticAttributesOnNode {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/suppliers/ChefVersionSupplier.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/suppliers/ChefVersionSupplier.java b/apis/chef/src/main/java/org/jclouds/chef/suppliers/ChefVersionSupplier.java
index 7f7f4e9..a0d8b04 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/suppliers/ChefVersionSupplier.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/suppliers/ChefVersionSupplier.java
@@ -35,8 +35,6 @@ import com.google.common.base.Supplier;
/**
* Properly supply the version of the Chef Server.
- *
- * @author Ignasi Barrera
*/
@Singleton
public class ChefVersionSupplier implements Supplier<Integer> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApi.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApi.java b/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApi.java
index 812fd29..c2c5f10 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApi.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApi.java
@@ -57,8 +57,6 @@ import com.google.common.base.Function;
/**
* In-memory chef simulator.
- *
- * @author Adrian Cole
*/
public class TransientChefApi implements ChefApi {
@Singleton
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java b/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java
index 88f7a8d..c485080 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java
@@ -30,8 +30,6 @@ import com.google.inject.Module;
/**
* Implementation of {@link ApiMetadata} for the Amazon-specific Chef API
- *
- * @author Adrian Cole
*/
public class TransientChefApiMetadata extends BaseHttpApiMetadata<TransientChefApi> {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java b/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java
index 648c917..d9eab4d 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java
@@ -52,10 +52,6 @@ import com.google.inject.Module;
import com.google.inject.Provides;
import com.google.inject.name.Names;
-/**
- *
- * @author Adrian Cole
- */
@ConfiguresHttpApi
public class TransientChefApiModule extends AbstractModule {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/util/ChefUtils.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/util/ChefUtils.java b/apis/chef/src/main/java/org/jclouds/chef/util/ChefUtils.java
index aff08d3..3ba0c59 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/util/ChefUtils.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/util/ChefUtils.java
@@ -33,11 +33,6 @@ import com.google.inject.Binder;
import com.google.inject.TypeLiteral;
import com.google.inject.multibindings.MapBinder;
-/**
- *
- *
- * @author Adrian Cole
- */
public class ChefUtils {
public static Date fromOhaiTime(JsonBall ohaiDate) {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/util/CollectionUtils.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/util/CollectionUtils.java b/apis/chef/src/main/java/org/jclouds/chef/util/CollectionUtils.java
index 0e62804..cabfbde 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/util/CollectionUtils.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/util/CollectionUtils.java
@@ -28,8 +28,6 @@ import com.google.common.collect.ImmutableSet;
/**
* Utility methods to work with collections.
- *
- * @author Ignasi Barrera
*/
public class CollectionUtils {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/chef/util/RunListBuilder.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/util/RunListBuilder.java b/apis/chef/src/main/java/org/jclouds/chef/util/RunListBuilder.java
index 619a0e0..27cc377 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/util/RunListBuilder.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/util/RunListBuilder.java
@@ -29,8 +29,6 @@ import com.google.common.collect.ImmutableList;
/**
* builds a run list in the correct syntax for chef.
- *
- * @author Adrian Cole
*/
public class RunListBuilder {
private List<String> list = newArrayList();
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/ohai/Automatic.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/ohai/Automatic.java b/apis/chef/src/main/java/org/jclouds/ohai/Automatic.java
index de6e373d..9b3d134 100644
--- a/apis/chef/src/main/java/org/jclouds/ohai/Automatic.java
+++ b/apis/chef/src/main/java/org/jclouds/ohai/Automatic.java
@@ -26,10 +26,6 @@ import java.lang.annotation.Target;
import javax.inject.Qualifier;
-/**
- *
- * @author Adrian Cole
- */
@Retention(RUNTIME)
@Target({ TYPE, METHOD, PARAMETER })
@Qualifier
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/ohai/AutomaticSupplier.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/ohai/AutomaticSupplier.java b/apis/chef/src/main/java/org/jclouds/ohai/AutomaticSupplier.java
index e7c78d1..681558e 100644
--- a/apis/chef/src/main/java/org/jclouds/ohai/AutomaticSupplier.java
+++ b/apis/chef/src/main/java/org/jclouds/ohai/AutomaticSupplier.java
@@ -29,11 +29,6 @@ import org.jclouds.ohai.functions.NestSlashKeys;
import com.google.common.base.Supplier;
import com.google.common.collect.Multimap;
-/**
- *
- * @author Adrian Cole
- *
- */
@Singleton
public class AutomaticSupplier implements Supplier<Map<String, JsonBall>> {
private final Multimap<String, Supplier<JsonBall>> autoAttrs;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/ohai/config/ConfiguresOhai.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/ohai/config/ConfiguresOhai.java b/apis/chef/src/main/java/org/jclouds/ohai/config/ConfiguresOhai.java
index d1d17a3..1ca0df4 100644
--- a/apis/chef/src/main/java/org/jclouds/ohai/config/ConfiguresOhai.java
+++ b/apis/chef/src/main/java/org/jclouds/ohai/config/ConfiguresOhai.java
@@ -22,10 +22,6 @@ import java.lang.annotation.Target;
import static java.lang.annotation.ElementType.TYPE;
import static java.lang.annotation.RetentionPolicy.RUNTIME;
-/**
- *
- * @author Adrian Cole
- */
@Retention(RUNTIME)
@Target(TYPE)
public @interface ConfiguresOhai {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/2982d996/apis/chef/src/main/java/org/jclouds/ohai/config/JMXOhaiModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/ohai/config/JMXOhaiModule.java b/apis/chef/src/main/java/org/jclouds/ohai/config/JMXOhaiModule.java
index 1f106ec..a8d01f7 100644
--- a/apis/chef/src/main/java/org/jclouds/ohai/config/JMXOhaiModule.java
+++ b/apis/chef/src/main/java/org/jclouds/ohai/config/JMXOhaiModule.java
@@ -30,8 +30,6 @@ import com.google.inject.multibindings.MapBinder;
/**
* Wires the components needed to parse ohai data from a JVM
- *
- * @author Adrian Cole
*/
@ConfiguresOhai
public class JMXOhaiModule extends OhaiModule {
[35/50] [abbrv] jclouds git commit: [maven-release-plugin] prepare
for next development iteration
Posted by na...@apache.org.
[maven-release-plugin] prepare for next development iteration
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/22d8a38d
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/22d8a38d
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/22d8a38d
Branch: refs/heads/1.8.x
Commit: 22d8a38d83280e23d65327d5ed3e0095b7d3238a
Parents: 34b6f4a
Author: Andrew Phillips <an...@apache.org>
Authored: Tue Jul 29 19:53:30 2014 -0400
Committer: Andrew Phillips <an...@apache.org>
Committed: Tue Jul 29 19:53:30 2014 -0400
----------------------------------------------------------------------
apis/chef/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/22d8a38d/apis/chef/pom.xml
----------------------------------------------------------------------
diff --git a/apis/chef/pom.xml b/apis/chef/pom.xml
index 4f4e378..00a1c4c 100644
--- a/apis/chef/pom.xml
+++ b/apis/chef/pom.xml
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.jclouds.chef</groupId>
<artifactId>chef-project</artifactId>
- <version>1.8.0</version>
+ <version>1.8.1-SNAPSHOT</version>
<relativePath>../project/pom.xml</relativePath>
</parent>
<groupId>org.apache.jclouds.api</groupId>
[44/50] [abbrv] jclouds git commit: [maven-release-plugin] prepare
for next development iteration
Posted by na...@apache.org.
[maven-release-plugin] prepare for next development iteration
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/a48ea89d
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/a48ea89d
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/a48ea89d
Branch: refs/heads/1.8.x
Commit: a48ea89d854c81897e9340794521614a6c8e651b
Parents: 415e625
Author: Andrew Phillips <an...@apache.org>
Authored: Fri Oct 10 14:22:16 2014 -0400
Committer: Andrew Phillips <an...@apache.org>
Committed: Fri Oct 10 14:22:16 2014 -0400
----------------------------------------------------------------------
apis/chef/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/a48ea89d/apis/chef/pom.xml
----------------------------------------------------------------------
diff --git a/apis/chef/pom.xml b/apis/chef/pom.xml
index 3fb7dfe..fee7190 100644
--- a/apis/chef/pom.xml
+++ b/apis/chef/pom.xml
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.jclouds.chef</groupId>
<artifactId>chef-project</artifactId>
- <version>1.8.1</version>
+ <version>1.8.2-SNAPSHOT</version>
<relativePath>../project/pom.xml</relativePath>
</parent>
<groupId>org.apache.jclouds.api</groupId>
[49/50] [abbrv] jclouds git commit: Removed obsolete TransientChefApi
Posted by na...@apache.org.
Removed obsolete TransientChefApi
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/494f35dd
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/494f35dd
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/494f35dd
Branch: refs/heads/1.8.x
Commit: 494f35ddaef427afda281bab95273e03e85775af
Parents: ea1c772
Author: Ignasi Barrera <na...@apache.org>
Authored: Fri Oct 10 11:29:45 2014 +0200
Committer: Ignasi Barrera <na...@apache.org>
Committed: Sun Nov 23 22:24:44 2014 +0100
----------------------------------------------------------------------
.../org/jclouds/chef/test/TransientChefApi.java | 387 -------------------
.../chef/test/TransientChefApiMetadata.java | 75 ----
.../test/config/TransientChefApiModule.java | 114 ------
.../services/org.jclouds.apis.ApiMetadata | 1 -
.../test/TransientChefApiIntegrationTest.java | 69 ----
.../chef/test/TransientChefApiMetadataTest.java | 33 --
6 files changed, 679 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/494f35dd/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApi.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApi.java b/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApi.java
deleted file mode 100644
index c2c5f10..0000000
--- a/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApi.java
+++ /dev/null
@@ -1,387 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jclouds.chef.test;
-
-import static com.google.common.base.Preconditions.checkNotNull;
-import static com.google.common.base.Throwables.propagate;
-import static com.google.common.collect.Iterables.transform;
-import static com.google.common.collect.Sets.newLinkedHashSet;
-
-import java.io.IOException;
-import java.io.InputStream;
-import java.net.URI;
-import java.util.List;
-import java.util.Set;
-
-import javax.inject.Inject;
-import javax.inject.Named;
-import javax.inject.Singleton;
-
-import org.jclouds.blobstore.config.LocalBlobStore;
-import org.jclouds.blobstore.domain.Blob;
-import org.jclouds.blobstore.domain.PageSet;
-import org.jclouds.blobstore.domain.StorageMetadata;
-import org.jclouds.chef.ChefApi;
-import org.jclouds.chef.domain.Client;
-import org.jclouds.chef.domain.CookbookDefinition;
-import org.jclouds.chef.domain.CookbookVersion;
-import org.jclouds.chef.domain.DatabagItem;
-import org.jclouds.chef.domain.Environment;
-import org.jclouds.chef.domain.Node;
-import org.jclouds.chef.domain.Resource;
-import org.jclouds.chef.domain.Role;
-import org.jclouds.chef.domain.Sandbox;
-import org.jclouds.chef.domain.SearchResult;
-import org.jclouds.chef.domain.UploadSandbox;
-import org.jclouds.chef.options.CreateClientOptions;
-import org.jclouds.chef.options.SearchOptions;
-import org.jclouds.io.Payload;
-import org.jclouds.lifecycle.Closer;
-import org.jclouds.util.Strings2;
-
-import com.google.common.base.Function;
-
-/**
- * In-memory chef simulator.
- */
-public class TransientChefApi implements ChefApi {
- @Singleton
- private static class StorageMetadataToName implements Function<PageSet<? extends StorageMetadata>, Set<String>> {
- @Override
- public Set<String> apply(PageSet<? extends StorageMetadata> from) {
- return newLinkedHashSet(transform(from, new Function<StorageMetadata, String>() {
-
- @Override
- public String apply(StorageMetadata from) {
- return from.getName();
- }
- }));
- }
- }
-
- @Singleton
- private static class BlobToDatabagItem implements Function<Blob, DatabagItem> {
- @Override
- public DatabagItem apply(Blob from) {
- try {
- return from == null ? null : new DatabagItem(from.getMetadata().getName(), Strings2.toStringAndClose(from
- .getPayload().getInput()));
- } catch (IOException e) {
- propagate(e);
- return null;
- }
- }
- }
-
- private final LocalBlobStore databags;
- private final BlobToDatabagItem blobToDatabagItem;
- private final StorageMetadataToName storageMetadataToName;
- private final Closer closer;
-
- @Inject
- TransientChefApi(@Named("databags") LocalBlobStore databags, StorageMetadataToName storageMetadataToName,
- BlobToDatabagItem blobToDatabagItem, Closer closer) {
- this.databags = checkNotNull(databags, "databags");
- this.storageMetadataToName = checkNotNull(storageMetadataToName, "storageMetadataToName");
- this.blobToDatabagItem = checkNotNull(blobToDatabagItem, "blobToDatabagItem");
- this.closer = checkNotNull(closer, "closer");
- }
-
- @Override
- public Sandbox commitSandbox(String id, boolean isCompleted) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Client createClient(String clientName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Client createClient(String clientName, CreateClientOptions options) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public void createDatabag(String databagName) {
- databags.createContainerInLocation(null, databagName);
- }
-
- @Override
- public DatabagItem createDatabagItem(String databagName, DatabagItem databagItem) {
- Blob blob = databags.blobBuilder(databagItem.getId()).payload(databagItem.toString()).build();
- databags.putBlob(databagName, blob);
- return databagItem;
- }
-
- @Override
- public void createNode(Node node) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public void createRole(Role role) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Client deleteClient(String clientName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public CookbookVersion deleteCookbook(String cookbookName, String version) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public void deleteDatabag(String databagName) {
- databags.deleteContainer(databagName);
- }
-
- @Override
- public DatabagItem deleteDatabagItem(String databagName, String databagItemId) {
- DatabagItem item = blobToDatabagItem.apply(databags.getBlob(databagName, databagItemId));
- databags.removeBlob(databagName, databagItemId);
- return item;
- }
-
- @Override
- public Node deleteNode(String nodeName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Role deleteRole(String rolename) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Client generateKeyForClient(String clientName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Client getClient(String clientName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public CookbookVersion getCookbook(String cookbookName, String version) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public DatabagItem getDatabagItem(String databagName, String databagItemId) {
- return blobToDatabagItem.apply(databags.getBlob(databagName, databagItemId));
- }
-
- @Override
- public Node getNode(String nodeName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Role getRole(String roleName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public UploadSandbox createUploadSandboxForChecksums(Set<List<Byte>> md5s) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Set<String> listVersionsOfCookbook(String cookbookName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Set<String> listClients() {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Set<String> listCookbooks() {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Set<String> listDatabagItems(String databagName) {
- return storageMetadataToName.apply(databags.list(databagName));
- }
-
- @Override
- public Set<String> listDatabags() {
- return storageMetadataToName.apply(databags.list());
- }
-
- @Override
- public Set<String> listNodes() {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Set<String> listRoles() {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Set<String> listSearchIndexes() {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public SearchResult<? extends Client> searchClients() {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public SearchResult<? extends Client> searchClients(SearchOptions options) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public SearchResult<? extends DatabagItem> searchDatabagItems(String databagName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public SearchResult<? extends DatabagItem> searchDatabagItems(String databagName, SearchOptions options) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public SearchResult<? extends Node> searchNodes() {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public SearchResult<? extends Node> searchNodes(SearchOptions options) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public SearchResult<? extends Role> searchRoles() {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public SearchResult<? extends Role> searchRoles(SearchOptions options) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public CookbookVersion updateCookbook(String cookbookName, String version, CookbookVersion cookbook) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public DatabagItem updateDatabagItem(String databagName, DatabagItem item) {
- return createDatabagItem(databagName, item);
- }
-
- @Override
- public Node updateNode(Node node) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Role updateRole(Role role) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public void uploadContent(URI location, Payload content) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public InputStream getResourceContents(Resource resource) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Set<String> listEnvironments() {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public void createEnvironment(Environment environment) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Environment deleteEnvironment(String environmentName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Environment getEnvironment(String environmentName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Environment updateEnvironment(Environment environment) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Set<CookbookDefinition> listCookbooksInEnvironment(String environmentName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Set<CookbookDefinition> listCookbooksInEnvironment(String environmentName, String numVersions) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public CookbookDefinition getCookbookInEnvironment(String environmentName, String cookbookName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public CookbookDefinition getCookbookInEnvironment(String environmentName, String cookbookName, String numVersions) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public SearchResult<? extends Environment> searchEnvironments() {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public SearchResult<? extends Environment> searchEnvironments(SearchOptions options) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Set<String> listRecipesInEnvironment(String environmentName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public Set<String> listNodesInEnvironment(String environmentName) {
- throw new UnsupportedOperationException();
- }
-
- @Override
- public void close() throws IOException {
- closer.close();
- }
-}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/494f35dd/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java b/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java
deleted file mode 100644
index c485080..0000000
--- a/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java
+++ /dev/null
@@ -1,75 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jclouds.chef.test;
-
-import java.net.URI;
-
-import org.jclouds.chef.ChefApiMetadata;
-import org.jclouds.chef.config.ChefBootstrapModule;
-import org.jclouds.chef.config.ChefParserModule;
-import org.jclouds.chef.test.config.TransientChefApiModule;
-import org.jclouds.ohai.config.JMXOhaiModule;
-import org.jclouds.rest.internal.BaseHttpApiMetadata;
-
-import com.google.common.collect.ImmutableSet;
-import com.google.inject.Module;
-
-/**
- * Implementation of {@link ApiMetadata} for the Amazon-specific Chef API
- */
-public class TransientChefApiMetadata extends BaseHttpApiMetadata<TransientChefApi> {
-
- @Override
- public Builder toBuilder() {
- return new Builder().fromApiMetadata(this);
- }
-
- public TransientChefApiMetadata() {
- this(new Builder());
- }
-
- protected TransientChefApiMetadata(Builder builder) {
- super(builder);
- }
-
- public static class Builder extends BaseHttpApiMetadata.Builder<TransientChefApi, Builder> {
- protected Builder() {
- id("transientchef")
- .name("In-memory Chef API")
- .identityName("unused")
- .defaultIdentity("api")
- .documentation(URI.create("http://localhost"))
- .defaultCredential(
- "-----BEGIN RSA PRIVATE KEY-----\nMIIEpQIBAAKCAQEAyb2ZJJqGm0KKR+8nfQJNsSd+F9tXNMV7CfOcW6jsqs8EZgiV\nR09hD1IYOj4YqM0qJONlgyg4xRWewdSG7QTPj1lJpVAida9sXy2+kzyagZA1Am0O\nZcbqb5hoeIDgcX+eDa79s0u0DomjcfO9EKhvHLBz+zM+3QqPRkPV8nYTbfs+HjVz\nzOU6D1B0XR3+IPZZl2AnWs2d0qhnStHcDUvnRVQ0P482YwN9VgceOZtpPz0DCKEJ\n5Tx5STub8k0/zt/VAMHQafLSuQMLd2s4ZLuOZptN//uAsTmxireqd37z+8ZTdBbJ\n8LEpJ+iCXuSfm5aUh7iw6oxvToY2AL53+jK2UQIDAQABAoIBAQDA88B3i/xWn0vX\nBVxFamCYoecuNjGwXXkSyZew616A+EOCu47bh4aTurdFbYL0YFaAtaWvzlaN2eHg\nDb+HDuTefE29+WkcGk6SshPmiz5T0XOCAICWw6wSVDkHmGwS4jZvbAFm7W8nwGk9\nYhxgxFiRngswJZFopOLoF5WXs2td8guIYNslMpo7tu50iFnBHwKO2ZsPAk8t9nnS\nxlDavKruymEmqHCr3+dtio5eaenJcp3fjoXBQOKUk3ipII29XRB8NqeCVV/7Kxwq\nckqOBEbRwBclckyIbD+RiAgKvOelORjEiE9R42vuqvxRA6k9kd9o7utlX0AUtpEn\n3gZc6LepAoGBAP9ael5Y75+sK2JJUNOOhO8ae45cdsilp2yI0X+UBaSuQs2+dyPp\nkpEHAxd4pmmSvn/8c9TlEZhr+qYbABXVPlDncxpIuw2Ajbk7s/S4XaSKsRqpXL57\nzj/QOqLkRk8+OVV9q6lMeQNqLtEj1u6JPviX70Ro+FQtRttNOYbfdP/fAoGBAMpA\nXjR5woV5sUb+REg9vE
uYo8RSyOarxqKFCIXVUNsLOx+22+AK4+CQpbueWN7jotrl\nYD6uT6svWi3AAC7kiY0UI/fjVPRCUi8tVoQUE0TaU5VLITaYOB+W/bBaDE4M9560\n1NuDWO90baA5dfU44iuzva02rGJXK9+nS3o8nk/PAoGBALOL6djnDe4mwAaG6Jco\ncd4xr8jkyPzCRZuyBCSBbwphIUXLc7hDprPky064ncJD1UDmwIdkXd/fpMkg2QmA\n/CUk6LEFjMisqHojOaCL9gQZJPhLN5QUN2x1PJWGjs1vQh8Tkx0iUUCOa8bQPXNR\n+34OTsW6TUna4CSZAycLfhffAoGBAIggVsefBCvuQkF0NeUhmDCRZfhnd8y55RHR\n1HCvqKIlpv+rhcX/zmyBLuteopYyRJRsOiE2FW00i8+rIPRu4Z3Q5nybx7w3PzV9\noHN5R5baE9OyI4KpZWztpYYitZF67NcnAvVULHHOvVJQGnKYfLHJYmrJF7GA1ojM\nAuMdFbjFAoGAPxUhxwFy8gaqBahKUEZn4F81HFP5ihGhkT4QL6AFPO2e+JhIGjuR\n27+85hcFqQ+HHVtFsm81b/a+R7P4UuCRgc8eCjxQMoJ1Xl4n7VbjPbHMnIN0Ryvd\nO4ZpWDWYnCO021JTOUUOJ4J/y0416Bvkw0z59y7sNX7wDBBHHbK/XCc=\n-----END RSA PRIVATE KEY-----\n")
- .defaultEndpoint("transientchef")
- .defaultProperties(ChefApiMetadata.defaultProperties())
- .defaultModules(
- ImmutableSet.<Class<? extends Module>> of(TransientChefApiModule.class, ChefParserModule.class,
- ChefBootstrapModule.class, JMXOhaiModule.class));
- }
-
- @Override
- public TransientChefApiMetadata build() {
- return new TransientChefApiMetadata(this);
- }
-
- @Override
- protected Builder self() {
- return this;
- }
- }
-}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/494f35dd/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java b/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java
deleted file mode 100644
index bab35d0..0000000
--- a/apis/chef/src/main/java/org/jclouds/chef/test/config/TransientChefApiModule.java
+++ /dev/null
@@ -1,114 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jclouds.chef.test.config;
-
-import static com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor;
-
-import java.io.IOException;
-import java.security.PrivateKey;
-import java.security.spec.InvalidKeySpecException;
-import java.util.List;
-
-import javax.inject.Singleton;
-
-import org.jclouds.ContextBuilder;
-import org.jclouds.blobstore.TransientApiMetadata;
-import org.jclouds.blobstore.config.LocalBlobStore;
-import org.jclouds.chef.ChefApi;
-import org.jclouds.chef.config.Validator;
-import org.jclouds.chef.domain.Client;
-import org.jclouds.chef.functions.BootstrapConfigForGroup;
-import org.jclouds.chef.functions.ClientForGroup;
-import org.jclouds.chef.functions.RunListForGroup;
-import org.jclouds.chef.test.TransientChefApi;
-import org.jclouds.concurrent.config.ExecutorServiceModule;
-import org.jclouds.crypto.Crypto;
-import org.jclouds.domain.JsonBall;
-import org.jclouds.rest.ConfiguresHttpApi;
-import org.jclouds.rest.config.RestModule;
-
-import com.google.common.base.Optional;
-import com.google.common.base.Supplier;
-import com.google.common.cache.CacheLoader;
-import com.google.common.collect.ImmutableSet;
-import com.google.inject.AbstractModule;
-import com.google.inject.Injector;
-import com.google.inject.Module;
-import com.google.inject.Provides;
-import com.google.inject.name.Names;
-
-@ConfiguresHttpApi
-public class TransientChefApiModule extends AbstractModule {
-
- @Override
- protected void configure() {
- install(new RestModule());
- bind(ChefApi.class).to(TransientChefApi.class);
- bind(LocalBlobStore.class).annotatedWith(Names.named("databags"))
- .toInstance(
- ContextBuilder
- .newBuilder(new TransientApiMetadata())
- .modules(
- ImmutableSet.<Module> of(new ExecutorServiceModule(sameThreadExecutor(),
- sameThreadExecutor()))).buildInjector().getInstance(LocalBlobStore.class));
- }
-
- @Provides
- @Singleton
- public Supplier<PrivateKey> supplyKey() {
- return new Supplier<PrivateKey>() {
- @Override
- public PrivateKey get() {
- return null;
- }
- };
- }
-
- @Provides
- @Singleton
- CacheLoader<String, List<String>> runListForGroup(RunListForGroup runListForGroup) {
- return CacheLoader.from(runListForGroup);
- }
-
- @Provides
- @Singleton
- CacheLoader<String, ? extends JsonBall> bootstrapConfigForGroup(BootstrapConfigForGroup bootstrapConfigForGroup) {
- return CacheLoader.from(bootstrapConfigForGroup);
- }
-
- @Provides
- @Singleton
- CacheLoader<String, Client> groupToClient(ClientForGroup clientForGroup) {
- return CacheLoader.from(clientForGroup);
- }
-
- @Provides
- @Singleton
- @Validator
- public Optional<String> provideValidatorName(Injector injector) {
- return Optional.absent();
- }
-
- @Provides
- @Singleton
- @Validator
- public Optional<PrivateKey> provideValidatorCredential(Crypto crypto, Injector injector)
- throws InvalidKeySpecException, IOException {
- return Optional.absent();
- }
-
-}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/494f35dd/apis/chef/src/main/resources/META-INF/services/org.jclouds.apis.ApiMetadata
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/resources/META-INF/services/org.jclouds.apis.ApiMetadata b/apis/chef/src/main/resources/META-INF/services/org.jclouds.apis.ApiMetadata
index 07e3240..c7a6f4e 100644
--- a/apis/chef/src/main/resources/META-INF/services/org.jclouds.apis.ApiMetadata
+++ b/apis/chef/src/main/resources/META-INF/services/org.jclouds.apis.ApiMetadata
@@ -1,2 +1 @@
-org.jclouds.chef.test.TransientChefApiMetadata
org.jclouds.chef.ChefApiMetadata
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/jclouds/blob/494f35dd/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiIntegrationTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiIntegrationTest.java b/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiIntegrationTest.java
deleted file mode 100644
index ecd5d16..0000000
--- a/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiIntegrationTest.java
+++ /dev/null
@@ -1,69 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jclouds.chef.test;
-
-import static org.testng.Assert.assertEquals;
-import static org.testng.Assert.assertNotNull;
-
-import java.util.Properties;
-
-import org.jclouds.chef.ChefApi;
-import org.jclouds.chef.domain.DatabagItem;
-import org.jclouds.chef.internal.BaseChefLiveTest;
-import org.testng.annotations.Test;
-
-/**
- * Tests behavior of {@code TransientChefApi}
- */
-@Test(groups = { "integration" })
-public class TransientChefApiIntegrationTest extends BaseChefLiveTest<ChefApi> {
- public static final String PREFIX = System.getProperty("user.name") + "-jcloudstest";
- private DatabagItem databagItem;
-
- public TransientChefApiIntegrationTest() {
- provider = "transientchef";
- }
-
- @Override
- protected Properties setupProperties() {
- return new Properties();
- }
-
- public void testCreateDatabag() {
- api.deleteDatabag(PREFIX);
- api.createDatabag(PREFIX);
- }
-
- @Test(dependsOnMethods = { "testCreateDatabag" })
- public void testCreateDatabagItem() {
- Properties config = new Properties();
- config.setProperty("foo", "bar");
- databagItem = api.createDatabagItem(PREFIX, new DatabagItem("config", json.toJson(config)));
- assertNotNull(databagItem);
- assertEquals(databagItem.getId(), "config");
- assertEquals(config, json.fromJson(databagItem.toString(), Properties.class));
- }
-
- @Test(dependsOnMethods = "testCreateDatabagItem")
- public void testUpdateDatabagItem() {
- for (String databagItemId : api.listDatabagItems(PREFIX)) {
- DatabagItem databagItem = api.getDatabagItem(PREFIX, databagItemId);
- api.updateDatabagItem(PREFIX, databagItem);
- }
- }
-
-}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/494f35dd/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiMetadataTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiMetadataTest.java b/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiMetadataTest.java
deleted file mode 100644
index eac33f3..0000000
--- a/apis/chef/src/test/java/org/jclouds/chef/test/TransientChefApiMetadataTest.java
+++ /dev/null
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.jclouds.chef.test;
-
-import org.jclouds.View;
-import org.jclouds.rest.internal.BaseHttpApiMetadataTest;
-import org.testng.annotations.Test;
-
-import com.google.common.collect.ImmutableSet;
-import com.google.common.reflect.TypeToken;
-
-@Test(groups = "unit", testName = "TransientChefApiMetadataTest")
-public class TransientChefApiMetadataTest extends BaseHttpApiMetadataTest {
-
- // no config management abstraction, yet
- public TransientChefApiMetadataTest() {
- super(new TransientChefApiMetadata(), ImmutableSet.<TypeToken<? extends View>> of());
- }
-}
[05/50] [abbrv] jclouds git commit: JCLOUDS-285: Add name field in
CookbookDefinition domain
Posted by na...@apache.org.
JCLOUDS-285: Add name field in CookbookDefinition domain
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/996a4778
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/996a4778
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/996a4778
Branch: refs/heads/1.8.x
Commit: 996a47783a04051118b3e8c92554f32eab671de6
Parents: 18a3b77
Author: Noorul Islam K M <no...@noorul.com>
Authored: Tue Sep 17 23:03:50 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Thu Sep 19 15:13:25 2013 +0200
----------------------------------------------------------------------
.../jclouds/chef/domain/CookbookDefinition.java | 33 +++++++++++++++++---
.../ParseCookbookDefinitionFromJsonv10.java | 8 ++++-
.../ParseCookbookDefinitionListFromJsonv10.java | 17 ++++++++--
.../org/jclouds/chef/ChefApiExpectTest.java | 15 +++++++++
.../ParseCookbookDefinitionFromJsonv10Test.java | 2 +-
...seCookbookDefinitionListFromJsonv10Test.java | 6 ++--
.../chef/internal/BaseChefApiLiveTest.java | 14 +++++++++
apis/chef/src/test/resources/env_cookbooks.json | 20 ++++++++++++
8 files changed, 104 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/996a4778/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookDefinition.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookDefinition.java b/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookDefinition.java
index 6531f03..b2f071a 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookDefinition.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/domain/CookbookDefinition.java
@@ -38,9 +38,15 @@ public class CookbookDefinition {
}
public static class Builder {
+ private String name;
private URI url;
private ImmutableSet.Builder<Version> versions = ImmutableSet.builder();
+ public Builder name(String name) {
+ this.name = checkNotNull(name, "name");
+ return this;
+ }
+
public Builder url(URI url) {
this.url = checkNotNull(url, "url");
return this;
@@ -56,20 +62,33 @@ public class CookbookDefinition {
return this;
}
+ public Builder from(CookbookDefinition def) {
+ this.url = checkNotNull(def.getUrl(), "url");
+ this.versions.addAll(checkNotNull(def.getVersions(), "versions"));
+ this.name = def.getName();
+ return this;
+ }
+
public CookbookDefinition build() {
- return new CookbookDefinition(url, versions.build());
+ return new CookbookDefinition(name, url, versions.build());
}
}
+ private final String name;
private final URI url;
private final Set<Version> versions;
- @ConstructorProperties({ "url", "versions" })
- protected CookbookDefinition(URI url, @Nullable Set<Version> versions) {
+ @ConstructorProperties({"name", "url", "versions" })
+ protected CookbookDefinition(String name, URI url, @Nullable Set<Version> versions) {
+ this.name = name;
this.url = url;
this.versions = copyOfOrEmpty(versions);
}
+ public String getName() {
+ return name;
+ }
+
public URI getUrl() {
return url;
}
@@ -82,6 +101,7 @@ public class CookbookDefinition {
public int hashCode() {
final int prime = 31;
int result = 1;
+ result = prime * result + ((name == null) ? 0 : name.hashCode());
result = prime * result + ((url == null) ? 0 : url.hashCode());
result = prime * result + ((versions == null) ? 0 : versions.hashCode());
return result;
@@ -96,6 +116,11 @@ public class CookbookDefinition {
if (getClass() != obj.getClass())
return false;
CookbookDefinition other = (CookbookDefinition) obj;
+ if (name == null) {
+ if (other.name != null)
+ return false;
+ } else if (!name.equals(other.name))
+ return false;
if (url == null) {
if (other.url != null)
return false;
@@ -111,7 +136,7 @@ public class CookbookDefinition {
@Override
public String toString() {
- return "CookbookDefinition [url=" + url + ", versions=" + versions + "]";
+ return "CookbookDefinition [name=" + name + ", url=" + url + ", versions=" + versions + "]";
}
public static class Version {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/996a4778/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10.java
index 562a00a..80ba9af 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10.java
@@ -43,6 +43,12 @@ public class ParseCookbookDefinitionFromJsonv10 implements Function<HttpResponse
@Override
public CookbookDefinition apply(HttpResponse response) {
- return parser.apply(response).values().iterator().next();
+ Map<String, CookbookDefinition> result = parser.apply(response);
+ String cookbookName = result.keySet().iterator().next();
+ CookbookDefinition def = result.values().iterator().next();
+ return CookbookDefinition.builder() //
+ .from(def) //
+ .name(cookbookName) //
+ .build();
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/996a4778/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10.java b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10.java
index 311e44b..019ed0d 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10.java
@@ -17,7 +17,6 @@
package org.jclouds.chef.functions;
import com.google.common.base.Function;
-import com.google.common.collect.Sets;
import org.jclouds.chef.domain.CookbookDefinition;
import org.jclouds.http.HttpResponse;
import org.jclouds.http.functions.ParseJson;
@@ -27,6 +26,9 @@ import javax.inject.Singleton;
import java.util.Map;
import java.util.Set;
+import static com.google.common.collect.Iterables.transform;
+import static com.google.common.collect.Sets.newLinkedHashSet;
+
/**
* Parses the cookbook versions in a Chef Server >= 0.10.8.
*
@@ -47,6 +49,17 @@ public class ParseCookbookDefinitionListFromJsonv10 implements Function<HttpResp
@Override
public Set<CookbookDefinition> apply(HttpResponse response) {
- return Sets.newLinkedHashSet(parser.apply(response).values());
+ Set<Map.Entry<String, CookbookDefinition>> result = parser.apply(response).entrySet();
+ return newLinkedHashSet(transform(result, new Function<Map.Entry<String, CookbookDefinition>, CookbookDefinition>() {
+ @Override
+ public CookbookDefinition apply(Map.Entry<String, CookbookDefinition> input) {
+ String cookbookName = input.getKey();
+ CookbookDefinition def = input.getValue();
+ return CookbookDefinition.builder() //
+ .from(def) //
+ .name(cookbookName) //
+ .build();
+ }
+ }));
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/996a4778/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
index 7706609..65344ef 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
@@ -24,6 +24,7 @@ import java.util.Set;
import javax.ws.rs.core.MediaType;
import org.jclouds.chef.config.ChefHttpApiModule;
+import org.jclouds.chef.domain.CookbookDefinition;
import org.jclouds.date.TimeStamp;
import org.jclouds.http.HttpRequest;
import org.jclouds.http.HttpResponse;
@@ -156,6 +157,20 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
assertTrue(nodes.isEmpty(), String.format("Expected nodes to be empty but was: %s", nodes));
}
+ public void testListCookbooksInEnvironmentReturnsValidSet() {
+ ChefApi api = requestSendsResponse(
+ signed(HttpRequest.builder() //
+ .method("GET") //
+ .endpoint("http://localhost:4000/environments/dev/cookbooks") //
+ .addHeader("X-Chef-Version", ChefApiMetadata.DEFAULT_API_VERSION) //
+ .addHeader("Accept", MediaType.APPLICATION_JSON).build()), //
+ HttpResponse.builder().statusCode(200)
+ .payload(payloadFromResourceWithContentType("/env_cookbooks.json", MediaType.APPLICATION_JSON)) //
+ .build());
+ Set<CookbookDefinition> cookbooks = api.listCookbooksInEnvironment("dev");
+ assertEquals(cookbooks.size(), 2);
+ }
+
@Override
protected Module createModule() {
return new TestChefRestClientModule();
http://git-wip-us.apache.org/repos/asf/jclouds/blob/996a4778/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10Test.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10Test.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10Test.java
index 0df9d64..b5d8a8b 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10Test.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionFromJsonv10Test.java
@@ -58,7 +58,7 @@ public class ParseCookbookDefinitionFromJsonv10Test {
CookbookDefinition.Version v420 = CookbookDefinition.Version.builder()
.url(new URI("http://localhost:4000/cookbooks/apache2/4.2.0")).version("4.2.0").build();
CookbookDefinition definition = CookbookDefinition.builder()
- .url(new URI("http://localhost:4000/cookbooks/apache2")).version(v510).version(v420).build();
+ .name("apache2").url(new URI("http://localhost:4000/cookbooks/apache2")).version(v510).version(v420).build();
assertEquals(handler.apply(HttpResponse
.builder()
http://git-wip-us.apache.org/repos/asf/jclouds/blob/996a4778/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10Test.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10Test.java b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10Test.java
index b39343d..04f8e35 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10Test.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/functions/ParseCookbookDefinitionListFromJsonv10Test.java
@@ -59,14 +59,14 @@ public class ParseCookbookDefinitionListFromJsonv10Test {
CookbookDefinition.Version v420 = CookbookDefinition.Version.builder()
.url(new URI("http://localhost:4000/cookbooks/apache2/4.2.0")).version("4.2.0").build();
CookbookDefinition apache2 = CookbookDefinition.builder()
- .url(new URI("http://localhost:4000/cookbooks/apache2")).version(v510).version(v420).build();
+ .name("apache2").url(new URI("http://localhost:4000/cookbooks/apache2")).version(v510).version(v420).build();
CookbookDefinition.Version v100 = CookbookDefinition.Version.builder()
.url(new URI("http://localhost:4000/cookbooks/nginx/1.0.0")).version("1.0.0").build();
- CookbookDefinition.Version v130 = CookbookDefinition.Version.builder()
+ CookbookDefinition.Version v030 = CookbookDefinition.Version.builder()
.url(new URI("http://localhost:4000/cookbooks/nginx/0.3.0")).version("0.3.0").build();
CookbookDefinition nginx = CookbookDefinition.builder()
- .url(new URI("http://localhost:4000/cookbooks/nginx")).version(v100).version(v130).build();
+ .name("nginx").url(new URI("http://localhost:4000/cookbooks/nginx")).version(v100).version(v030).build();
assertEquals(handler.apply(HttpResponse
.builder()
http://git-wip-us.apache.org/repos/asf/jclouds/blob/996a4778/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
index a742bd1..6d5f075 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
@@ -39,6 +39,7 @@ import java.util.Set;
import org.jclouds.chef.ChefApi;
import org.jclouds.chef.domain.ChecksumStatus;
import org.jclouds.chef.domain.Client;
+import org.jclouds.chef.domain.CookbookDefinition;
import org.jclouds.chef.domain.CookbookVersion;
import org.jclouds.chef.domain.DatabagItem;
import org.jclouds.chef.domain.Environment;
@@ -64,6 +65,9 @@ import com.google.common.collect.ImmutableSet;
import com.google.common.io.Closeables;
import com.google.common.primitives.Bytes;
+import static com.google.common.collect.Iterables.any;
+import static com.google.common.collect.Iterables.all;
+
/**
* Tests behavior of {@code ChefApi}
*
@@ -483,6 +487,16 @@ public abstract class BaseChefApiLiveTest<A extends ChefApi> extends BaseChefLiv
assertTrue(!nodeList.isEmpty());
}
+ @Test(dependsOnMethods = "testCreateNewCookbook")
+ public void testListCookbooksInEnvironment() throws Exception {
+ Set<CookbookDefinition> cookbooks = api.listCookbooksInEnvironment("_default");
+ assertTrue(any(cookbooks, new Predicate<CookbookDefinition>() {
+ @Override
+ public boolean apply(CookbookDefinition input) {
+ return PREFIX.equals(input.getName());
+ }}), String.format("Cookbook %s not in %s", PREFIX, cookbooks));
+ }
+
@AfterClass(groups = { "live", "integration" })
@Override
public void tearDown() {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/996a4778/apis/chef/src/test/resources/env_cookbooks.json
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/resources/env_cookbooks.json b/apis/chef/src/test/resources/env_cookbooks.json
new file mode 100644
index 0000000..ee7114f
--- /dev/null
+++ b/apis/chef/src/test/resources/env_cookbooks.json
@@ -0,0 +1,20 @@
+{
+ "apache2" => {
+ "url" => "http://localhost:4000/cookbooks/apache2",
+ "versions" => [
+ {"url" => "http://localhost:4000/cookbooks/apache2/5.1.0",
+ "version" => "5.1.0"},
+ {"url" => "http://localhost:4000/cookbooks/apache2/4.2.0",
+ "version" => "4.2.0"}
+ ]
+ },
+ "nginx" => {
+ "url" => "http://localhost:4000/cookbooks/nginx",
+ "versions" => [
+ {"url" => "http://localhost:4000/cookbooks/nginx/1.0.0",
+ "version" => "1.0.0"},
+ {"url" => "http://localhost:4000/cookbooks/nginx/0.3.0",
+ "version" => "0.3.0"}
+ ]
+ }
+}
[12/50] [abbrv] jclouds git commit: JCLOUDS-272: Migrate list roles,
cookbooks and databags tests from ChefApiTest to ChefApiExpectTest.
Posted by na...@apache.org.
JCLOUDS-272: Migrate list roles, cookbooks and databags tests from ChefApiTest to ChefApiExpectTest.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/c1ff33d1
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/c1ff33d1
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/c1ff33d1
Branch: refs/heads/1.8.x
Commit: c1ff33d1b9d03025f83b0437d77c3d5c8b685b40
Parents: 8f20547
Author: Noorul Islam K M <no...@noorul.com>
Authored: Sun Oct 13 11:48:28 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Tue Oct 15 23:09:23 2013 +0200
----------------------------------------------------------------------
.../org/jclouds/chef/ChefApiExpectTest.java | 57 ++++++++++++++++++++
.../test/java/org/jclouds/chef/ChefApiTest.java | 51 ------------------
apis/chef/src/test/resources/data_list.json | 4 ++
apis/chef/src/test/resources/roles_list.json | 4 ++
4 files changed, 65 insertions(+), 51 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/c1ff33d1/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
index 90e99da..4417f0d 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
@@ -133,6 +133,25 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
assertTrue(nodes.isEmpty(), String.format("Expected nodes to be empty but was: %s", nodes));
}
+ public void testListCookbooksReturnsValidSet() {
+ ChefApi api = requestSendsResponse(
+ signed(getHttpRequestBuilder("GET", "/cookbooks").build()),
+ HttpResponse.builder().statusCode(200)
+ .payload(payloadFromResourceWithContentType("/env_cookbooks.json", MediaType.APPLICATION_JSON)) //
+ .build());
+ Set<String> cookbooks = api.listCookbooks();
+ assertEquals(cookbooks.size(), 2);
+ assertTrue(cookbooks.contains("apache2"), String.format("Expected cookbooks to contain 'apache2' but was: %s", cookbooks));
+ }
+
+ public void testListCookbooksReturnsEmptySetOn404() {
+ ChefApi api = requestSendsResponse(
+ signed(getHttpRequestBuilder("GET", "/cookbooks").build()),
+ HttpResponse.builder().statusCode(404).build());
+ Set<String> cookbooks = api.listCookbooks();
+ assertTrue(cookbooks.isEmpty(), String.format("Expected cookbooks to be empty but was: %s", cookbooks));
+ }
+
public void testListCookbooksInEnvironmentReturnsValidSet() {
ChefApi api = requestSendsResponse(
signed(getHttpRequestBuilder("GET", "/environments/dev/cookbooks").build()),
@@ -203,6 +222,44 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
assertTrue(result.isEmpty(), String.format("Expected search result to be empty but was: %s", result));
}
+ public void testListRolesReturnsValidSet() {
+ ChefApi api = requestSendsResponse(
+ signed(getHttpRequestBuilder("GET", "/roles").build()),
+ HttpResponse.builder().statusCode(200)
+ .payload(payloadFromResourceWithContentType("/roles_list.json", MediaType.APPLICATION_JSON)) //
+ .build());
+ Set<String> roles = api.listRoles();
+ assertEquals(roles.size(), 2);
+ assertTrue(roles.contains("webserver"), String.format("Expected roles to contain 'websever' but was: %s", roles));
+ }
+
+ public void testListRolesReturnsEmptySetOn404() {
+ ChefApi api = requestSendsResponse(
+ signed(getHttpRequestBuilder("GET", "/roles").build()),
+ HttpResponse.builder().statusCode(404).build());
+ Set<String> roles = api.listRoles();
+ assertTrue(roles.isEmpty(), String.format("Expected roles to be empty but was: %s", roles));
+ }
+
+ public void testListDatabagsReturnsValidSet() {
+ ChefApi api = requestSendsResponse(
+ signed(getHttpRequestBuilder("GET", "/data").build()),
+ HttpResponse.builder().statusCode(200)
+ .payload(payloadFromResourceWithContentType("/data_list.json", MediaType.APPLICATION_JSON)) //
+ .build());
+ Set<String> databags = api.listDatabags();
+ assertEquals(databags.size(), 2);
+ assertTrue(databags.contains("applications"), String.format("Expected databags to contain 'applications' but was: %s", databags));
+ }
+
+ public void testListDatabagsReturnsEmptySetOn404() {
+ ChefApi api = requestSendsResponse(
+ signed(getHttpRequestBuilder("GET", "/data").build()),
+ HttpResponse.builder().statusCode(404).build());
+ Set<String> databags = api.listDatabags();
+ assertTrue(databags.isEmpty(), String.format("Expected databags to be empty but was: %s", databags));
+ }
+
@Override
protected Module createModule() {
return new TestChefRestClientModule();
http://git-wip-us.apache.org/repos/asf/jclouds/blob/c1ff33d1/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
index 05eca4b..28df35f 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
@@ -192,23 +192,6 @@ public class ChefApiTest extends BaseAsyncApiTest<ChefApi> {
}
- public void testListCookbooks() throws SecurityException, NoSuchMethodException, IOException {
- Invokable<?, ?> method = method(ChefApi.class, "listCookbooks");
- GeneratedHttpRequest httpRequest = processor.apply(Invocation.create(method, ImmutableList.of()));
-
- assertRequestLineEquals(httpRequest, "GET http://localhost:4000/cookbooks HTTP/1.1");
- assertNonPayloadHeadersEqual(httpRequest, "Accept: application/json\nX-Chef-Version: " + ChefApiMetadata.DEFAULT_API_VERSION
- + "-test\n");
- assertPayloadEquals(httpRequest, null, null, false);
-
- assertResponseParserClassEquals(method, httpRequest, ParseCookbookDefinitionCheckingChefVersion.class);
- assertSaxResponseParserClassEquals(method, null);
- assertFallbackClassEquals(method, EmptySetOnNotFoundOr404.class);
-
- checkFilters(httpRequest);
-
- }
-
public void testListVersionsOfCookbook() throws SecurityException, NoSuchMethodException, IOException {
Invokable<?, ?> method = method(ChefApi.class, "listVersionsOfCookbook", String.class);
GeneratedHttpRequest httpRequest = processor
@@ -414,23 +397,6 @@ public class ChefApiTest extends BaseAsyncApiTest<ChefApi> {
}
- public void testListRoles() throws SecurityException, NoSuchMethodException, IOException {
- Invokable<?, ?> method = method(ChefApi.class, "listRoles");
- GeneratedHttpRequest httpRequest = processor.apply(Invocation.create(method, ImmutableList.of()));
-
- assertRequestLineEquals(httpRequest, "GET http://localhost:4000/roles HTTP/1.1");
- assertNonPayloadHeadersEqual(httpRequest, "Accept: application/json\nX-Chef-Version: " + ChefApiMetadata.DEFAULT_API_VERSION
- + "-test\n");
- assertPayloadEquals(httpRequest, null, null, false);
-
- assertResponseParserClassEquals(method, httpRequest, ParseKeySetFromJson.class);
- assertSaxResponseParserClassEquals(method, null);
- assertFallbackClassEquals(method, EmptySetOnNotFoundOr404.class);
-
- checkFilters(httpRequest);
-
- }
-
public void testDeleteDatabag() throws SecurityException, NoSuchMethodException, IOException {
Invokable<?, ?> method = method(ChefApi.class, "deleteDatabag", String.class);
GeneratedHttpRequest httpRequest = processor
@@ -465,23 +431,6 @@ public class ChefApiTest extends BaseAsyncApiTest<ChefApi> {
}
- public void testListDatabags() throws SecurityException, NoSuchMethodException, IOException {
- Invokable<?, ?> method = method(ChefApi.class, "listDatabags");
- GeneratedHttpRequest httpRequest = processor.apply(Invocation.create(method, ImmutableList.of()));
-
- assertRequestLineEquals(httpRequest, "GET http://localhost:4000/data HTTP/1.1");
- assertNonPayloadHeadersEqual(httpRequest, "Accept: application/json\nX-Chef-Version: " + ChefApiMetadata.DEFAULT_API_VERSION
- + "-test\n");
- assertPayloadEquals(httpRequest, null, null, false);
-
- assertResponseParserClassEquals(method, httpRequest, ParseKeySetFromJson.class);
- assertSaxResponseParserClassEquals(method, null);
- assertFallbackClassEquals(method, EmptySetOnNotFoundOr404.class);
-
- checkFilters(httpRequest);
-
- }
-
public void testDeleteDatabagItem() throws SecurityException, NoSuchMethodException, IOException {
Invokable<?, ?> method = method(ChefApi.class, "deleteDatabagItem", String.class, String.class);
GeneratedHttpRequest httpRequest = processor.apply(Invocation.create(method,
http://git-wip-us.apache.org/repos/asf/jclouds/blob/c1ff33d1/apis/chef/src/test/resources/data_list.json
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/resources/data_list.json b/apis/chef/src/test/resources/data_list.json
new file mode 100644
index 0000000..de9205d
--- /dev/null
+++ b/apis/chef/src/test/resources/data_list.json
@@ -0,0 +1,4 @@
+{
+ "users": "http://localhost:4000/data/users",
+ "applications": "http://localhost:4000/data/applications"
+}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/c1ff33d1/apis/chef/src/test/resources/roles_list.json
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/resources/roles_list.json b/apis/chef/src/test/resources/roles_list.json
new file mode 100644
index 0000000..1f75bc1
--- /dev/null
+++ b/apis/chef/src/test/resources/roles_list.json
@@ -0,0 +1,4 @@
+{
+ "webserver": "http://localhost:4000/roles/webserver",
+ "smtpserver": "http://localhost:4000/roles/smtpserver"
+}
[28/50] [abbrv] jclouds git commit: Remove unused imports to make
checkstyle happy
Posted by na...@apache.org.
Remove unused imports to make checkstyle happy
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/d082995c
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/d082995c
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/d082995c
Branch: refs/heads/1.8.x
Commit: d082995cf7166645a044b2163fa3989a208ce011
Parents: cd0f21d
Author: Ignasi Barrera <na...@apache.org>
Authored: Tue Jul 1 16:20:01 2014 +0200
Committer: Ignasi Barrera <na...@apache.org>
Committed: Wed Jul 2 17:54:33 2014 +0200
----------------------------------------------------------------------
.../java/org/jclouds/chef/filters/SignedHeaderAuth.java | 1 -
apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java | 1 -
.../ListCookbookVersionsInEnvironmentImplLiveTest.java | 10 +++-------
3 files changed, 3 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d082995c/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java b/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
index 0cab71f..7d789bb 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/filters/SignedHeaderAuth.java
@@ -52,7 +52,6 @@ import org.jclouds.logging.Logger;
import org.jclouds.util.Strings2;
import com.google.common.annotations.VisibleForTesting;
-import com.google.common.base.Preconditions;
import com.google.common.base.Predicate;
import com.google.common.base.Splitter;
import com.google.common.base.Supplier;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d082995c/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
index 98eeb0b..434c22c 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
@@ -39,7 +39,6 @@ import org.jclouds.chef.domain.Resource;
import org.jclouds.chef.domain.Role;
import org.jclouds.chef.filters.SignedHeaderAuth;
import org.jclouds.chef.filters.SignedHeaderAuthTest;
-import org.jclouds.chef.functions.ParseCookbookDefinitionCheckingChefVersion;
import org.jclouds.chef.functions.ParseCookbookVersionsCheckingChefVersion;
import org.jclouds.chef.functions.ParseKeySetFromJson;
import org.jclouds.chef.functions.ParseSearchClientsFromJson;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/d082995c/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
index 76ecee8..a9b667d 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
@@ -17,14 +17,14 @@
package org.jclouds.chef.strategy.internal;
import static com.google.common.collect.Iterables.size;
-import static org.testng.Assert.assertEquals;
-import static org.testng.Assert.assertNotNull;
import static org.testng.Assert.assertTrue;
import static org.testng.Assert.fail;
+import java.io.File;
+import java.util.List;
+
import org.jclouds.chef.ChefApi;
import org.jclouds.chef.domain.ChecksumStatus;
-import org.jclouds.chef.domain.CookbookDefinition;
import org.jclouds.chef.domain.CookbookVersion;
import org.jclouds.chef.domain.Metadata;
import org.jclouds.chef.domain.Resource;
@@ -36,10 +36,6 @@ import org.jclouds.io.payloads.FilePayload;
import org.testng.annotations.AfterClass;
import org.testng.annotations.Test;
-import java.io.File;
-import java.util.List;
-
-import com.google.common.base.Predicate;
import com.google.common.collect.ImmutableSet;
import com.google.common.hash.Hashing;
import com.google.common.io.Files;
[09/50] [abbrv] jclouds git commit: Rename test method names to
reflect what is being tested.
Posted by na...@apache.org.
Rename test method names to reflect what is being tested.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/223540a4
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/223540a4
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/223540a4
Branch: refs/heads/1.8.x
Commit: 223540a48c6116041a264ba2244814b6e002f27f
Parents: 373f9ea
Author: Noorul Islam K M <no...@noorul.com>
Authored: Fri Sep 20 06:52:48 2013 +0530
Committer: Ignasi Barrera <na...@apache.org>
Committed: Fri Sep 20 09:31:20 2013 +0200
----------------------------------------------------------------------
.../java/org/jclouds/chef/ChefApiExpectTest.java | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/223540a4/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
index 3a7bae4..c3a9372 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiExpectTest.java
@@ -53,7 +53,7 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
.addHeader("Accept", MediaType.APPLICATION_JSON);
}
- public void testListClientsReturns2xx() {
+ public void testListClientsReturnsValidSet() {
ChefApi api = requestSendsResponse(
signed(getHttpRequestBuilder("GET", "/clients").build()),
HttpResponse.builder().statusCode(200) //
@@ -64,7 +64,7 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
assertTrue(nodes.contains("adam"), String.format("Expected nodes to contain 'adam' but was: %s", nodes));
}
- public void testListClientsReturns404() {
+ public void testListClientsReturnsEmptySetOn404() {
ChefApi api = requestSendsResponse(
signed(getHttpRequestBuilder("GET", "/clients").build()),
HttpResponse.builder().statusCode(404)
@@ -73,7 +73,7 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
assertTrue(clients.isEmpty(), String.format("Expected clients to be empty but was: %s", clients));
}
- public void testListNodesReturns2xx() {
+ public void testListNodesReturnsValidSet() {
ChefApi api = requestSendsResponse(
signed(getHttpRequestBuilder("GET", "/nodes").build()),
HttpResponse.builder().statusCode(200)
@@ -84,7 +84,7 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
assertTrue(nodes.contains("blah"), String.format("Expected nodes to contain 'blah' but was: %s", nodes));
}
- public void testListNodesReturns404() {
+ public void testListNodesReturnsEmptySetOn404() {
ChefApi api = requestSendsResponse(
signed(getHttpRequestBuilder("GET", "/nodes").build()),
HttpResponse.builder().statusCode(404).build());
@@ -92,7 +92,7 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
assertTrue(nodes.isEmpty(), String.format("Expected nodes to be empty but was: %s", nodes));
}
- public void testListRecipesInEnvironmentReturns2xx() {
+ public void testListRecipesInEnvironmentReturnsValidSet() {
ChefApi api = requestSendsResponse(
signed(getHttpRequestBuilder("GET", "/environments/dev/recipes").build()),
HttpResponse.builder().statusCode(200)
@@ -103,7 +103,7 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
assertTrue(recipes.contains("apache2"), String.format("Expected recipes to contain 'apache2' but was: %s", recipes));
}
- public void testListRecipesInEnvironmentReturns404() {
+ public void testListRecipesInEnvironmentReturnsEmptySetOn404() {
ChefApi api = requestSendsResponse(
signed(getHttpRequestBuilder("GET", "/environments/dev/recipes").build()),
HttpResponse.builder().statusCode(404).build());
@@ -111,7 +111,7 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
assertTrue(recipes.isEmpty(), String.format("Expected recipes to be empty but was: %s", recipes));
}
- public void testListNodesInEnvironmentReturns2xx() {
+ public void testListNodesInEnvironmentReturnsValidSet() {
ChefApi api = requestSendsResponse(
signed(getHttpRequestBuilder("GET", "/environments/dev/nodes").build()),
HttpResponse.builder().statusCode(200)
@@ -122,7 +122,7 @@ public class ChefApiExpectTest extends BaseChefApiExpectTest<ChefApi> {
assertTrue(nodes.contains("blah"), String.format("Expected nodes to contain 'blah' but was: %s", nodes));
}
- public void testListNodesInEnvironmentReturns404() {
+ public void testListNodesInEnvironmentReturnsEmptySetOn404() {
ChefApi api = requestSendsResponse(
signed(getHttpRequestBuilder("GET", "/environments/dev/nodes").build()),
HttpResponse.builder().statusCode(404).build());
[17/50] [abbrv] jclouds git commit: JCLOUDS-368: Remove methods which
are not exposed to public and hence not used.
Posted by na...@apache.org.
JCLOUDS-368: Remove methods which are not exposed to public and hence not used.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/0ae9519a
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/0ae9519a
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/0ae9519a
Branch: refs/heads/1.8.x
Commit: 0ae9519ac01b5981999e8c49f6326906d834640f
Parents: 89a2b8a
Author: Noorul Islam K M <no...@noorul.com>
Authored: Fri Nov 1 08:20:37 2013 +0530
Committer: Andrew Phillips <an...@apache.org>
Committed: Wed Nov 6 18:03:18 2013 -0500
----------------------------------------------------------------------
.../org/jclouds/chef/strategy/ListClients.java | 10 ------
.../chef/strategy/ListCookbookVersions.java | 10 ------
.../jclouds/chef/strategy/ListEnvironments.java | 9 -----
.../org/jclouds/chef/strategy/ListNodes.java | 10 ------
.../chef/strategy/ListNodesInEnvironment.java | 10 ------
.../CleanupStaleNodesAndClientsImpl.java | 37 ++++++++++----------
.../chef/strategy/internal/ListClientsImpl.java | 21 +----------
.../internal/ListCookbookVersionsImpl.java | 24 ++-----------
.../strategy/internal/ListEnvironmentsImpl.java | 21 +----------
.../chef/strategy/internal/ListNodesImpl.java | 21 +----------
.../internal/ListNodesInEnvironmentImpl.java | 21 +----------
.../internal/ListNodesImplLiveTest.java | 20 -----------
.../ListNodesInEnvironmentImplLiveTest.java | 20 -----------
13 files changed, 24 insertions(+), 210 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
index 18b7c13..5d6b8a0 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListClients.java
@@ -19,13 +19,11 @@ package org.jclouds.chef.strategy;
import org.jclouds.chef.domain.Client;
import org.jclouds.chef.strategy.internal.ListClientsImpl;
-import com.google.common.base.Predicate;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.ImplementedBy;
/**
*
- *
* @author Adrian Cole
*/
@ImplementedBy(ListClientsImpl.class)
@@ -33,13 +31,5 @@ public interface ListClients {
Iterable<? extends Client> execute();
- Iterable<? extends Client> execute(Predicate<String> clientNameSelector);
-
- Iterable<? extends Client> execute(Iterable<String> toGet);
-
Iterable<? extends Client> execute(ListeningExecutorService executor);
-
- Iterable<? extends Client> execute(ListeningExecutorService executor, Predicate<String> clientNameSelector);
-
- Iterable<? extends Client> execute(ListeningExecutorService executor, Iterable<String> toGet);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
index 5987de0..01bcd33 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersions.java
@@ -19,13 +19,11 @@ package org.jclouds.chef.strategy;
import org.jclouds.chef.domain.CookbookVersion;
import org.jclouds.chef.strategy.internal.ListCookbookVersionsImpl;
-import com.google.common.base.Predicate;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.ImplementedBy;
/**
*
- *
* @author Adrian Cole
*/
@ImplementedBy(ListCookbookVersionsImpl.class)
@@ -33,13 +31,5 @@ public interface ListCookbookVersions {
Iterable<? extends CookbookVersion> execute();
- Iterable<? extends CookbookVersion> execute(Predicate<String> cookbookNameSelector);
-
- Iterable<? extends CookbookVersion> execute(Iterable<String> cookbookNames);
-
Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor);
-
- Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, Predicate<String> cookbookNameSelector);
-
- Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor, Iterable<String> cookbookNames);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java
index 6dc4aa3..3e5b11f 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListEnvironments.java
@@ -19,7 +19,6 @@ package org.jclouds.chef.strategy;
import org.jclouds.chef.domain.Environment;
import org.jclouds.chef.strategy.internal.ListEnvironmentsImpl;
-import com.google.common.base.Predicate;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.ImplementedBy;
@@ -28,13 +27,5 @@ public interface ListEnvironments {
Iterable<? extends Environment> execute();
- Iterable<? extends Environment> execute(Predicate<String> environmentNameSelector);
-
- Iterable<? extends Environment> execute(Iterable<String> toGet);
-
Iterable<? extends Environment> execute(ListeningExecutorService executor);
-
- Iterable<? extends Environment> execute(ListeningExecutorService executor, Predicate<String> environmentNameSelector);
-
- Iterable<? extends Environment> execute(ListeningExecutorService executor, Iterable<String> toGet);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
index 8790456..92b451b 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodes.java
@@ -19,13 +19,11 @@ package org.jclouds.chef.strategy;
import org.jclouds.chef.domain.Node;
import org.jclouds.chef.strategy.internal.ListNodesImpl;
-import com.google.common.base.Predicate;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.ImplementedBy;
/**
*
- *
* @author Adrian Cole
*/
@ImplementedBy(ListNodesImpl.class)
@@ -33,13 +31,5 @@ public interface ListNodes {
Iterable<? extends Node> execute();
- Iterable<? extends Node> execute(Predicate<String> nodeNameSelector);
-
- Iterable<? extends Node> execute(Iterable<String> toGet);
-
Iterable<? extends Node> execute(ListeningExecutorService executor);
-
- Iterable<? extends Node> execute(ListeningExecutorService executor, Predicate<String> nodeNameSelector);
-
- Iterable<? extends Node> execute(ListeningExecutorService executor, Iterable<String> toGet);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
index 9f6b324..6308747 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListNodesInEnvironment.java
@@ -19,13 +19,11 @@ package org.jclouds.chef.strategy;
import org.jclouds.chef.domain.Node;
import org.jclouds.chef.strategy.internal.ListNodesInEnvironmentImpl;
-import com.google.common.base.Predicate;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.ImplementedBy;
/**
*
- *
* @author Noorul Islam K M
*/
@ImplementedBy(ListNodesInEnvironmentImpl.class)
@@ -33,13 +31,5 @@ public interface ListNodesInEnvironment {
Iterable<? extends Node> execute(String environmentName);
- Iterable<? extends Node> execute(String environmentName, Predicate<String> nodeNameSelector);
-
- Iterable<? extends Node> execute(String environmentName, Iterable<String> toGet);
-
Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName);
-
- Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Predicate<String> nodeNameSelector);
-
- Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Iterable<String> toGet);
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImpl.java
index a3ef7c2..a9dbaa8 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/CleanupStaleNodesAndClientsImpl.java
@@ -72,25 +72,24 @@ public class CleanupStaleNodesAndClientsImpl implements CleanupStaleNodesAndClie
final Calendar expired = Calendar.getInstance();
expired.setTime(new Date());
expired.add(Calendar.SECOND, -secondsStale);
- Iterable<? extends Node> staleNodes = filter(nodeLister.execute(new Predicate<String>() {
-
- @Override
- public boolean apply(String input) {
- return input.startsWith(prefix);
- }
-
- }), and(notNull(), new Predicate<Node>() {
- @Override
- public boolean apply(Node input) {
- JsonBall dateLong = input.getAutomaticAttributes().get("ohai_time");
- if (dateLong == null)
- return true;
- Calendar nodeUpdate = Calendar.getInstance();
- nodeUpdate.setTime(fromOhaiTime(dateLong));
- return expired.after(nodeUpdate);
- }
-
- }));
+ Iterable<? extends Node> staleNodes = filter(
+ nodeLister.execute(), and(notNull(), new Predicate<Node>() {
+ @Override
+ public boolean apply(Node input) {
+ return input.getName().startsWith(prefix);
+ }
+ },
+ new Predicate<Node>() {
+ @Override
+ public boolean apply(Node input) {
+ JsonBall dateLong = input.getAutomaticAttributes().get("ohai_time");
+ if (dateLong == null)
+ return true;
+ Calendar nodeUpdate = Calendar.getInstance();
+ nodeUpdate.setTime(fromOhaiTime(dateLong));
+ return expired.after(nodeUpdate);
+ }
+ }));
Iterable<String> nodeNames = transform(staleNodes, new Function<Node, String>() {
@Override
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java
index 70e6a2a..63c2484 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListClientsImpl.java
@@ -17,7 +17,6 @@
package org.jclouds.chef.strategy.internal;
import static com.google.common.base.Preconditions.checkNotNull;
-import static com.google.common.collect.Iterables.filter;
import static com.google.common.collect.Iterables.transform;
import static com.google.common.util.concurrent.Futures.allAsList;
import static com.google.common.util.concurrent.Futures.getUnchecked;
@@ -38,14 +37,12 @@ import org.jclouds.logging.Logger;
import com.google.common.base.Function;
import com.google.common.base.Joiner;
-import com.google.common.base.Predicate;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
/**
*
- *
* @author Adrian Cole
*/
@Singleton
@@ -69,27 +66,11 @@ public class ListClientsImpl implements ListClients {
}
@Override
- public Iterable<? extends Client> execute(Predicate<String> clientNameSelector) {
- return execute(userExecutor, clientNameSelector);
- }
-
- @Override
- public Iterable<? extends Client> execute(Iterable<String> toGet) {
- return execute(userExecutor, toGet);
- }
-
- @Override
public Iterable<? extends Client> execute(ListeningExecutorService executor) {
return execute(executor, api.listClients());
}
- @Override
- public Iterable<? extends Client> execute(ListeningExecutorService executor, Predicate<String> clientNameSelector) {
- return execute(executor, filter(api.listClients(), clientNameSelector));
- }
-
- @Override
- public Iterable<? extends Client> execute(final ListeningExecutorService executor, Iterable<String> toGet) {
+ private Iterable<? extends Client> execute(final ListeningExecutorService executor, Iterable<String> toGet) {
ListenableFuture<List<Client>> futures = allAsList(transform(toGet,
new Function<String, ListenableFuture<Client>>() {
@Override
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java
index 3bf77a6..cdd71c4 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsImpl.java
@@ -18,7 +18,6 @@ package org.jclouds.chef.strategy.internal;
import static com.google.common.base.Preconditions.checkNotNull;
import static com.google.common.collect.Iterables.concat;
-import static com.google.common.collect.Iterables.filter;
import static com.google.common.collect.Iterables.transform;
import static com.google.common.util.concurrent.Futures.allAsList;
import static com.google.common.util.concurrent.Futures.getUnchecked;
@@ -39,14 +38,12 @@ import org.jclouds.chef.strategy.ListCookbookVersions;
import org.jclouds.logging.Logger;
import com.google.common.base.Function;
-import com.google.common.base.Predicate;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
/**
*
- *
* @author Adrian Cole
*/
@Singleton
@@ -70,28 +67,11 @@ public class ListCookbookVersionsImpl implements ListCookbookVersions {
}
@Override
- public Iterable<? extends CookbookVersion> execute(Predicate<String> cookbookNameSelector) {
- return execute(userExecutor, cookbookNameSelector);
- }
-
- @Override
- public Iterable<? extends CookbookVersion> execute(Iterable<String> toGet) {
- return execute(userExecutor, toGet);
- }
-
- @Override
public Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor) {
return execute(executor, api.listCookbooks());
}
- @Override
- public Iterable<? extends CookbookVersion> execute(ListeningExecutorService executor,
- Predicate<String> cookbookNameSelector) {
- return execute(executor, filter(api.listCookbooks(), cookbookNameSelector));
- }
-
- @Override
- public Iterable<? extends CookbookVersion> execute(final ListeningExecutorService executor,
+ private Iterable<? extends CookbookVersion> execute(final ListeningExecutorService executor,
Iterable<String> cookbookNames) {
return concat(transform(cookbookNames, new Function<String, Iterable<? extends CookbookVersion>>() {
@@ -112,7 +92,7 @@ public class ListCookbookVersionsImpl implements ListCookbookVersions {
}
}));
- logger.trace(String.format("getting versions of cookbook: " + cookbook));
+ logger.trace(String.format("getting versions of cookbook: %s", cookbook));
return getUnchecked(futures);
}
}));
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentsImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentsImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentsImpl.java
index 6429b72..9b79de2 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentsImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListEnvironmentsImpl.java
@@ -17,7 +17,6 @@
package org.jclouds.chef.strategy.internal;
import static com.google.common.base.Preconditions.checkNotNull;
-import static com.google.common.collect.Iterables.filter;
import static com.google.common.collect.Iterables.transform;
import static com.google.common.util.concurrent.Futures.allAsList;
import static com.google.common.util.concurrent.Futures.getUnchecked;
@@ -38,7 +37,6 @@ import org.jclouds.logging.Logger;
import com.google.common.base.Function;
import com.google.common.base.Joiner;
-import com.google.common.base.Predicate;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
@@ -64,28 +62,11 @@ public class ListEnvironmentsImpl implements ListEnvironments {
}
@Override
- public Iterable<? extends Environment> execute(Predicate<String> environmentNameSelector) {
- return execute(userExecutor, environmentNameSelector);
- }
-
- @Override
- public Iterable<? extends Environment> execute(Iterable<String> toGet) {
- return execute(userExecutor, toGet);
- }
-
- @Override
public Iterable<? extends Environment> execute(ListeningExecutorService executor) {
return execute(executor, api.listEnvironments());
}
- @Override
- public Iterable<? extends Environment> execute(ListeningExecutorService executor,
- Predicate<String> environmentNameSelector) {
- return execute(executor, filter(api.listEnvironments(), environmentNameSelector));
- }
-
- @Override
- public Iterable<? extends Environment> execute(final ListeningExecutorService executor, Iterable<String> toGet) {
+ private Iterable<? extends Environment> execute(final ListeningExecutorService executor, Iterable<String> toGet) {
ListenableFuture<List<Environment>> futures = allAsList(transform(toGet,
new Function<String, ListenableFuture<Environment>>() {
@Override
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java
index 7547f6b..3af264b 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesImpl.java
@@ -17,7 +17,6 @@
package org.jclouds.chef.strategy.internal;
import static com.google.common.base.Preconditions.checkNotNull;
-import static com.google.common.collect.Iterables.filter;
import static com.google.common.collect.Iterables.transform;
import static com.google.common.util.concurrent.Futures.allAsList;
import static com.google.common.util.concurrent.Futures.getUnchecked;
@@ -38,14 +37,12 @@ import org.jclouds.logging.Logger;
import com.google.common.base.Function;
import com.google.common.base.Joiner;
-import com.google.common.base.Predicate;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
/**
*
- *
* @author Adrian Cole
*/
@Singleton
@@ -69,27 +66,11 @@ public class ListNodesImpl implements ListNodes {
}
@Override
- public Iterable<? extends Node> execute(Predicate<String> nodeNameSelector) {
- return execute(userExecutor, nodeNameSelector);
- }
-
- @Override
- public Iterable<? extends Node> execute(Iterable<String> toGet) {
- return execute(userExecutor, toGet);
- }
-
- @Override
public Iterable<? extends Node> execute(ListeningExecutorService executor) {
return execute(executor, api.listNodes());
}
- @Override
- public Iterable<? extends Node> execute(ListeningExecutorService executor, Predicate<String> nodeNameSelector) {
- return execute(executor, filter(api.listNodes(), nodeNameSelector));
- }
-
- @Override
- public Iterable<? extends Node> execute(final ListeningExecutorService executor, Iterable<String> toGet) {
+ private Iterable<? extends Node> execute(final ListeningExecutorService executor, Iterable<String> toGet) {
ListenableFuture<List<Node>> futures = allAsList(transform(toGet, new Function<String, ListenableFuture<Node>>() {
@Override
public ListenableFuture<Node> apply(final String input) {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
index c430b95..a2b2244 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImpl.java
@@ -17,7 +17,6 @@
package org.jclouds.chef.strategy.internal;
import static com.google.common.base.Preconditions.checkNotNull;
-import static com.google.common.collect.Iterables.filter;
import static com.google.common.collect.Iterables.transform;
import static com.google.common.util.concurrent.Futures.allAsList;
import static com.google.common.util.concurrent.Futures.getUnchecked;
@@ -38,14 +37,12 @@ import org.jclouds.logging.Logger;
import com.google.common.base.Function;
import com.google.common.base.Joiner;
-import com.google.common.base.Predicate;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
/**
*
- *
* @author Noorul Islam K M
*/
@Singleton
@@ -69,27 +66,11 @@ public class ListNodesInEnvironmentImpl implements ListNodesInEnvironment {
}
@Override
- public Iterable<? extends Node> execute(String environmentName, Predicate<String> nodeNameSelector) {
- return execute(userExecutor, environmentName, nodeNameSelector);
- }
-
- @Override
- public Iterable<? extends Node> execute(String environmentName, Iterable<String> toGet) {
- return execute(userExecutor, environmentName, toGet);
- }
-
- @Override
public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName) {
return execute(executor, environmentName, api.listNodesInEnvironment(environmentName));
}
- @Override
- public Iterable<? extends Node> execute(ListeningExecutorService executor, String environmentName, Predicate<String> nodeNameSelector) {
- return execute(executor, environmentName, filter(api.listNodesInEnvironment(environmentName), nodeNameSelector));
- }
-
- @Override
- public Iterable<? extends Node> execute(final ListeningExecutorService executor, String environmentName, Iterable<String> toGet) {
+ private Iterable<? extends Node> execute(final ListeningExecutorService executor, String environmentName, Iterable<String> toGet) {
ListenableFuture<List<Node>> futures = allAsList(transform(toGet, new Function<String, ListenableFuture<Node>>() {
@Override
public ListenableFuture<Node> apply(final String input) {
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
index 80b9678..f4c7ed1 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesImplLiveTest.java
@@ -17,7 +17,6 @@
package org.jclouds.chef.strategy.internal;
import static com.google.common.collect.Iterables.size;
-import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;
import org.jclouds.chef.ChefApi;
@@ -25,7 +24,6 @@ import org.jclouds.chef.internal.BaseChefLiveTest;
import org.testng.annotations.AfterClass;
import org.testng.annotations.Test;
-import com.google.common.base.Predicate;
import com.google.common.collect.ImmutableSet;
/**
@@ -60,22 +58,4 @@ public class ListNodesImplLiveTest extends BaseChefLiveTest<ChefApi> {
public void testExecute() {
assertTrue(size(strategy.execute()) > 0, "Expected one or more elements");
}
-
- @Test
- public void testExecutePredicateOfString() {
- assertEquals(size(strategy.execute(new Predicate<String>() {
-
- @Override
- public boolean apply(String input) {
- return input.startsWith(prefix);
- }
-
- })), 2);
- }
-
- @Test
- public void testExecuteIterableOfString() {
- assertEquals(size(strategy.execute(ImmutableSet.of(prefix, prefix + 1))), 2);
- }
-
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/0ae9519a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
index 0d19c12..25863d9 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListNodesInEnvironmentImplLiveTest.java
@@ -17,7 +17,6 @@
package org.jclouds.chef.strategy.internal;
import static com.google.common.collect.Iterables.size;
-import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;
import org.jclouds.chef.ChefApi;
@@ -25,7 +24,6 @@ import org.jclouds.chef.internal.BaseChefLiveTest;
import org.testng.annotations.AfterClass;
import org.testng.annotations.Test;
-import com.google.common.base.Predicate;
import com.google.common.collect.ImmutableSet;
/**
@@ -60,22 +58,4 @@ public class ListNodesInEnvironmentImplLiveTest extends BaseChefLiveTest<ChefApi
public void testExecute() {
assertTrue(size(strategy.execute("_default")) > 0, "Expected one or more elements");
}
-
- @Test
- public void testExecutePredicateOfString() {
- assertEquals(size(strategy.execute("_default", new Predicate<String>() {
-
- @Override
- public boolean apply(String input) {
- return input.startsWith(prefix);
- }
-
- })), 2);
- }
-
- @Test
- public void testExecuteIterableOfString() {
- assertEquals(size(strategy.execute("_default", ImmutableSet.of(prefix, prefix + 1))), 2);
- }
-
}
[43/50] [abbrv] jclouds git commit: [maven-release-plugin] prepare
for next development iteration
Posted by na...@apache.org.
[maven-release-plugin] prepare for next development iteration
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/b8730300
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/b8730300
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/b8730300
Branch: refs/heads/1.8.x
Commit: b873030064c7791ff3e1c164f669db8901db6fd8
Parents: 4b13de2
Author: Andrew Phillips <an...@apache.org>
Authored: Fri Oct 10 14:22:16 2014 -0400
Committer: Andrew Phillips <an...@apache.org>
Committed: Fri Oct 10 14:22:16 2014 -0400
----------------------------------------------------------------------
providers/enterprisechef/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/b8730300/providers/enterprisechef/pom.xml
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/pom.xml b/providers/enterprisechef/pom.xml
index 5753c31..1d608ad 100644
--- a/providers/enterprisechef/pom.xml
+++ b/providers/enterprisechef/pom.xml
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.jclouds.chef</groupId>
<artifactId>chef-project</artifactId>
- <version>1.8.1</version>
+ <version>1.8.2-SNAPSHOT</version>
<relativePath>../project/pom.xml</relativePath>
</parent>
<groupId>org.apache.jclouds.provider</groupId>
[48/50] [abbrv] jclouds git commit: Aligned pom.xml files for Chef
Posted by na...@apache.org.
Aligned pom.xml files for Chef
Conflicts:
apis/chef/pom.xml
providers/enterprisechef/pom.xml
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/ea1c772e
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/ea1c772e
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/ea1c772e
Branch: refs/heads/1.8.x
Commit: ea1c772e2c9ac749fe65b4d7068d1f2f15e1a748
Parents: da34161
Author: Ignasi Barrera <na...@apache.org>
Authored: Fri Oct 10 11:27:33 2014 +0200
Committer: Ignasi Barrera <na...@apache.org>
Committed: Sun Nov 23 22:23:23 2014 +0100
----------------------------------------------------------------------
all/pom.xml | 10 ++++++++++
apis/chef/pom.xml | 24 ++++++++++++------------
apis/pom.xml | 1 +
project/pom.xml | 2 ++
providers/enterprisechef/pom.xml | 15 +++++++--------
providers/pom.xml | 1 +
6 files changed, 33 insertions(+), 20 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/ea1c772e/all/pom.xml
----------------------------------------------------------------------
diff --git a/all/pom.xml b/all/pom.xml
index 85418eb..f6e2225 100644
--- a/all/pom.xml
+++ b/all/pom.xml
@@ -44,6 +44,11 @@
<version>${project.version}</version>
</dependency>
<dependency>
+ <groupId>org.apache.jclouds.api</groupId>
+ <artifactId>chef</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
<groupId>org.apache.jclouds.provider</groupId>
<artifactId>aws-cloudwatch</artifactId>
<version>${project.version}</version>
@@ -104,6 +109,11 @@
<version>${project.version}</version>
</dependency>
<dependency>
+ <groupId>org.apache.jclouds.provider</groupId>
+ <artifactId>enterprisechef</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
<groupId>${project.groupId}</groupId>
<artifactId>jclouds-allloadbalancer</artifactId>
<version>${project.version}</version>
http://git-wip-us.apache.org/repos/asf/jclouds/blob/ea1c772e/apis/chef/pom.xml
----------------------------------------------------------------------
diff --git a/apis/chef/pom.xml b/apis/chef/pom.xml
index fee7190..2c6c02a 100644
--- a/apis/chef/pom.xml
+++ b/apis/chef/pom.xml
@@ -20,15 +20,15 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>org.apache.jclouds.chef</groupId>
- <artifactId>chef-project</artifactId>
+ <groupId>org.apache.jclouds</groupId>
+ <artifactId>jclouds-project</artifactId>
<version>1.8.2-SNAPSHOT</version>
- <relativePath>../project/pom.xml</relativePath>
+ <relativePath>../../project/pom.xml</relativePath>
</parent>
<groupId>org.apache.jclouds.api</groupId>
<artifactId>chef</artifactId>
<packaging>bundle</packaging>
- <name>Apache jclouds Chef :: Core</name>
+ <name>jclouds Chef api</name>
<description>jclouds components to access Chef</description>
<properties>
@@ -38,8 +38,8 @@
<test.chef.identity>chef-webui</test.chef.identity>
<test.chef.credential>${user.home}/.chef/webui.pem</test.chef.credential>
<jclouds.osgi.import>
- org.jclouds;version=${jclouds.version},
- org.jclouds*;version=${jclouds.version},
+ org.jclouds;version=${project.version},
+ org.jclouds*;version=${project.version},
*
</jclouds.osgi.import>
<jclouds.osgi.export>
@@ -52,24 +52,24 @@
<dependency>
<groupId>org.apache.jclouds</groupId>
<artifactId>jclouds-core</artifactId>
- <version>${jclouds.version}</version>
+ <version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.jclouds</groupId>
<artifactId>jclouds-core</artifactId>
- <version>${jclouds.version}</version>
+ <version>${project.version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.jclouds</groupId>
<artifactId>jclouds-scriptbuilder</artifactId>
- <version>${jclouds.version}</version>
+ <version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.jclouds</groupId>
<artifactId>jclouds-scriptbuilder</artifactId>
- <version>${jclouds.version}</version>
+ <version>${project.version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>
@@ -83,13 +83,13 @@
<dependency>
<groupId>org.apache.jclouds</groupId>
<artifactId>jclouds-blobstore</artifactId>
- <version>${jclouds.version}</version>
+ <version>${project.version}</version>
<optional>true</optional>
</dependency>
<dependency>
<groupId>org.apache.jclouds.driver</groupId>
<artifactId>jclouds-slf4j</artifactId>
- <version>${jclouds.version}</version>
+ <version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
http://git-wip-us.apache.org/repos/asf/jclouds/blob/ea1c772e/apis/pom.xml
----------------------------------------------------------------------
diff --git a/apis/pom.xml b/apis/pom.xml
index 89888e7..1e94bb5 100644
--- a/apis/pom.xml
+++ b/apis/pom.xml
@@ -52,6 +52,7 @@
<module>rackspace-clouddns</module>
<module>sts</module>
<module>route53</module>
+ <module>chef</module>
</modules>
<profiles>
<profile>
http://git-wip-us.apache.org/repos/asf/jclouds/blob/ea1c772e/project/pom.xml
----------------------------------------------------------------------
diff --git a/project/pom.xml b/project/pom.xml
index 27625fd..e1669d0 100644
--- a/project/pom.xml
+++ b/project/pom.xml
@@ -542,8 +542,10 @@
<ignoredResource>logback.xml</ignoredResource>
<ignoredResource>amzn_images.xml</ignoredResource>
<ignoredResource>test.jks</ignoredResource>
+ <ignoredResource>test</ignoredResource>
<ignoredResource>CreateInternetService-options-test.xml</ignoredResource>
<ignoredResource>.gitattributes</ignoredResource>
+ <ignoredResource>functions/.gitattributes</ignoredResource>
<ignoredResource>OSGI-OPT/bnd.bnd</ignoredResource>
<!-- For bouncycastle -->
<ignoredResource>META-INF/BCKEY.DSA</ignoredResource>
http://git-wip-us.apache.org/repos/asf/jclouds/blob/ea1c772e/providers/enterprisechef/pom.xml
----------------------------------------------------------------------
diff --git a/providers/enterprisechef/pom.xml b/providers/enterprisechef/pom.xml
index 1d608ad..283c539 100644
--- a/providers/enterprisechef/pom.xml
+++ b/providers/enterprisechef/pom.xml
@@ -20,14 +20,14 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
- <groupId>org.apache.jclouds.chef</groupId>
- <artifactId>chef-project</artifactId>
+ <groupId>org.apache.jclouds</groupId>
+ <artifactId>jclouds-project</artifactId>
<version>1.8.2-SNAPSHOT</version>
- <relativePath>../project/pom.xml</relativePath>
+ <relativePath>../../project/pom.xml</relativePath>
</parent>
<groupId>org.apache.jclouds.provider</groupId>
<artifactId>enterprisechef</artifactId>
- <name>Apache jclouds Chef :: Enterprise</name>
+ <name>jclouds Enterprise Chef provider</name>
<description>jclouds components to access Enterprise Chef</description>
<properties>
@@ -38,7 +38,7 @@
<test.enterprisechef.identity>YOUR_USER</test.enterprisechef.identity>
<test.enterprisechef.credential>${user.home}/.chef/${test.enterprisechef.org}/${test.enterprisechef.identity}.pem</test.enterprisechef.credential>
<jclouds.osgi.export>org.jclouds.enterprisechef*;version="${project.version}"</jclouds.osgi.export>
- <jclouds.osgi.import>org.jclouds*;version="${jclouds.version}",*</jclouds.osgi.import>
+ <jclouds.osgi.import>org.jclouds*;version="${project.version}",*</jclouds.osgi.import>
</properties>
<dependencies>
@@ -57,20 +57,19 @@
<dependency>
<groupId>org.apache.jclouds</groupId>
<artifactId>jclouds-core</artifactId>
- <version>${jclouds.version}</version>
+ <version>${project.version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.jclouds.driver</groupId>
<artifactId>jclouds-slf4j</artifactId>
- <version>${jclouds.version}</version>
+ <version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
- <version>1.0.9</version>
<scope>test</scope>
</dependency>
</dependencies>
http://git-wip-us.apache.org/repos/asf/jclouds/blob/ea1c772e/providers/pom.xml
----------------------------------------------------------------------
diff --git a/providers/pom.xml b/providers/pom.xml
index b8f412f..4c6f071 100644
--- a/providers/pom.xml
+++ b/providers/pom.xml
@@ -70,5 +70,6 @@
<module>aws-route53</module>
<module>ultradns-ws</module>
<module>dynect</module>
+ <module>enterprisechef</module>
</modules>
</project>
[45/50] [abbrv] jclouds git commit: JCLOUDS-534 Avoid runtime
incompatibility introduced by Guava's closeQuietly.
Posted by na...@apache.org.
JCLOUDS-534 Avoid runtime incompatibility introduced by Guava's closeQuietly.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/35c1df4c
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/35c1df4c
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/35c1df4c
Branch: refs/heads/1.8.x
Commit: 35c1df4cefe186678a77849edae6040624827f51
Parents: a48ea89
Author: Adrian Cole <ac...@twitter.com>
Authored: Wed Oct 29 17:14:42 2014 -0700
Committer: Adrian Cole <ac...@twitter.com>
Committed: Wed Oct 29 18:39:25 2014 -0700
----------------------------------------------------------------------
.../org/jclouds/chef/handlers/ChefErrorHandler.java | 14 ++------------
.../jclouds/chef/internal/BaseChefApiLiveTest.java | 11 ++---------
2 files changed, 4 insertions(+), 21 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/35c1df4c/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefErrorHandler.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefErrorHandler.java b/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefErrorHandler.java
index 3376219..85f9129 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefErrorHandler.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/handlers/ChefErrorHandler.java
@@ -16,9 +16,7 @@
*/
package org.jclouds.chef.handlers;
-import static com.google.common.base.Throwables.propagate;
-
-import java.io.IOException;
+import static org.jclouds.util.Closeables2.closeQuietly;
import javax.annotation.Resource;
import javax.inject.Inject;
@@ -33,8 +31,6 @@ import org.jclouds.logging.Logger;
import org.jclouds.rest.AuthorizationException;
import org.jclouds.rest.ResourceNotFoundException;
-import com.google.common.io.Closeables;
-
/**
* This will parse and set an appropriate exception on the command object.
*/
@@ -67,13 +63,7 @@ public class ChefErrorHandler implements HttpErrorHandler {
break;
}
} finally {
- if (response.getPayload() != null) {
- try {
- Closeables.close(response.getPayload().getInput(), true);
- } catch (IOException e) {
- throw propagate(e);
- }
- }
+ closeQuietly(response.getPayload());
command.setException(exception);
}
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/35c1df4c/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
index 225e593..a477be0 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
@@ -16,11 +16,11 @@
*/
package org.jclouds.chef.internal;
-import static com.google.common.base.Throwables.propagate;
import static com.google.common.collect.Iterables.any;
import static com.google.common.collect.Iterables.isEmpty;
import static com.google.common.hash.Hashing.md5;
import static java.util.concurrent.TimeUnit.MILLISECONDS;
+import static org.jclouds.util.Closeables2.closeQuietly;
import static org.jclouds.util.Predicates2.retry;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
@@ -30,7 +30,6 @@ import static org.testng.Assert.assertTrue;
import static org.testng.Assert.fail;
import java.io.File;
-import java.io.IOException;
import java.io.InputStream;
import java.util.Collections;
import java.util.List;
@@ -65,7 +64,6 @@ import com.google.common.base.Predicate;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableSet;
import com.google.common.hash.Hashing;
-import com.google.common.io.Closeables;
import com.google.common.io.Files;
import com.google.common.primitives.Bytes;
@@ -531,12 +529,7 @@ public abstract class BaseChefApiLiveTest<A extends ChefApi> extends BaseChefLiv
Client client = clientApi.getClient(identity);
assertNotNull(client, "Client not found: " + identity);
} finally {
- try {
- Closeables.close(clientApi, true);
- } catch (IOException e) {
- throw propagate(e);
- }
+ closeQuietly(clientApi);
}
}
-
}
[19/50] [abbrv] jclouds git commit: Enforce no unused imports via
Checkstyle
Posted by na...@apache.org.
Enforce no unused imports via Checkstyle
Removed with:
mvn checkstyle:checkstyle --quiet -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain | tac | while read i; do echo $i | sed -n 's/\([^:]*\):\([^:]*\):.*/sed -i \2d \1/p' | bash; done
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/a02b61fd
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/a02b61fd
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/a02b61fd
Branch: refs/heads/1.8.x
Commit: a02b61fd82528e8788d0b589b8f04923803d234f
Parents: 0ae9519
Author: Andrew Gaul <ga...@apache.org>
Authored: Wed Dec 11 17:27:59 2013 -0800
Committer: Andrew Gaul <ga...@apache.org>
Committed: Wed Dec 11 17:27:59 2013 -0800
----------------------------------------------------------------------
apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java | 1 -
apis/chef/src/main/java/org/jclouds/chef/ChefService.java | 3 ---
.../src/main/java/org/jclouds/chef/config/ChefProperties.java | 1 -
.../main/java/org/jclouds/chef/functions/GroupToBootScript.java | 1 -
.../jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java | 2 --
.../strategy/internal/ListCookbookVersionsInEnvironmentImpl.java | 3 ---
.../main/java/org/jclouds/chef/test/TransientChefApiMetadata.java | 1 -
7 files changed, 12 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/a02b61fd/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java b/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java
index 951d2d2..614d58d 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/ChefApiMetadata.java
@@ -28,7 +28,6 @@ import static org.jclouds.chef.config.ChefProperties.CHEF_USE_OMNIBUS;
import java.net.URI;
import java.util.Properties;
-import org.jclouds.apis.ApiMetadata;
import org.jclouds.chef.config.ChefBootstrapModule;
import org.jclouds.chef.config.ChefHttpApiModule;
import org.jclouds.chef.config.ChefParserModule;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/a02b61fd/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/ChefService.java b/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
index 8006b88..1fe9814 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/ChefService.java
@@ -20,16 +20,13 @@ import java.io.IOException;
import java.io.InputStream;
import java.util.List;
-import org.jclouds.chef.config.ChefProperties;
import org.jclouds.chef.domain.BootstrapConfig;
import org.jclouds.chef.domain.Client;
import org.jclouds.chef.domain.CookbookVersion;
import org.jclouds.chef.domain.Environment;
import org.jclouds.chef.domain.Node;
import org.jclouds.chef.internal.BaseChefService;
-import org.jclouds.chef.util.ChefUtils;
import org.jclouds.domain.JsonBall;
-import org.jclouds.ohai.config.OhaiModule;
import org.jclouds.rest.annotations.SinceApiVersion;
import org.jclouds.scriptbuilder.domain.Statement;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/a02b61fd/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java b/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java
index a6cf5f2..c366ee9 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/config/ChefProperties.java
@@ -16,7 +16,6 @@
*/
package org.jclouds.chef.config;
-import org.jclouds.chef.ChefService;
/**
* Configuration properties and constants used in Chef connections.
http://git-wip-us.apache.org/repos/asf/jclouds/blob/a02b61fd/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java b/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java
index 707119b..1472d19 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/functions/GroupToBootScript.java
@@ -31,7 +31,6 @@ import java.util.Map;
import java.util.regex.Pattern;
import javax.inject.Inject;
-import javax.inject.Named;
import javax.inject.Singleton;
import org.jclouds.chef.config.InstallChef;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/a02b61fd/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
index e19918c..1c1186e 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/ListCookbookVersionsInEnvironment.java
@@ -16,11 +16,9 @@
*/
package org.jclouds.chef.strategy;
-import org.jclouds.chef.domain.CookbookDefinition;
import org.jclouds.chef.domain.CookbookVersion;
import org.jclouds.chef.strategy.internal.ListCookbookVersionsInEnvironmentImpl;
-import com.google.common.base.Predicate;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.ImplementedBy;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/a02b61fd/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
index 48d563e..881f251 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImpl.java
@@ -18,8 +18,6 @@ package org.jclouds.chef.strategy.internal;
import static com.google.common.base.Preconditions.checkNotNull;
import static com.google.common.collect.Iterables.concat;
-import static com.google.common.collect.Iterables.contains;
-import static com.google.common.collect.Iterables.filter;
import static com.google.common.collect.Iterables.transform;
import static com.google.common.util.concurrent.Futures.allAsList;
import static com.google.common.util.concurrent.Futures.getUnchecked;
@@ -41,7 +39,6 @@ import org.jclouds.chef.strategy.ListCookbookVersionsInEnvironment;
import org.jclouds.logging.Logger;
import com.google.common.base.Function;
-import com.google.common.base.Predicate;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.inject.Inject;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/a02b61fd/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java b/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java
index e0eaace..88f7a8d 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/test/TransientChefApiMetadata.java
@@ -18,7 +18,6 @@ package org.jclouds.chef.test;
import java.net.URI;
-import org.jclouds.apis.ApiMetadata;
import org.jclouds.chef.ChefApiMetadata;
import org.jclouds.chef.config.ChefBootstrapModule;
import org.jclouds.chef.config.ChefParserModule;
[20/50] [abbrv] jclouds git commit: Updating to 1.8.0-SNAPSHOT
Posted by na...@apache.org.
Updating to 1.8.0-SNAPSHOT
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/1e37c676
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/1e37c676
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/1e37c676
Branch: refs/heads/1.8.x
Commit: 1e37c67620e8c74af04604947e6a5ecc5df99c52
Parents: a02b61f
Author: Andrew Bayer <an...@gmail.com>
Authored: Tue Dec 17 11:51:11 2013 -0800
Committer: Andrew Bayer <an...@gmail.com>
Committed: Tue Dec 17 11:51:11 2013 -0800
----------------------------------------------------------------------
apis/chef/pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/1e37c676/apis/chef/pom.xml
----------------------------------------------------------------------
diff --git a/apis/chef/pom.xml b/apis/chef/pom.xml
index fec3d8a..74780d2 100644
--- a/apis/chef/pom.xml
+++ b/apis/chef/pom.xml
@@ -22,7 +22,7 @@
<parent>
<groupId>org.apache.jclouds.chef</groupId>
<artifactId>chef-project</artifactId>
- <version>1.7.0-SNAPSHOT</version>
+ <version>1.8.0-SNAPSHOT</version>
<relativePath>../project/pom.xml</relativePath>
</parent>
<groupId>org.apache.jclouds.api</groupId>
[27/50] [abbrv] jclouds git commit: Address removal of calculateMD5
Posted by na...@apache.org.
Address removal of calculateMD5
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/1fe6bca6
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/1fe6bca6
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/1fe6bca6
Branch: refs/heads/1.8.x
Commit: 1fe6bca62da0c582d3dfea4e3ddf9a4139b082bc
Parents: 2982d99
Author: Andrew Gaul <ga...@apache.org>
Authored: Sat Jun 7 21:39:21 2014 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Sat Jun 7 21:39:21 2014 -0700
----------------------------------------------------------------------
.../java/org/jclouds/chef/internal/BaseChefApiLiveTest.java | 7 +++++--
.../ListCookbookVersionsInEnvironmentImplLiveTest.java | 7 +++++--
2 files changed, 10 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/1fe6bca6/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
index bbc1473..2d04dcd 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
@@ -64,7 +64,9 @@ import org.testng.annotations.Test;
import com.google.common.base.Predicate;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableSet;
+import com.google.common.hash.Hashing;
import com.google.common.io.Closeables;
+import com.google.common.io.Files;
import com.google.common.primitives.Bytes;
/**
@@ -84,11 +86,12 @@ public abstract class BaseChefApiLiveTest<A extends ChefApi> extends BaseChefLiv
public void testCreateNewCookbook() throws Exception {
// Define the file you want in the cookbook
- FilePayload content = Payloads.newFilePayload(new File(System.getProperty("user.dir"), "pom.xml"));
+ File file = new File(System.getProperty("user.dir"), "pom.xml");
+ FilePayload content = Payloads.newFilePayload(file);
content.getContentMetadata().setContentType("application/x-binary");
// Get an md5 so that you can see if the server already has it or not
- Payloads.calculateMD5(content);
+ content.getContentMetadata().setContentMD5(Files.asByteSource(file).hash(Hashing.md5()).asBytes());
// Note that java collections cannot effectively do equals or hashcodes on
// byte arrays, so let's convert to a list of bytes.
http://git-wip-us.apache.org/repos/asf/jclouds/blob/1fe6bca6/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
index d1786aa..76ecee8 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/strategy/internal/ListCookbookVersionsInEnvironmentImplLiveTest.java
@@ -41,6 +41,8 @@ import java.util.List;
import com.google.common.base.Predicate;
import com.google.common.collect.ImmutableSet;
+import com.google.common.hash.Hashing;
+import com.google.common.io.Files;
import com.google.common.primitives.Bytes;
/**
@@ -94,11 +96,12 @@ public class ListCookbookVersionsInEnvironmentImplLiveTest extends BaseChefLiveT
private FilePayload uploadContent(String fileName) throws Exception {
// Define the file you want in the cookbook
- FilePayload content = Payloads.newFilePayload(new File(System.getProperty("user.dir"), fileName));
+ File file = new File(System.getProperty("user.dir"), fileName);
+ FilePayload content = Payloads.newFilePayload(file);
content.getContentMetadata().setContentType("application/x-binary");
// Get an md5 so that you can see if the server already has it or not
- Payloads.calculateMD5(content);
+ content.getContentMetadata().setContentMD5(Files.asByteSource(file).hash(Hashing.md5()).asBytes());
// Note that java collections cannot effectively do equals or hashcodes on
// byte arrays, so let's convert to a list of bytes.
[11/50] [abbrv] jclouds git commit: JCLOUDS-335: Properly deserialize
the deleteDatabagItem response
Posted by na...@apache.org.
JCLOUDS-335: Properly deserialize the deleteDatabagItem response
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/8f205479
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/8f205479
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/8f205479
Branch: refs/heads/1.8.x
Commit: 8f205479ad6e5feeea129f9ff32fdc570949afad
Parents: eee53e3
Author: Ignasi Barrera <na...@apache.org>
Authored: Fri Oct 4 10:14:28 2013 +0200
Committer: Ignasi Barrera <na...@apache.org>
Committed: Fri Oct 4 10:56:15 2013 +0200
----------------------------------------------------------------------
apis/chef/src/main/java/org/jclouds/chef/ChefApi.java | 2 ++
.../chef/src/test/java/org/jclouds/chef/ChefApiTest.java | 4 ++--
.../org/jclouds/chef/internal/BaseChefApiLiveTest.java | 11 +++++++++++
3 files changed, 15 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8f205479/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java b/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java
index 5601022..1b1ca2a 100644
--- a/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java
+++ b/apis/chef/src/main/java/org/jclouds/chef/ChefApi.java
@@ -79,6 +79,7 @@ import org.jclouds.rest.annotations.ParamParser;
import org.jclouds.rest.annotations.PayloadParam;
import org.jclouds.rest.annotations.RequestFilters;
import org.jclouds.rest.annotations.ResponseParser;
+import org.jclouds.rest.annotations.SelectJson;
import org.jclouds.rest.annotations.SinceApiVersion;
import org.jclouds.rest.annotations.SkipEncoding;
import org.jclouds.rest.annotations.WrapWith;
@@ -424,6 +425,7 @@ public interface ChefApi extends Closeable {
@DELETE
@Path("/data/{databagName}/{databagItemId}")
@Fallback(NullOnNotFoundOr404.class)
+ @SelectJson("raw_data")
DatabagItem deleteDatabagItem(@PathParam("databagName") String databagName,
@PathParam("databagItemId") String databagItemId);
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8f205479/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java b/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
index 5899486..05eca4b 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/ChefApiTest.java
@@ -45,12 +45,12 @@ import org.jclouds.chef.functions.ParseKeySetFromJson;
import org.jclouds.chef.functions.ParseSearchClientsFromJson;
import org.jclouds.chef.functions.ParseSearchDatabagFromJson;
import org.jclouds.chef.functions.ParseSearchNodesFromJson;
-import org.jclouds.chef.functions.ParseSearchRolesFromJson;
import org.jclouds.chef.options.CreateClientOptions;
import org.jclouds.chef.options.SearchOptions;
import org.jclouds.date.TimeStamp;
import org.jclouds.fallbacks.MapHttp4xxCodesToExceptions;
import org.jclouds.http.HttpRequest;
+import org.jclouds.http.functions.ParseFirstJsonValueNamed;
import org.jclouds.http.functions.ParseJson;
import org.jclouds.http.functions.ReleasePayloadAndReturn;
import org.jclouds.http.functions.ReturnInputStream;
@@ -490,7 +490,7 @@ public class ChefApiTest extends BaseAsyncApiTest<ChefApi> {
+ "-test\n");
assertPayloadEquals(httpRequest, null, null, false);
- assertResponseParserClassEquals(method, httpRequest, ParseJson.class);
+ assertResponseParserClassEquals(method, httpRequest, ParseFirstJsonValueNamed.class);
assertSaxResponseParserClassEquals(method, null);
assertFallbackClassEquals(method, NullOnNotFoundOr404.class);
http://git-wip-us.apache.org/repos/asf/jclouds/blob/8f205479/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
----------------------------------------------------------------------
diff --git a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
index 85acc44..bae390f 100644
--- a/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
+++ b/apis/chef/src/test/java/org/jclouds/chef/internal/BaseChefApiLiveTest.java
@@ -26,6 +26,7 @@ import static org.jclouds.util.Predicates2.retry;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertNotNull;
+import static org.testng.Assert.assertNull;
import static org.testng.Assert.assertTrue;
import static org.testng.Assert.fail;
@@ -297,6 +298,16 @@ public abstract class BaseChefApiLiveTest<A extends ChefApi> extends BaseChefLiv
}
}
+ @Test(dependsOnMethods = "testSearchDatabagWithOptions")
+ public void testDeleteDatabagItem() throws Exception {
+ for (String databagItemId : api.listDatabagItems(PREFIX)) {
+ DatabagItem databagItem = api.deleteDatabagItem(PREFIX, databagItemId);
+ assertNotNull(databagItem, "Deleted data bag item should not be null");
+ assertEquals(databagItem.getId(), databagItemId, "Deleted data bag item id must match the original id");
+ assertNull(api.getDatabagItem(PREFIX, databagItemId), "Data bag item should not exist");
+ }
+ }
+
@Test
public void testListSearchIndexes() throws Exception {
Set<String> indexes = api.listSearchIndexes();