You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/05/04 17:27:00 UTC

[jira] [Work logged] (GOBBLIN-1639) Remove adhoc job metric emission and also provide a more uniform way of emitting per pipeline metrics on Gobblin

     [ https://issues.apache.org/jira/browse/GOBBLIN-1639?focusedWorklogId=766184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766184 ]

ASF GitHub Bot logged work on GOBBLIN-1639:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/May/22 17:26
            Start Date: 04/May/22 17:26
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request, #3500:
URL: https://github.com/apache/gobblin/pull/3500

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1639
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   
   For Adhoc flows in GaaS, metrics are still being emitted on the Gobblin pipeline. This will use the adhoc configuration to determine whether or not to emit these metrics.
   
   Also a small improvement to the workunit count metric to be emitted on the gobblin pipeline. In the future, all pipeline related metrics should be only emitted by the pipeline, not by the service.
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 766184)
    Remaining Estimate: 0h
            Time Spent: 10m

> Remove adhoc job metric emission and also provide a more uniform way of emitting per pipeline metrics on Gobblin
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1639
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1639
>             Project: Apache Gobblin
>          Issue Type: Task
>          Components: gobblin-service
>            Reporter: William Lo
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Gobblin flows still emit certain metrics by default.
> 1. GaaS flows which are adhoc should not be emitting metrics outside of GTE
> 2. Per pipeline metrics are too disorganized right now, need to unify them and this can be the first step.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)