You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/01 07:02:55 UTC
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #7052: Fix Jetty HTTP `TRACE` issue, disable HTTP methods except `POST`.

codecov[bot] edited a comment on pull request #7052:
URL: https://github.com/apache/skywalking/pull/7052#issuecomment-851877549


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/7052?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#7052](https://codecov.io/gh/apache/skywalking/pull/7052?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d1efca) into [master](https://codecov.io/gh/apache/skywalking/commit/518843633f3498762423742d2e92cf25a49cc71d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5188436) will **decrease** coverage by `13.67%`.
   > The diff coverage is `34.37%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/7052/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/skywalking/pull/7052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #7052       +/-   ##
   =============================================
   - Coverage     53.36%   39.69%   -13.68%     
   + Complexity     4225     2580     -1645     
   =============================================
     Files          1864      860     -1004     
     Lines         40260    21903    -18357     
     Branches       4494     2099     -2395     
   =============================================
   - Hits          21486     8695    -12791     
   + Misses        17731    12531     -5200     
   + Partials       1043      677      -366     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/7052?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../server/library/server/jetty/JettyJsonHandler.java](https://codecov.io/gh/apache/skywalking/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2pldHR5L0pldHR5SnNvbkhhbmRsZXIuamF2YQ==) | `39.39% <ø> (+0.50%)` | :arrow_up: |
   | [.../rest/BrowserErrorLogReportBaseServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyRXJyb3JMb2dSZXBvcnRCYXNlU2VydmxldEhhbmRsZXIuamF2YQ==) | `45.83% <ø> (-27.25%)` | :arrow_down: |
   | [...dler/rest/BrowserPerfDataReportServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL2hhbmRsZXIvcmVzdC9Ccm93c2VyUGVyZkRhdGFSZXBvcnRTZXJ2bGV0SGFuZGxlci5qYXZh) | `38.70% <ø> (-40.08%)` | :arrow_down: |
   | [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `33.33% <ø> (-62.67%)` | :arrow_down: |
   | [...rest/ManagementServiceReportPropertiesHandler.java](https://codecov.io/gh/apache/skywalking/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VSZXBvcnRQcm9wZXJ0aWVzSGFuZGxlci5qYXZh) | `28.57% <ø> (-61.09%)` | :arrow_down: |
   | [.../v8/rest/TraceSegmentReportBaseServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydEJhc2VTZXJ2bGV0SGFuZGxlci5qYXZh) | `50.00% <ø> (-23.08%)` | :arrow_down: |
   | [.../oap/server/library/server/jetty/JettyHandler.java](https://codecov.io/gh/apache/skywalking/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2pldHR5L0pldHR5SGFuZGxlci5qYXZh) | `30.00% <26.31%> (-70.00%)` | :arrow_down: |
   | [...g/oap/server/library/server/jetty/JettyServer.java](https://codecov.io/gh/apache/skywalking/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2pldHR5L0pldHR5U2VydmVyLmphdmE=) | `55.73% <44.44%> (-1.96%)` | :arrow_down: |
   | [...rver/library/server/jetty/JettyDefaultHandler.java](https://codecov.io/gh/apache/skywalking/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2pldHR5L0pldHR5RGVmYXVsdEhhbmRsZXIuamF2YQ==) | `50.00% <50.00%> (ø)` | |
   | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/7052/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [1472 more](https://codecov.io/gh/apache/skywalking/pull/7052/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/7052?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/7052?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fb389f9...5d1efca](https://codecov.io/gh/apache/skywalking/pull/7052?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org