You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2016/10/04 10:58:06 UTC

[GitHub] brooklyn-server pull request #366: Test jclouds location choose reachable ad...

GitHub user bostko opened a pull request:

    https://github.com/apache/brooklyn-server/pull/366

    Test jclouds location choose reachable address

    Used changes from https://github.com/aledsage/brooklyn-server/tree/test-JcloudsLocation-chooseReachableAddress
    and https://github.com/bostko/brooklyn-server/tree/test-JcloudsLocation-chooseReachableAddress

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bostko/brooklyn-server test-JcloudsLocation-chooseReachableAddress-unit-rebase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/366.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #366
    
----
commit 47193927249e4f49ef0a96e6dab557e6e2510936
Author: Aled Sage <al...@gmail.com>
Date:   2016-09-30T11:33:51Z

    JcloudsLocation.reachableAddressPredicate: improve generics

commit 7a372e20e22b287ff7e0e60569a0c7e614010a92
Author: Aled Sage <al...@gmail.com>
Date:   2016-09-30T11:34:05Z

    Adds JcloudsReachableAddressStubbedLiveTest (WIP)

commit b8c4b39bbed7d868c638bde123556a9ec1bb09ac
Author: Aled Sage <al...@gmail.com>
Date:   2016-10-04T08:11:45Z

    More tests in JcloudsReachableAddressStubbedLiveTest

commit d3af55d53c44d5d4a3e0dd7278d03276a7f3fe13
Author: Valentin Aitken <bo...@gmail.com>
Date:   2016-10-03T14:54:24Z

    JcloudsReachableAddressStubbedTest is now a unit test
    
    - verify it chooses first Public address when
      POLL_FOR_FIRST_REACHABLE_ADDRESS, is false

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #366: Test jclouds location choose reachable ad...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/366


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #366: Test jclouds location choose reachable address

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/366
  
    Looks great - love the way you have made `JcloudsReachableAddressStubbedTest` a true unit test by stubbing out the `TemplateBuilder` with `JcloudsStubTemplateBuilder`.
    
    I may take a look at that separately, for how much we hardcode in `JcloudsStubTemplateBuilder`. And look at using that in more of our tests that don't actually require real responses from the cloud provider!
    
    Merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---