You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/10 09:40:04 UTC
[GitHub] [incubator-mxnet] connorgoggins opened a new pull request #18016:
[Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
connorgoggins opened a new pull request #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016
## Description ##
I noticed that recently my nightly build pipeline for v1.x (drawing on the v1.x branch from the main repository as its source) began to fail. I hadn't changed any code, but I noticed that the error being generated stemmed from an RVM version issue that I fixed in master by pinning the dependency version as part of my [General Version Dropdown PR](https://github.com/apache/incubator-mxnet/pull/17948). Since v1.x doesn't include changes to master, I realized that I would need to incorporate this fix in v1.x as well in order to get my nightly builds (or any website builds on this branch) to pass.
I tested my fix for this branch via my [v1.x nightly build Jenkins pipeline](http://jenkins.mxnet-ci.amazon-ml.com/job/restricted-nightly-website-build-1.x/), and it passed with my changes.
## Checklist ##
### Essentials ###
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- M ci/docker/Dockerfile.build.ubuntu_cpu_jekyll
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins edited a comment on issue #18016:
[Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
connorgoggins edited a comment on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-612099453
@ChaiBapchya my hypothesis is that the RVM package was updated to include a new release version (>2.6.3) sometime in the last couple of days. Since the previous RVM install code didn't specify a package version to install but required 2.6.3 to be used, once the higher-order version became available it was installed by default and the required lower-order version was not found, leading to the error being thrown.
Just to clarify, my PRs did not introduce this error - they actually fixed it (in master). This was an issue introduced in the past (since the dependency wasn't pinned for install but a specific version was required for runtime) that didn't surface until RVM released a new version of the package. While adding the version dropdown, I noticed the problem in master and added a fix to [my PR](https://github.com/apache/incubator-mxnet/pull/17948/files#diff-1ac33fe99d6318a01a56fca7d6301d56R48). The reason the other branches are failing is because I only added the fix for master, and the other branches (which also rely on the RVM package) did not have the benefit of my fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins commented on issue #18016: [Website
2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-612099453
@ChaiBapchya my hypothesis is that the RVM package was updated sometime in the last couple of days. Since the previous RVM install code didn't specify a package version to install but required 2.6.3 to be used, once the higher-order version became available it was installed by default and the required lower-order version was not found, leading to the error being thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins edited a comment on issue #18016:
[Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
connorgoggins edited a comment on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-612099453
@ChaiBapchya my hypothesis is that the RVM package was updated with a new version (>2.6.3) sometime in the last couple of days. Since the previous RVM install code didn't specify a package version to install but required 2.6.3 to be used, once the higher-order version became available it was installed by default and the required lower-order version was not found, leading to the error being thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins commented on issue #18016: [Website
2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-611961257
@mxnet-label-bot add [Website]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins commented on issue #18016: [Website
2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-612158650
@ChaiBapchya 2.6.3 doesn't break the build. What breaks the build is not specifying a version of RVM. Either 2.6.3 or 2.6.5 is valid as long as the version installed is the same as the version required for the run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18016: [Website
2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-611960890
Hey @connorgoggins , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [miscellaneous, centos-cpu, unix-gpu, centos-gpu, sanity, unix-cpu, edge, windows-gpu, website, windows-cpu, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #18016: [Website
2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-612155181
@connorgoggins looks like 2.6.3 breaks the build
Hence the master branch was updated to 2.6.5
https://github.com/apache/incubator-mxnet/issues/17918#issuecomment-605290574
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins edited a comment on issue #18016:
[Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
connorgoggins edited a comment on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-612099453
@ChaiBapchya my hypothesis is that the RVM package was updated to include a new release version (>2.6.3) sometime in the last couple of days. Since the previous RVM install code didn't specify a package version to install but required 2.6.3 to be used, once the higher-order version became available it was installed by default and the required lower-order version was not found, leading to the error being thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins edited a comment on issue #18016:
[Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
connorgoggins edited a comment on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-612099453
@ChaiBapchya my hypothesis is that the RVM package was updated to include a new release version (>2.6.3) sometime in the last couple of days. Since the previous RVM install code didn't specify a package version to install but required 2.6.3 to be used, once the higher-order version became available it was installed by default and the required lower-order version was not found, leading to the error being thrown.
Just to clarify, my PRs did not introduce this error - this is an external issue. While adding the version dropdown, I noticed the problem in master and added a fix to my PR. The reason the other branches are failing is because I only added the fix for master, and the other branches (which also rely on the RVM package) did not have the benefit of my fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins edited a comment on issue #18016:
[Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
connorgoggins edited a comment on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-612158650
@ChaiBapchya 2.6.3 doesn't break the build. What breaks the build is not specifying a version of RVM. Either 2.6.3 or 2.6.5 is valid as long as the [version installed](https://github.com/apache/incubator-mxnet/pull/18016/files#diff-1ac33fe99d6318a01a56fca7d6301d56R46) is the same as the [version required for the run](https://github.com/apache/incubator-mxnet/pull/18016/files#diff-1ac33fe99d6318a01a56fca7d6301d56R47).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins edited a comment on issue #18016:
[Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
connorgoggins edited a comment on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-612099453
@ChaiBapchya my hypothesis is that the RVM package was updated to include a new release version (>2.6.3) sometime in the last couple of days. Since the previous RVM install code didn't specify a package version to install but required 2.6.3 to be used, once the higher-order version became available it was installed by default and the required lower-order version was not found, leading to the error being thrown.
Just to clarify, my PRs did not introduce this error - this was an issue introduced in the past (since the dependency wasn't pinned for install but a specific version was required for runtime) that didn't surface until RVM released a new version of the package. While adding the version dropdown, I noticed the problem in master and added a fix to [my PR](https://github.com/apache/incubator-mxnet/pull/17948/files#diff-1ac33fe99d6318a01a56fca7d6301d56R48). The reason the other branches are failing is because I only added the fix for master, and the other branches (which also rely on the RVM package) did not have the benefit of my fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ChaiBapchya commented on issue #18016: [Website
2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-612163238
Thanks for the clarification!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] connorgoggins commented on issue #18016: [Website
2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
connorgoggins commented on issue #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016#issuecomment-611961172
@mxnet-label-bot add [pr-awaiting-review]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] aaronmarkham merged pull request #18016: [Website
2.0] Fix RVM version to satisfy Jekyll build in v1.x
Posted by GitBox <gi...@apache.org>.
aaronmarkham merged pull request #18016: [Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x
URL: https://github.com/apache/incubator-mxnet/pull/18016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services