You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/01/29 14:44:05 UTC

[PR] Add validation using kubeconform [pulsar-helm-chart]

lhotari opened a new pull request, #449:
URL: https://github.com/apache/pulsar-helm-chart/pull/449

   ### Motivation
   
   - `helm lint` doesn't validate extra keys in the Kubernetes objects
   - [`kubeconform`](https://github.com/yannh/kubeconform) provides a proper solution for that.
   
   ### Modifications
   
   - Add kubeconform step to the "chart-testing lint" build job in the CI workflow
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add validation using kubeconform [pulsar-helm-chart]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #449:
URL: https://github.com/apache/pulsar-helm-chart/pull/449#issuecomment-1914952696

   > LGTM. Wonder what PR you mean... :D
   
   @Mortom123 this particular invalid indentation: https://github.com/apache/pulsar-helm-chart/pull/448#discussion_r1469615572 . It didn't get caught by validation. After adding `kubeconform` validation, it would be detected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add validation using kubeconform [pulsar-helm-chart]

Posted by "Mortom123 (via GitHub)" <gi...@apache.org>.
Mortom123 commented on PR #449:
URL: https://github.com/apache/pulsar-helm-chart/pull/449#issuecomment-1914944578

   LGTM. Wonder what PR you mean... :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add validation using kubeconform [pulsar-helm-chart]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #449:
URL: https://github.com/apache/pulsar-helm-chart/pull/449#issuecomment-1914899921

   @frankjkelly @Mortom123 Please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add validation using kubeconform [pulsar-helm-chart]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #449:
URL: https://github.com/apache/pulsar-helm-chart/pull/449


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org