You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Stephan Huttenhuis (JIRA)" <ji...@apache.org> on 2010/07/22 15:58:52 UTC

[jira] Created: (JCR-2686) Data store garbage collection: interrupt mark

Data store garbage collection: interrupt mark
---------------------------------------------

                 Key: JCR-2686
                 URL: https://issues.apache.org/jira/browse/JCR-2686
             Project: Jackrabbit Content Repository
          Issue Type: Improvement
    Affects Versions: 2.1.0
            Reporter: Stephan Huttenhuis


It would be nice if the DataStore GarbageCollector can be interrupted during a mark. This allows applications that use JackRabbit to shutdown without having to wait for the mark to complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (JCR-2686) Data store garbage collection: interrupt mark

Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Mueller reassigned JCR-2686:
-----------------------------------

    Assignee: Thomas Mueller

> Data store garbage collection: interrupt mark
> ---------------------------------------------
>
>                 Key: JCR-2686
>                 URL: https://issues.apache.org/jira/browse/JCR-2686
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>    Affects Versions: 2.1.0
>            Reporter: Stephan Huttenhuis
>            Assignee: Thomas Mueller
>
> It would be nice if the DataStore GarbageCollector can be interrupted during a mark. This allows applications that use JackRabbit to shutdown without having to wait for the mark to complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-2686) Data store garbage collection: interrupt mark

Posted by "Stephan Huttenhuis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899318#action_12899318 ] 

Stephan Huttenhuis commented on JCR-2686:
-----------------------------------------

Close only removes the oberservation listener and does not do what  I want. I would like an option to interrupt the mark method (or more precisely the scanNodes and scanPersistenceManagers methods) during a scan, so that a garbage collect does not prevent jackrabbit from stopping

> Data store garbage collection: interrupt mark
> ---------------------------------------------
>
>                 Key: JCR-2686
>                 URL: https://issues.apache.org/jira/browse/JCR-2686
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>    Affects Versions: 2.1.0
>            Reporter: Stephan Huttenhuis
>
> It would be nice if the DataStore GarbageCollector can be interrupted during a mark. This allows applications that use JackRabbit to shutdown without having to wait for the mark to complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-2686) Data store garbage collection: interrupt mark

Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892329#action_12892329 ] 

Thomas Mueller commented on JCR-2686:
-------------------------------------

Could you check if calling close() does what you want?

> Data store garbage collection: interrupt mark
> ---------------------------------------------
>
>                 Key: JCR-2686
>                 URL: https://issues.apache.org/jira/browse/JCR-2686
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>    Affects Versions: 2.1.0
>            Reporter: Stephan Huttenhuis
>
> It would be nice if the DataStore GarbageCollector can be interrupted during a mark. This allows applications that use JackRabbit to shutdown without having to wait for the mark to complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-2686) Data store garbage collection: interrupt mark

Posted by "Stephan Huttenhuis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899357#action_12899357 ] 

Stephan Huttenhuis commented on JCR-2686:
-----------------------------------------

We would like to interrupt the sweep phase. We have two large JackRabbit installations with the following characteristics:
An environment with about 9000 binary values (BINVAL) and 350.000 node bundles where garbage collection took about 4 minutes.
An environment with about 4000 binary values (BINVAL) and 400.000 node bundles where garbage collection took about 7 minutes.


> Data store garbage collection: interrupt mark
> ---------------------------------------------
>
>                 Key: JCR-2686
>                 URL: https://issues.apache.org/jira/browse/JCR-2686
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>    Affects Versions: 2.1.0
>            Reporter: Stephan Huttenhuis
>            Assignee: Thomas Mueller
>
> It would be nice if the DataStore GarbageCollector can be interrupted during a mark. This allows applications that use JackRabbit to shutdown without having to wait for the mark to complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-2686) Data store garbage collection: interrupt mark

Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-2686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899332#action_12899332 ] 

Thomas Mueller commented on JCR-2686:
-------------------------------------

Hi,

You are right. Looking at the code, I'm not sure if calling close() already interrupts the "mark" phase if isPersistenceManagerScan() is false (because close() logs out the session). But the persistence manager scan isn't stopped. It should be relatively easy to implement and test this feature.

The "sweep" phase can't be interrupted currently, but I guess that's not the problem? I don't know how long a "sweep" call takes, but I guess not that long (a few seconds at most?)


> Data store garbage collection: interrupt mark
> ---------------------------------------------
>
>                 Key: JCR-2686
>                 URL: https://issues.apache.org/jira/browse/JCR-2686
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>    Affects Versions: 2.1.0
>            Reporter: Stephan Huttenhuis
>            Assignee: Thomas Mueller
>
> It would be nice if the DataStore GarbageCollector can be interrupted during a mark. This allows applications that use JackRabbit to shutdown without having to wait for the mark to complete.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.