You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by billliuatuber <gi...@git.apache.org> on 2017/01/28 01:24:56 UTC
[GitHub] flink pull request #3231: [FLINK-5682] Fix scala version in flink-streaming-...
GitHub user billliuatuber opened a pull request:
https://github.com/apache/flink/pull/3231
[FLINK-5682] Fix scala version in flink-streaming-scala POM file
Fix scala version in flink-streaming-scala POM file.
In flink-streaming-scala, it doesn't define the scala library version,
when build Flink for scala 2.10, it still possiblely includes scala 2.11
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/billliuatuber/flink FLINK-5682
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3231
----
commit 101ad2c295f6aada5c1117de7b56cd5c86405e2b
Author: Bill Liu <bi...@uber.com>
Date: 2017-01-28T01:03:55Z
[FLINK-5682] fix scala library version in streaming-scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3231: [FLINK-5682] Fix scala version in flink-streaming-scala P...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3231
@billliuatuber Since the dependency management section in the root `pom.xml` defines the Scala version for all sub-modules, I think this change is not needed.
If you agree, could you close the pull request?
If you think I am overlooking something, please let me know!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3231: [FLINK-5682] Fix scala version in flink-streaming-scala P...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3231
I think this is not necessary. The Scala Version is defined in the root `pom.xml` in the `dependencyManagement` section already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3231: [FLINK-5682] Fix scala version in flink-streaming-...
Posted by billliuatuber <gi...@git.apache.org>.
Github user billliuatuber closed the pull request at:
https://github.com/apache/flink/pull/3231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---