You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2014/06/07 08:17:30 UTC

svn commit: r1601067 - /maven/plugins/trunk/maven-plugins/pom.xml

Author: hboutemy
Date: Sat Jun  7 06:17:29 2014
New Revision: 1601067

URL: http://svn.apache.org/r1601067
Log:
[MPOM-49] configure plugin-tools with phase override instead of twice-descriptor execution

Modified:
    maven/plugins/trunk/maven-plugins/pom.xml

Modified: maven/plugins/trunk/maven-plugins/pom.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-plugins/pom.xml?rev=1601067&r1=1601066&r2=1601067&view=diff
==============================================================================
--- maven/plugins/trunk/maven-plugins/pom.xml (original)
+++ maven/plugins/trunk/maven-plugins/pom.xml Sat Jun  7 06:17:29 2014
@@ -135,21 +135,19 @@ under the License.
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-plugin-plugin</artifactId>
           <version>${mavenPluginToolsVersion}</version>
-          <configuration>
-            <skipErrorNoDescriptorsFound>true</skipErrorNoDescriptorsFound>
-          </configuration>
           <executions>
             <execution>
-              <id>mojo-descriptor</id>
-              <goals>
-                <goal>descriptor</goal>
-              </goals>
+              <id>default-descriptor</id>
+              <phase>process-classes</phase>
             </execution>
             <execution>
               <id>generated-helpmojo</id>
               <goals>
                 <goal>helpmojo</goal>
               </goals>
+              <configuration><!-- TODO: remove when upgrading plugin-tools to 3.4: see MPLUGIN-238 -->
+                <skipErrorNoDescriptorsFound>true</skipErrorNoDescriptorsFound>
+              </configuration>
             </execution>
           </executions>
         </plugin>
@@ -301,5 +299,34 @@ under the License.
         </plugins>        
       </build>   
     </profile>
+    <profile>
+      <id>maven-2</id>
+      <activation>
+        <file>
+          <!--  This employs that the basedir expression is only recognized by Maven 3.x (see MNG-2363) -->
+          <missing>${basedir}</missing>
+        </file>
+      </activation>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-plugin-plugin</artifactId>
+            <configuration>
+              <!-- see http://jira.codehaus.org/browse/MNG-5346 -->
+              <skipErrorNoDescriptorsFound>true</skipErrorNoDescriptorsFound>
+            </configuration>
+            <executions>
+              <execution>
+                <id>mojo-descriptor</id>
+                <goals><!-- Maven 2 does not support phase overriding: need to add an execution -->
+                  <goal>descriptor</goal>
+                </goals>
+              </execution>
+            </executions>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>    
   </profiles>
 </project>