You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/11/06 13:20:44 UTC

[GitHub] [spark] srowen commented on a change in pull request #26263: [SPARK-29570][WEBUI] Improve tooltip for Executor Tab for Shuffle Write, Blacklisted, Logs, Threaddump columns

srowen commented on a change in pull request #26263: [SPARK-29570][WEBUI] Improve tooltip for Executor Tab for Shuffle Write,Blacklisted,Logs,Threaddump columns
URL: https://github.com/apache/spark/pull/26263#discussion_r343089461
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
 ##########
 @@ -200,10 +200,10 @@ private[ui] class StagePagedTable(
       stageHeadersAndCssClasses.map { case (header, tooltip, sortable) =>
         val headerSpan = tooltip.map { case (title, left) =>
           if (left) {
-            /* Place the shuffle write tooltip on the left (rather than the default position
+            /* Place the shuffle write tooltip on the auto (rather than the default position
 
 Review comment:
   That's weird! OK then let's standardize on anything that displays reasonably everywhere. I think a few of these worked differently on purpose to avoid display issues though; maybe we leave any special logic as-is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org