[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #5411: refactor: add subtask register for github plugin

["keon94 (via GitHub)" <gi...@apache.org>]

keon94 commented on code in PR #5411:
URL: https://github.com/apache/incubator-devlake/pull/5411#discussion_r1244701515


##########
backend/helpers/pluginhelper/subtaskmeta_sorter/subtask.go:
##########
@@ -32,11 +32,11 @@ func NewDependencySorter(metas []*plugin.SubTaskMeta) SubTaskMetaSorter {
 }
 
 func (d *DependencySorter) Sort() ([]plugin.SubTaskMeta, error) {
-	return topologicalSort(d.metas)
+	return dependenciesTopologicalSort(d.metas)
 }
 
 // stable topological sort
-func topologicalSort(metas []*plugin.SubTaskMeta) ([]plugin.SubTaskMeta, error) {

Review Comment:
   Our convention is to use errors.Error (our own impl) in our code instead of the base Go error interface



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org