[GitHub] [incubator-nemo] hy00nc commented on a change in pull request #258: [NEMO-429] SWPP TEAM 21 code smell fix

[GitBox <gi...@apache.org>]

hy00nc commented on a change in pull request #258: [NEMO-429] SWPP TEAM 21 code smell fix
URL: https://github.com/apache/incubator-nemo/pull/258#discussion_r352968487
 
 

 ##########
 File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/datatransfer/OperatorVertexOutputCollector.java
 ##########
 @@ -42,9 +42,13 @@
   private static final Logger LOG = LoggerFactory.getLogger(OperatorVertexOutputCollector.class.getName());
 
   private final IRVertex irVertex;
+  @SuppressWarnings("squid:S1948")
   private final List<NextIntraTaskOperatorInfo> internalMainOutputs;
+  @SuppressWarnings("squid:S1948")
   private final Map<String, List<NextIntraTaskOperatorInfo>> internalAdditionalOutputs;
+  @SuppressWarnings("squid:S1948")
   private final List<OutputWriter> externalMainOutputs;
+  @SuppressWarnings("squid:S1948")
 
 Review comment:
   Please remove the four `@SuppressWarnings` here. `@SuppressWarnings` is reasonable, yet let's keep this part untouched so that we handle this warning later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services