You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/02/15 11:03:42 UTC

[GitHub] [ignite] nizhikov commented on a change in pull request #8795: IGNITE-14169 .NET: BinaryBasicNameMapperForJava introduced

nizhikov commented on a change in pull request #8795:
URL: https://github.com/apache/ignite/pull/8795#discussion_r576111060



##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Binary/BinaryBasicNameMapper.cs
##########
@@ -48,7 +48,7 @@ public class BinaryBasicNameMapper : IBinaryNameMapper
         /// <summary>
         /// Gets the type name.
         /// </summary>
-        public string GetTypeName(string name)
+        public virtual string GetTypeName(string name)

Review comment:
       I reworked the solution according to your proposals on the dev-list.
   
   `NamespaceToLower` and `JavaDomain` flags added to `BinaryBasicNameMapper`.
   Please, take a look.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org