You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2015/06/11 02:07:06 UTC
Review Request 35333: Small fix in updateSlave() to make resource math
clearer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35333/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
A follow-up on BenM's suggestion in /r/35118/.
Diffs
-----
src/master/master.cpp 95ca2e5f6c903dea7528e559f86639e78ec92b9b
Diff: https://reviews.apache.org/r/35333/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request 35333: Small fix in updateSlave() to make resource
math clearer.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35333/#review87509
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35333]
All tests passed.
- Mesos ReviewBot
On June 11, 2015, 12:07 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35333/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 12:07 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A follow-up on BenM's suggestion in /r/35118/.
>
>
> Diffs
> -----
>
> src/master/master.cpp 95ca2e5f6c903dea7528e559f86639e78ec92b9b
>
> Diff: https://reviews.apache.org/r/35333/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 35333: Small fix in updateSlave() to make resource
math clearer.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35333/#review87603
-----------------------------------------------------------
Ship it!
Thanks for following up!
- Ben Mahler
On June 11, 2015, 12:07 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35333/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 12:07 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A follow-up on BenM's suggestion in /r/35118/.
>
>
> Diffs
> -----
>
> src/master/master.cpp 95ca2e5f6c903dea7528e559f86639e78ec92b9b
>
> Diff: https://reviews.apache.org/r/35333/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>