You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/10/26 22:54:02 UTC
Review Request 63342: Fixed CMake binary dependencies.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63342/
-----------------------------------------------------------
Review request for mesos, Jeff Coffler, John Kordich, and Joseph Wu.
Bugs: MESOS-8035
https://issues.apache.org/jira/browse/MESOS-8035
Repository: mesos
Description
-------
This resolves MESOS-8035 so that building just the `mesos-agent`, etc.
target should correctly build its runtime dependencies (such as the
containerizer, executor, etc.).
Diffs
-----
src/local/CMakeLists.txt 5e5bee3b70b2407bd86d9e7ffe0d169346054942
src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924
src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76
Diff: https://reviews.apache.org/r/63342/diff/1/
Testing
-------
Cleaned build folder, built just the `mesos-agent` target on Windows and Linux, verified it could launch and connect to a master (built clean with just `--target mesos-master`. Launched a simple task via Marathon to confirm end-to-end support.
Thanks,
Andrew Schwartzmeyer
Re: Review Request 63342: Fixed CMake binary dependencies.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63342/#review189398
-----------------------------------------------------------
Bad patch!
Reviews applied: [63342, 63341, 63340, 60628, 60626, 60624, 60623, 60622, 60621, 60620]
Failed command: python support/apply-reviews.py -n -r 63342
Error:
2017-10-27 05:33:00 URL:https://reviews.apache.org/r/63342/diff/raw/ [2375/2375] -> "63342.patch" [1]
error: patch failed: src/tests/CMakeLists.txt:260
error: src/tests/CMakeLists.txt: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19909/console
- Mesos Reviewbot
On Oct. 26, 2017, 10:54 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63342/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2017, 10:54 p.m.)
>
>
> Review request for mesos, Jeff Coffler, John Kordich, and Joseph Wu.
>
>
> Bugs: MESOS-8035
> https://issues.apache.org/jira/browse/MESOS-8035
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This resolves MESOS-8035 so that building just the `mesos-agent`, etc.
> target should correctly build its runtime dependencies (such as the
> containerizer, executor, etc.).
>
>
> Diffs
> -----
>
> src/local/CMakeLists.txt 5e5bee3b70b2407bd86d9e7ffe0d169346054942
> src/slave/CMakeLists.txt 6f08f3dc95f3a1408cbef7b8f0b0cc2522558924
> src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76
>
>
> Diff: https://reviews.apache.org/r/63342/diff/1/
>
>
> Testing
> -------
>
> Cleaned build folder, built just the `mesos-agent` target on Windows and Linux, verified it could launch and connect to a master (built clean with just `--target mesos-master`. Launched a simple task via Marathon to confirm end-to-end support.
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>