You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2016/11/07 03:14:20 UTC

[GitHub] spark pull request #15793: [SPARK-18296][SQL] Use consistent naming for expr...

GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/15793

    [SPARK-18296][SQL] Use consistent naming for expression test suites

    ## What changes were proposed in this pull request?
    We have an undocumented naming convention to call expression unit tests ExpressionsSuite, and the end-to-end tests FunctionsSuite. It'd be great to make all test suites consistent with this naming convention.
    
    ## How was this patch tested?
    This is a test-only naming change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark SPARK-18296

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15793.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15793
    
----
commit 33f5498bd83c0ef9e53cc235b227e85a22fe8573
Author: Reynold Xin <rx...@databricks.com>
Date:   2016-11-07T03:13:30Z

    [SPARK-18296][SQL] Use consistent naming for expression test suites

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15793: [SPARK-18296][SQL] Use consistent naming for expression ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/15793
  
    **[Test build #68262 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68262/consoleFull)** for PR 15793 at commit [`33f5498`](https://github.com/apache/spark/commit/33f5498bd83c0ef9e53cc235b227e85a22fe8573).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #15793: [SPARK-18296][SQL] Use consistent naming for expr...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/15793


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15793: [SPARK-18296][SQL] Use consistent naming for expression ...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/15793
  
    LGTM pending test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15793: [SPARK-18296][SQL] Use consistent naming for expression ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/15793
  
    **[Test build #68262 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68262/consoleFull)** for PR 15793 at commit [`33f5498`](https://github.com/apache/spark/commit/33f5498bd83c0ef9e53cc235b227e85a22fe8573).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `class BitwiseExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper `
      * `class CollectionExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper `
      * `class MathExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper `
      * `class MiscExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper `
      * `class NullExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper `
      * `  case class DoubleData(a: java.lang.Double, b: java.lang.Double)`
      * `  case class NullDoubles(a: java.lang.Double)`
      * `class MathFunctionsSuite extends QueryTest with SharedSQLContext `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15793: [SPARK-18296][SQL] Use consistent naming for expression ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/15793
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68262/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15793: [SPARK-18296][SQL] Use consistent naming for expression ...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/15793
  
    Thanks - merging in master/branch-2.1. I've disabled the flaky test also (via a commit push).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15793: [SPARK-18296][SQL] Use consistent naming for expression ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/15793
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org