You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by kf...@collab.net on 2004/02/13 20:13:01 UTC
Re: svn commit: r8621 - in branches/1.0.x: . tools/hook-scripts
Branko Čibej <br...@xbc.nu> writes:
> I thought we'd agreed that setting the value of ^W not the right
> solution, and "use warnings" was the right one. How come this change got
> onto the 1.0.x branch?
A more important question is: how did this change get into trunk, if
we'd agreed that it wasn't the way to go? (I don't remember the
discussion, but if you do, maybe it's time to restart it.)
As for how the change got into 1.0.x: any trunk change that affects
only tools/ can go into a release line with just one +1 and a +1 or
"concept +1" from another committer, which these changes had. See
HACKING for more details.
So, the gateway to scrutinize in this case is the trunk...
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r8621 - in branches/1.0.x: . tools/hook-scripts
Posted by Ben Reser <be...@reser.org>.
On Fri, Feb 13, 2004 at 02:13:01PM -0600, kfogel@collab.net wrote:
> A more important question is: how did this change get into trunk, if
> we'd agreed that it wasn't the way to go? (I don't remember the
> discussion, but if you do, maybe it's time to restart it.)
It was committed to trunk on the 29th of Jan. I've been busy and didn't
notice it until Feb 6th. I posted some emails explaining why it was
wrong. But like I said, I've been busy, so I didn't follow up on it or
notice that we were voting on this.
> As for how the change got into 1.0.x: any trunk change that affects
> only tools/ can go into a release line with just one +1 and a +1 or
> "concept +1" from another committer, which these changes had. See
> HACKING for more details.
>
> So, the gateway to scrutinize in this case is the trunk...
Agreed, but I did respond on the trunk commit although late, why nobody
responded, and nobody said anything about my comments when voting is
unclear to me.
I would have made some noise had I not been busy. I don't think I have
the authority to veto this so I probably wouldn't have. But if it was
clear to me that I had that authority I would have vetoed it.
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r8621 - in branches/1.0.x: . tools/hook-scripts
Posted by kf...@collab.net.
Branko Čibej <br...@xbc.nu> writes:
> I think the changes were committed to trunk first, then a few people
> objected. Dunno what happened then, as I haven't been in touch the last
> few days.
Ah, so the objections hadn't yet made it to the point of the trunk
change being reverted, and then it got merged to 1.0.
Well, we can merge a followup rev into 1.0 just as easily, if someone
can provide one :-).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r8621 - in branches/1.0.x: . tools/hook-scripts
Posted by Branko Čibej <br...@xbc.nu>.
kfogel@collab.net wrote:
>Branko Čibej <br...@xbc.nu> writes:
>
>
>>I thought we'd agreed that setting the value of ^W not the right
>>solution, and "use warnings" was the right one. How come this change got
>>onto the 1.0.x branch?
>>
>>
>
>A more important question is: how did this change get into trunk, if
>we'd agreed that it wasn't the way to go? (I don't remember the
>discussion, but if you do, maybe it's time to restart it.)
>
>
I think the changes were committed to trunk first, then a few people
objected. Dunno what happened then, as I haven't been in touch the last
few days.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org