[GitHub] [hive] miklosgergely commented on a change in pull request #843: HIVE-22488 Break up DDLSemanticAnalyzer - extract Table creation analyzers

[GitBox <gi...@apache.org>]

miklosgergely commented on a change in pull request #843: HIVE-22488 Break up DDLSemanticAnalyzer - extract Table creation analyzers
URL: https://github.com/apache/hive/pull/843#discussion_r350228189
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/creation/createlike/CreateTableLikeDesc.java
 ##########
 @@ -16,7 +16,7 @@
  * limitations under the License.
  */
 
-package org.apache.hadoop.hive.ql.ddl.table.creation;
 
 Review comment:
   I choose this package structure was to have a structure for the table related operations. There are 46 of them, and having a package for each of them would mean an endless list of packages, this is why they were put into packages by categories.
   
   Yet I understand your point, if someone is looking at an import it seems odd. One way to solve is that you suggested, or we could replace the "creation" with something else, like "basic", or "existence", or if you have a better suggestion :) This way we'll have a more balanced structure, where there is the main category (table), the sub category (some label), and then the actual command. But if you believe that having the undoubtedly most straightforward name that you've suggested is more important than the balanced package structure, I'm totally fine with that too, I think the most important thing is to break up the DDLSemanticAnalyzer here, and this question is secondary.
   
   Please let me know what you think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org