You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2018/03/20 20:05:00 UTC

[jira] [Created] (HBASE-20233) [metrics] Ill-formatted numRegions metric in "Hadoop:service=HBase,name=RegionServer,sub=Regions" mbean

stack created HBASE-20233:
-----------------------------

             Summary: [metrics] Ill-formatted numRegions metric in "Hadoop:service=HBase,name=RegionServer,sub=Regions" mbean
                 Key: HBASE-20233
                 URL: https://issues.apache.org/jira/browse/HBASE-20233
             Project: HBase
          Issue Type: Bug
          Components: metrics
         Environment: Noticed this poking at metrics. The MBean "Hadoop:service=HBase,name=RegionServer,sub=Regions" carries per region metrics. They are all formatted like so:

{code}
Namespace_default_table_IntegrationTestBigLinkedList_metric_incrementTime_98th_percentile: 0,
Namespace_default_table_IntegrationTestBigLinkedList_metric_incrementTime_99th_percentile: 0,
Namespace_default_table_IntegrationTestBigLinkedList_metric_incrementTime_99.9th_percentile: 0,
Namespace_default_table_IntegrationTestBigLinkedList_metric_appendTime_num_ops: 0,
Namespace_default_table_IntegrationTestBigLinkedList_metric_appendTime_min: 0,
Namespace_default_table_IntegrationTestBigLinkedList_metric_appendTime_max: 0,
Namespace_default_table_IntegrationTestBigLinkedList_metric_appendTime_mean: 0,
{code}

In the middle of them all is a metric named...
{code}
numRegions: 15,
{code}

It has a different format and it is out of scope when compared to the other metrics in this mbean; it belongs better elsewhere, perhaps in the Server bean.

I noticed it because it breaks the parse done by tcollector scraping our metrics from /jmx

It was added long ago in HBASE-14166
            Reporter: stack






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [jira] [Created] (HBASE-20233) [metrics] Ill-formatted numRegions metric in "Hadoop:service=HBase,name=RegionServer,sub=Regions" mbean

Posted by Ted Yu <yu...@gmail.com>.
Hi,
I have added you as contributor.

Please upload patch.

Thanks

On Fri, Apr 13, 2018 at 4:28 PM, Xu Cang <xc...@salesforce.com> wrote:

> Hi,
> This is a small patch for this issue. (first time trying to use Apache
> JIRA, it does not allow me to upload patch file. please let me know if this
> is the wrong way to send patches.)
>
> Best,
> Xu
>
>
>

Re: [jira] [Created] (HBASE-20233) [metrics] Ill-formatted numRegions metric in "Hadoop:service=HBase,name=RegionServer,sub=Regions" mbean

Posted by Xu Cang <xc...@salesforce.com>.
Hi,
This is a small patch for this issue. (first time trying to use Apache
JIRA, it does not allow me to upload patch file. please let me know if this
is the wrong way to send patches.)

Best,
Xu

On Tue, Mar 20, 2018 at 1:05 PM, stack (JIRA) <ji...@apache.org> wrote:

> stack created HBASE-20233:
> -----------------------------
>
>              Summary: [metrics] Ill-formatted numRegions metric in
> "Hadoop:service=HBase,name=RegionServer,sub=Regions" mbean
>                  Key: HBASE-20233
>                  URL: https://issues.apache.org/jira/browse/HBASE-20233
>              Project: HBase
>           Issue Type: Bug
>           Components: metrics
>          Environment: Noticed this poking at metrics. The MBean
> "Hadoop:service=HBase,name=RegionServer,sub=Regions" carries per region
> metrics. They are all formatted like so:
>
> {code}
> Namespace_default_table_IntegrationTestBigLinkedList_
> metric_incrementTime_98th_percentile: 0,
> Namespace_default_table_IntegrationTestBigLinkedList_
> metric_incrementTime_99th_percentile: 0,
> Namespace_default_table_IntegrationTestBigLinkedList_
> metric_incrementTime_99.9th_percentile: 0,
> Namespace_default_table_IntegrationTestBigLinkedList_metric_appendTime_num_ops:
> 0,
> Namespace_default_table_IntegrationTestBigLinkedList_metric_appendTime_min:
> 0,
> Namespace_default_table_IntegrationTestBigLinkedList_metric_appendTime_max:
> 0,
> Namespace_default_table_IntegrationTestBigLinkedList_metric_appendTime_mean:
> 0,
> {code}
>
> In the middle of them all is a metric named...
> {code}
> numRegions: 15,
> {code}
>
> It has a different format and it is out of scope when compared to the
> other metrics in this mbean; it belongs better elsewhere, perhaps in the
> Server bean.
>
> I noticed it because it breaks the parse done by tcollector scraping our
> metrics from /jmx
>
> It was added long ago in HBASE-14166
>             Reporter: stack
>
>
>
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>