You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/29 04:58:22 UTC
[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3405: [Profile] Make running profile clearer and more intuitive to improve usability
chaoyli commented on a change in pull request #3405:
URL: https://github.com/apache/incubator-doris/pull/3405#discussion_r417066888
##########
File path: be/src/runtime/bufferpool/buffer_pool_counters.h
##########
@@ -35,19 +35,19 @@ struct BufferPoolClientCounters {
RuntimeProfile::Counter* cumulative_bytes_alloced;
/// Amount of time spent waiting for reads from disk to complete.
- RuntimeProfile::Counter* read_wait_time;
+ //RuntimeProfile::Counter* read_wait_time;
/// Total number of read I/O operations issued.
- RuntimeProfile::Counter* read_io_ops;
+ //RuntimeProfile::Counter* read_io_ops;
/// Total bytes read from disk.
RuntimeProfile::Counter* bytes_read;
/// Amount of time spent waiting for writes to disk to complete.
- RuntimeProfile::Counter* write_wait_time;
+ //RuntimeProfile::Counter* write_wait_time;
/// Total number of write I/O operations issued.
- RuntimeProfile::Counter* write_io_ops;
+ //RuntimeProfile::Counter* write_io_ops;
Review comment:
not used profile can be removed
##########
File path: be/src/runtime/bufferpool/buffer_pool.cc
##########
@@ -392,11 +392,11 @@ BufferPool::Client::Client(BufferPool* pool, //TmpFileMgr::FileGroup* file_group
ADD_COUNTER(child_profile, "CumulativeAllocations", TUnit::UNIT);
counters_.cumulative_bytes_alloced =
ADD_COUNTER(child_profile, "CumulativeAllocationBytes", TUnit::BYTES);
- counters_.read_wait_time = ADD_TIMER(child_profile, "ReadIoWaitTime");
- counters_.read_io_ops = ADD_COUNTER(child_profile, "ReadIoOps", TUnit::UNIT);
+// counters_.read_wait_time = ADD_TIMER(child_profile, "ReadIoWaitTime");
+// counters_.read_io_ops = ADD_COUNTER(child_profile, "ReadIoOps", TUnit::UNIT);
counters_.bytes_read = ADD_COUNTER(child_profile, "ReadIoBytes", TUnit::BYTES);
Review comment:
not used profile can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org