You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/10/26 21:38:28 UTC

[jira] [Commented] (TS-3969) NetHandler::mainNetEvent always output DEBUG info "Unhandled epoll event" for EVENTIO_READ

    [ https://issues.apache.org/jira/browse/TS-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974991#comment-14974991 ] 

ASF subversion and git services commented on TS-3969:
-----------------------------------------------------

Commit 05ba3e71e9efedd85277841666c46da18fb920ee in trafficserver's branch refs/heads/master from [~oknet]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=05ba3e7 ]

TS-3969 Fixes Debug() output to use the right event check

I also added some curly brackets to make the code less
error prone, and easier to read.


> NetHandler::mainNetEvent always output DEBUG info "Unhandled epoll event" for EVENTIO_READ
> ------------------------------------------------------------------------------------------
>
>                 Key: TS-3969
>                 URL: https://issues.apache.org/jira/browse/TS-3969
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core
>            Reporter: Oknet Xu
>            Assignee: Leif Hedstrom
>             Fix For: 6.1.0
>
>
> {code}
> diff --git a/iocore/net/UnixNet.cc b/iocore/net/UnixNet.cc
> index 5930273..188f2b4 100644
> --- a/iocore/net/UnixNet.cc
> +++ b/iocore/net/UnixNet.cc
> @@ -487,7 +487,7 @@ NetHandler::mainNetEvent(int event, Event *e)
>            Debug("iocore_net_main", "Unhandled epoll event on write: 0x%04x write.enabled=%d closed=%d write.netready_queue=%d",
>                  get_ev_events(pd, x), vc->write.enabled, vc->closed, write_ready_list.in(vc));
>          }
> -      } else if (!(get_ev_events(pd, x) & EVENTIO_ERROR)) {
> +      } else if (!(get_ev_events(pd, x) & EVENTIO_READ)) {
>          Debug("iocore_net_main", "Unhandled epoll event: 0x%04x", get_ev_events(pd, x));
>        }
>      } else if (epd->type == EVENTIO_DNS_CONNECTION) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)