You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@datafusion.apache.org by "kumarUjjawal (via GitHub)" <gi...@apache.org> on 2026/05/13 06:33:53 UTC

Re: [PR] fix: eliminate group by constant empty input [datafusion]

kumarUjjawal commented on code in PR #22132:
URL: https://github.com/apache/datafusion/pull/22132#discussion_r3232005125


##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########


Review Comment:
   Also could you add a non-empty positive case alongside the empty-table reproducer?



##########
datafusion/sqllogictest/test_files/aggregate.slt:
##########


Review Comment:
   We should also add this test `SELECT AVG(v1) FROM t1 GROUP BY false;`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org