You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/01 15:52:41 UTC
[GitHub] [shardingsphere] tuohai666 opened a new pull request #7205: remove unexpected error log
tuohai666 opened a new pull request #7205:
URL: https://github.com/apache/shardingsphere/pull/7205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7205: remove unexpected error log
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7205:
URL: https://github.com/apache/shardingsphere/pull/7205#issuecomment-685051707
## Pull Request Test Coverage Report for [Build 14350](https://coveralls.io/builds/33164789)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **35.664%**
---
| Totals | [](https://coveralls.io/builds/33164789) |
| :-- | --: |
| Change from base [Build 14344](https://coveralls.io/builds/33152998): | 0.0% |
| Covered Lines: | 35604 |
| Relevant Lines: | 99831 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7205: remove unexpected error log
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7205:
URL: https://github.com/apache/shardingsphere/pull/7205#issuecomment-685051707
## Pull Request Test Coverage Report for [Build 14345](https://coveralls.io/builds/33153636)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **35.664%**
---
| Totals | [](https://coveralls.io/builds/33153636) |
| :-- | --: |
| Change from base [Build 14344](https://coveralls.io/builds/33152998): | 0.0% |
| Covered Lines: | 35604 |
| Relevant Lines: | 99831 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7205: remove unexpected error log
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #7205:
URL: https://github.com/apache/shardingsphere/pull/7205#discussion_r481554105
##########
File path: shardingsphere-integration-test/shardingsphere-test-suite/src/test/java/org/apache/shardingsphere/dbtest/env/authority/AuthorityEnvironmentManager.java
##########
@@ -83,10 +83,7 @@ private void executeOnInstanceDataSource(final DataSource dataSource, final Coll
try (Connection connection = dataSource.getConnection()) {
for (String each : sqls) {
try (Statement statement = connection.createStatement()) {
- boolean executeRet = statement.execute(each);
- if (!executeRet) {
- System.err.println("execute '" + each + "' failed");
- }
+ statement.execute(each);
} catch (final SQLException ex) {
System.err.println("execute '" + each + "' failed, ex.msg=" + ex.getMessage());
Review comment:
Please use `log.error` instead of `System.err.println`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7205: #6872, remove unexpected error log
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7205:
URL: https://github.com/apache/shardingsphere/pull/7205#issuecomment-685051707
## Pull Request Test Coverage Report for [Build 14352](https://coveralls.io/builds/33165175)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **35.664%**
---
| Totals | [](https://coveralls.io/builds/33165175) |
| :-- | --: |
| Change from base [Build 14344](https://coveralls.io/builds/33152998): | 0.0% |
| Covered Lines: | 35604 |
| Relevant Lines: | 99831 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #7205: #6872, remove unexpected error log
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7205:
URL: https://github.com/apache/shardingsphere/pull/7205
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org