You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by se...@apache.org on 2007/04/14 22:19:25 UTC

svn commit: r528867 [1/2] - in /directory/ldapstudio/trunk: ldapstudio-browser-common/src/main/java/org/apache/directory/ldapstudio/browser/common/widgets/browser/ ldapstudio-browser-common/src/main/java/org/apache/directory/ldapstudio/browser/common/w...

Author: seelmann
Date: Sat Apr 14 13:19:23 2007
New Revision: 528867

URL: http://svn.apache.org/viewvc?view=rev&rev=528867
Log:
Replaced Integer constants by Enums. Javadoc and code cleanings.

Modified:
    directory/ldapstudio/trunk/ldapstudio-browser-common/src/main/java/org/apache/directory/ldapstudio/browser/common/widgets/browser/BrowserUniversalListener.java
    directory/ldapstudio/trunk/ldapstudio-browser-common/src/main/java/org/apache/directory/ldapstudio/browser/common/widgets/connection/ConnectionUniversalListener.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BookmarkManager.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BrowserCorePlugin.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BrowserCorePreferences.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/ConnectionManager.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/SearchManager.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributeAddedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributeDeletedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributesInitializedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BookmarkUpdateEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BookmarkUpdateListener.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BulkModificationEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ChildrenInitializedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionRenamedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionUpdateEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionUpdateListener.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EmptyValueAddedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EmptyValueDeletedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryAddedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryDeletedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryModificationEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryMovedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryRenamedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryUpdateListener.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/SearchUpdateEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/SearchUpdateListener.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueAddedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueDeletedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueModifiedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueRenamedEvent.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/internal/model/Bookmark.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/internal/model/Connection.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/internal/model/DelegateEntry.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/internal/model/Search.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/jobs/DeleteEntriesJob.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/jobs/MoveEntriesJob.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/jobs/OpenConnectionsJob.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/jobs/ReloadSchemasJob.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/jobs/RenameEntryJob.java
    directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/jobs/SearchJob.java
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/dialogs/properties/SearchPropertyPage.java
    directory/ldapstudio/trunk/ldapstudio-browser-ui/src/main/java/org/apache/directory/ldapstudio/browser/ui/views/browser/BrowserViewUniversalListener.java
    directory/ldapstudio/trunk/ldapstudio-ldifeditor/src/main/java/org/apache/directory/ldapstudio/ldifeditor/editor/LdifEditor.java

Modified: directory/ldapstudio/trunk/ldapstudio-browser-common/src/main/java/org/apache/directory/ldapstudio/browser/common/widgets/browser/BrowserUniversalListener.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-common/src/main/java/org/apache/directory/ldapstudio/browser/common/widgets/browser/BrowserUniversalListener.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-common/src/main/java/org/apache/directory/ldapstudio/browser/common/widgets/browser/BrowserUniversalListener.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-common/src/main/java/org/apache/directory/ldapstudio/browser/common/widgets/browser/BrowserUniversalListener.java Sat Apr 14 13:19:23 2007
@@ -150,11 +150,11 @@
      */
     public void connectionUpdated( ConnectionUpdateEvent connectionUpdateEvent )
     {
-        if ( connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.CONNECTION_CLOSED )
+        if ( connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.EventDetail.CONNECTION_CLOSED )
         {
             viewer.collapseAll();
         }
-        else if ( connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.CONNECTION_OPENED )
+        else if ( connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.EventDetail.CONNECTION_OPENED )
         {
             viewer.refresh( connectionUpdateEvent.getConnection() );
         }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-common/src/main/java/org/apache/directory/ldapstudio/browser/common/widgets/connection/ConnectionUniversalListener.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-common/src/main/java/org/apache/directory/ldapstudio/browser/common/widgets/connection/ConnectionUniversalListener.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-common/src/main/java/org/apache/directory/ldapstudio/browser/common/widgets/connection/ConnectionUniversalListener.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-common/src/main/java/org/apache/directory/ldapstudio/browser/common/widgets/connection/ConnectionUniversalListener.java Sat Apr 14 13:19:23 2007
@@ -92,7 +92,7 @@
         if ( viewer != null )
         {
             viewer.refresh();
-            if ( connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.CONNECTION_ADDED )
+            if ( connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.EventDetail.CONNECTION_ADDED )
             {
                 viewer.setSelection( new StructuredSelection( connectionUpdateEvent.getConnection() ) );
             }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BookmarkManager.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BookmarkManager.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BookmarkManager.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BookmarkManager.java Sat Apr 14 13:19:23 2007
@@ -107,7 +107,7 @@
         }
 
         bookmarkList.add( index, bookmark );
-        EventRegistry.fireBookmarkUpdated( new BookmarkUpdateEvent( bookmark, BookmarkUpdateEvent.BOOKMARK_ADDED ),
+        EventRegistry.fireBookmarkUpdated( new BookmarkUpdateEvent( bookmark, BookmarkUpdateEvent.Detail.BOOKMARK_ADDED ),
             this );
     }
 
@@ -157,7 +157,7 @@
     public void removeBookmark( IBookmark bookmark )
     {
         bookmarkList.remove( bookmark );
-        EventRegistry.fireBookmarkUpdated( new BookmarkUpdateEvent( bookmark, BookmarkUpdateEvent.BOOKMARK_REMOVED ),
+        EventRegistry.fireBookmarkUpdated( new BookmarkUpdateEvent( bookmark, BookmarkUpdateEvent.Detail.BOOKMARK_REMOVED ),
             this );
     }
 

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BrowserCorePlugin.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BrowserCorePlugin.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BrowserCorePlugin.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BrowserCorePlugin.java Sat Apr 14 13:19:23 2007
@@ -21,7 +21,6 @@
 package org.apache.directory.ldapstudio.browser.core;
 
 
-import org.apache.directory.ldapstudio.browser.core.events.EventPerformanceMeter;
 import org.apache.directory.ldapstudio.browser.core.model.IAuthHandler;
 import org.apache.directory.ldapstudio.browser.core.model.IConnection;
 import org.apache.directory.ldapstudio.browser.core.model.IReferralHandler;
@@ -52,8 +51,6 @@
     /** The preferences */
     private BrowserCorePreferences preferences;
 
-    private EventPerformanceMeter eventPerformanceMeter;
-
 
     /**
      * Creates a new instance of BrowserCorePlugin.
@@ -63,7 +60,6 @@
         super();
         plugin = this;
         this.preferences = new BrowserCorePreferences();
-        this.eventPerformanceMeter = new EventPerformanceMeter();
     }
 
 
@@ -74,12 +70,10 @@
     {
         super.start( context );
 
-        if ( this.connectionManager == null )
+        if ( connectionManager == null )
         {
-            this.connectionManager = new ConnectionManager();
+            connectionManager = new ConnectionManager();
         }
-
-        // this.eventPerformanceMeter.start();
     }
 
 
@@ -90,17 +84,15 @@
     {
         super.stop( context );
 
-        if ( this.connectionManager != null )
+        if ( connectionManager != null )
         {
-            IConnection[] connections = this.connectionManager.getConnections();
+            IConnection[] connections = connectionManager.getConnections();
             for ( int i = 0; i < connections.length; i++ )
             {
                 connections[i].close();
             }
-            this.connectionManager = null;
+            connectionManager = null;
         }
-
-        // this.eventPerformanceMeter.stop();
     }
 
 
@@ -123,7 +115,7 @@
      */
     public ConnectionManager getConnectionManager()
     {
-        return this.connectionManager;
+        return connectionManager;
     }
 
 
@@ -133,7 +125,7 @@
      */
     public BrowserCorePreferences getCorePreferences()
     {
-        return this.preferences;
+        return preferences;
     }
 
 

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BrowserCorePreferences.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BrowserCorePreferences.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BrowserCorePreferences.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/BrowserCorePreferences.java Sat Apr 14 13:19:23 2007
@@ -38,9 +38,9 @@
  */
 public class BrowserCorePreferences
 {
-    private Set binaryAttributeCache;
+    private Set<String> binaryAttributeCache;
 
-    private Set binarySyntaxCache;
+    private Set<String> binarySyntaxCache;
 
 
     /**
@@ -51,27 +51,19 @@
      */
     public Set getBinaryAttributeOidsAndNames()
     {
-        if ( this.binaryAttributeCache == null )
+        if ( binaryAttributeCache == null )
         {
-            this.binaryAttributeCache = new HashSet();
-            BinaryAttribute[] binaryAttributes = this.getBinaryAttributes();
+            binaryAttributeCache = new HashSet<String>();
+            BinaryAttribute[] binaryAttributes =getBinaryAttributes();
             for ( int i = 0; i < binaryAttributes.length; i++ )
             {
                 if ( binaryAttributes[i].getAttributeNumericOidOrName() != null )
                 {
-                    this.binaryAttributeCache.add( binaryAttributes[i].getAttributeNumericOidOrName() );
+                    binaryAttributeCache.add( binaryAttributes[i].getAttributeNumericOidOrName() );
                 }
-                // if(binaryAttributes[i].getNames() != null) {
-                // for(int ii=0; ii<binaryAttributes[i].getNames().length; ii++)
-                // {
-                // if(binaryAttributes[i].getNames()[ii] != null) {
-                // this.binaryAttributeCache.add(binaryAttributes[i].getNames()[ii]);
-                // }
-                // }
-                // }
             }
         }
-        return this.binaryAttributeCache;
+        return binaryAttributeCache;
     }
 
 
@@ -97,7 +89,7 @@
     public void setBinaryAttributes( BinaryAttribute[] binaryAttributes )
     {
         store( BrowserCoreConstants.PREFERENCE_BINARY_ATTRIBUTES, binaryAttributes );
-        this.binaryAttributeCache = null;
+        binaryAttributeCache = null;
     }
 
 
@@ -126,21 +118,26 @@
     }
 
 
-    public Set getBinarySyntaxOids()
+    /**
+     * Gets the binary syntax oids.
+     * 
+     * @return the binary syntax oids
+     */
+    public Set<String> getBinarySyntaxOids()
     {
-        if ( this.binarySyntaxCache == null )
+        if ( binarySyntaxCache == null )
         {
-            this.binarySyntaxCache = new HashSet();
-            BinarySyntax[] binarySyntaxes = this.getBinarySyntaxes();
+            binarySyntaxCache = new HashSet<String>();
+            BinarySyntax[] binarySyntaxes = getBinarySyntaxes();
             for ( int i = 0; i < binarySyntaxes.length; i++ )
             {
                 if ( binarySyntaxes[i].getSyntaxNumericOid() != null )
                 {
-                    this.binarySyntaxCache.add( binarySyntaxes[i].getSyntaxNumericOid() );
+                    binarySyntaxCache.add( binarySyntaxes[i].getSyntaxNumericOid() );
                 }
             }
         }
-        return this.binarySyntaxCache;
+        return binarySyntaxCache;
     }
 
 
@@ -166,7 +163,7 @@
     public void setBinarySyntaxes( BinarySyntax[] binarySyntaxes )
     {
         store( BrowserCoreConstants.PREFERENCE_BINARY_SYNTAXES, binarySyntaxes );
-        this.binarySyntaxCache = null;
+        binarySyntaxCache = null;
     }
 
 

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/ConnectionManager.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/ConnectionManager.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/ConnectionManager.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/ConnectionManager.java Sat Apr 14 13:19:23 2007
@@ -6,16 +6,16 @@
  *  to you under the Apache License, Version 2.0 (the
  *  "License"); you may not use this file except in compliance
  *  with the License.  You may obtain a copy of the License at
- *  
+ *
  *    http://www.apache.org/licenses/LICENSE-2.0
- *  
+ *
  *  Unless required by applicable law or agreed to in writing,
  *  software distributed under the License is distributed on an
  *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  *  KIND, either express or implied.  See the License for the
  *  specific language governing permissions and limitations
- *  under the License. 
- *  
+ *  under the License.
+ *
  */
 
 package org.apache.directory.ldapstudio.browser.core;
@@ -59,14 +59,16 @@
 
 
 /**
- * This class is used to manage Connections.
+ * This class is used to manage {@link IConnection}s.
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$
  */
 public class ConnectionManager implements ConnectionUpdateListener, SearchUpdateListener, BookmarkUpdateListener
 {
-    private List connectionList;
+
+    /** The list of connections. */
+    private List<IConnection> connectionList;
 
 
     /**
@@ -74,8 +76,8 @@
      */
     public ConnectionManager()
     {
-        this.connectionList = new ArrayList();
-        this.loadConnections();
+        this.connectionList = new ArrayList<IConnection>();
+        loadConnections();
         EventRegistry.addConnectionUpdateListener( this );
         EventRegistry.addSearchUpdateListener( this );
         EventRegistry.addBookmarkUpdateListener( this );
@@ -173,12 +175,12 @@
     /**
      * Adds the connection to the end of the connection list. If there is
      * already a connection with this name, the new connection is renamed.
-     * 
+     *
      * @param connection
      */
     public void addConnection( IConnection connection )
     {
-        this.addConnection( this.connectionList.size(), connection );
+        addConnection( connectionList.size(), connection );
     }
 
 
@@ -186,17 +188,17 @@
      * Adds the connection at the specified position of the connection list.
      * If there is already a connection with this name the new connection is
      * renamed.
-     * 
+     *
      * @param index
      * @param connection
      */
     public void addConnection( int index, IConnection connection )
     {
-        if ( this.getConnection( connection.getName() ) != null )
+        if ( getConnection( connection.getName() ) != null )
         {
             String newConnectionName = BrowserCoreMessages.bind( BrowserCoreMessages.copy_n_of_s,
                 "", connection.getName() ); //$NON-NLS-1$
-            for ( int i = 2; this.getConnection( newConnectionName ) != null; i++ )
+            for ( int i = 2; getConnection( newConnectionName ) != null; i++ )
             {
                 newConnectionName = BrowserCoreMessages.bind( BrowserCoreMessages.copy_n_of_s,
                     i + " ", connection.getName() ); //$NON-NLS-1$
@@ -204,9 +206,9 @@
             connection.getConnectionParameter().setName( newConnectionName );
         }
 
-        this.connectionList.add( index, connection );
+        connectionList.add( index, connection );
         EventRegistry.fireConnectionUpdated( new ConnectionUpdateEvent( connection,
-            ConnectionUpdateEvent.CONNECTION_ADDED ), this );
+            ConnectionUpdateEvent.EventDetail.CONNECTION_ADDED ), this );
     }
 
 
@@ -220,7 +222,7 @@
      */
     public IConnection getConnection( String name )
     {
-        for ( Iterator it = this.connectionList.iterator(); it.hasNext(); )
+        for ( Iterator it = connectionList.iterator(); it.hasNext(); )
         {
             IConnection conn = ( IConnection ) it.next();
             if ( conn.getName().equals( name ) )
@@ -242,7 +244,7 @@
      */
     public int indexOf( IConnection connection )
     {
-        return this.connectionList.indexOf( connection );
+        return connectionList.indexOf( connection );
     }
 
 
@@ -254,9 +256,9 @@
      */
     public void removeConnection( IConnection conn )
     {
-        this.connectionList.remove( conn );
+        connectionList.remove( conn );
         EventRegistry.fireConnectionUpdated(
-            new ConnectionUpdateEvent( conn, ConnectionUpdateEvent.CONNECTION_REMOVED ), this );
+            new ConnectionUpdateEvent( conn, ConnectionUpdateEvent.EventDetail.CONNECTION_REMOVED ), this );
     }
 
 
@@ -268,7 +270,7 @@
      */
     public IConnection[] getConnections()
     {
-        return ( IConnection[] ) this.connectionList.toArray( new IConnection[0] );
+        return ( IConnection[] ) connectionList.toArray( new IConnection[0] );
     }
 
 
@@ -280,7 +282,7 @@
      */
     public int getConnectionCount()
     {
-        return this.connectionList.size();
+        return connectionList.size();
     }
 
 
@@ -289,12 +291,12 @@
      */
     public void connectionUpdated( ConnectionUpdateEvent connectionUpdateEvent )
     {
-        if ( connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.CONNECTION_ADDED
-            || connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.CONNECTION_REMOVED
-            || connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.CONNECTION_RENAMED
-            || connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.CONNECTION_PARAMETER_UPDATED )
+        if ( connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.EventDetail.CONNECTION_ADDED
+            || connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.EventDetail.CONNECTION_REMOVED
+            || connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.EventDetail.CONNECTION_RENAMED
+            || connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.EventDetail.CONNECTION_PARAMETER_UPDATED )
         {
-            this.saveConnections();
+            saveConnections();
         }
 
         if ( connectionUpdateEvent instanceof ConnectionRenamedEvent )
@@ -310,12 +312,12 @@
                 oldFile.renameTo( newFile );
             }
         }
-        if ( connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.CONNECTION_SCHEMA_LOADED 
-            || connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.CONNECTION_OPENED )
+        if ( connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.EventDetail.SCHEMA_LOADED
+            || connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.EventDetail.CONNECTION_OPENED )
         {
-            this.saveSchema( connectionUpdateEvent.getConnection() );
+            saveSchema( connectionUpdateEvent.getConnection() );
         }
-        if ( connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.CONNECTION_REMOVED )
+        if ( connectionUpdateEvent.getDetail() == ConnectionUpdateEvent.EventDetail.CONNECTION_REMOVED )
         {
             File file = new File( getSchemaCacheFileName( connectionUpdateEvent.getConnection().getName() ) );
             if ( file.exists() )
@@ -331,12 +333,12 @@
      */
     public void searchUpdated( SearchUpdateEvent searchUpdateEvent )
     {
-        if ( searchUpdateEvent.getDetail() == SearchUpdateEvent.SEARCH_ADDED
-            || searchUpdateEvent.getDetail() == SearchUpdateEvent.SEARCH_REMOVED
-            || searchUpdateEvent.getDetail() == SearchUpdateEvent.SEARCH_RENAMED
-            || searchUpdateEvent.getDetail() == SearchUpdateEvent.SEARCH_PARAMETER_UPDATED )
+        if ( searchUpdateEvent.getDetail() == SearchUpdateEvent.EventDetail.SEARCH_ADDED
+            || searchUpdateEvent.getDetail() == SearchUpdateEvent.EventDetail.SEARCH_REMOVED
+            || searchUpdateEvent.getDetail() == SearchUpdateEvent.EventDetail.SEARCH_RENAMED
+            || searchUpdateEvent.getDetail() == SearchUpdateEvent.EventDetail.SEARCH_PARAMETER_UPDATED )
         {
-            this.saveConnections();
+            saveConnections();
         }
     }
 
@@ -346,11 +348,11 @@
      */
     public void bookmarkUpdated( BookmarkUpdateEvent bookmarkUpdateEvent )
     {
-        if ( bookmarkUpdateEvent.getDetail() == BookmarkUpdateEvent.BOOKMARK_ADDED
-            || bookmarkUpdateEvent.getDetail() == BookmarkUpdateEvent.BOOKMARK_REMOVED
-            || bookmarkUpdateEvent.getDetail() == BookmarkUpdateEvent.BOOKMARK_UPDATED )
+        if ( bookmarkUpdateEvent.getDetail() == BookmarkUpdateEvent.Detail.BOOKMARK_ADDED
+            || bookmarkUpdateEvent.getDetail() == BookmarkUpdateEvent.Detail.BOOKMARK_REMOVED
+            || bookmarkUpdateEvent.getDetail() == BookmarkUpdateEvent.Detail.BOOKMARK_UPDATED )
         {
-            this.saveConnections();
+            saveConnections();
         }
     }
 
@@ -380,17 +382,12 @@
                 bookmarkParameters[k] = bookmarks[k].getBookmarkParameter();
             }
 
-            // object[i][0] = conn.getClass().getName();
             object[i][0] = connectionParameters;
             object[i][1] = searchParameters;
             object[i][2] = bookmarkParameters;
         }
 
-        // long t1 = System.currentTimeMillis();
-        this.save( object, getConnectionStoreFileName() );
-        // long t2 = System.currentTimeMillis();
-        // System.out.println("Saved connections in " + (t2-t1) + "ms");
-
+        save( object, getConnectionStoreFileName() );
     }
 
 
@@ -412,8 +409,6 @@
         catch ( Exception e )
         {
             e.printStackTrace();
-            // BrowserPlugin.getDefault().getExceptionHandler().handleException(e.getMessage(),
-            // e);
         }
     }
 
@@ -425,11 +420,7 @@
     {
         try
         {
-            // long t1 = System.currentTimeMillis();
             Object[][] object = ( Object[][] ) this.load( getConnectionStoreFileName() );
-            // long t2 = System.currentTimeMillis();
-            // System.out.println("Loaded connections in " + (t2-t1) +
-            // "ms");
 
             if ( object != null )
             {
@@ -474,7 +465,7 @@
                         {
                         }
 
-                        this.connectionList.add( conn );
+                        connectionList.add( conn );
                     }
 
                 }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/SearchManager.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/SearchManager.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/SearchManager.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/SearchManager.java Sat Apr 14 13:19:23 2007
@@ -6,16 +6,16 @@
  *  to you under the Apache License, Version 2.0 (the
  *  "License"); you may not use this file except in compliance
  *  with the License.  You may obtain a copy of the License at
- *  
+ *
  *    http://www.apache.org/licenses/LICENSE-2.0
- *  
+ *
  *  Unless required by applicable law or agreed to in writing,
  *  software distributed under the License is distributed on an
  *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  *  KIND, either express or implied.  See the License for the
  *  specific language governing permissions and limitations
- *  under the License. 
- *  
+ *  under the License.
+ *
  */
 
 package org.apache.directory.ldapstudio.browser.core;
@@ -33,7 +33,7 @@
 
 
 /**
- * This class is used to manage Searches
+ * This class is used to manages {@link ISearch}es of an {@link IConnection}
  *
  * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
  * @version $Rev$, $Date$
@@ -41,10 +41,13 @@
 public class SearchManager implements Serializable
 {
 
+    /** The Constant serialVersionUID. */
     private static final long serialVersionUID = 8665227628274097691L;
 
+    /** The list of searches. */
     private List<ISearch> searchList;
 
+    /** The connection. */
     private IConnection connection;
 
 
@@ -106,17 +109,17 @@
         if ( getSearch( search.getName() ) != null )
         {
             String newSearchName = NLS.bind( BrowserCoreMessages.copy_n_of_s, "", search.getName() ); //$NON-NLS-1$
-            
+
             for ( int i = 2; this.getSearch( newSearchName ) != null; i++ )
             {
                 newSearchName = NLS.bind( BrowserCoreMessages.copy_n_of_s, i + " ", search.getName() ); //$NON-NLS-1$
             }
-            
+
             search.setName( newSearchName );
         }
 
         searchList.add( index, search );
-        EventRegistry.fireSearchUpdated( new SearchUpdateEvent( search, SearchUpdateEvent.SEARCH_ADDED ), this );
+        EventRegistry.fireSearchUpdated( new SearchUpdateEvent( search, SearchUpdateEvent.EventDetail.SEARCH_ADDED ), this );
     }
 
 
@@ -137,7 +140,7 @@
                 return search;
             }
         }
-        
+
         return null;
     }
 
@@ -165,7 +168,7 @@
     public void removeSearch( ISearch search )
     {
         searchList.remove( search );
-        EventRegistry.fireSearchUpdated( new SearchUpdateEvent( search, SearchUpdateEvent.SEARCH_REMOVED ), this );
+        EventRegistry.fireSearchUpdated( new SearchUpdateEvent( search, SearchUpdateEvent.EventDetail.SEARCH_REMOVED ), this );
     }
 
 

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributeAddedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributeAddedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributeAddedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributeAddedEvent.java Sat Apr 14 13:19:23 2007
@@ -27,12 +27,26 @@
 import org.apache.directory.ldapstudio.browser.core.model.IEntry;
 
 
+/**
+ * An AttributeAddedEvent indicates that an {@link IAttribute} was added to an {@link IEntry}.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class AttributeAddedEvent extends EntryModificationEvent
 {
 
+    /** The added attribute. */
     private IAttribute addedAttribute;
 
 
+    /**
+     * Creates a new instance of AttributeAddedEvent.
+     * 
+     * @param connection the connection
+     * @param modifiedEntry the modified entry
+     * @param addedAttribute the added attribute
+     */
     public AttributeAddedEvent( IConnection connection, IEntry modifiedEntry, IAttribute addedAttribute )
     {
         super( connection, modifiedEntry );
@@ -40,12 +54,20 @@
     }
 
 
+    /**
+     * Gets the added attribute.
+     * 
+     * @return the added attribute
+     */
     public IAttribute getAddedAttribute()
     {
-        return this.addedAttribute;
+        return addedAttribute;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__added_att_to_dn, new String[]

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributeDeletedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributeDeletedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributeDeletedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributeDeletedEvent.java Sat Apr 14 13:19:23 2007
@@ -27,12 +27,26 @@
 import org.apache.directory.ldapstudio.browser.core.model.IEntry;
 
 
+/**
+ * An AttributeDeletedEvent indicates that an {@link IAttribute} was deleted from an {@link IEntry}.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class AttributeDeletedEvent extends EntryModificationEvent
 {
 
+    /** The deleted attribute. */
     private IAttribute deletedAttribute;
 
 
+    /**
+     * Creates a new instance of AttributeDeletedEvent.
+     * 
+     * @param connection the connection
+     * @param modifiedEntry the modified entry
+     * @param deletedAttribute the deleted attribute
+     */
     public AttributeDeletedEvent( IConnection connection, IEntry modifiedEntry, IAttribute deletedAttribute )
     {
         super( connection, modifiedEntry );
@@ -40,15 +54,24 @@
     }
 
 
+    /**
+     * Gets the deleted attribute.
+     * 
+     * @return the deleted attribute
+     */
     public IAttribute getDeletedAttribute()
     {
-        return this.deletedAttribute;
+        return deletedAttribute;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__deleted_att_from_dn, new String[]
             { getDeletedAttribute().getDescription(), getModifiedEntry().getDn().toString() } );
     }
+    
 }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributesInitializedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributesInitializedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributesInitializedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/AttributesInitializedEvent.java Sat Apr 14 13:19:23 2007
@@ -22,18 +22,35 @@
 
 
 import org.apache.directory.ldapstudio.browser.core.BrowserCoreMessages;
+import org.apache.directory.ldapstudio.browser.core.model.IAttribute;
 import org.apache.directory.ldapstudio.browser.core.model.IEntry;
 
 
+/**
+ * An AttributesInitializedEvent indicates that the {@link IAttribute}s
+ * of an {@link IEntry} were newly initialized from the underlying 
+ * directory.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class AttributesInitializedEvent extends EntryModificationEvent
 {
 
+    /**
+     * Creates a new instance of AttributesInitializedEvent.
+     * 
+     * @param initializedEntry the initialized entry
+     */
     public AttributesInitializedEvent( IEntry initializedEntry )
     {
         super( initializedEntry.getConnection(), initializedEntry );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__dn_attributes_initialized, new String[]

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BookmarkUpdateEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BookmarkUpdateEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BookmarkUpdateEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BookmarkUpdateEvent.java Sat Apr 14 13:19:23 2007
@@ -6,16 +6,16 @@
  *  to you under the Apache License, Version 2.0 (the
  *  "License"); you may not use this file except in compliance
  *  with the License.  You may obtain a copy of the License at
- *  
+ *
  *    http://www.apache.org/licenses/LICENSE-2.0
- *  
+ *
  *  Unless required by applicable law or agreed to in writing,
  *  software distributed under the License is distributed on an
  *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  *  KIND, either express or implied.  See the License for the
  *  specific language governing permissions and limitations
- *  under the License. 
- *  
+ *  under the License.
+ *
  */
 
 package org.apache.directory.ldapstudio.browser.core.events;
@@ -24,34 +24,67 @@
 import org.apache.directory.ldapstudio.browser.core.model.IBookmark;
 
 
+/**
+ * An BookmarkUpdateEvent indicates that an {@link IBookmark} was modified.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class BookmarkUpdateEvent
 {
 
-    public static final int BOOKMARK_ADDED = 1;
+    /**
+     * Contains constants to specify the event detail.
+     */
+    public enum Detail
+    {
+        /** Indicates that the bookmark was added. */
+        BOOKMARK_ADDED,
 
-    public static final int BOOKMARK_REMOVED = 2;
+        /** Indicates that the bookmark was updated. */
+        BOOKMARK_UPDATED,
 
-    public static final int BOOKMARK_UPDATED = 3;
+        /** Indicates that the bookmark was removed. */
+        BOOKMARK_REMOVED
+    }
 
-    private int detail;
+    /** The event detail. */
+    private Detail detail;
 
+    /** The updated bookmark. */
     private IBookmark bookmark;
 
 
-    public BookmarkUpdateEvent( IBookmark bookmark, int detail )
+    /**
+     * Creates a new instance of BookmarkUpdateEvent.
+     *
+     * @param bookmark the updated bookmark
+     * @param detail the event detail
+     */
+    public BookmarkUpdateEvent( IBookmark bookmark, Detail detail )
     {
         this.bookmark = bookmark;
         this.detail = detail;
     }
 
 
+    /**
+     * Gets the updated bookmark.
+     *
+     * @return the updated bookmark
+     */
     public IBookmark getBookmark()
     {
         return bookmark;
     }
 
 
-    public int getDetail()
+    /**
+     * Gets the event detail.
+     *
+     * @return the event detail
+     */
+    public Detail getDetail()
     {
         return detail;
     }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BookmarkUpdateListener.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BookmarkUpdateListener.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BookmarkUpdateListener.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BookmarkUpdateListener.java Sat Apr 14 13:19:23 2007
@@ -20,10 +20,23 @@
 
 package org.apache.directory.ldapstudio.browser.core.events;
 
+import org.apache.directory.ldapstudio.browser.core.model.IBookmark;
 
+
+/**
+ * A listener for {@link BookmarkUpdateEvent}s
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public interface BookmarkUpdateListener extends EventListener
 {
 
+    /**
+     * Called when an {@link IBookmark} was updated.
+     * 
+     * @param bookmarkUpdateEvent the bookmark update event
+     */
     public void bookmarkUpdated( BookmarkUpdateEvent bookmarkUpdateEvent );
 
 }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BulkModificationEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BulkModificationEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BulkModificationEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/BulkModificationEvent.java Sat Apr 14 13:19:23 2007
@@ -23,18 +23,31 @@
 
 import org.apache.directory.ldapstudio.browser.core.BrowserCoreMessages;
 import org.apache.directory.ldapstudio.browser.core.model.IConnection;
-import org.apache.directory.ldapstudio.browser.core.model.IEntry;
 
 
+/**
+ * An BulkModificationEvent indicates that a bulk modification has occured.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class BulkModificationEvent extends EntryModificationEvent
 {
 
+    /**
+     * Creates a new instance of BulkModificationEvent.
+     * 
+     * @param connection the connection
+     */
     public BulkModificationEvent( IConnection connection )
     {
         super( connection, connection.getRootDSE() );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.event__bulk_modification;

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ChildrenInitializedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ChildrenInitializedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ChildrenInitializedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ChildrenInitializedEvent.java Sat Apr 14 13:19:23 2007
@@ -25,15 +25,31 @@
 import org.apache.directory.ldapstudio.browser.core.model.IEntry;
 
 
+/**
+ * A ChildrenInitializedEvent indicates that the children
+ * of an {@link IEntry} were newly initialized from the underlying 
+ * directory.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class ChildrenInitializedEvent extends EntryModificationEvent
 {
 
+    /**
+     * Creates a new instance of ChildrenInitializedEvent.
+     * 
+     * @param initializedEntry the initialized entry
+     */
     public ChildrenInitializedEvent( IEntry initializedEntry )
     {
         super( initializedEntry.getConnection(), initializedEntry );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__dn_children_initialized, new String[]

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionRenamedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionRenamedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionRenamedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionRenamedEvent.java Sat Apr 14 13:19:23 2007
@@ -24,19 +24,37 @@
 import org.apache.directory.ldapstudio.browser.core.model.IConnection;
 
 
+/**
+ * An ConnectionRenamedEvent indicates that an {@link IConnection} was renamed.
+ * 
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class ConnectionRenamedEvent extends ConnectionUpdateEvent
 {
 
+    /** The old name. */
     private String oldName;
 
 
+    /**
+     * Creates a new instance of ConnectionRenamedEvent.
+     * 
+     * @param connection the connection
+     * @param oldName the old name
+     */
     public ConnectionRenamedEvent( IConnection connection, String oldName )
     {
-        super( connection, CONNECTION_RENAMED );
+        super( connection, EventDetail.CONNECTION_RENAMED );
         this.oldName = oldName;
     }
 
 
+    /**
+     * Gets the old name.
+     * 
+     * @return the old name
+     */
     public String getOldName()
     {
         return oldName;

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionUpdateEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionUpdateEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionUpdateEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionUpdateEvent.java Sat Apr 14 13:19:23 2007
@@ -6,60 +6,106 @@
  *  to you under the Apache License, Version 2.0 (the
  *  "License"); you may not use this file except in compliance
  *  with the License.  You may obtain a copy of the License at
- *  
+ *
  *    http://www.apache.org/licenses/LICENSE-2.0
- *  
+ *
  *  Unless required by applicable law or agreed to in writing,
  *  software distributed under the License is distributed on an
  *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  *  KIND, either express or implied.  See the License for the
  *  specific language governing permissions and limitations
- *  under the License. 
- *  
+ *  under the License.
+ *
  */
 
 package org.apache.directory.ldapstudio.browser.core.events;
 
 
+/**
+ * An ConnectionUpdateEvent indicates that an {@link IConnection} was modified.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 import org.apache.directory.ldapstudio.browser.core.model.IConnection;
 
 
+/**
+ * An ConnectionUpdateEvent indicates that an {@link IConnection} was modified.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class ConnectionUpdateEvent
 {
 
-    public static final int CONNECTION_OPENED = 1;
+    /**
+     * Contains constants to specify the event detail.
+     */
+    public enum EventDetail
+    {
+        /** Indicates that the connection to the directory was opened. */
+        CONNECTION_OPENED,
 
-    public static final int CONNECTION_CLOSED = 2;
+        /** Indicates that the connection to the directory was closed. */
+        CONNECTION_CLOSED,
 
-    public static final int CONNECTION_SCHEMA_LOADED = 3;
+        /** Indicates that the schema was loaded from directory. */
+        SCHEMA_LOADED,
 
-    public static final int CONNECTION_ADDED = 4;
+        /** Indicates that the connection was added to the connection pool. */
+        CONNECTION_ADDED,
 
-    public static final int CONNECTION_REMOVED = 5;
+        /** Indicates that the connection was removed from the connection pool. */
+        CONNECTION_REMOVED,
 
-    public static final int CONNECTION_PARAMETER_UPDATED = 6;
+        /**
+         * Indicates that the connection parameters were updated.
+         * Note: This event detail doesn't include the renaming of a connection!
+         * */
+        CONNECTION_PARAMETER_UPDATED,
 
-    public static final int CONNECTION_RENAMED = 7;
+        /** Indicates that the connection was renamed. */
+        CONNECTION_RENAMED
+    }
 
-    private int detail;
+    /** The event detail. */
+    private EventDetail detail;
 
+    /** The updated connection. */
     private IConnection connection;
 
 
-    public ConnectionUpdateEvent( IConnection connection, int detail )
+    /**
+     * Creates a new instance of ConnectionUpdateEvent.
+     *
+     * @param detail the event detail
+     * @param connection the updated connection
+     */
+    public ConnectionUpdateEvent( IConnection connection, EventDetail detail )
     {
         this.connection = connection;
         this.detail = detail;
     }
 
 
+    /**
+     * Gets the updated connection.
+     *
+     * @return the updated connection
+     */
     public IConnection getConnection()
     {
         return connection;
     }
 
 
-    public int getDetail()
+    /**
+     * Gets the event detail.
+     *
+     * @return the event detail
+     */
+    public EventDetail getDetail()
     {
         return detail;
     }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionUpdateListener.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionUpdateListener.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionUpdateListener.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ConnectionUpdateListener.java Sat Apr 14 13:19:23 2007
@@ -21,9 +21,23 @@
 package org.apache.directory.ldapstudio.browser.core.events;
 
 
+import org.apache.directory.ldapstudio.browser.core.model.IConnection;
+
+
+/**
+ * A listener for {@link ConnectionUpdateEvent}s
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public interface ConnectionUpdateListener extends EventListener
 {
 
+    /**
+     * Called when an {@link IConnection} was updated.
+     * 
+     * @param connectionUpdateEvent the connection update event
+     */
     public void connectionUpdated( ConnectionUpdateEvent connectionUpdateEvent );
 
 }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EmptyValueAddedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EmptyValueAddedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EmptyValueAddedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EmptyValueAddedEvent.java Sat Apr 14 13:19:23 2007
@@ -28,14 +28,30 @@
 import org.apache.directory.ldapstudio.browser.core.model.IValue;
 
 
+/**
+ * An EmptyValueAddedEvent indicates that an empty {@link IValue} was added to an {@link IEntry}.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class EmptyValueAddedEvent extends EntryModificationEvent
 {
 
+    /** The modified attribute. */
     private IAttribute modifiedAttribute;
 
+    /** The added value. */
     private IValue addedValue;
 
 
+    /**
+     * Creates a new instance of EmptyValueAddedEvent.
+     * 
+     * @param connection the connection
+     * @param modifiedEntry the modified entry
+     * @param modifiedAttribute the modified attribute
+     * @param addedValue the added value
+     */
     public EmptyValueAddedEvent( IConnection connection, IEntry modifiedEntry, IAttribute modifiedAttribute,
         IValue addedValue )
     {
@@ -45,18 +61,31 @@
     }
 
 
+    /**
+     * Gets the modified attribute.
+     * 
+     * @return the modified attribute
+     */
     public IAttribute getModifiedAttribute()
     {
         return this.modifiedAttribute;
     }
 
 
+    /**
+     * Gets the added value.
+     * 
+     * @return the added value
+     */
     public IValue getAddedValue()
     {
         return this.addedValue;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__empty_value_added_to_att_at_dn, new String[]

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EmptyValueDeletedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EmptyValueDeletedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EmptyValueDeletedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EmptyValueDeletedEvent.java Sat Apr 14 13:19:23 2007
@@ -28,14 +28,30 @@
 import org.apache.directory.ldapstudio.browser.core.model.IValue;
 
 
+/**
+ * An EmptyValueDeletedEvent indicates that an empty {@link IValue} was deleted from an {@link IEntry}.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class EmptyValueDeletedEvent extends EntryModificationEvent
 {
 
+    /** The modified attribute. */
     private IAttribute modifiedAttribute;
 
+    /** The deleted value. */
     private IValue deletedValue;
 
 
+    /**
+     * Creates a new instance of EmptyValueDeletedEvent.
+     * 
+     * @param connection the connection
+     * @param modifiedEntry the modified entry
+     * @param modifiedAttribute the modified attribute
+     * @param deletedValue the deleted value
+     */
     public EmptyValueDeletedEvent( IConnection connection, IEntry modifiedEntry, IAttribute modifiedAttribute,
         IValue deletedValue )
     {
@@ -45,18 +61,31 @@
     }
 
 
+    /**
+     * Gets the modified attribute.
+     * 
+     * @return the modified attribute
+     */
     public IAttribute getModifiedAttribute()
     {
         return this.modifiedAttribute;
     }
 
 
+    /**
+     * Gets the deleted value.
+     * 
+     * @return the deleted value
+     */
     public IValue getDeletedValue()
     {
         return this.deletedValue;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__empty_value_deleted_from_att_at_dn, new String[]

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryAddedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryAddedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryAddedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryAddedEvent.java Sat Apr 14 13:19:23 2007
@@ -26,15 +26,30 @@
 import org.apache.directory.ldapstudio.browser.core.model.IEntry;
 
 
+/**
+ * An EntryAddedEvent indicates that an {@link IEntry} was added to the underlying directory.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class EntryAddedEvent extends EntryModificationEvent
 {
 
+    /**
+     * Creates a new instance of EntryAddedEvent.
+     * 
+     * @param connection the connection
+     * @param addedEntry the added entry
+     */
     public EntryAddedEvent( IConnection connection, IEntry addedEntry )
     {
         super( connection, addedEntry );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__added_dn, new String[]

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryDeletedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryDeletedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryDeletedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryDeletedEvent.java Sat Apr 14 13:19:23 2007
@@ -26,15 +26,30 @@
 import org.apache.directory.ldapstudio.browser.core.model.IEntry;
 
 
+/**
+ * An EntryDeletedEvent indicates that an {@link IEntry} was deleted from the underlying directory.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class EntryDeletedEvent extends EntryModificationEvent
 {
 
+    /**
+     * Creates a new instance of EntryDeletedEvent.
+     * 
+     * @param connection the connection
+     * @param deletedEntry the deleted entry
+     */
     public EntryDeletedEvent( IConnection connection, IEntry deletedEntry )
     {
         super( connection, deletedEntry );
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__deleted_dn, new String[]

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryModificationEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryModificationEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryModificationEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryModificationEvent.java Sat Apr 14 13:19:23 2007
@@ -25,30 +25,54 @@
 import org.apache.directory.ldapstudio.browser.core.model.IEntry;
 
 
+/**
+ * The root of all events that indecate an {@link IEntry} modification.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public abstract class EntryModificationEvent
 {
 
-    protected IConnection originalConnection;
+    /** The connection. */
+    protected IConnection connection;
 
+    /** The entry. */
     protected IEntry modifiedEntry;
 
 
+    /**
+     * Creates a new instance of EntryModificationEvent.
+     * 
+     * @param modifiedEntry the modified entry
+     * @param connection the connection
+     */
     public EntryModificationEvent( IConnection connection, IEntry modifiedEntry )
     {
-        this.originalConnection = connection;
+        this.connection = connection;
         this.modifiedEntry = modifiedEntry;
     }
 
 
-    public IConnection getOriginalConnection()
+    /**
+     * Gets the connection.
+     * 
+     * @return the connection
+     */
+    public IConnection getConnection()
     {
-        return this.originalConnection;
+        return connection;
     }
 
 
+    /**
+     * Gets the modified entry.
+     * 
+     * @return the modified entry
+     */
     public IEntry getModifiedEntry()
     {
-        return this.modifiedEntry;
+        return modifiedEntry;
     }
 
 }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryMovedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryMovedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryMovedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryMovedEvent.java Sat Apr 14 13:19:23 2007
@@ -25,14 +25,28 @@
 import org.apache.directory.ldapstudio.browser.core.model.IEntry;
 
 
+/**
+ * An EntryMovedEvent indicates that an {@link IEntry} was moved in the underlying directory.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class EntryMovedEvent extends EntryModificationEvent
 {
 
+    /** The old entry. */
     private IEntry oldEntry;
 
+    /** The new entry. */
     private IEntry newEntry;
 
 
+    /**
+     * Creates a new instance of EntryMovedEvent.
+     * 
+     * @param oldEntry the old entry
+     * @param newEntry the new entry
+     */
     public EntryMovedEvent( IEntry oldEntry, IEntry newEntry )
     {
         super( newEntry.getConnection(), newEntry.getParententry() );
@@ -41,18 +55,31 @@
     }
 
 
+    /**
+     * Gets the new entry with the new DN.
+     * 
+     * @return the new entry
+     */
     public IEntry getNewEntry()
     {
         return newEntry;
     }
 
 
+    /**
+     * Gets the old entry with the old DN.
+     * 
+     * @return the old entry
+     */
     public IEntry getOldEntry()
     {
         return oldEntry;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__moved_oldrdn_from_oldparent_to_newparent,

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryRenamedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryRenamedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryRenamedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryRenamedEvent.java Sat Apr 14 13:19:23 2007
@@ -25,14 +25,28 @@
 import org.apache.directory.ldapstudio.browser.core.model.IEntry;
 
 
+/**
+ * An EntryRenamedEvent indicates that an {@link IEntry} was renamed in the underlying directory.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class EntryRenamedEvent extends EntryModificationEvent
 {
 
+    /** The old entry. */
     private IEntry oldEntry;
 
+    /** The new entry. */
     private IEntry newEntry;
 
 
+    /**
+     * Creates a new instance of EntryRenamedEvent.
+     * 
+     * @param oldEntry the old entry
+     * @param newEntry the new entry
+     */
     public EntryRenamedEvent( IEntry oldEntry, IEntry newEntry )
     {
         super( newEntry.getConnection(), newEntry.getParententry() );
@@ -41,18 +55,31 @@
     }
 
 
+    /**
+     * Gets the new entry with the new DN.
+     * 
+     * @return the new entry
+     */
     public IEntry getNewEntry()
     {
         return newEntry;
     }
 
 
+    /**
+     * Gets the old entry with the old DN.
+     * 
+     * @return the old entry
+     */
     public IEntry getOldEntry()
     {
         return oldEntry;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__renamed_olddn_to_newdn, new String[]

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryUpdateListener.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryUpdateListener.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryUpdateListener.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/EntryUpdateListener.java Sat Apr 14 13:19:23 2007
@@ -20,10 +20,23 @@
 
 package org.apache.directory.ldapstudio.browser.core.events;
 
+import org.apache.directory.ldapstudio.browser.core.model.IEntry;
 
+
+/**
+ * A listener for {@link EntryModificationEvent}s
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public interface EntryUpdateListener extends EventListener
 {
 
+    /**
+     * Called when an {@link IEntry} was updated.
+     * 
+     * @param event the event
+     */
     public void entryUpdated( EntryModificationEvent event );
 
 }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/SearchUpdateEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/SearchUpdateEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/SearchUpdateEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/SearchUpdateEvent.java Sat Apr 14 13:19:23 2007
@@ -6,16 +6,16 @@
  *  to you under the Apache License, Version 2.0 (the
  *  "License"); you may not use this file except in compliance
  *  with the License.  You may obtain a copy of the License at
- *  
+ *
  *    http://www.apache.org/licenses/LICENSE-2.0
- *  
+ *
  *  Unless required by applicable law or agreed to in writing,
  *  software distributed under the License is distributed on an
  *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  *  KIND, either express or implied.  See the License for the
  *  specific language governing permissions and limitations
- *  under the License. 
- *  
+ *  under the License.
+ *
  */
 
 package org.apache.directory.ldapstudio.browser.core.events;
@@ -24,38 +24,77 @@
 import org.apache.directory.ldapstudio.browser.core.model.ISearch;
 
 
+/**
+ * An SearchUpdateEvent indicates that an {@link ISearch} was updated.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class SearchUpdateEvent
 {
 
-    public static final int SEARCH_ADDED = 1;
+    /**
+     * Contains constants to specify the event detail.
+     */
+    public enum EventDetail
+    {
+
+        /** Indicates that the search was added. */
+        SEARCH_ADDED,
 
-    public static final int SEARCH_REMOVED = 2;
+        /** Indicates that the search was removed. */
+        SEARCH_REMOVED,
 
-    public static final int SEARCH_PERFORMED = 3;
+        /** Indicates that the search was performed. */
+        SEARCH_PERFORMED,
 
-    public static final int SEARCH_PARAMETER_UPDATED = 4;
+        /**
+         * Indicates that the search parameters were updated.
+         * Note: This event detail doesn't include the renaming of a search!
+         */
+        SEARCH_PARAMETER_UPDATED,
 
-    public static final int SEARCH_RENAMED = 5;
+        /** Indicates that the search was renamed. */
+        SEARCH_RENAMED
+    }
 
-    private int detail;
+    /** The event detail. */
+    private EventDetail detail;
 
+    /** The updated search. */
     private ISearch search;
 
 
-    public SearchUpdateEvent( ISearch search, int detail )
+    /**
+     * Creates a new instance of SearchUpdateEvent.
+     *
+     * @param search the updated search
+     * @param detail the event detail
+     */
+    public SearchUpdateEvent( ISearch search, EventDetail detail )
     {
         this.search = search;
         this.detail = detail;
     }
 
 
+    /**
+     * Gets the updated search.
+     *
+     * @return the updated search
+     */
     public ISearch getSearch()
     {
         return search;
     }
 
 
-    public int getDetail()
+    /**
+     * Gets the event detail.
+     *
+     * @return the event detail
+     */
+    public EventDetail getDetail()
     {
         return detail;
     }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/SearchUpdateListener.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/SearchUpdateListener.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/SearchUpdateListener.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/SearchUpdateListener.java Sat Apr 14 13:19:23 2007
@@ -6,24 +6,38 @@
  *  to you under the Apache License, Version 2.0 (the
  *  "License"); you may not use this file except in compliance
  *  with the License.  You may obtain a copy of the License at
- *  
+ *
  *    http://www.apache.org/licenses/LICENSE-2.0
- *  
+ *
  *  Unless required by applicable law or agreed to in writing,
  *  software distributed under the License is distributed on an
  *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  *  KIND, either express or implied.  See the License for the
  *  specific language governing permissions and limitations
- *  under the License. 
- *  
+ *  under the License.
+ *
  */
 
 package org.apache.directory.ldapstudio.browser.core.events;
 
 
+import org.apache.directory.ldapstudio.browser.core.model.ISearch;
+
+
+/**
+ * A listener for {@link SearchUpdateEvent}s
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public interface SearchUpdateListener extends EventListener
 {
 
+    /**
+     * Called when an {@link ISearch} was updated.
+     *
+     * @param searchUpdateEvent the search update event
+     */
     public void searchUpdated( SearchUpdateEvent searchUpdateEvent );
 
 }

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueAddedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueAddedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueAddedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueAddedEvent.java Sat Apr 14 13:19:23 2007
@@ -6,16 +6,16 @@
  *  to you under the Apache License, Version 2.0 (the
  *  "License"); you may not use this file except in compliance
  *  with the License.  You may obtain a copy of the License at
- *  
+ *
  *    http://www.apache.org/licenses/LICENSE-2.0
- *  
+ *
  *  Unless required by applicable law or agreed to in writing,
  *  software distributed under the License is distributed on an
  *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  *  KIND, either express or implied.  See the License for the
  *  specific language governing permissions and limitations
- *  under the License. 
- *  
+ *  under the License.
+ *
  */
 
 package org.apache.directory.ldapstudio.browser.core.events;
@@ -28,14 +28,30 @@
 import org.apache.directory.ldapstudio.browser.core.model.IValue;
 
 
+/**
+ * An ValueAddedEvent indicates that an {@link IValue} was added to an {@link IEntry}.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class ValueAddedEvent extends EntryModificationEvent
 {
 
+    /** The modified attribute. */
     private IAttribute modifiedAttribute;
 
+    /** The added value. */
     private IValue addedValue;
 
 
+    /**
+     * Creates a new instance of ValueAddedEvent.
+     *
+     * @param connection the connection
+     * @param modifiedEntry the modified entry
+     * @param modifiedAttribute the modified attribute
+     * @param addedValue the added value
+     */
     public ValueAddedEvent( IConnection connection, IEntry modifiedEntry, IAttribute modifiedAttribute,
         IValue addedValue )
     {
@@ -45,18 +61,31 @@
     }
 
 
+    /**
+     * Gets the modified attribute.
+     *
+     * @return the modified attribute
+     */
     public IAttribute getModifiedAttribute()
     {
-        return this.modifiedAttribute;
+        return modifiedAttribute;
     }
 
 
+    /**
+     * Gets the added value.
+     *
+     * @return the added value
+     */
     public IValue getAddedValue()
     {
-        return this.addedValue;
+        return addedValue;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__added_val_to_att_at_dn, new String[]

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueDeletedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueDeletedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueDeletedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueDeletedEvent.java Sat Apr 14 13:19:23 2007
@@ -6,16 +6,16 @@
  *  to you under the Apache License, Version 2.0 (the
  *  "License"); you may not use this file except in compliance
  *  with the License.  You may obtain a copy of the License at
- *  
+ *
  *    http://www.apache.org/licenses/LICENSE-2.0
- *  
+ *
  *  Unless required by applicable law or agreed to in writing,
  *  software distributed under the License is distributed on an
  *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  *  KIND, either express or implied.  See the License for the
  *  specific language governing permissions and limitations
- *  under the License. 
- *  
+ *  under the License.
+ *
  */
 
 package org.apache.directory.ldapstudio.browser.core.events;
@@ -28,14 +28,30 @@
 import org.apache.directory.ldapstudio.browser.core.model.IValue;
 
 
+/**
+ * An ValueDeletedEvent indicates that an {@link IValue} was deleted from an {@link IEntry}.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class ValueDeletedEvent extends EntryModificationEvent
 {
 
+    /** The modified attribute. */
     private IAttribute modifiedAttribute;
 
+    /** The deleted value. */
     private IValue deletedValue;
 
 
+    /**
+     * Creates a new instance of ValueDeletedEvent.
+     *
+     * @param connection the connection
+     * @param modifiedEntry the modified entry
+     * @param modifiedAttribute the modified attribute
+     * @param deletedValue the deleted value
+     */
     public ValueDeletedEvent( IConnection connection, IEntry modifiedEntry, IAttribute modifiedAttribute,
         IValue deletedValue )
     {
@@ -45,18 +61,31 @@
     }
 
 
+    /**
+     * Gets the modified attribute.
+     *
+     * @return the modified attribute
+     */
     public IAttribute getModifiedAttribute()
     {
-        return this.modifiedAttribute;
+        return modifiedAttribute;
     }
 
 
+    /**
+     * Gets the deleted value.
+     *
+     * @return the deleted value
+     */
     public IValue getDeletedValue()
     {
-        return this.deletedValue;
+        return deletedValue;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__deleted_val_from_att_at_dn, new String[]

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueModifiedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueModifiedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueModifiedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueModifiedEvent.java Sat Apr 14 13:19:23 2007
@@ -6,16 +6,16 @@
  *  to you under the Apache License, Version 2.0 (the
  *  "License"); you may not use this file except in compliance
  *  with the License.  You may obtain a copy of the License at
- *  
+ *
  *    http://www.apache.org/licenses/LICENSE-2.0
- *  
+ *
  *  Unless required by applicable law or agreed to in writing,
  *  software distributed under the License is distributed on an
  *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  *  KIND, either express or implied.  See the License for the
  *  specific language governing permissions and limitations
- *  under the License. 
- *  
+ *  under the License.
+ *
  */
 
 package org.apache.directory.ldapstudio.browser.core.events;
@@ -28,16 +28,34 @@
 import org.apache.directory.ldapstudio.browser.core.model.IValue;
 
 
+/**
+ * An ValueModifiedEvent indicates that an {@link IValue} was modified.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class ValueModifiedEvent extends EntryModificationEvent
 {
 
+    /** The modified attribute. */
     private IAttribute modifiedAttribute;
 
+    /** The old value. */
     private IValue oldValue;
 
+    /** The new value. */
     private IValue newValue;
 
 
+    /**
+     * Creates a new instance of ValueModifiedEvent.
+     *
+     * @param connection the connection
+     * @param modifiedEntry the modified entry
+     * @param modifiedAttribute the modified attribute
+     * @param oldValue the old value
+     * @param newValue the new value
+     */
     public ValueModifiedEvent( IConnection connection, IEntry modifiedEntry, IAttribute modifiedAttribute,
         IValue oldValue, IValue newValue )
     {
@@ -48,24 +66,42 @@
     }
 
 
+    /**
+     * Gets the modified attribute.
+     *
+     * @return the modified attribute
+     */
     public IAttribute getModifiedAttribute()
     {
-        return this.modifiedAttribute;
+        return modifiedAttribute;
     }
 
 
+    /**
+     * Gets the old value.
+     *
+     * @return the old value
+     */
     public IValue getOldValue()
     {
-        return this.oldValue;
+        return oldValue;
     }
 
 
+    /**
+     * Gets the new value.
+     *
+     * @return the new value
+     */
     public IValue getNewValue()
     {
-        return this.newValue;
+        return newValue;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__replaced_oldval_by_newval_at_att_at_dn,

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueRenamedEvent.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueRenamedEvent.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueRenamedEvent.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/events/ValueRenamedEvent.java Sat Apr 14 13:19:23 2007
@@ -6,16 +6,16 @@
  *  to you under the Apache License, Version 2.0 (the
  *  "License"); you may not use this file except in compliance
  *  with the License.  You may obtain a copy of the License at
- *  
+ *
  *    http://www.apache.org/licenses/LICENSE-2.0
- *  
+ *
  *  Unless required by applicable law or agreed to in writing,
  *  software distributed under the License is distributed on an
  *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
  *  KIND, either express or implied.  See the License for the
  *  specific language governing permissions and limitations
- *  under the License. 
- *  
+ *  under the License.
+ *
  */
 
 package org.apache.directory.ldapstudio.browser.core.events;
@@ -27,14 +27,31 @@
 import org.apache.directory.ldapstudio.browser.core.model.IValue;
 
 
+/**
+ * An ValueRenamedEvent indicates that an {@link IValue} was renamed. This
+ * means that the attribute type was modified.
+ *
+ * @author <a href="mailto:dev@directory.apache.org">Apache Directory Project</a>
+ * @version $Rev$, $Date$
+ */
 public class ValueRenamedEvent extends EntryModificationEvent
 {
 
+    /** The old value with the old attribute type. */
     private IValue oldValue;
 
+    /** The new value with the new attribute type. */
     private IValue newValue;
 
 
+    /**
+     * Creates a new instance of ValueRenamedEvent.
+     *
+     * @param connection the connection
+     * @param modifiedEntry the modified entry
+     * @param oldValue the old value with the old attribute type
+     * @param newValue the new value with the new attribute type
+     */
     public ValueRenamedEvent( IConnection connection, IEntry modifiedEntry, IValue oldValue, IValue newValue )
     {
         super( connection, modifiedEntry );
@@ -43,18 +60,31 @@
     }
 
 
+    /**
+     * Gets the new value with the new attribute type.
+     *
+     * @return the new value with the new attribute type
+     */
     public IValue getNewValue()
     {
-        return this.newValue;
+        return newValue;
     }
 
 
+    /**
+     * Gets the old value with the old attribute type.
+     *
+     * @return the old value with the old attribute type
+     */
     public IValue getOldValue()
     {
-        return this.oldValue;
+        return oldValue;
     }
 
 
+    /**
+     * {@inheritDoc}
+     */
     public String toString()
     {
         return BrowserCoreMessages.bind( BrowserCoreMessages.event__renamed_oldval_by_newval_at_dn, new String[]

Modified: directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/internal/model/Bookmark.java
URL: http://svn.apache.org/viewvc/directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/internal/model/Bookmark.java?view=diff&rev=528867&r1=528866&r2=528867
==============================================================================
--- directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/internal/model/Bookmark.java (original)
+++ directory/ldapstudio/trunk/ldapstudio-browser-core/src/main/java/org/apache/directory/ldapstudio/browser/core/internal/model/Bookmark.java Sat Apr 14 13:19:23 2007
@@ -106,7 +106,7 @@
     public void setDn( DN dn )
     {
         this.bookmarkParameter.setDn( dn );
-        this.fireBookmarkUpdated( BookmarkUpdateEvent.BOOKMARK_UPDATED );
+        this.fireBookmarkUpdated( BookmarkUpdateEvent.Detail.BOOKMARK_UPDATED );
     }
 
 
@@ -125,7 +125,7 @@
     public void setName( String name )
     {
         this.bookmarkParameter.setName( name );
-        this.fireBookmarkUpdated( BookmarkUpdateEvent.BOOKMARK_UPDATED );
+        this.fireBookmarkUpdated( BookmarkUpdateEvent.Detail.BOOKMARK_UPDATED );
     }
 
 
@@ -156,7 +156,7 @@
     }
 
 
-    private void fireBookmarkUpdated( int detail )
+    private void fireBookmarkUpdated( BookmarkUpdateEvent.Detail detail )
     {
         if ( this.getName() != null && !"".equals( this.getName() ) ) { //$NON-NLS-1$
             EventRegistry.fireBookmarkUpdated( new BookmarkUpdateEvent( this, detail ), this );