[Bug 56231] New: Move redirect location processing from HC3/HC4 samplers to HTTPSamplerBase#followRedirects()

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=56231

            Bug ID: 56231
           Summary: Move redirect location processing from HC3/HC4
                    samplers to HTTPSamplerBase#followRedirects()
           Product: JMeter
           Version: 2.11
          Hardware: PC
                OS: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HTTP
          Assignee: issues@jmeter.apache.org
          Reporter: sebb@apache.org

Redirect location processing should all be handled in the shared method
HTTPSamplerBase#followRedirects(), rather than in individual samplers.

The location processing code thus needs to be removed from the HC3 and HC4
samplers, which should just store the location header for subsequent processing
by the method HTTPSamplerBase#followRedirects() (as is done by the Java and
Soap samplers).

Since it was found necessary to add location fixups to the HC3/HC4 samplers,
this must mean that the existing processing in the followRedirects() method was
incomplete. The next stage is to document the bug ids that drove changes to
HC3/HC4 and see how to integrate fixes for these in followRedirects().

To be continued.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56231] Move redirect location processing from HC3/HC4 samplers to HTTPSamplerBase#followRedirects()

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=56231

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Sebb <se...@apache.org> ---
URL: http://svn.apache.org/r1578188
Log:
Move redirect location processing from HC3/HC4 samplers to
HTTPSamplerBase#followRedirects()
Bugzilla Id: 56231

Modified:
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC3Impl.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56231] Move redirect location processing from HC3/HC4 samplers to HTTPSamplerBase#followRedirects()

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=56231

--- Comment #1 from Sebb <se...@apache.org> ---
Related fixed bugs:

Bug 54482 - HC fails to follow redirects with non-encoded chars

Bug 55717 - Bad handling of Redirect when URLs are in relative format by
HttpClient4 and HttpClient31

Related unfixed bugs:
Bug 56207 - URLs get encoded on redirects in HC3.1 & HC4 samplers

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 56231] Move redirect location processing from HC3/HC4 samplers to HTTPSamplerBase#followRedirects()

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=56231

--- Comment #2 from Sebb <se...@apache.org> ---
The Location header value seems to be unencoded, so needs to be encoded before
use by samplers.

This is quite easy using the java.net.URI class.

Unfortunately HC3.1 does its own parsing, and this is too strict: e.g. it does
not allow [] in query strings. As HC3.1 has been EOL for some while now there
seems little point in applying a special fix for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.