You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by "CrCliff (via GitHub)" <gi...@apache.org> on 2025/03/20 23:41:26 UTC
[PR] Fix US GovCloud AD endpoint for AZURE_ARM provider [libcloud]
CrCliff opened a new pull request, #2062:
URL: https://github.com/apache/libcloud/pull/2062
## [AZURE_ARM] Update AD endpoint for Azure US GovCloud
### Description
The AZURE_ARM provider was using the incorrect Active Directory endpoint for the Azure US Government environment.
I was seeing the following error when attempting to use the provider with the environment.
```python
cls = get_driver(Provider.AZURE_ARM)
driver = cls(
cloud_environment="AzureUSGovernment",
tenant_id="...",
subscription_id="....",
key="...",
secret="...",
)
# BaseHTTPError: Confidential Client is not supported in Cross Cloud request.
```
The `az cloud list` command provides the current AD endpoint.
```bash
$ az cloud list
{
"name": "AzureUSGovernment",
"endpoints": {
"activeDirectory": "https://login.microsoftonline.us",
// ....
},
// ...
},
```
After updating the endpoint the service principal authenticates as expected.
### Status
- done, ready for review
### Checklist
- [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update US GovCloud AD endpoint for AZURE_ARM provider [libcloud]
Posted by "micafer (via GitHub)" <gi...@apache.org>.
micafer merged PR #2062:
URL: https://github.com/apache/libcloud/pull/2062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update US GovCloud AD endpoint for AZURE_ARM provider [libcloud]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2062:
URL: https://github.com/apache/libcloud/pull/2062#issuecomment-3883640478
## [Codecov](https://app.codecov.io/gh/apache/libcloud/pull/2062?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 83.34%. Comparing base ([`124c47d`](https://app.codecov.io/gh/apache/libcloud/commit/124c47d03ea01214206c31a66f56bdb9f55f79f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5767351`](https://app.codecov.io/gh/apache/libcloud/commit/576735120c77402649b07d1825e8e520ec3d9254?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 10 commits behind head on trunk.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## trunk #2062 +/- ##
=======================================
Coverage 83.34% 83.34%
=======================================
Files 353 353
Lines 81769 81769
Branches 8993 8993
=======================================
Hits 68148 68148
Misses 10796 10796
Partials 2825 2825
```
| [Files with missing lines](https://app.codecov.io/gh/apache/libcloud/pull/2062?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [libcloud/common/azure\_arm.py](https://app.codecov.io/gh/apache/libcloud/pull/2062?src=pr&el=tree&filepath=libcloud%2Fcommon%2Fazure_arm.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bGliY2xvdWQvY29tbW9uL2F6dXJlX2FybS5weQ==) | `73.02% <ø> (ø)` | |
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org