You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/07 10:03:05 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4792: board: Run ./tools/refresh.sh --silent all
xiaoxiang781216 opened a new pull request #4792:
URL: https://github.com/apache/incubator-nuttx/pull/4792
## Summary
Follow up https://github.com/apache/incubator-nuttx-apps/pull/884
## Impact
Should same as before
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4792: board: Run ./tools/refresh.sh --silent all
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #4792:
URL: https://github.com/apache/incubator-nuttx/pull/4792#issuecomment-962593892
apache/incubator-nuttx-apps#884 disable some feature by default, so this PR remove these options from defconfig which make the binary size increase temporarily and then make CI fail like this:
```
arm-none-eabi-ld: /github/workspace/sources/nuttx/nuttx section `.text' will not fit in region `flash'
```
Please ignore this false alarm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4792: board: Run ./tools/refresh.sh --silent all
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #4792:
URL: https://github.com/apache/incubator-nuttx/pull/4792#issuecomment-962600643
All right. I already merged the apps, this needs to be merged too and we need to keep an eye on the pipeline run on master to make sure that everything is as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4792: board: Run ./tools/refresh.sh --silent all
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #4792:
URL: https://github.com/apache/incubator-nuttx/pull/4792#issuecomment-962592994
> We had an old issue about disabling some of these commands for security reasons, is this to address the same issue?
No, this patch try to reduce the image size with default setting when DEFAULT_SMALL is enabled. mb/mh/mw always disable by default regardless DEFAULT_SMALL setting(same as before).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4792: board: Run ./tools/refresh.sh --silent all
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4792:
URL: https://github.com/apache/incubator-nuttx/pull/4792#issuecomment-962592994
> We had an old issue about disabling some of these commands for security reasons, is this to address the same issue?
No, this patch try to reduce the image size with default setting when DEFAULT_SMALL is enabled. mb/mh/mw always disable by default regardless DEFAULT_SMALL setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #4792: board: Run ./tools/refresh.sh --silent all
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #4792:
URL: https://github.com/apache/incubator-nuttx/pull/4792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4792: board: Run ./tools/refresh.sh --silent all
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #4792:
URL: https://github.com/apache/incubator-nuttx/pull/4792#issuecomment-962587393
We had an old issue about disabling some of these commands for security reasons, is this to address the same issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4792: board: Run ./tools/refresh.sh --silent all
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4792:
URL: https://github.com/apache/incubator-nuttx/pull/4792#issuecomment-962593892
apache/incubator-nuttx-apps#884 disable some feature by default, so this PR remove these options from defconfig which make the binary size increase temporarily and make CI fail like this:
```
arm-none-eabi-ld: /github/workspace/sources/nuttx/nuttx section `.text' will not fit in region `flash'
```
Please ignore this false alarm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org