You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/06/27 14:43:48 UTC

[GitHub] [incubator-druid] leventov commented on a change in pull request #7969: Making StatusResponseHandler singleton and fixing all its instantiation invocations

leventov commented on a change in pull request #7969: Making StatusResponseHandler singleton and fixing all its instantiation invocations
URL: https://github.com/apache/incubator-druid/pull/7969#discussion_r298213240
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java
 ##########
 @@ -129,7 +128,7 @@
 public class RemoteTaskRunner implements WorkerTaskRunner, TaskLogStreamer
 {
   private static final EmittingLogger log = new EmittingLogger(RemoteTaskRunner.class);
-  private static final StatusResponseHandler RESPONSE_HANDLER = new StatusResponseHandler(StandardCharsets.UTF_8);
+  private static final StatusResponseHandler RESPONSE_HANDLER = StatusResponseHandler.getInstance();
 
 Review comment:
   `StatusResponseHandler.getInstance()` can be used directly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org