You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/22 00:16:43 UTC

[GitHub] [kafka] mumrah commented on a diff in pull request #13027: MINOR Send ZK broker epoch in registration

mumrah commented on code in PR #13027:
URL: https://github.com/apache/kafka/pull/13027#discussion_r1054964559


##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -359,6 +354,11 @@ class KafkaServer(
         val brokerInfo = createBrokerInfo
         val brokerEpoch = zkClient.registerBroker(brokerInfo)
 
+        lifecycleManager = new BrokerLifecycleManager(config,
+          time,
+          threadNamePrefix,
+          zkBrokerEpoch = Some(brokerEpoch))

Review Comment:
   Good catch. We do get new broker epochs after Zk session re-initializes. I'll change this to use the same pattern we use in AlterPartitionManager



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org