You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/06/22 07:16:31 UTC
Review Request 60359: The user is easy to configure the wrong
format's data
for 'YARN REST URL' property when adding a new yarn service. It will cause
testconnection fail.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60359/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1662
https://issues.apache.org/jira/browse/RANGER-1662
Repository: ranger
Description
-------
User can only configure the ‘YARN REST URL’ property using the specified format. In order to avoid that user inputs error format's data, we should add a hint for ‘YARN REST URL’ property.
Diffs
-----
security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js fee50f5
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4397721
Diff: https://reviews.apache.org/r/60359/diff/1/
Testing
-------
test?
Thanks,
pengjianhua
Re: Review Request 60359: The user is easy to configure the wrong
format's
data for 'YARN REST URL' property when adding a new yarn service. It will
cause testconnection fail.
Posted by pengjianhua <pe...@zte.com.cn>.
> On 六月 22, 2017, 9:04 a.m., Colm O hEigeartaigh wrote:
> > Looks fine, but change it to "For multiple urls"
Thanks,
I have changed and updated the patch.
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60359/#review178645
-----------------------------------------------------------
On 六月 22, 2017, 9:20 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60359/
> -----------------------------------------------------------
>
> (Updated 六月 22, 2017, 9:20 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1662
> https://issues.apache.org/jira/browse/RANGER-1662
>
>
> Repository: ranger
>
>
> Description
> -------
>
> User can only configure the ‘YARN REST URL’ property using the specified format. In order to avoid that user inputs error format's data, we should add a hint for ‘YARN REST URL’ property.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js fee50f5
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4397721
>
>
> Diff: https://reviews.apache.org/r/60359/diff/2/
>
>
> Testing
> -------
>
> test?
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 60359: The user is easy to configure the wrong
format's
data for 'YARN REST URL' property when adding a new yarn service. It will
cause testconnection fail.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60359/#review178645
-----------------------------------------------------------
Looks fine, but change it to "For multiple urls"
- Colm O hEigeartaigh
On June 22, 2017, 7:16 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60359/
> -----------------------------------------------------------
>
> (Updated June 22, 2017, 7:16 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1662
> https://issues.apache.org/jira/browse/RANGER-1662
>
>
> Repository: ranger
>
>
> Description
> -------
>
> User can only configure the ‘YARN REST URL’ property using the specified format. In order to avoid that user inputs error format's data, we should add a hint for ‘YARN REST URL’ property.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js fee50f5
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4397721
>
>
> Diff: https://reviews.apache.org/r/60359/diff/1/
>
>
> Testing
> -------
>
> test?
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 60359: The user is easy to configure the wrong
format's
data for 'YARN REST URL' property when adding a new yarn service. It will
cause testconnection fail.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60359/#review178766
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On 六月 22, 2017, 9:20 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60359/
> -----------------------------------------------------------
>
> (Updated 六月 22, 2017, 9:20 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1662
> https://issues.apache.org/jira/browse/RANGER-1662
>
>
> Repository: ranger
>
>
> Description
> -------
>
> User can only configure the ‘YARN REST URL’ property using the specified format. In order to avoid that user inputs error format's data, we should add a hint for ‘YARN REST URL’ property.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js fee50f5
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4397721
>
>
> Diff: https://reviews.apache.org/r/60359/diff/2/
>
>
> Testing
> -------
>
> test?
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 60359: The user is easy to configure the wrong
format's
data for 'YARN REST URL' property when adding a new yarn service. It will
cause testconnection fail.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60359/#review178648
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On June 22, 2017, 9:20 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60359/
> -----------------------------------------------------------
>
> (Updated June 22, 2017, 9:20 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1662
> https://issues.apache.org/jira/browse/RANGER-1662
>
>
> Repository: ranger
>
>
> Description
> -------
>
> User can only configure the ‘YARN REST URL’ property using the specified format. In order to avoid that user inputs error format's data, we should add a hint for ‘YARN REST URL’ property.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js fee50f5
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4397721
>
>
> Diff: https://reviews.apache.org/r/60359/diff/2/
>
>
> Testing
> -------
>
> test?
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 60359: The user is easy to configure the wrong
format's
data for 'YARN REST URL' property when adding a new yarn service. It will
cause testconnection fail.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60359/
-----------------------------------------------------------
(Updated 六月 22, 2017, 9:20 a.m.)
Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1662
https://issues.apache.org/jira/browse/RANGER-1662
Repository: ranger
Description
-------
User can only configure the ‘YARN REST URL’ property using the specified format. In order to avoid that user inputs error format's data, we should add a hint for ‘YARN REST URL’ property.
Diffs (updated)
-----
security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js fee50f5
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 4397721
Diff: https://reviews.apache.org/r/60359/diff/2/
Changes: https://reviews.apache.org/r/60359/diff/1-2/
Testing
-------
test?
Thanks,
pengjianhua