You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/11/18 00:03:24 UTC
Review Request 63931: MesosTidy [misc-use-after-move]: Fixed
`HashMapTest` test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63931/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
```
3rdparty/stout/tests/hashmap_tests.cpp:68:17: warning: 'map1' used after
it was moved [misc-use-after-move]
EXPECT_EQ(2u, map1.size());
^
3rdparty/stout/tests/hashmap_tests.cpp:66:21: note: move occurred here
hashmap<int, int> map2(std::move(map1));
^
```
Diffs
-----
3rdparty/stout/tests/hashmap_tests.cpp 321f404035cd9a80140800483498189f1875926d
Diff: https://reviews.apache.org/r/63931/diff/1/
Testing
-------
Thanks,
Michael Park
Re: Review Request 63931: MesosTidy [misc-use-after-move]: Fixed
`HashMapTest` test.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63931/#review191449
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Nov. 18, 2017, 12:03 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63931/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2017, 12:03 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> ```
> 3rdparty/stout/tests/hashmap_tests.cpp:68:17: warning: 'map1' used after
> it was moved [misc-use-after-move]
> EXPECT_EQ(2u, map1.size());
> ^
> 3rdparty/stout/tests/hashmap_tests.cpp:66:21: note: move occurred here
> hashmap<int, int> map2(std::move(map1));
> ^
> ```
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/hashmap_tests.cpp 321f404035cd9a80140800483498189f1875926d
>
>
> Diff: https://reviews.apache.org/r/63931/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>