You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "lavanv11 (via GitHub)" <gi...@apache.org> on 2026/05/13 22:14:17 UTC
[PR] [SPARK-56854][PYTHON] Filter None values in DataFrame[Stream]Reader/Writer .option(s) [spark]
lavanv11 opened a new pull request, #55867:
URL: https://github.com/apache/spark/pull/55867
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Filter None values in Classic PySpark's DataFrameReader, DataFrameWriter, DataFrameWriterV2, DataStreamReader, and DataStreamWriter `.option(key, value)` and `.options(**kwargs)` methods. After this change, `option(key, None)` is a no-op and `options(**{key: None, ...})` drops the None entries before forwarding to the JVM. The loop-style methods mirror the shape of `OptionUtils._set_opts` at `python/pyspark/sql/readwriter.py:41-53`: `for k, v in options.items(): if v is not None: ...`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Classic and Spark Connect Python currently disagree on what `option(key, None)` means. Classic forwards Python None to the JVM as Java null, which several data sources interpret differently from "unset". For example, with `spark.read.options(nullValue=None).schema("a STRING, b STRING").csv(path)` and a row `"",val`, Classic produces `[Row(a='', b='val')]` while Connect produces `[Row(a=None, b='val')]` because Connect drops the None, the default `nullValue` of `""` stays in effect, and the quoted empty cell matches it. This PR aligns Classic with Connect (which has filtered None since SPARK-49263) and with the long-standing `OptionUtils._set_opts` convention.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. `option(k, None)` and `options(**{k: None})` were previously forwarded to the JVM as null; they are now no-ops. A migration-guide entry under "Upgrading from PySpark 4.1 to 4.2" documents the change. To set an option to its default, omit it or pass None; to set it to an empty string, pass `""` explicitly.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
New parity test `test_option_none_is_filtered` in `ReadwriterTestsMixin` pins the CSV `nullValue=None` case to `[Row(a=None, b="val")]` for both `.option` and `.options`. Because `ReadwriterParityTests` inherits the mixin, the regression test runs on Classic and on Spark Connect, giving cross-backend coverage automatically.
Additional defensive smoke tests guard the writer / V2 writer / streaming reader / streaming writer API contracts:
- `test_writer_option_none_chains_safely`
- `test_v2_writer_option_none_chains_safely`
- `test_stream_reader_option_none_chains_safely`
- `test_stream_writer_option_none_chains_safely`
### Was this patch authored or co-authored using generative AI tooling?
Partially Generated-by: Claude Opus 4.7
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56854][PYTHON] Filter None values in DataFrame[Stream]Reader/Writer .option(s) [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #55867: [SPARK-56854][PYTHON] Filter None values in DataFrame[Stream]Reader/Writer .option(s)
URL: https://github.com/apache/spark/pull/55867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56854][PYTHON] Filter None values in DataFrame[Stream]Reader/Writer .option(s) [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #55867:
URL: https://github.com/apache/spark/pull/55867#issuecomment-4447727856
Seems like one test is realted. could we take a quick look and fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56854][PYTHON] Filter None values in DataFrame[Stream]Reader/Writer .option(s) [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #55867:
URL: https://github.com/apache/spark/pull/55867#issuecomment-4455008026
Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56854][PYTHON] Filter None values in DataFrame[Stream]Reader/Writer .option(s) [spark]
Posted by "lavanv11 (via GitHub)" <gi...@apache.org>.
lavanv11 commented on PR #55867:
URL: https://github.com/apache/spark/pull/55867#issuecomment-4453493715
> Seems like one test is realted. could we take a quick look and fix?
Fixed. The Connect-side writers and streaming reader don't have the plan-level None filter that the Connect batch reader has, so .option(k, None) was forwarding None straight to the protobuf options map. Added the same if value is None: return self guard. Pushed as a followup test fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56854][PYTHON] Filter None values in DataFrame[Stream]Reader/Writer .option(s) [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #55867:
URL: https://github.com/apache/spark/pull/55867#issuecomment-4455018693
Merged to master and branch-4.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org