You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2026/10/14 18:09:04 UTC
[PR] fix(store): unblock batch scan cancellation [hugegraph]
imbajin opened a new pull request, #3345:
URL: https://github.com/apache/hugegraph/pull/3345
## Purpose of the PR
Follow up on [ASF #3303](https://github.com/apache/hugegraph/pull/3303) and [the cancellation review feedback](https://github.com/hugegraph/hugegraph/pull/280#discussion_r4240430733).
Before, a batch-scan half-close or receipt could wait for a slow iterator while holding the request manager lock. Later transport cancellation then waited for that lock and could not reach the reader interrupt.
## Main Changes
Keep request state and worker publication under the manager lock; perform worker scheduling, notification and cleanup after releasing it. Cancellation can now interrupt an interruptible reader while half-close is waiting. Native RocksDB calls retain their existing cooperative cancellation limits.
## Verifying these changes
- [x] Need tests and can be verified as follows:
- The actual Store service/context regression fails before the fix and passes after it, requiring interruption and iterator/owner cleanup before fallback release.
- Existing Store lifecycle, half-close and shutdown tests pass against this worktree's reactor targets.
- JDK 17 root compile, EditorConfig formatting and diff checks pass.
## Does this PR potentially affect the following parts?
- [ ] Dependencies
- [ ] Modify configurations
- [ ] The public API
- [x] Other affects: Store batch-scan cancellation during a slow read.
- [ ] Nope
## Documentation Status
- [x] `Doc - Done`: `docs/storage-lifecycle.md` describes the manager-lock boundary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(store): unblock batch scan cancellation [hugegraph]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3345:
URL: https://github.com/apache/hugegraph/pull/3345#issuecomment-6175537518
## [Codecov](https://app.codecov.io/gh/apache/hugegraph/pull/3345?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 31.97%. Comparing base ([`92af2f8`](https://app.codecov.io/gh/apache/hugegraph/commit/92af2f89c320c3e6fa7c10765a061f3edadea319?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e40aec7`](https://app.codecov.io/gh/apache/hugegraph/commit/e40aec72c3b18460f2304aa0cce70c1ca997e446?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3345 +/- ##
=============================================
- Coverage 54.31% 31.97% -22.34%
+ Complexity 2250 1252 -998
=============================================
Files 770 203 -567
Lines 67952 14066 -53886
Branches 9213 1528 -7685
=============================================
- Hits 36905 4498 -32407
+ Misses 27470 9193 -18277
+ Partials 3577 375 -3202
```
| [Flag](https://app.codecov.io/gh/apache/hugegraph/pull/3345/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [store](https://app.codecov.io/gh/apache/hugegraph/pull/3345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.97% <ø> (?)` | |
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/hugegraph/pull/3345?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] fix(store): unblock batch scan cancellation [hugegraph]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #3345:
URL: https://github.com/apache/hugegraph/pull/3345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org