You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/26 10:51:38 UTC

[GitHub] [spark] cloud-fan opened a new pull request #24471: [SPARK-27579][SQL] remove BaseStreamingSource and BaseStreamingSink

cloud-fan opened a new pull request #24471: [SPARK-27579][SQL] remove BaseStreamingSource and BaseStreamingSink
URL: https://github.com/apache/spark/pull/24471
 
 
   ## What changes were proposed in this pull request?
   
   `BaseStreamingSource` and `BaseStreamingSink` is used to unify v1 and v2 streaming data source API in some code paths.
   
   This PR removes these 2 interfaces, and let the v1 API extend v2 API to keep API compatibility.
   
   The motivation is https://github.com/apache/spark/pull/24416 . We want to move data source v2 to catalyst module, but `BaseStreamingSource` and `BaseStreamingSink` are in sql/core.
   
   ## How was this patch tested?
   
   existing tests
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org