You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/16 06:24:27 UTC

[GitHub] [shardingsphere] azexcy commented on a diff in pull request #22905: Fix occasional ci error at InventoryTaskTest

azexcy commented on code in PR #22905:
URL: https://github.com/apache/shardingsphere/pull/22905#discussion_r1050407518


##########
test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/task/InventoryTaskTest.java:
##########
@@ -77,7 +76,7 @@ public void assertStartWithGetEstimatedRowsFailure() throws ExecutionException,
         PipelineTableMetaDataLoader metaDataLoader = new StandardPipelineTableMetaDataLoader(dataSource);
         try (
                 InventoryTask inventoryTask = new InventoryTask(inventoryDumperConfig, taskConfig.getImporterConfig(),
-                        PipelineContextUtil.getPipelineChannelCreator(), new DataSourceImporterConnector(DATA_SOURCE_MANAGER), dataSource,

Review Comment:
   TODO, In concurrent scenarios, importer may not stop causing ci timeout, I will follow up on this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org