You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/10 05:34:57 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24350: fix: Address dashboard permission regression in #23586
codecov[bot] commented on PR #24350:
URL: https://github.com/apache/superset/pull/24350#issuecomment-1585495632
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24350?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24350](https://app.codecov.io/gh/apache/superset/pull/24350?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e52da5f) into [master](https://app.codecov.io/gh/apache/superset/commit/0e3f1f638c06de11668c37329ca7141fd1159293?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0e3f1f6) will **decrease** coverage by `11.20%`.
> The diff coverage is `8.33%`.
> :exclamation: Current head e52da5f differs from pull request most recent head 72017e2. Consider uploading reports for the commit 72017e2 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24350 +/- ##
===========================================
- Coverage 69.09% 57.89% -11.20%
===========================================
Files 1903 1903
Lines 74608 74584 -24
Branches 8107 8107
===========================================
- Hits 51550 43181 -8369
- Misses 20947 29292 +8345
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.72% <8.33%> (+<0.01%)` | :arrow_up: |
| python | `60.31% <8.33%> (-23.08%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.21% <8.33%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/utils/decorators.py](https://app.codecov.io/gh/apache/superset/pull/24350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `94.33% <ø> (-0.11%)` | :arrow_down: |
| [superset/security/manager.py](https://app.codecov.io/gh/apache/superset/pull/24350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `61.35% <5.88%> (-34.58%)` | :arrow_down: |
| [superset/views/core.py](https://app.codecov.io/gh/apache/superset/pull/24350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `38.60% <14.28%> (-37.65%)` | :arrow_down: |
... and [299 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org