[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1140: feat: support endpointslice, and improve test/e2e/endpoints.go tests.

[GitBox <gi...@apache.org>]

tao12345666333 commented on code in PR #1140:
URL: https://github.com/apache/apisix-ingress-controller/pull/1140#discussion_r916614137


##########
test/e2e/suite-endpoints/endpoints.go:
##########
@@ -21,17 +21,27 @@ import (
 
 	ginkgo "github.com/onsi/ginkgo/v2"
 	"github.com/stretchr/testify/assert"
+	"k8s.io/apimachinery/pkg/util/wait"
 
 	"github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
 )
 
+func ensureNumListUpstreamNodes(s *scaffold.Scaffold, upsNum int, upsNodesNum int) error {
+	condFunc := func() (bool, error) {
+		ups, err := s.ListApisixUpstreams()
+		if err != nil || len(ups) != upsNum || len(ups[0].Nodes) != upsNodesNum {

Review Comment:
   I thought it would be better to add some comments here.
   
   such as expected return values, data structures and examples



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org