You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Cesar Rodriguez (JIRA)" <ji...@apache.org> on 2019/02/06 13:38:00 UTC
[jira] [Commented] (SOLR-13202) Three NullPointerExceptions in
org.apache.solr.search.JoinQuery.hashCode()
[ https://issues.apache.org/jira/browse/SOLR-13202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761743#comment-16761743 ]
Cesar Rodriguez commented on SOLR-13202:
----------------------------------------
In fact, if you run Solr with assertions enabled, the queries above produce an assertion violation in the constructor of {{JoinQuery}}, which clearly says it doesn't want null pointers:
{code:java}
public JoinQuery(String fromField, String toField, String coreName, Query subQuery) {
assert null != fromField;
assert null != toField;
assert null != subQuery;
this.fromField = fromField;
this.toField = toField;
this.q = subQuery;
this.fromIndex = coreName; // may be null
}
{code}
> Three NullPointerExceptions in org.apache.solr.search.JoinQuery.hashCode()
> --------------------------------------------------------------------------
>
> Key: SOLR-13202
> URL: https://issues.apache.org/jira/browse/SOLR-13202
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: master (9.0)
> Environment: h1. Steps to reproduce
> * Use a Linux machine.
> * Build commit {{ea2c8ba}} of Solr as described in the section below.
> * Build the films collection as described below.
> * Start the server using the command {{./bin/solr start -f -p 8983 -s /tmp/home}}
> * Request the URL given in the bug description.
> h1. Compiling the server
> {noformat}
> git clone https://github.com/apache/lucene-solr
> cd lucene-solr
> git checkout ea2c8ba
> ant compile
> cd solr
> ant server
> {noformat}
> h1. Building the collection
> We followed [Exercise 2|http://lucene.apache.org/solr/guide/7_5/solr-tutorial.html#exercise-2] from the [Solr Tutorial|http://lucene.apache.org/solr/guide/7_5/solr-tutorial.html]. The attached file ({{home.zip}}) gives the contents of folder {{/tmp/home}} that you will obtain by following the steps below:
> {noformat}
> mkdir -p /tmp/home
> echo '<?xml version="1.0" encoding="UTF-8" ?><solr></solr>' > /tmp/home/solr.xml
> {noformat}
> In one terminal start a Solr instance in foreground:
> {noformat}
> ./bin/solr start -f -p 8983 -s /tmp/home
> {noformat}
> In another terminal, create a collection of movies, with no shards and no replication, and initialize it:
> {noformat}
> bin/solr create -c films
> curl -X POST -H 'Content-type:application/json' --data-binary '{"add-field": {"name":"name", "type":"text_general", "multiValued":false, "stored":true}}' http://localhost:8983/solr/films/schema
> curl -X POST -H 'Content-type:application/json' --data-binary '{"add-copy-field" : {"source":"*","dest":"_text_"}}' http://localhost:8983/solr/films/schema
> ./bin/post -c films example/films/films.json
> {noformat}
> Reporter: Cesar Rodriguez
> Priority: Major
> Labels: diffblue, newdev
> Attachments: home.zip
>
>
> Requesting any of the following URLs causes Solr to return an HTTP 500 error response:
> {noformat}
> http://localhost:8983/solr/films/select?fq={!join%20from=b%20to=a}
> http://localhost:8983/solr/films/select?fq={!join%20to=a}
> http://localhost:8983/solr/films/select?fq={!join}
> {noformat}
> The error response seems to be caused by the following uncaught exception:
> {noformat}
> java.lang.NullPointerException
> at org.apache.solr.search.JoinQuery.hashCode(JoinQParserPlugin.java:578)
> at org.apache.solr.search.QueryResultKey.<init>(QueryResultKey.java:52)
> at org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1328)
> at org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:567)
> at org.apache.solr.handler.component.QueryComponent.doProcessUngroupedSearch(QueryComponent.java:1434)
> at org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:373)
> at org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:298)
> at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:199)
> at org.apache.solr.core.SolrCore.execute(SolrCore.java:2559)
> [...]
> {noformat}
> The problem seems to be related with method {{hasCode}} in the class {{org.apache.solr.search.JoinQuery}}:
> {code:java}
> @Override
> public int hashCode() {
> int h = classHash();
> h = h * 31 + fromField.hashCode();
> h = h * 31 + toField.hashCode();
> h = h * 31 + q.hashCode();
> h = h * 31 + Objects.hashCode(fromIndex);
> h = h * 31 + (int) fromCoreOpenTime;
> return h;
> }
> {code}
> The URLs provided above selectively leave uninitialized the fields {{fromField}}, {{fromIndex}}, {{q}}, and {{toField}}, but all of these fields are accessed by this method.
>
> We found this issue and ~70 more like this using [Diffblue Microservices Testing|https://www.diffblue.com/labs/?utm_source=solr-br]. Find more information on this [fuzz testing campaign|https://www.diffblue.com/blog/2018/12/19/diffblue-microservice-testing-a-sneak-peek-at-our-early-product-and-results?utm_source=solr-br].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org