You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jonkeane (via GitHub)" <gi...@apache.org> on 2026/05/05 14:04:40 UTC

Re: [PR] GH-40742: [R] fix max_rows_per_group must be a positive number [arrow]

jonkeane commented on code in PR #49709:
URL: https://github.com/apache/arrow/pull/49709#discussion_r3189043147


##########
r/R/dataset-write.R:
##########
@@ -218,7 +218,12 @@ write_dataset <- function(
   existing_data_behavior_opts <- c("delete_matching", "overwrite", "error")
   existing_data_behavior <- match(match.arg(existing_data_behavior), existing_data_behavior_opts) - 1L
 
-  if (!missing(max_rows_per_file) && missing(max_rows_per_group) && max_rows_per_group > max_rows_per_file) {
+  if (
+    !missing(max_rows_per_file) &&
+      missing(max_rows_per_group) &&
+      max_rows_per_file > 0 &&

Review Comment:
   This line `max_rows_per_file > 0` is the one condition that was change, yeah? The rest is whitespace?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org