[GitHub] [doris] adonis0147 commented on a diff in pull request #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV

[GitBox <gi...@apache.org>]

adonis0147 commented on code in PR #13147:
URL: https://github.com/apache/doris/pull/13147#discussion_r1002863740


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -1936,6 +1946,17 @@ public long loadCatalog(DataInputStream in, long checksum) throws IOException {
         return checksum;
     }
 
+    /**
+     * Load schedule jobs.
+     **/
+    public long loadJobManager(DataInputStream in, long checksum) throws IOException {
+        if (Config.enable_mtmv_scheduler_framework) {
+            this.mtmvJobManager = MtmvJobManager.read(in, checksum);
+        }
+        LOG.info("finished replay job and tasks from image");

Review Comment:
   Move to the branch `if (Config.enable_mtmv_scheduler_framework)`



##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -2209,6 +2230,13 @@ public long saveCatalog(CountingDataOutputStream out, long checksum) throws IOEx
         return checksum;
     }
 
+    public long saveJobManager(CountingDataOutputStream out, long checksum) throws IOException {
+        if (Config.enable_mtmv_scheduler_framework) {
+            Env.getCurrentEnv().getMtmvJobManager().write(out, checksum);

Review Comment:
   Add a log as `loadMtmvJobManager`



##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -432,6 +433,8 @@ public class Env {
 
     private PolicyMgr policyMgr;
 
+    private MtmvJobManager mtmvJobManager;

Review Comment:
   `MTMV` is short for *Multiple Table Materialized Table*. I think to use `MTMV` (all capital characters) is better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org