Re: [PR] CASSANDRA-19946 Uses ParameterizedClass for all auth-related implementations [cassandra]

["michaelsembwever (via GitHub)" <gi...@apache.org>]

michaelsembwever commented on code in PR #3600:
URL: https://github.com/apache/cassandra/pull/3600#discussion_r1792251007


##########
conf/cassandra_latest.yaml:
##########
@@ -180,37 +184,57 @@ authenticator:
 # Authorization backend, implementing IAuthorizer; used to limit access/provide permissions
 # Out of the box, Cassandra provides org.apache.cassandra.auth.{AllowAllAuthorizer,
 # CassandraAuthorizer}.
+# Optional parameters can be specified in the form of:
+#   parameters:
+#    param_key1: param_value1
+#    ...
 #
 # - AllowAllAuthorizer allows any action to any user - set it to disable authorization.
 # - CassandraAuthorizer stores permissions in system_auth.role_permissions table. Please
 #   increase system_auth keyspace replication factor if you use this authorizer.
-authorizer: AllowAllAuthorizer
+authorizer:
+  class_name: org.apache.cassandra.auth.AllowAllAuthorizer

Review Comment:
   it's easy to be wrong about these things, but my understanding is the precedence is to use short names for actual values, and also FQNs in the comments so that it's intuitive that both can be used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org