[jira] [Comment Edited] (JCRVLT-188) Ensure that hollow packages still proivde PackageProperties and JcrPackageDefinition.

["Konrad Windszus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCRVLT-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074311#comment-16074311 ] 

Konrad Windszus edited comment on JCRVLT-188 at 7/5/17 6:42 AM:
----------------------------------------------------------------

LGTM but I would appreciate a high level API like {{boolean JcrPackageManager.exists(Archive)}} which works on those properties to determine whether an archive (local or remote) is uploaded already in the remote repository. To achieve that it should work as follows: 
# extract the PID and the created date from the given archive
# try to find a package in the package manager with the same pid
# if there is a package compare its created date with the created date from the archive and only return true if both are equal.
This method should not consider at all if the package in the repository is installed or not (i.e. shouldn't care about {{JcrPackage.isInstalled()}}, because this is mainly used to determine whether the upload should be triggered.


was (Author: kwin):
LGTM but I would appreciate a high level API like {{boolean JcrPackageManager.isExisting(Archive)}} which works on those properties to determine whether an archive (local or remote) is uploaded already in the remote repository. To achieve that it should work as follows: 
# extract the PID and the created date from the given archive
# try to find a package in the package manager with the same pid
# if there is a package compare its created date with the created date from the archive and only return true if both are equal.
This method should not consider at all if the package in the repository is installed or not (i.e. shouldn't care about {{JcrPackage.isInstalled()}}, because this is mainly used to determine whether the upload should be triggered.

> Ensure that hollow packages still proivde PackageProperties and JcrPackageDefinition.
> -------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-188
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-188
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 3.1.40
>            Reporter: Konrad Windszus
>            Assignee: Tobias Bocanegra
>
> Currently for hollow packages (JCRVLT-50) only the following meta information is stored in the repository:
> * name
> * version
> * group
> * lastUnpacked
> * lastUnpackedBy
> * lastModified
> * lastModifiedBy
> What is missing is a {{jcr:created}} date which would allow to check if a to-be extracted hollow package has already been extracted previously in the repository.
> I am interested to prevent duplicate installations of the same hollow packages in the system and only the {{jcr:created}} would allow to achieve that (compare with JCRVLT-155).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)