You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/20 11:01:05 UTC

[GitHub] [apisix] liuxiran opened a new issue #2479: bug: route name should be unique, but new it can be duplicate

liuxiran opened a new issue #2479:
URL: https://github.com/apache/apisix/issues/2479


   ### Issue description
   refer to https://github.com/apache/apisix/pull/1655
   route name should be unique, actually I can create two routes with the same name. 
   
   ### Environment
   
   * apisix version (cmd: `apisix version`): latest master
   * OS: fedora32
   
   ### Minimal test code / Steps to reproduce the issue
   1. create route, id: 1000, name:test1
    ```shell
   [****** compose]$ curl http://127.0.0.1:9080/apisix/admin/routes/1000 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '{"name":"test1","uri":"/index.html","hosts":["foo.com","*.bar.com"],"remote_addrs":["127.0.0.0/8"],"methods":["PUT","GET"],"upstream":{"type":"roundrobin","nodes":{"39.97.63.215:80":1}}}'
   HTTP/1.1 201 Created
   Server: openresty
   Date: Tue, 20 Oct 2020 10:51:27 GMT
   Content-Type: application/json
   Transfer-Encoding: chunked
   Connection: keep-alive
   Access-Control-Allow-Origin: *
   Access-Control-Allow-Credentials: true
   Access-Control-Expose-Headers: *
   Access-Control-Max-Age: 3600
   
   {"header":{"raft_term":"5","cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"97"},"node":{"key":"\/apisix\/routes\/1000","value":{"priority":0,"methods":["PUT","GET"],"uri":"\/index.html","remote_addrs":["127.0.0.0\/8"],"hosts":["foo.com","*.bar.com"],"name":"test1","id":"1000","upstream":{"pass_host":"pass","hash_on":"vars","nodes":{"39.97.63.215:80":1},"type":"roundrobin"}}},"action":"set"}
   
   
   
   ```
   2. create route, id: 1001, name test1
   ```shell
   [***** compose]$ curl http://127.0.0.1:9080/apisix/admin/routes/1001 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '{"name":"test1","uri":"/index.html","hosts":["foo.com","*.bar.com"],"remote_addrs":["127.0.0.0/8"],"methods":["PUT","GET"],"upstream":{"type":"roundrobin","nodes":{"39.97.63.215:80":1}}}'
   HTTP/1.1 201 Created
   Server: openresty
   Date: Tue, 20 Oct 2020 10:51:43 GMT
   Content-Type: application/json
   Transfer-Encoding: chunked
   Connection: keep-alive
   Access-Control-Allow-Origin: *
   Access-Control-Allow-Credentials: true
   Access-Control-Expose-Headers: *
   Access-Control-Max-Age: 3600
   
   {"header":{"raft_term":"5","cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"98"},"node":{"key":"\/apisix\/routes\/1001","value":{"priority":0,"methods":["PUT","GET"],"uri":"\/index.html","remote_addrs":["127.0.0.0\/8"],"hosts":["foo.com","*.bar.com"],"name":"test1","id":"1001","upstream":{"pass_host":"pass","hash_on":"vars","nodes":{"39.97.63.215:80":1},"type":"roundrobin"}}},"action":"set"}
   
   ```
   3. both of the two routes above can be created successfully
   
   
   ### What's the expected result?
   In practical application, you will  use name to distinguish route, so duplicate names would make users confused.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] liuxiran commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-712908195


   > you used the `PUT` method, so it will update the exist one. you can try the `POST` method. Thanks, Ming Wen Twitter: 
   
   I also tried `POST` method, the result:
   
   ```shell
   [****** compose]$ curl http://127.0.0.1:9080/apisix/admin/routes -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X POST -i -d '{"name":"just-test","uri":"/index.html","hosts":["foo.com","*.bar.com"],"remote_addrs":["127.0.0.0/8"],"methods":["PUT","GET"],"upstream":{"type":"roundrobin","nodes":{"39.97.63.215:80":1}}}'
   HTTP/1.1 201 Created
   Server: openresty
   Date: Tue, 20 Oct 2020 12:24:14 GMT
   Content-Type: application/json
   Transfer-Encoding: chunked
   Connection: keep-alive
   Access-Control-Allow-Origin: *
   Access-Control-Allow-Credentials: true
   Access-Control-Expose-Headers: *
   Access-Control-Max-Age: 3600
   
   {"header":{"raft_term":"5","cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"107"},"node":{"key":"\/apisix\/routes\/00000000000000000106","value":{"priority":0,"methods":["PUT","GET"],"uri":"\/index.html","remote_addrs":["127.0.0.0\/8"],"hosts":["foo.com","*.bar.com"],"name":"just-test","upstream":{"pass_host":"pass","hash_on":"vars","nodes":{"39.97.63.215:80":1},"type":"roundrobin"}}},"action":"create"}
   
   ``` 
   
   the Key point is that the response data did not contain `id` value, so the route created by post cannot be updated,Or there are other ways to update this data ,which are not mentioned in the documentation :)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-909146676


   Better not add a unique restriction on the name field, which will introduce a break change. Since the name field is widely used, such break change is unacceptable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] liuxiran commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-713236051


   > Hi @liuxiran , actually there is a field `{"node":{"key":"\/apisix\/routes\/00000000000000000106"}` within response in your example, and the `00000000000000000106` is indeed the `id` of route. When we are using `POST` method to create a route, the `id` is automatically set to the latest `version` of the etcd by APISIX, which is a global counter incremented every time the data in etcd modified.
   
   Thanks for your explanation,  for this point,  it would be better to return the same data format under different circumstances.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-909139181


   Why not use the name as id?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] moonming commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-712932263


   @membphis please take a look


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] liuxiran commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-909026759


   ![image](https://user-images.githubusercontent.com/2561857/131470475-473d7a6e-24e8-4b1e-b462-46bd58b0b837.png)
   
   ![image](https://user-images.githubusercontent.com/2561857/131470565-bdcd2c6f-ce38-4ca0-a8b6-e4f871936143.png)
   
   from the above screenshots, we can see that the current Admin-API( run apisix with master branch) still allow to create the route with same name, so any updates on this issue? @membphis @spacewander thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] liuxiran edited a comment on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-909026759


   I tried to create routes with the same name by`POST` method:
    
   ![image](https://user-images.githubusercontent.com/2561857/131470475-473d7a6e-24e8-4b1e-b462-46bd58b0b837.png)
   
   ![image](https://user-images.githubusercontent.com/2561857/131470565-bdcd2c6f-ce38-4ca0-a8b6-e4f871936143.png)
   
   from the above screenshots, we can see that the current Admin-API( run apisix with master branch) still allow to create the route with same name, so any updates on this issue? @membphis @spacewander thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] liuxiran commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-909026759


   ![image](https://user-images.githubusercontent.com/2561857/131470475-473d7a6e-24e8-4b1e-b462-46bd58b0b837.png)
   
   ![image](https://user-images.githubusercontent.com/2561857/131470565-bdcd2c6f-ce38-4ca0-a8b6-e4f871936143.png)
   
   from the above screenshots, we can see that the current Admin-API( run apisix with master branch) still allow to create the route with same name, so any updates on this issue? @membphis @spacewander thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] moonming commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-712894195


   you used the `PUT` method, so it will update the exist one.
   you can try the `POST` method.
   
   Thanks,
   Ming Wen
   Twitter: _WenMing
   
   
   liuxiran <no...@github.com> 于2020年10月20日周二 下午8:28写道:
   
   > you can take the name as id, for example:
   > http://127.0.0.1:9080/apisix/admin/routes/test1
   >
   > test result:
   >
   >    1. create a route id: user1,name:test1
   >
   > [**** compose]$ curl http://127.0.0.1:9080/apisix/admin/routes/user1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '{"name":"test1","uri":"/index.html","hosts":["foo.com","*.bar.com"],"remote_addrs":["127.0.0.0/8"],"methods":["PUT","GET"],"upstream":{"type":"roundrobin","nodes":{"39.97.63.215:80":1}}}'
   >
   > HTTP/1.1 201 Created
   >
   > Server: openresty
   >
   > Date: Tue, 20 Oct 2020 12:01:43 GMT
   >
   > Content-Type: application/json
   >
   > Transfer-Encoding: chunked
   >
   > Connection: keep-alive
   >
   > Access-Control-Allow-Origin: *
   >
   > Access-Control-Allow-Credentials: true
   >
   > Access-Control-Expose-Headers: *
   >
   > Access-Control-Max-Age: 3600
   >
   >
   >
   > {"node":{"key":"\/apisix\/routes\/1000","value":{"priority":0,"methods":["PUT","GET"],"uri":"\/index.html","remote_addrs":["127.0.0.0\/8"],"hosts":["foo.com","*.bar.com"],"name":"test1","id":"1000","upstream":{"pass_host":"pass","hash_on":"vars","nodes":{"39.97.63.215:80":1},"type":"roundrobin"}}},"header":{"raft_term":"5","cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"102"},"action":"set"}
   >
   >
   >    1. create route id: user1, name test2
   >
   > [**** compose]$ curl http://127.0.0.1:9080/apisix/admin/routes/user1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '{"name":"test2","uri":"/index.html","hosts":["foo.com","*.bar.com"],"remote_addrs":["127.0.0.0/8"],"methods":["PUT","GET"],"upstream":{"type":"roundrobin","nodes":{"39.97.63.215:80":1}}}'
   >
   > HTTP/1.1 200 OK
   >
   > Server: openresty
   >
   > Date: Tue, 20 Oct 2020 12:11:10 GMT
   >
   > Content-Type: application/json
   >
   > Transfer-Encoding: chunked
   >
   > Connection: keep-alive
   >
   > Access-Control-Allow-Origin: *
   >
   > Access-Control-Allow-Credentials: true
   >
   > Access-Control-Expose-Headers: *
   >
   > Access-Control-Max-Age: 3600
   >
   >
   >
   > {"node":{"key":"\/apisix\/routes\/user1","value":{"priority":0,"methods":["PUT","GET"],"uri":"\/index.html","remote_addrs":["127.0.0.0\/8"],"hosts":["foo.com","*.bar.com"],"name":"test2","id":"user1","upstream":{"pass_host":"pass","hash_on":"vars","nodes":{"39.97.63.215:80":1},"type":"roundrobin"}}},"header":{"raft_term":"5","cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"105"},"action":"set"}
   >
   > [**** compose]$ curl http://127.0.0.1:9080/apisix/admin/routes/user1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
   >
   > {"node":{"value":{"priority":0,"methods":["PUT","GET"],"uri":"\/index.html","remote_addrs":["127.0.0.0\/8"],"hosts":["foo.com","*.bar.com"],"name":"test2","upstream":{"type":"roundrobin","nodes":{"39.97.63.215:80":1},"hash_on":"vars","pass_host":"pass"},"id":"user1"},"modifiedIndex":105,"key":"\/apisix\/routes\/user1","createdIndex":103},"count":"1","action":"get","header":{"raft_term":"5","cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"105"}}
   >
   > *Actually two duplicate id route create successfully, and the second one‘s
   > data coverd the former*
   > so there should be a unique key whether it's id or name
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/apisix/issues/2479#issuecomment-712813560>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGJZBK7RQZG5CGMQAF4SNA3SLV657ANCNFSM4SYDVW5Q>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] imjoey commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-713211974


   > the Key point is that the response data did not contain id value, so the route created by post cannot be updated,Or there are other ways to update this data ,which are not mentioned in the documentation :)
   
   Hi @liuxiran , actually there is a field `{"node":{"key":"\/apisix\/routes\/00000000000000000106"}` within response in your example, and the `00000000000000000106` is indeed the `id` of route. When we are using `POST` method to create a route, the `id` is automatically set to the latest `version` of the etcd by APISIX, which is a global counter incremented every time the data in etcd modified.
   
   > you used the `PUT` method, so it will update the exist one. you can try the `POST` method. Thanks, Ming Wen Twitter: 
   
   @moonming @membphis @juzhiyuan @liuxiran , I guess the real problem is that we can NOT specify a custom (unique) `id` within a `POST` request, which would lead to `{"error_msg":"wrong route id, do not need it"}`. So using `name` as `id` for the uniqueness seems not worked. Looking forward to your feedback, thank you guys.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] liuxiran edited a comment on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-909026759


   I tried to create routes with the same name by`POST` method:
    
   ![image](https://user-images.githubusercontent.com/2561857/131470475-473d7a6e-24e8-4b1e-b462-46bd58b0b837.png)
   
   ![image](https://user-images.githubusercontent.com/2561857/131470565-bdcd2c6f-ce38-4ca0-a8b6-e4f871936143.png)
   
   from the above screenshots, we can see that the current Admin-API( run apisix with master branch) still allow to create the route with same name, so any updates on this issue? @membphis @spacewander thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] liuxiran commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-712813560


   > you can take the `name` as `id`, for example:
   > `http://127.0.0.1:9080/apisix/admin/routes/test1`
   
   test result:
   
   1. create a route id: user1,name:test1
   
   ```shell
   [**** compose]$ curl http://127.0.0.1:9080/apisix/admin/routes/user1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '{"name":"test1","uri":"/index.html","hosts":["foo.com","*.bar.com"],"remote_addrs":["127.0.0.0/8"],"methods":["PUT","GET"],"upstream":{"type":"roundrobin","nodes":{"39.97.63.215:80":1}}}'
   HTTP/1.1 201 Created
   Server: openresty
   Date: Tue, 20 Oct 2020 12:01:43 GMT
   Content-Type: application/json
   Transfer-Encoding: chunked
   Connection: keep-alive
   Access-Control-Allow-Origin: *
   Access-Control-Allow-Credentials: true
   Access-Control-Expose-Headers: *
   Access-Control-Max-Age: 3600
   
   {"node":{"key":"\/apisix\/routes\/1000","value":{"priority":0,"methods":["PUT","GET"],"uri":"\/index.html","remote_addrs":["127.0.0.0\/8"],"hosts":["foo.com","*.bar.com"],"name":"test1","id":"1000","upstream":{"pass_host":"pass","hash_on":"vars","nodes":{"39.97.63.215:80":1},"type":"roundrobin"}}},"header":{"raft_term":"5","cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"102"},"action":"set"}
   ```
   
   2. create route id: user1, name test2
   
   ```shell
   [**** compose]$ curl http://127.0.0.1:9080/apisix/admin/routes/user1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '{"name":"test2","uri":"/index.html","hosts":["foo.com","*.bar.com"],"remote_addrs":["127.0.0.0/8"],"methods":["PUT","GET"],"upstream":{"type":"roundrobin","nodes":{"39.97.63.215:80":1}}}'
   HTTP/1.1 200 OK
   Server: openresty
   Date: Tue, 20 Oct 2020 12:11:10 GMT
   Content-Type: application/json
   Transfer-Encoding: chunked
   Connection: keep-alive
   Access-Control-Allow-Origin: *
   Access-Control-Allow-Credentials: true
   Access-Control-Expose-Headers: *
   Access-Control-Max-Age: 3600
   
   {"node":{"key":"\/apisix\/routes\/user1","value":{"priority":0,"methods":["PUT","GET"],"uri":"\/index.html","remote_addrs":["127.0.0.0\/8"],"hosts":["foo.com","*.bar.com"],"name":"test2","id":"user1","upstream":{"pass_host":"pass","hash_on":"vars","nodes":{"39.97.63.215:80":1},"type":"roundrobin"}}},"header":{"raft_term":"5","cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"105"},"action":"set"}
   [**** compose]$ curl http://127.0.0.1:9080/apisix/admin/routes/user1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1'
   {"node":{"value":{"priority":0,"methods":["PUT","GET"],"uri":"\/index.html","remote_addrs":["127.0.0.0\/8"],"hosts":["foo.com","*.bar.com"],"name":"test2","upstream":{"type":"roundrobin","nodes":{"39.97.63.215:80":1},"hash_on":"vars","pass_host":"pass"},"id":"user1"},"modifiedIndex":105,"key":"\/apisix\/routes\/user1","createdIndex":103},"count":"1","action":"get","header":{"raft_term":"5","cluster_id":"14841639068965178418","member_id":"10276657743932975437","revision":"105"}}
   ```
   
   **Actually two duplicate id route create successfully, and the second one‘s data coverd the former**
   so there should be a  unique key whether it's id or name


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] moonming commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-712786714


   you can take the `name` as `id`, for example:
   ```http://127.0.0.1:9080/apisix/admin/routes/test1```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] liuxiran commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-712782620


   I feel that it is a bug that affects the user experience, it would be better to solve before2.0, how about your options @membphis @nic-chen @moonming @juzhiyuan 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-909139181






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] liuxiran edited a comment on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-909026759


   I tried to create routes with the same name by`POST` method:
    
   ![image](https://user-images.githubusercontent.com/2561857/131470475-473d7a6e-24e8-4b1e-b462-46bd58b0b837.png)
   
   ![image](https://user-images.githubusercontent.com/2561857/131470565-bdcd2c6f-ce38-4ca0-a8b6-e4f871936143.png)
   
   from the above screenshots, we can see that the current Admin-API( run apisix with master branch) still allow to create the route with same name, so any updates on this issue? @membphis @spacewander thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-909139181






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] liuxiran commented on issue #2479: bug: route name should be unique, but now it can be duplicate

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #2479:
URL: https://github.com/apache/apisix/issues/2479#issuecomment-909026759


   ![image](https://user-images.githubusercontent.com/2561857/131470475-473d7a6e-24e8-4b1e-b462-46bd58b0b837.png)
   
   ![image](https://user-images.githubusercontent.com/2561857/131470565-bdcd2c6f-ce38-4ca0-a8b6-e4f871936143.png)
   
   from the above screenshots, we can see that the current Admin-API( run apisix with master branch) still allow to create the route with same name, so any updates on this issue? @membphis @spacewander thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org