You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/20 21:05:13 UTC

[GitHub] [arrow] kou commented on a change in pull request #10365: ARROW-12836: [C++] Add support for newer IBM i

kou commented on a change in pull request #10365:
URL: https://github.com/apache/arrow/pull/10365#discussion_r636469587



##########
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##########
@@ -28,7 +28,7 @@ if(NOT DEFINED ARROW_CPU_FLAG)
     set(ARROW_CPU_FLAG "armv8")
   elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "armv7")
     set(ARROW_CPU_FLAG "armv7")
-  elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "ppc")
+  elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "powerpc|powerpc64|ppc")

Review comment:
       It seems that `poerpc64` is redundant.
   
   Does the following pattern work?
   
   ```suggestion
     elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "powerpc|ppc")
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org