You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2018/04/18 01:27:41 UTC

[GitHub] flink pull request #5864: [FLINK-8661] Replace Collections.EMPTY_MAP with Co...

GitHub user zhangminglei opened a pull request:

    https://github.com/apache/flink/pull/5864

    [FLINK-8661] Replace Collections.EMPTY_MAP with Collections.emptyMap()

    
    ## What is the purpose of the change
    
    The use of Collections.EMPTY_SET and Collections.EMPTY_MAP often causes unchecked assignment. It should be replaced with Collections.emptySet() and Collections.emptyMap() .
    
    
    
    ## Brief change log
    Change Collections.EMPTY_MAP and Collections.EMPTY_LIST to Collections.emptyList() & Collections.emptyMap().
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-8661

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5864.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5864
    
----
commit f021149aa73576a9a9fd05ba00fcf7e5d1901318
Author: zhangminglei <zm...@...>
Date:   2018-04-18T01:24:57Z

    [FLINK-8661] Replace Collections.EMPTY_MAP with Collections.emptyMap()

----


---

[GitHub] flink issue #5864: [FLINK-8661] Replace Collections.EMPTY_MAP with Collectio...

Posted by bowenli86 <gi...@git.apache.org>.

Github user bowenli86 commented on the issue:

    https://github.com/apache/flink/pull/5864
  
    does using Collections.EMPTY_MAP/EMPTY_SET lead to some warnings logging? 


---

[GitHub] flink issue #5864: [FLINK-8661] Replace Collections.EMPTY_MAP with Collectio...

Posted by zhangminglei <gi...@git.apache.org>.

Github user zhangminglei commented on the issue:

    https://github.com/apache/flink/pull/5864
  
    Thanks @zentol 👍 


---

[GitHub] flink pull request #5864: [FLINK-8661] Replace Collections.EMPTY_MAP with Co...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5864


---

[GitHub] flink issue #5864: [FLINK-8661] Replace Collections.EMPTY_MAP with Collectio...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5864
  
    merging.


---

[GitHub] flink issue #5864: [FLINK-8661] Replace Collections.EMPTY_MAP with Collectio...

Posted by zhangminglei <gi...@git.apache.org>.

Github user zhangminglei commented on the issue:

    https://github.com/apache/flink/pull/5864
  
    Hi, @bowenli86 No. It wont gives warning logging, instead it will gives static compilation warning.


---

[GitHub] flink issue #5864: [FLINK-8661] Replace Collections.EMPTY_MAP with Collectio...

Posted by bowenli86 <gi...@git.apache.org>.

Github user bowenli86 commented on the issue:

    https://github.com/apache/flink/pull/5864
  
    +1


---