You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "zwangsheng (via GitHub)" <gi...@apache.org> on 2023/06/30 06:15:03 UTC
[GitHub] [kyuubi] zwangsheng opened a new pull request, #5011: [KYUUBI #5009]Pass Spark Engine Log Path to Spark Conf
zwangsheng opened a new pull request, #5011:
URL: https://github.com/apache/kyuubi/pull/5011
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Close #5009
When Kyuubi Server Log is Huge, it's difficult to find `Spark Engine Log Path` in logs.
Here pass the path to spark conf, user can find engine log path in spark ui or spark history server.
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cxzl25 commented on a diff in pull request #5011: [KYUUBI #5009] Pass Spark Engine Log Path to Spark Conf
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #5011:
URL: https://github.com/apache/kyuubi/pull/5011#discussion_r1250065109
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilderSuite.scala:
##########
@@ -300,10 +300,12 @@ class SparkProcessBuilderSuite extends KerberizedTestHelper with MockitoSugar {
}
test("[KYUUBI #5009] Test pass spark engine log path to spark conf") {
+ System.getenv().put("KYUUBI_WORK_DIR_ROOT", "/tmp/kyuubi/unit-test")
Review Comment:
env map should not be modifiable.
java.lang.ProcessEnvironment
```java
theUnmodifiableEnvironment
= Collections.unmodifiableMap
(new StringEnvironment(theEnvironment));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #5011: [KYUUBI #5009] Pass Spark Engine Log Path to Spark Conf
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5011:
URL: https://github.com/apache/kyuubi/pull/5011#issuecomment-1644929985
Thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] zwangsheng commented on pull request #5011: [KYUUBI #5009] Pass Spark Engine Log Path to Spark Conf
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on PR #5011:
URL: https://github.com/apache/kyuubi/pull/5011#issuecomment-1629990481
> The reason is that, before this pr, the `engineLog` is materialized when creating file. This pr breaks it, so test failed. Maybe we can try to make `command` lazy to work around it.
Sure, i will fix this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] zwangsheng commented on a diff in pull request #5011: [KYUUBI #5009] Pass Spark Engine Log Path to Spark Conf
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on code in PR #5011:
URL: https://github.com/apache/kyuubi/pull/5011#discussion_r1250271988
##########
kyuubi-server/src/test/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilderSuite.scala:
##########
@@ -300,10 +300,12 @@ class SparkProcessBuilderSuite extends KerberizedTestHelper with MockitoSugar {
}
test("[KYUUBI #5009] Test pass spark engine log path to spark conf") {
+ System.getenv().put("KYUUBI_WORK_DIR_ROOT", "/tmp/kyuubi/unit-test")
Review Comment:
Thanks, i'd find other way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #5011: [KYUUBI #5009] Pass Spark Engine Log Path to Spark Conf
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #5011:
URL: https://github.com/apache/kyuubi/pull/5011#issuecomment-1615943371
please fix the UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #5011: [KYUUBI #5009] Pass Spark Engine Log Path to Spark Conf
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #5011: [KYUUBI #5009] Pass Spark Engine Log Path to Spark Conf
URL: https://github.com/apache/kyuubi/pull/5011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] zwangsheng commented on pull request #5011: [KYUUBI #5009]Pass Spark Engine Log Path to Spark Conf
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on PR #5011:
URL: https://github.com/apache/kyuubi/pull/5011#issuecomment-1614182911
cc @yaooqinn @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] zwangsheng commented on pull request #5011: [KYUUBI #5009] Pass Spark Engine Log Path to Spark Conf
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on PR #5011:
URL: https://github.com/apache/kyuubi/pull/5011#issuecomment-1617394062
Given that it is related to failed unit tests, also cc why unit test failed @bowenliang123 @ulysses-you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] ulysses-you commented on pull request #5011: [KYUUBI #5009] Pass Spark Engine Log Path to Spark Conf
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #5011:
URL: https://github.com/apache/kyuubi/pull/5011#issuecomment-1617575461
The reason is that, before this pr, the `engineLog` is materialized when creating file. This pr breaks it, so test failed. Maybe we can try to make `command` lazy to work around it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org